[PATCH] oe-run-native: Add *-native directories under STAGING_BINDIR_NATIVE to PATH environment variable

[PATCH] oe-run-native: Add *-native directories under STAGING_BINDIR_NATIVE to PATH environment variable

[Jagadeesh Krishnanjanappa]

It helps to find/use native tools under ${STAGING_BINDIR_NATIVE}/*-native.

Solving below error:

$ oe-run-native python3-native python3
Running bitbake -e python3-native
Error: Unable to find 'python3' in .../tmp/work/x86_64-linux/python3-native/3.5.5-r1.0/recipe-sysroot-native/usr/bin:.../tmp/work/x86_64-linux/python3-native/3.5.5-r1.0/recipe-sysroot-native/bin:.../tmp/work/x86_64-linux/python3-native/3.5.5-r1.0/recipe-sysroot-native/usr/sbin:.../tmp/work/x86_64-linux/python3-native/3.5.5-r1.0/recipe-sysroot-native/sbin
Error: Have you run 'bitbake python3-native -caddto_recipe_sysroot'?
-- snip --

After this change we have native python3 to be found:

$ oe-run-native python3-native python3
Running bitbake -e python3-native
Python 3.5.5 (default, Aug  8 2018, 17:45:49)
[GCC 4.8.5 20150623 (Red Hat 4.8.5-28)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>
-- snip --

[YOCTO #12889]

Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
---
 scripts/oe-run-native | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/oe-run-native b/scripts/oe-run-native
index bbdd1d8..8412b18 100755
--- a/scripts/oe-run-native
+++ b/scripts/oe-run-native
@@ -55,7 +55,7 @@ fi
 OLD_PATH=$PATH
 
 # look for a tool only in native sysroot
-PATH=$OECORE_NATIVE_SYSROOT/usr/bin:$OECORE_NATIVE_SYSROOT/bin:$OECORE_NATIVE_SYSROOT/usr/sbin:$OECORE_NATIVE_SYSROOT/sbin
+PATH=$OECORE_NATIVE_SYSROOT/usr/bin:$OECORE_NATIVE_SYSROOT/bin:$OECORE_NATIVE_SYSROOT/usr/sbin:$OECORE_NATIVE_SYSROOT/sbin:$(find $OECORE_NATIVE_SYSROOT/usr/bin/*-native -maxdepth 1 -type d -printf ":%p")
 tool_find=`/usr/bin/which $tool 2>/dev/null`
 
 if [ -n "$tool_find" ] ; then
-- 
2.7.4

✗ patchtest: failure for oe-run-native: Add *-native directories under STAGING_BINDIR_NATIVE to PATH environment variable

[Patchwork]

== Series Details ==

Series: oe-run-native: Add *-native directories under STAGING_BINDIR_NATIVE to PATH environment variable
Revision: 1
URL   : https://patchwork.openembedded.org/series/13558/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            oe-run-native: Add *-native directories under STAGING_BINDIR_NATIVE to PATH environment variable
 Issue             Commit shortlog is too long [test_shortlog_length] 
  Suggested fix    Edit shortlog so that it is 90 characters or less (currently 96 characters)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH] oe-run-native: Add *-native directories under STAGING_BINDIR_NATIVE to PATH environment variable

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 2155 bytes --]

On Thu, Aug 16, 2018 at 10:45 AM Jagadeesh Krishnanjanappa <
jkrishnanjanappa@mvista.com> wrote:

> It helps to find/use native tools under ${STAGING_BINDIR_NATIVE}/*-native.
>
> Solving below error:
>
> $ oe-run-native python3-native python3
> Running bitbake -e python3-native
> Error: Unable to find 'python3' in
> .../tmp/work/x86_64-linux/python3-native/3.5.5-r1.0/recipe-sysroot-native/usr/bin:.../tmp/work/x86_64-linux/python3-native/3.5.5-r1.0/recipe-sysroot-native/bin:.../tmp/work/x86_64-linux/python3-native/3.5.5-r1.0/recipe-sysroot-native/usr/sbin:.../tmp/work/x86_64-linux/python3-native/3.5.5-r1.0/recipe-sysroot-native/sbin
> Error: Have you run 'bitbake python3-native -caddto_recipe_sysroot'?
> -- snip --
>
> After this change we have native python3 to be found:
>
> $ oe-run-native python3-native python3
> Running bitbake -e python3-native
> Python 3.5.5 (default, Aug  8 2018, 17:45:49)
> [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)] on linux
> Type "help", "copyright", "credits" or "license" for more information.
> >>>
> -- snip --
>
> [YOCTO #12889]
>
> Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
> ---
>  scripts/oe-run-native | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/oe-run-native b/scripts/oe-run-native
> index bbdd1d8..8412b18 100755
> --- a/scripts/oe-run-native
> +++ b/scripts/oe-run-native
> @@ -55,7 +55,7 @@ fi
>  OLD_PATH=$PATH
>
>  # look for a tool only in native sysroot
>
> -PATH=$OECORE_NATIVE_SYSROOT/usr/bin:$OECORE_NATIVE_SYSROOT/bin:$OECORE_NATIVE_SYSROOT/usr/sbin:$OECORE_NATIVE_SYSROOT/sbin
> +PATH=$OECORE_NATIVE_SYSROOT/usr/bin:$OECORE_NATIVE_SYSROOT/bin:$OECORE_NATIVE_SYSROOT/usr/sbin:$OECORE_NATIVE_SYSROOT/sbin:$(find
> $OECORE_NATIVE_SYSROOT/usr/bin/*-native -maxdepth 1 -type d -printf ":%p")
>

If I'm reading this right, this will leave an empty entry in PATH if no
-native subdirectories are found, which is harmful. I'd suggest reworking
that.
-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2765 bytes --]

Re: [PATCH] oe-run-native: Add *-native directories under STAGING_BINDIR_NATIVE to PATH environment variable

[Jagadeesh Krishnanjanappa]

Thanks for the review. I have removed colon ":" before
find expression in v2.

Regards,
Jagadeesh

On Fri, Aug 17, 2018 at 2:59 AM, Christopher Larson <kergoth@gmail.com> wrote:
> On Thu, Aug 16, 2018 at 10:45 AM Jagadeesh Krishnanjanappa
> <jkrishnanjanappa@mvista.com> wrote:
>>
>> It helps to find/use native tools under ${STAGING_BINDIR_NATIVE}/*-native.
>>
>> Solving below error:
>>
>> $ oe-run-native python3-native python3
>> Running bitbake -e python3-native
>> Error: Unable to find 'python3' in
>> .../tmp/work/x86_64-linux/python3-native/3.5.5-r1.0/recipe-sysroot-native/usr/bin:.../tmp/work/x86_64-linux/python3-native/3.5.5-r1.0/recipe-sysroot-native/bin:.../tmp/work/x86_64-linux/python3-native/3.5.5-r1.0/recipe-sysroot-native/usr/sbin:.../tmp/work/x86_64-linux/python3-native/3.5.5-r1.0/recipe-sysroot-native/sbin
>> Error: Have you run 'bitbake python3-native -caddto_recipe_sysroot'?
>> -- snip --
>>
>> After this change we have native python3 to be found:
>>
>> $ oe-run-native python3-native python3
>> Running bitbake -e python3-native
>> Python 3.5.5 (default, Aug  8 2018, 17:45:49)
>> [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)] on linux
>> Type "help", "copyright", "credits" or "license" for more information.
>> >>>
>> -- snip --
>>
>> [YOCTO #12889]
>>
>> Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
>> ---
>>  scripts/oe-run-native | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/oe-run-native b/scripts/oe-run-native
>> index bbdd1d8..8412b18 100755
>> --- a/scripts/oe-run-native
>> +++ b/scripts/oe-run-native
>> @@ -55,7 +55,7 @@ fi
>>  OLD_PATH=$PATH
>>
>>  # look for a tool only in native sysroot
>>
>> -PATH=$OECORE_NATIVE_SYSROOT/usr/bin:$OECORE_NATIVE_SYSROOT/bin:$OECORE_NATIVE_SYSROOT/usr/sbin:$OECORE_NATIVE_SYSROOT/sbin
>>
>> +PATH=$OECORE_NATIVE_SYSROOT/usr/bin:$OECORE_NATIVE_SYSROOT/bin:$OECORE_NATIVE_SYSROOT/usr/sbin:$OECORE_NATIVE_SYSROOT/sbin:$(find
>> $OECORE_NATIVE_SYSROOT/usr/bin/*-native -maxdepth 1 -type d -printf ":%p")
>
>
> If I'm reading this right, this will leave an empty entry in PATH if no
> -native subdirectories are found, which is harmful. I'd suggest reworking
> that.
> --
> Christopher Larson
> kergoth at gmail dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Senior Software Engineer, Mentor Graphics