Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] mesa: disable LLVM on x86
@ 2018-09-06 15:07 Ross Burton
  2018-09-06 17:24 ` Khem Raj
  0 siblings, 1 reply; 3+ messages in thread
From: Ross Burton @ 2018-09-06 15:07 UTC (permalink / raw)
  To: openembedded-core

Whilst turning on the LLVM drivers is a honourable goal, the performance impact
is *huge*.  Instead let specific BSPs turn it on as required.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-graphics/mesa/mesa.inc | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
index dd626d9f00c..5afd0db4b7d 100644
--- a/meta/recipes-graphics/mesa/mesa.inc
+++ b/meta/recipes-graphics/mesa/mesa.inc
@@ -48,9 +48,6 @@ PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'wayland vulkan', d)} \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'x11 vulkan', 'dri3', '', d)} \
 		   "
 
-PACKAGECONFIG_append_x86 = " gallium-llvm gallium r600"
-PACKAGECONFIG_append_x86-64 = " gallium-llvm gallium r600"
-
 # "gbm" requires "dri", "opengl"
 PACKAGECONFIG[gbm] = "--enable-gbm,--disable-gbm"
 
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mesa: disable LLVM on x86
  2018-09-06 15:07 [PATCH] mesa: disable LLVM on x86 Ross Burton
@ 2018-09-06 17:24 ` Khem Raj
  2018-09-06 18:07   ` Burton, Ross
  0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2018-09-06 17:24 UTC (permalink / raw)
  To: Burton, Ross; +Cc: Patches and discussions about the oe-core layer

On Thu, Sep 6, 2018 at 8:07 AM Ross Burton <ross.burton@intel.com> wrote:
>
> Whilst turning on the LLVM drivers is a honourable goal, the performance impact
> is *huge*.  Instead let specific BSPs turn it on as required.
>

Can we turn this into a variable so we can add it in a bbappend ?

> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-graphics/mesa/mesa.inc | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
> index dd626d9f00c..5afd0db4b7d 100644
> --- a/meta/recipes-graphics/mesa/mesa.inc
> +++ b/meta/recipes-graphics/mesa/mesa.inc
> @@ -48,9 +48,6 @@ PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'wayland vulkan', d)} \
>                     ${@bb.utils.contains('DISTRO_FEATURES', 'x11 vulkan', 'dri3', '', d)} \
>                    "
>
> -PACKAGECONFIG_append_x86 = " gallium-llvm gallium r600"
> -PACKAGECONFIG_append_x86-64 = " gallium-llvm gallium r600"
> -
>  # "gbm" requires "dri", "opengl"
>  PACKAGECONFIG[gbm] = "--enable-gbm,--disable-gbm"
>
> --
> 2.11.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mesa: disable LLVM on x86
  2018-09-06 17:24 ` Khem Raj
@ 2018-09-06 18:07   ` Burton, Ross
  0 siblings, 0 replies; 3+ messages in thread
From: Burton, Ross @ 2018-09-06 18:07 UTC (permalink / raw)
  To: Khem Raj; +Cc: Patches and discussions about the oe-core layer

You can fiddle a packageconfig in a bbappend already.

On 6 September 2018 at 18:24, Khem Raj <raj.khem@gmail.com> wrote:
> On Thu, Sep 6, 2018 at 8:07 AM Ross Burton <ross.burton@intel.com> wrote:
>>
>> Whilst turning on the LLVM drivers is a honourable goal, the performance impact
>> is *huge*.  Instead let specific BSPs turn it on as required.
>>
>
> Can we turn this into a variable so we can add it in a bbappend ?
>
>> Signed-off-by: Ross Burton <ross.burton@intel.com>
>> ---
>>  meta/recipes-graphics/mesa/mesa.inc | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/meta/recipes-graphics/mesa/mesa.inc b/meta/recipes-graphics/mesa/mesa.inc
>> index dd626d9f00c..5afd0db4b7d 100644
>> --- a/meta/recipes-graphics/mesa/mesa.inc
>> +++ b/meta/recipes-graphics/mesa/mesa.inc
>> @@ -48,9 +48,6 @@ PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'wayland vulkan', d)} \
>>                     ${@bb.utils.contains('DISTRO_FEATURES', 'x11 vulkan', 'dri3', '', d)} \
>>                    "
>>
>> -PACKAGECONFIG_append_x86 = " gallium-llvm gallium r600"
>> -PACKAGECONFIG_append_x86-64 = " gallium-llvm gallium r600"
>> -
>>  # "gbm" requires "dri", "opengl"
>>  PACKAGECONFIG[gbm] = "--enable-gbm,--disable-gbm"
>>
>> --
>> 2.11.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-06 18:07 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-06 15:07 [PATCH] mesa: disable LLVM on x86 Ross Burton
2018-09-06 17:24 ` Khem Raj
2018-09-06 18:07   ` Burton, Ross

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox