* [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1
@ 2018-09-14 16:04 Armin Kuster
2018-09-14 16:04 ` [PATCH 2/3] xf86-video-fbdev: update to 0.5.0 Armin Kuster
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Armin Kuster @ 2018-09-14 16:04 UTC (permalink / raw)
To: akuster808, openembedded-core
removed included patch
Refresh 0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC
Remove 0001-config-fix-NULL-value-detection-for-ID_INPUT-being-u.patch
Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
...NULL-value-detection-for-ID_INPUT-being-u.patch | 40 -------------------
...onfigure.ac-Fix-check-for-CLOCK_MONOTONIC.patch | 19 +++++----
...003-modesetting-Fix-16-bit-depth-bpp-mode.patch | 46 ----------------------
.../xorg-xserver/xserver-xorg_1.19.6.bb | 33 ----------------
.../xorg-xserver/xserver-xorg_1.20.1.bb | 31 +++++++++++++++
5 files changed, 40 insertions(+), 129 deletions(-)
delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-value-detection-for-ID_INPUT-being-u.patch
delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/0003-modesetting-Fix-16-bit-depth-bpp-mode.patch
delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg_1.19.6.bb
create mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg_1.20.1.bb
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-value-detection-for-ID_INPUT-being-u.patch b/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-value-detection-for-ID_INPUT-being-u.patch
deleted file mode 100644
index 964d5dd..0000000
--- a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-value-detection-for-ID_INPUT-being-u.patch
+++ /dev/null
@@ -1,40 +0,0 @@
-From a309323328d9d6e0bf5d9ea1d75920e53b9beef3 Mon Sep 17 00:00:00 2001
-From: Peter Hutterer <peter.hutterer@who-t.net>
-Date: Fri, 5 Jan 2018 11:58:42 +1000
-Subject: [PATCH] config: fix NULL value detection for ID_INPUT being unset
-
-Erroneous condition caused us to keep going with all devices that didn't have
-ID_INPUT set.
-
-Fixes: 5aad81445c8c3d6
-Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104382
-Reviewed-by: Adam Jackson <ajax@redhat.com>
-Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
-Upstream-status: Backport
-https://patchwork.freedesktop.org/patch/196090/
-Affects: < 1.20.0
-[Yocto # 12899]
-
-Signed-off-by: Armin Kuster <akuser808@gmail.com>
-
----
- config/udev.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/config/udev.c b/config/udev.c
-index e198e8609..3a73189e2 100644
---- a/config/udev.c
-+++ b/config/udev.c
-@@ -135,7 +135,7 @@ device_added(struct udev_device *udev_device)
- #endif
-
- value = udev_device_get_property_value(udev_device, "ID_INPUT");
-- if (value && !strcmp(value, "0")) {
-+ if (!value || !strcmp(value, "0")) {
- LogMessageVerb(X_INFO, 10,
- "config/udev: ignoring device %s without "
- "property ID_INPUT set\n", path);
---
-2.17.1
-
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC.patch b/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC.patch
index 16ec3ed..020a1cf 100644
--- a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC.patch
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC.patch
@@ -1,12 +1,13 @@
-Discover monotonic clock using compile-time check
+From 8a91316c4a38f20e7866289f3d779a037d27a129 Mon Sep 17 00:00:00 2001
+From: Jussi Kukkonen <jussi.kukkonen@intel.com>
+Date: Mon, 12 Dec 2016 12:11:39 +0200
+Subject: [PATCH] Discover monotonic clock using compile-time check
monotonic clock check does not work when cross-compiling.
Upstream-Status: Denied [Does not work on OpenBSD]
Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
-
-
Original patch follows:
When xorg-xserver is being cross-compiled, there is currently no way
@@ -21,15 +22,16 @@ monotonic clock is available. This check can run just fine when we are
cross-compiling.
Signed-off-by: David James <davidjames at google.com>
+
---
configure.ac | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/configure.ac b/configure.ac
-index f7ab48c..26e85cd 100644
+index 2b21667..786e002 100644
--- a/configure.ac
+++ b/configure.ac
-@@ -1048,19 +1048,16 @@ if ! test "x$have_clock_gettime" = xno; then
+@@ -984,19 +984,16 @@ if ! test "x$have_clock_gettime" = xno; then
CPPFLAGS="$CPPFLAGS -D_POSIX_C_SOURCE=200112L"
fi
@@ -54,8 +56,5 @@ index f7ab48c..26e85cd 100644
- [MONOTONIC_CLOCK="cross compiling"])
+]])],[MONOTONIC_CLOCK=yes], [MONOTONIC_CLOCK=no])
- LIBS="$LIBS_SAVE"
- CPPFLAGS="$CPPFLAGS_SAVE"
---
-2.1.4
-
+ if test "$MONOTONIC_CLOCK" = "cross compiling"; then
+ AC_CHECK_DECL([CLOCK_MONOTONIC],[MONOTONIC_CLOCK="guessing yes"],[MONOTONIC_CLOCK=no],[#include <time.h>])
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0003-modesetting-Fix-16-bit-depth-bpp-mode.patch b/meta/recipes-graphics/xorg-xserver/xserver-xorg/0003-modesetting-Fix-16-bit-depth-bpp-mode.patch
deleted file mode 100644
index 5243761..0000000
--- a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0003-modesetting-Fix-16-bit-depth-bpp-mode.patch
+++ /dev/null
@@ -1,46 +0,0 @@
-From 5028ef46ff4ab0930224b71024a7349b05610d42 Mon Sep 17 00:00:00 2001
-From: Stefan Agner <stefan@agner.ch>
-Date: Thu, 22 Dec 2016 15:41:06 +0100
-Subject: [PATCH] modesetting: Fix 16 bit depth/bpp mode
-
-When setting DefaultDepth to 16 in the Screen section, the current
-code requests a 32 bpp framebuffer, however the X-Server seems to
-assumes 16 bpp.
-
-Fixes commit 21217d02168d ("modesetting: Implement 32->24 bpp
-conversion in shadow update")
-
-Signed-off-by: Stefan Agner <stefan@agner.ch>
-
-Upstream-Status: Submitted [1]
-
-[1] https://lists.x.org/archives/xorg-devel/2016-December/052113.html
----
- hw/xfree86/drivers/modesetting/driver.c | 4 +++-
- 1 file changed, 3 insertions(+), 1 deletion(-)
-
-diff --git a/hw/xfree86/drivers/modesetting/driver.c b/hw/xfree86/drivers/modesetting/driver.c
-index d7030e5..647ad83 100644
---- a/hw/xfree86/drivers/modesetting/driver.c
-+++ b/hw/xfree86/drivers/modesetting/driver.c
-@@ -930,7 +930,7 @@ PreInit(ScrnInfoPtr pScrn, int flags)
- "Using 24bpp hw front buffer with 32bpp shadow\n");
- defaultbpp = 32;
- } else {
-- ms->drmmode.kbpp = defaultbpp;
-+ ms->drmmode.kbpp = 0;
- }
- bppflags = PreferConvert24to32 | SupportConvert24to32 | Support32bppFb;
-
-@@ -950,6 +950,8 @@ PreInit(ScrnInfoPtr pScrn, int flags)
- return FALSE;
- }
- xf86PrintDepthBpp(pScrn);
-+ if (!ms->drmmode.kbpp)
-+ ms->drmmode.kbpp = pScrn->bitsPerPixel;
-
- /* Process the options */
- xf86CollectOptions(pScrn, NULL);
---
-2.7.4
-
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg_1.19.6.bb b/meta/recipes-graphics/xorg-xserver/xserver-xorg_1.19.6.bb
deleted file mode 100644
index 7e8a954..0000000
--- a/meta/recipes-graphics/xorg-xserver/xserver-xorg_1.19.6.bb
+++ /dev/null
@@ -1,33 +0,0 @@
-require xserver-xorg.inc
-
-SRC_URI += "file://musl-arm-inb-outb.patch \
- file://0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC.patch \
- file://0003-modesetting-Fix-16-bit-depth-bpp-mode.patch \
- file://0003-Remove-check-for-useSIGIO-option.patch \
- file://0001-xf86pciBus.c-use-Intel-ddx-only-for-pre-gen4-hardwar.patch \
- file://0001-config-fix-NULL-value-detection-for-ID_INPUT-being-u.patch \
- "
-SRC_URI[md5sum] = "3e47777ff034a331aed2322b078694a8"
-SRC_URI[sha256sum] = "a732502f1db000cf36a376cd0c010ffdbf32ecdd7f1fa08ba7f5bdf9601cc197"
-
-# These extensions are now integrated into the server, so declare the migration
-# path for in-place upgrades.
-
-RREPLACES_${PN} = "${PN}-extension-dri \
- ${PN}-extension-dri2 \
- ${PN}-extension-record \
- ${PN}-extension-extmod \
- ${PN}-extension-dbe \
- "
-RPROVIDES_${PN} = "${PN}-extension-dri \
- ${PN}-extension-dri2 \
- ${PN}-extension-record \
- ${PN}-extension-extmod \
- ${PN}-extension-dbe \
- "
-RCONFLICTS_${PN} = "${PN}-extension-dri \
- ${PN}-extension-dri2 \
- ${PN}-extension-record \
- ${PN}-extension-extmod \
- ${PN}-extension-dbe \
- "
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg_1.20.1.bb b/meta/recipes-graphics/xorg-xserver/xserver-xorg_1.20.1.bb
new file mode 100644
index 0000000..2cbcd90
--- /dev/null
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg_1.20.1.bb
@@ -0,0 +1,31 @@
+require xserver-xorg.inc
+
+SRC_URI += "file://musl-arm-inb-outb.patch \
+ file://0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC.patch \
+ file://0003-Remove-check-for-useSIGIO-option.patch \
+ file://0001-xf86pciBus.c-use-Intel-ddx-only-for-pre-gen4-hardwar.patch \
+ "
+SRC_URI[md5sum] = "e525846d1d0af5732ba835f2e2ec066d"
+SRC_URI[sha256sum] = "59c99fe86fe75b8164c6567bfc6e982aecc2e4a51e6fbac1b842d5d00549e918"
+
+# These extensions are now integrated into the server, so declare the migration
+# path for in-place upgrades.
+
+RREPLACES_${PN} = "${PN}-extension-dri \
+ ${PN}-extension-dri2 \
+ ${PN}-extension-record \
+ ${PN}-extension-extmod \
+ ${PN}-extension-dbe \
+ "
+RPROVIDES_${PN} = "${PN}-extension-dri \
+ ${PN}-extension-dri2 \
+ ${PN}-extension-record \
+ ${PN}-extension-extmod \
+ ${PN}-extension-dbe \
+ "
+RCONFLICTS_${PN} = "${PN}-extension-dri \
+ ${PN}-extension-dri2 \
+ ${PN}-extension-record \
+ ${PN}-extension-extmod \
+ ${PN}-extension-dbe \
+ "
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] xf86-video-fbdev: update to 0.5.0
2018-09-14 16:04 [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1 Armin Kuster
@ 2018-09-14 16:04 ` Armin Kuster
2018-09-14 16:04 ` [PATCH 3/3] xorg-xserver 1.20 qemumips fix Armin Kuster
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Armin Kuster @ 2018-09-14 16:04 UTC (permalink / raw)
To: akuster808, openembedded-core
Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
meta/recipes-graphics/xorg-driver/xf86-video-fbdev_0.4.4.bb | 9 ---------
meta/recipes-graphics/xorg-driver/xf86-video-fbdev_0.5.0.bb | 9 +++++++++
2 files changed, 9 insertions(+), 9 deletions(-)
delete mode 100644 meta/recipes-graphics/xorg-driver/xf86-video-fbdev_0.4.4.bb
create mode 100644 meta/recipes-graphics/xorg-driver/xf86-video-fbdev_0.5.0.bb
diff --git a/meta/recipes-graphics/xorg-driver/xf86-video-fbdev_0.4.4.bb b/meta/recipes-graphics/xorg-driver/xf86-video-fbdev_0.4.4.bb
deleted file mode 100644
index 52e9bd1..0000000
--- a/meta/recipes-graphics/xorg-driver/xf86-video-fbdev_0.4.4.bb
+++ /dev/null
@@ -1,9 +0,0 @@
-require xorg-driver-video.inc
-
-SUMMARY = "X.Org X server -- fbdev display driver"
-DESCRIPTION = "fbdev is an Xorg driver for framebuffer devices. This is a non-accelerated driver."
-
-LIC_FILES_CHKSUM = "file://COPYING;md5=d8cbd99fff773f92e844948f74ef0df8"
-
-SRC_URI[md5sum] = "3931c0e19d441cc576dc088f9eb9fd73"
-SRC_URI[sha256sum] = "9dd4b326498223abbfdf786089a46ea3db4fa6bbd341308eb48a9e00bc3fd51b"
diff --git a/meta/recipes-graphics/xorg-driver/xf86-video-fbdev_0.5.0.bb b/meta/recipes-graphics/xorg-driver/xf86-video-fbdev_0.5.0.bb
new file mode 100644
index 0000000..7b4ac88
--- /dev/null
+++ b/meta/recipes-graphics/xorg-driver/xf86-video-fbdev_0.5.0.bb
@@ -0,0 +1,9 @@
+require xorg-driver-video.inc
+
+SUMMARY = "X.Org X server -- fbdev display driver"
+DESCRIPTION = "fbdev is an Xorg driver for framebuffer devices. This is a non-accelerated driver."
+
+LIC_FILES_CHKSUM = "file://COPYING;md5=d8cbd99fff773f92e844948f74ef0df8"
+
+SRC_URI[md5sum] = "f07475655376be5a124d8187aacd87b6"
+SRC_URI[sha256sum] = "dcc3d85f378022180e437a9ec00a59b6cb7680ff79c40394d695060af2374699"
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] xorg-xserver 1.20 qemumips fix
2018-09-14 16:04 [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1 Armin Kuster
2018-09-14 16:04 ` [PATCH 2/3] xf86-video-fbdev: update to 0.5.0 Armin Kuster
@ 2018-09-14 16:04 ` Armin Kuster
2018-09-14 16:35 ` ✗ patchtest: failure for "xserver-xorg: upgrade 1.19.6 -..." and 2 more Patchwork
2018-09-18 2:51 ` [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1 Mittal, Anuj
3 siblings, 0 replies; 7+ messages in thread
From: Armin Kuster @ 2018-09-14 16:04 UTC (permalink / raw)
To: akuster808, openembedded-core
When updating to xorg-xserve 1.20+, mips64 would not work correctly and
cause the xorg test to fail.
Changing the DefaultDepth fixed that.
[Yocto # 12845]
Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
.../xorg-xserver/xserver-xf86-config/qemumips64/xorg.conf | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xf86-config/qemumips64/xorg.conf b/meta/recipes-graphics/xorg-xserver/xserver-xf86-config/qemumips64/xorg.conf
index f4cd139..03b94dc 100644
--- a/meta/recipes-graphics/xorg-xserver/xserver-xf86-config/qemumips64/xorg.conf
+++ b/meta/recipes-graphics/xorg-xserver/xserver-xf86-config/qemumips64/xorg.conf
@@ -26,6 +26,7 @@ Section "Screen"
Identifier "Default Screen"
Device "Graphics Controller"
Monitor "Generic Monitor"
+ DefaultDepth 16
SubSection "Display"
Modes "640x480"
EndSubSection
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* ✗ patchtest: failure for "xserver-xorg: upgrade 1.19.6 -..." and 2 more
2018-09-14 16:04 [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1 Armin Kuster
2018-09-14 16:04 ` [PATCH 2/3] xf86-video-fbdev: update to 0.5.0 Armin Kuster
2018-09-14 16:04 ` [PATCH 3/3] xorg-xserver 1.20 qemumips fix Armin Kuster
@ 2018-09-14 16:35 ` Patchwork
2018-09-18 2:51 ` [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1 Mittal, Anuj
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-09-14 16:35 UTC (permalink / raw)
To: Armin Kuster; +Cc: openembedded-core
== Series Details ==
Series: "xserver-xorg: upgrade 1.19.6 -..." and 2 more
Revision: 1
URL : https://patchwork.openembedded.org/series/14080/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Patch [3/3] xorg-xserver 1.20 qemumips fix
Issue Shortlog does not follow expected format [test_shortlog_format]
Suggested fix Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1
2018-09-14 16:04 [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1 Armin Kuster
` (2 preceding siblings ...)
2018-09-14 16:35 ` ✗ patchtest: failure for "xserver-xorg: upgrade 1.19.6 -..." and 2 more Patchwork
@ 2018-09-18 2:51 ` Mittal, Anuj
2018-09-19 4:14 ` Khem Raj
3 siblings, 1 reply; 7+ messages in thread
From: Mittal, Anuj @ 2018-09-18 2:51 UTC (permalink / raw)
To: Armin Kuster, openembedded-core@lists.openembedded.org
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-
> core-bounces@lists.openembedded.org] On Behalf Of Armin Kuster
> Sent: Saturday, September 15, 2018 12:04 AM
> To: akuster808@gmail.com; openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1
>
> removed included patch
>
> Refresh 0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC
> Remove 0001-config-fix-NULL-value-detection-for-ID_INPUT-being-u.patch
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
> ...NULL-value-detection-for-ID_INPUT-being-u.patch | 40 -------------------
> ...onfigure.ac-Fix-check-for-CLOCK_MONOTONIC.patch | 19 +++++---- ...003-
> modesetting-Fix-16-bit-depth-bpp-mode.patch | 46 ----------------------
> .../xorg-xserver/xserver-xorg_1.19.6.bb | 33 ----------------
> .../xorg-xserver/xserver-xorg_1.20.1.bb | 31 +++++++++++++++
> 5 files changed, 40 insertions(+), 129 deletions(-) delete mode 100644 meta/recipes-
> graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-value-detection-for-
> ID_INPUT-being-u.patch
> delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/0003-
> modesetting-Fix-16-bit-depth-bpp-mode.patch
> delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg_1.19.6.bb
> create mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg_1.20.1.bb
>
> diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-
> value-detection-for-ID_INPUT-being-u.patch b/meta/recipes-graphics/xorg-
> xserver/xserver-xorg/0001-config-fix-NULL-value-detection-for-ID_INPUT-being-
> u.patch
> deleted file mode 100644
> index 964d5dd..0000000
> --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-value-
> detection-for-ID_INPUT-being-u.patch
> +++ /dev/null
> @@ -1,40 +0,0 @@
> -From a309323328d9d6e0bf5d9ea1d75920e53b9beef3 Mon Sep 17 00:00:00 2001
> -From: Peter Hutterer <peter.hutterer@who-t.net>
> -Date: Fri, 5 Jan 2018 11:58:42 +1000
> -Subject: [PATCH] config: fix NULL value detection for ID_INPUT being unset
> -
> -Erroneous condition caused us to keep going with all devices that didn't have -
> ID_INPUT set.
> -
> -Fixes: 5aad81445c8c3d6
> -Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104382
> -Reviewed-by: Adam Jackson <ajax@redhat.com>
> -Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
> -
> -Upstream-status: Backport
> -https://patchwork.freedesktop.org/patch/196090/
> -Affects: < 1.20.0
> -[Yocto # 12899]
> -
> -Signed-off-by: Armin Kuster <akuser808@gmail.com>
> -
> ----
> - config/udev.c | 2 +-
> - 1 file changed, 1 insertion(+), 1 deletion(-)
> -
> -diff --git a/config/udev.c b/config/udev.c -index e198e8609..3a73189e2 100644
> ---- a/config/udev.c
> -+++ b/config/udev.c
> -@@ -135,7 +135,7 @@ device_added(struct udev_device *udev_device)
> - #endif
> -
> - value = udev_device_get_property_value(udev_device, "ID_INPUT");
> -- if (value && !strcmp(value, "0")) {
> -+ if (!value || !strcmp(value, "0")) {
> - LogMessageVerb(X_INFO, 10,
> - "config/udev: ignoring device %s without "
> - "property ID_INPUT set\n", path);
> ---
> -2.17.1
> -
> diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-Fix-
> check-for-CLOCK_MONOTONIC.patch b/meta/recipes-graphics/xorg-
> xserver/xserver-xorg/0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC.patch
> index 16ec3ed..020a1cf 100644
> --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-Fix-check-
> for-CLOCK_MONOTONIC.patch
> +++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-
> +++ Fix-check-for-CLOCK_MONOTONIC.patch
> @@ -1,12 +1,13 @@
> -Discover monotonic clock using compile-time check
> +From 8a91316c4a38f20e7866289f3d779a037d27a129 Mon Sep 17 00:00:00 2001
> +From: Jussi Kukkonen <jussi.kukkonen@intel.com>
> +Date: Mon, 12 Dec 2016 12:11:39 +0200
> +Subject: [PATCH] Discover monotonic clock using compile-time check
>
> monotonic clock check does not work when cross-compiling.
>
> Upstream-Status: Denied [Does not work on OpenBSD]
> Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
>
> -
> -
> Original patch follows:
>
> When xorg-xserver is being cross-compiled, there is currently no way @@ -21,15
> +22,16 @@ monotonic clock is available. This check can run just fine when we are
> cross-compiling.
>
> Signed-off-by: David James <davidjames at google.com>
> +
> ---
> configure.ac | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/configure.ac b/configure.ac -index f7ab48c..26e85cd 100644
> +index 2b21667..786e002 100644
> --- a/configure.ac
> +++ b/configure.ac
> -@@ -1048,19 +1048,16 @@ if ! test "x$have_clock_gettime" = xno; then
> +@@ -984,19 +984,16 @@ if ! test "x$have_clock_gettime" = xno; then
> CPPFLAGS="$CPPFLAGS -D_POSIX_C_SOURCE=200112L"
> fi
>
> @@ -54,8 +56,5 @@ index f7ab48c..26e85cd 100644
> - [MONOTONIC_CLOCK="cross compiling"])
> +]])],[MONOTONIC_CLOCK=yes], [MONOTONIC_CLOCK=no])
>
> - LIBS="$LIBS_SAVE"
> - CPPFLAGS="$CPPFLAGS_SAVE"
> ---
> -2.1.4
> -
> + if test "$MONOTONIC_CLOCK" = "cross compiling"; then
> +
> AC_CHECK_DECL([CLOCK_MONOTONIC],[MONOTONIC_CLOCK="guessing
> + yes"],[MONOTONIC_CLOCK=no],[#include <time.h>])
Do we still need this patch after this change in 1.20:
https://cgit.freedesktop.org/xorg/xserver/commit/configure.ac?h=server-1.20-branch&id=c601c8faf54ff9e3bcbc653421828d71042deef7
Thanks,
Anuj
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1
2018-09-18 2:51 ` [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1 Mittal, Anuj
@ 2018-09-19 4:14 ` Khem Raj
2018-09-20 12:37 ` Burton, Ross
0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2018-09-19 4:14 UTC (permalink / raw)
To: Anuj Mittal; +Cc: Patches and discussions about the oe-core layer
On Mon, Sep 17, 2018 at 7:51 PM Mittal, Anuj <anuj.mittal@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-
> > core-bounces@lists.openembedded.org] On Behalf Of Armin Kuster
> > Sent: Saturday, September 15, 2018 12:04 AM
> > To: akuster808@gmail.com; openembedded-core@lists.openembedded.org
> > Subject: [OE-core] [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1
> >
> > removed included patch
> >
> > Refresh 0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC
> > Remove 0001-config-fix-NULL-value-detection-for-ID_INPUT-being-u.patch
> >
> > Signed-off-by: Armin Kuster <akuster808@gmail.com>
> > ---
> > ...NULL-value-detection-for-ID_INPUT-being-u.patch | 40 -------------------
> > ...onfigure.ac-Fix-check-for-CLOCK_MONOTONIC.patch | 19 +++++---- ...003-
> > modesetting-Fix-16-bit-depth-bpp-mode.patch | 46 ----------------------
> > .../xorg-xserver/xserver-xorg_1.19.6.bb | 33 ----------------
> > .../xorg-xserver/xserver-xorg_1.20.1.bb | 31 +++++++++++++++
> > 5 files changed, 40 insertions(+), 129 deletions(-) delete mode 100644 meta/recipes-
> > graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-value-detection-for-
> > ID_INPUT-being-u.patch
> > delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/0003-
> > modesetting-Fix-16-bit-depth-bpp-mode.patch
> > delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg_1.19.6.bb
> > create mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg_1.20.1.bb
> >
> > diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-
> > value-detection-for-ID_INPUT-being-u.patch b/meta/recipes-graphics/xorg-
> > xserver/xserver-xorg/0001-config-fix-NULL-value-detection-for-ID_INPUT-being-
> > u.patch
> > deleted file mode 100644
> > index 964d5dd..0000000
> > --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-value-
> > detection-for-ID_INPUT-being-u.patch
> > +++ /dev/null
> > @@ -1,40 +0,0 @@
> > -From a309323328d9d6e0bf5d9ea1d75920e53b9beef3 Mon Sep 17 00:00:00 2001
> > -From: Peter Hutterer <peter.hutterer@who-t.net>
> > -Date: Fri, 5 Jan 2018 11:58:42 +1000
> > -Subject: [PATCH] config: fix NULL value detection for ID_INPUT being unset
> > -
> > -Erroneous condition caused us to keep going with all devices that didn't have -
> > ID_INPUT set.
> > -
> > -Fixes: 5aad81445c8c3d6
> > -Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104382
> > -Reviewed-by: Adam Jackson <ajax@redhat.com>
> > -Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
> > -
> > -Upstream-status: Backport
> > -https://patchwork.freedesktop.org/patch/196090/
> > -Affects: < 1.20.0
> > -[Yocto # 12899]
> > -
> > -Signed-off-by: Armin Kuster <akuser808@gmail.com>
> > -
> > ----
> > - config/udev.c | 2 +-
> > - 1 file changed, 1 insertion(+), 1 deletion(-)
> > -
> > -diff --git a/config/udev.c b/config/udev.c -index e198e8609..3a73189e2 100644
> > ---- a/config/udev.c
> > -+++ b/config/udev.c
> > -@@ -135,7 +135,7 @@ device_added(struct udev_device *udev_device)
> > - #endif
> > -
> > - value = udev_device_get_property_value(udev_device, "ID_INPUT");
> > -- if (value && !strcmp(value, "0")) {
> > -+ if (!value || !strcmp(value, "0")) {
> > - LogMessageVerb(X_INFO, 10,
> > - "config/udev: ignoring device %s without "
> > - "property ID_INPUT set\n", path);
> > ---
> > -2.17.1
> > -
> > diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-Fix-
> > check-for-CLOCK_MONOTONIC.patch b/meta/recipes-graphics/xorg-
> > xserver/xserver-xorg/0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC.patch
> > index 16ec3ed..020a1cf 100644
> > --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-Fix-check-
> > for-CLOCK_MONOTONIC.patch
> > +++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-
> > +++ Fix-check-for-CLOCK_MONOTONIC.patch
> > @@ -1,12 +1,13 @@
> > -Discover monotonic clock using compile-time check
> > +From 8a91316c4a38f20e7866289f3d779a037d27a129 Mon Sep 17 00:00:00 2001
> > +From: Jussi Kukkonen <jussi.kukkonen@intel.com>
> > +Date: Mon, 12 Dec 2016 12:11:39 +0200
> > +Subject: [PATCH] Discover monotonic clock using compile-time check
> >
> > monotonic clock check does not work when cross-compiling.
> >
> > Upstream-Status: Denied [Does not work on OpenBSD]
> > Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
> >
> > -
> > -
> > Original patch follows:
> >
> > When xorg-xserver is being cross-compiled, there is currently no way @@ -21,15
> > +22,16 @@ monotonic clock is available. This check can run just fine when we are
> > cross-compiling.
> >
> > Signed-off-by: David James <davidjames at google.com>
> > +
> > ---
> > configure.ac | 17 +++++++----------
> > 1 file changed, 7 insertions(+), 10 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac -index f7ab48c..26e85cd 100644
> > +index 2b21667..786e002 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > -@@ -1048,19 +1048,16 @@ if ! test "x$have_clock_gettime" = xno; then
> > +@@ -984,19 +984,16 @@ if ! test "x$have_clock_gettime" = xno; then
> > CPPFLAGS="$CPPFLAGS -D_POSIX_C_SOURCE=200112L"
> > fi
> >
> > @@ -54,8 +56,5 @@ index f7ab48c..26e85cd 100644
> > - [MONOTONIC_CLOCK="cross compiling"])
> > +]])],[MONOTONIC_CLOCK=yes], [MONOTONIC_CLOCK=no])
> >
> > - LIBS="$LIBS_SAVE"
> > - CPPFLAGS="$CPPFLAGS_SAVE"
> > ---
> > -2.1.4
> > -
> > + if test "$MONOTONIC_CLOCK" = "cross compiling"; then
> > +
> > AC_CHECK_DECL([CLOCK_MONOTONIC],[MONOTONIC_CLOCK="guessing
> > + yes"],[MONOTONIC_CLOCK=no],[#include <time.h>])
>
>
> Do we still need this patch after this change in 1.20:
>
no we dont
> https://cgit.freedesktop.org/xorg/xserver/commit/configure.ac?h=server-1.20-branch&id=c601c8faf54ff9e3bcbc653421828d71042deef7
>
> Thanks,
> Anuj
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1
2018-09-19 4:14 ` Khem Raj
@ 2018-09-20 12:37 ` Burton, Ross
0 siblings, 0 replies; 7+ messages in thread
From: Burton, Ross @ 2018-09-20 12:37 UTC (permalink / raw)
To: Khem Raj; +Cc: OE-core
Patch to remove that sent. I also sent upstream the arm/musl/inb patch.
Ross
On Wed, 19 Sep 2018 at 05:15, Khem Raj <raj.khem@gmail.com> wrote:
>
> On Mon, Sep 17, 2018 at 7:51 PM Mittal, Anuj <anuj.mittal@intel.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-
> > > core-bounces@lists.openembedded.org] On Behalf Of Armin Kuster
> > > Sent: Saturday, September 15, 2018 12:04 AM
> > > To: akuster808@gmail.com; openembedded-core@lists.openembedded.org
> > > Subject: [OE-core] [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1
> > >
> > > removed included patch
> > >
> > > Refresh 0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC
> > > Remove 0001-config-fix-NULL-value-detection-for-ID_INPUT-being-u.patch
> > >
> > > Signed-off-by: Armin Kuster <akuster808@gmail.com>
> > > ---
> > > ...NULL-value-detection-for-ID_INPUT-being-u.patch | 40 -------------------
> > > ...onfigure.ac-Fix-check-for-CLOCK_MONOTONIC.patch | 19 +++++---- ...003-
> > > modesetting-Fix-16-bit-depth-bpp-mode.patch | 46 ----------------------
> > > .../xorg-xserver/xserver-xorg_1.19.6.bb | 33 ----------------
> > > .../xorg-xserver/xserver-xorg_1.20.1.bb | 31 +++++++++++++++
> > > 5 files changed, 40 insertions(+), 129 deletions(-) delete mode 100644 meta/recipes-
> > > graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-value-detection-for-
> > > ID_INPUT-being-u.patch
> > > delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg/0003-
> > > modesetting-Fix-16-bit-depth-bpp-mode.patch
> > > delete mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg_1.19.6.bb
> > > create mode 100644 meta/recipes-graphics/xorg-xserver/xserver-xorg_1.20.1.bb
> > >
> > > diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-
> > > value-detection-for-ID_INPUT-being-u.patch b/meta/recipes-graphics/xorg-
> > > xserver/xserver-xorg/0001-config-fix-NULL-value-detection-for-ID_INPUT-being-
> > > u.patch
> > > deleted file mode 100644
> > > index 964d5dd..0000000
> > > --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-config-fix-NULL-value-
> > > detection-for-ID_INPUT-being-u.patch
> > > +++ /dev/null
> > > @@ -1,40 +0,0 @@
> > > -From a309323328d9d6e0bf5d9ea1d75920e53b9beef3 Mon Sep 17 00:00:00 2001
> > > -From: Peter Hutterer <peter.hutterer@who-t.net>
> > > -Date: Fri, 5 Jan 2018 11:58:42 +1000
> > > -Subject: [PATCH] config: fix NULL value detection for ID_INPUT being unset
> > > -
> > > -Erroneous condition caused us to keep going with all devices that didn't have -
> > > ID_INPUT set.
> > > -
> > > -Fixes: 5aad81445c8c3d6
> > > -Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104382
> > > -Reviewed-by: Adam Jackson <ajax@redhat.com>
> > > -Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
> > > -
> > > -Upstream-status: Backport
> > > -https://patchwork.freedesktop.org/patch/196090/
> > > -Affects: < 1.20.0
> > > -[Yocto # 12899]
> > > -
> > > -Signed-off-by: Armin Kuster <akuser808@gmail.com>
> > > -
> > > ----
> > > - config/udev.c | 2 +-
> > > - 1 file changed, 1 insertion(+), 1 deletion(-)
> > > -
> > > -diff --git a/config/udev.c b/config/udev.c -index e198e8609..3a73189e2 100644
> > > ---- a/config/udev.c
> > > -+++ b/config/udev.c
> > > -@@ -135,7 +135,7 @@ device_added(struct udev_device *udev_device)
> > > - #endif
> > > -
> > > - value = udev_device_get_property_value(udev_device, "ID_INPUT");
> > > -- if (value && !strcmp(value, "0")) {
> > > -+ if (!value || !strcmp(value, "0")) {
> > > - LogMessageVerb(X_INFO, 10,
> > > - "config/udev: ignoring device %s without "
> > > - "property ID_INPUT set\n", path);
> > > ---
> > > -2.17.1
> > > -
> > > diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-Fix-
> > > check-for-CLOCK_MONOTONIC.patch b/meta/recipes-graphics/xorg-
> > > xserver/xserver-xorg/0001-configure.ac-Fix-check-for-CLOCK_MONOTONIC.patch
> > > index 16ec3ed..020a1cf 100644
> > > --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-Fix-check-
> > > for-CLOCK_MONOTONIC.patch
> > > +++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg/0001-configure.ac-
> > > +++ Fix-check-for-CLOCK_MONOTONIC.patch
> > > @@ -1,12 +1,13 @@
> > > -Discover monotonic clock using compile-time check
> > > +From 8a91316c4a38f20e7866289f3d779a037d27a129 Mon Sep 17 00:00:00 2001
> > > +From: Jussi Kukkonen <jussi.kukkonen@intel.com>
> > > +Date: Mon, 12 Dec 2016 12:11:39 +0200
> > > +Subject: [PATCH] Discover monotonic clock using compile-time check
> > >
> > > monotonic clock check does not work when cross-compiling.
> > >
> > > Upstream-Status: Denied [Does not work on OpenBSD]
> > > Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
> > >
> > > -
> > > -
> > > Original patch follows:
> > >
> > > When xorg-xserver is being cross-compiled, there is currently no way @@ -21,15
> > > +22,16 @@ monotonic clock is available. This check can run just fine when we are
> > > cross-compiling.
> > >
> > > Signed-off-by: David James <davidjames at google.com>
> > > +
> > > ---
> > > configure.ac | 17 +++++++----------
> > > 1 file changed, 7 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/configure.ac b/configure.ac -index f7ab48c..26e85cd 100644
> > > +index 2b21667..786e002 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > -@@ -1048,19 +1048,16 @@ if ! test "x$have_clock_gettime" = xno; then
> > > +@@ -984,19 +984,16 @@ if ! test "x$have_clock_gettime" = xno; then
> > > CPPFLAGS="$CPPFLAGS -D_POSIX_C_SOURCE=200112L"
> > > fi
> > >
> > > @@ -54,8 +56,5 @@ index f7ab48c..26e85cd 100644
> > > - [MONOTONIC_CLOCK="cross compiling"])
> > > +]])],[MONOTONIC_CLOCK=yes], [MONOTONIC_CLOCK=no])
> > >
> > > - LIBS="$LIBS_SAVE"
> > > - CPPFLAGS="$CPPFLAGS_SAVE"
> > > ---
> > > -2.1.4
> > > -
> > > + if test "$MONOTONIC_CLOCK" = "cross compiling"; then
> > > +
> > > AC_CHECK_DECL([CLOCK_MONOTONIC],[MONOTONIC_CLOCK="guessing
> > > + yes"],[MONOTONIC_CLOCK=no],[#include <time.h>])
> >
> >
> > Do we still need this patch after this change in 1.20:
> >
>
> no we dont
>
> > https://cgit.freedesktop.org/xorg/xserver/commit/configure.ac?h=server-1.20-branch&id=c601c8faf54ff9e3bcbc653421828d71042deef7
> >
> > Thanks,
> > Anuj
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-09-20 12:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-14 16:04 [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1 Armin Kuster
2018-09-14 16:04 ` [PATCH 2/3] xf86-video-fbdev: update to 0.5.0 Armin Kuster
2018-09-14 16:04 ` [PATCH 3/3] xorg-xserver 1.20 qemumips fix Armin Kuster
2018-09-14 16:35 ` ✗ patchtest: failure for "xserver-xorg: upgrade 1.19.6 -..." and 2 more Patchwork
2018-09-18 2:51 ` [PATCH 1/3] xserver-xorg: upgrade 1.19.6 -> 1.20.1 Mittal, Anuj
2018-09-19 4:14 ` Khem Raj
2018-09-20 12:37 ` Burton, Ross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox