From: Kevin Hao <kexin.hao@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH 2/4] wic: isoimage-isohybrid: Drop the unnecessary reference of STAGING_DATADIR
Date: Sat, 29 Sep 2018 15:01:45 +0800 [thread overview]
Message-ID: <20180929070147.88203-3-kexin.hao@windriver.com> (raw)
In-Reply-To: <20180929070147.88203-1-kexin.hao@windriver.com>
Actually the bootimg_dir is the value of the STAGING_DATADIR, so we
can use it directly.
Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
---
scripts/lib/wic/plugins/source/isoimage-isohybrid.py | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py b/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
index 170077c22c21..d9c7b55f03c5 100644
--- a/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
+++ b/scripts/lib/wic/plugins/source/isoimage-isohybrid.py
@@ -360,11 +360,6 @@ class IsoImagePlugin(SourcePlugin):
chmod_cmd = "chmod 644 %s" % bootimg
exec_cmd(chmod_cmd)
- # Prepare files for legacy boot
- syslinux_dir = get_bitbake_var("STAGING_DATADIR")
- if not syslinux_dir:
- raise WicError("Couldn't find STAGING_DATADIR, exiting.")
-
if os.path.exists("%s/isolinux" % isodir):
shutil.rmtree("%s/isolinux" % isodir)
@@ -373,19 +368,19 @@ class IsoImagePlugin(SourcePlugin):
cls.do_configure_syslinux(creator, cr_workdir)
- install_cmd = "install -m 444 %s/syslinux/ldlinux.sys " % syslinux_dir
+ install_cmd = "install -m 444 %s/syslinux/ldlinux.sys " % bootimg_dir
install_cmd += "%s/isolinux/ldlinux.sys" % isodir
exec_cmd(install_cmd)
- install_cmd = "install -m 444 %s/syslinux/isohdpfx.bin " % syslinux_dir
+ install_cmd = "install -m 444 %s/syslinux/isohdpfx.bin " % bootimg_dir
install_cmd += "%s/isolinux/isohdpfx.bin" % isodir
exec_cmd(install_cmd)
- install_cmd = "install -m 644 %s/syslinux/isolinux.bin " % syslinux_dir
+ install_cmd = "install -m 644 %s/syslinux/isolinux.bin " % bootimg_dir
install_cmd += "%s/isolinux/isolinux.bin" % isodir
exec_cmd(install_cmd)
- install_cmd = "install -m 644 %s/syslinux/ldlinux.c32 " % syslinux_dir
+ install_cmd = "install -m 644 %s/syslinux/ldlinux.c32 " % bootimg_dir
install_cmd += "%s/isolinux/ldlinux.c32" % isodir
exec_cmd(install_cmd)
--
2.14.4
next prev parent reply other threads:[~2018-09-29 7:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 7:01 [PATCH 0/4] Fix the build failure when creating a multilib wic Kevin Hao
2018-09-29 7:01 ` [PATCH 1/4] wic: bootimg-pcbios: Drop the unnecessary reference of STAGING_DATADIR Kevin Hao
2018-09-29 7:01 ` Kevin Hao [this message]
2018-09-29 7:01 ` [PATCH 3/4] bitbake.conf: Introduce variables used to access the other recipe specific sysroot directory in multilib case Kevin Hao
2018-10-01 14:30 ` Richard Purdie
2018-09-29 7:01 ` [PATCH 4/4] wic: Set the right bootimg_dir when building a multilib image Kevin Hao
2018-09-29 7:37 ` ✗ patchtest: failure for Fix the build failure when creating a multilib wic Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929070147.88203-3-kexin.hao@windriver.com \
--to=kexin.hao@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox