From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Kevin Hao <kexin.hao@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/4] bitbake.conf: Introduce variables used to access the other recipe specific sysroot directory in multilib case
Date: Mon, 01 Oct 2018 15:30:33 +0100 [thread overview]
Message-ID: <fe91943fdc053f9804ca1a2a628e39d64de44d3c.camel@linuxfoundation.org> (raw)
In-Reply-To: <20180929070147.88203-4-kexin.hao@windriver.com>
On Sat, 2018-09-29 at 15:01 +0800, Kevin Hao wrote:
> When multilib is enabled, there would be two different recipe
> specific
> sysroot directories:
> libxx-recipe-sysroot
> recipe-sysroot
>
> We do need to access the files under the "recipe-sysroot" directory
> in some cases. So introduces these variables for this purpose.
>
> Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
> ---
> meta/conf/bitbake.conf | 4 ++++
> meta/conf/multilib.conf | 1 +
> 2 files changed, 5 insertions(+)
This doesn't look like a good idea to me. With multilib its very easy
just to add in special case options and make it do the right thing
until something else needs 'fixing'. What is harder but works out
better in the long run is to figure out the real underlying problem and
the solution. This patch adds datadir but paves the way to add all the
other *dir variants.
Also, the name "RECIPE_ALT_SYSROOT" is horrible, its near impossible to
know what "ALT" means. Alternative to what?
So whilst I understand what this is trying to do, we need to come up
with a better way, sorry. I've tried thinking how to do it differently
but don't have a proposal right now, sorry.
Cheers,
Richard
next prev parent reply other threads:[~2018-10-01 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 7:01 [PATCH 0/4] Fix the build failure when creating a multilib wic Kevin Hao
2018-09-29 7:01 ` [PATCH 1/4] wic: bootimg-pcbios: Drop the unnecessary reference of STAGING_DATADIR Kevin Hao
2018-09-29 7:01 ` [PATCH 2/4] wic: isoimage-isohybrid: " Kevin Hao
2018-09-29 7:01 ` [PATCH 3/4] bitbake.conf: Introduce variables used to access the other recipe specific sysroot directory in multilib case Kevin Hao
2018-10-01 14:30 ` Richard Purdie [this message]
2018-09-29 7:01 ` [PATCH 4/4] wic: Set the right bootimg_dir when building a multilib image Kevin Hao
2018-09-29 7:37 ` ✗ patchtest: failure for Fix the build failure when creating a multilib wic Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe91943fdc053f9804ca1a2a628e39d64de44d3c.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=kexin.hao@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox