Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] glib-2.0: add missing locale dependencies to PN-ptest
@ 2018-10-09 11:00 Ross Burton
  2018-11-07 12:40 ` Mauno Niko
  0 siblings, 1 reply; 4+ messages in thread
From: Ross Burton @ 2018-10-09 11:00 UTC (permalink / raw)
  To: openembedded-core

The test suite skips several tests if the required locales are not found, so add
them as dependencies of glib-2.0-ptest.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
index ad4f2aebd71..f78aa9bfe6d 100644
--- a/meta/recipes-core/glib-2.0/glib.inc
+++ b/meta/recipes-core/glib-2.0/glib.inc
@@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\
             glibc-gconv-iso8859-15 \
             glibc-charmap-invariant \
             glibc-localedata-translit-cjk-variants \
+            locale-base-tr-tr \
+            locale-base-lt-lt \
+            locale-base-ja-jp.euc-jp \
+            locale-base-fa-ir \
+            locale-base-ru-ru \
+            locale-base-de-de \
+            locale-base-pl-pl \
+            locale-base-hr-hr \
+            locale-base-el-gr \
+            locale-base-fr-fr \
+            locale-base-fr-fr \
+            locale-base-es-es \
+            locale-base-en-gb \
            "
 
 INSANE_SKIP_${PN}-ptest += "libdir"
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] glib-2.0: add missing locale dependencies to PN-ptest
  2018-10-09 11:00 [PATCH] glib-2.0: add missing locale dependencies to PN-ptest Ross Burton
@ 2018-11-07 12:40 ` Mauno Niko
  2018-11-07 13:55   ` Burton, Ross
  0 siblings, 1 reply; 4+ messages in thread
From: Mauno Niko @ 2018-11-07 12:40 UTC (permalink / raw)
  To: Ross Burton, openembedded-core@lists.openembedded.org

On 10/09/2018 02:00 PM, Ross Burton wrote:
> The test suite skips several tests if the required locales are not found, so add
> them as dependencies of glib-2.0-ptest.
> 
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>   meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
> index ad4f2aebd71..f78aa9bfe6d 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\
>               glibc-gconv-iso8859-15 \
>               glibc-charmap-invariant \
>               glibc-localedata-translit-cjk-variants \
> +            locale-base-tr-tr \
> +            locale-base-lt-lt \
> +            locale-base-ja-jp.euc-jp \
> +            locale-base-fa-ir \
> +            locale-base-ru-ru \
> +            locale-base-de-de \
> +            locale-base-pl-pl \
> +            locale-base-hr-hr \
> +            locale-base-el-gr \
> +            locale-base-fr-fr \
> +            locale-base-fr-fr \
> +            locale-base-es-es \
> +            locale-base-en-gb \
>              "
>   
>   INSANE_SKIP_${PN}-ptest += "libdir"
> 

Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in DISTRO_FEATURES, it would seem after this commit I'm seeing following warnings during bitbake:

  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps]
  WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps]

If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer appear.

-Niko


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] glib-2.0: add missing locale dependencies to PN-ptest
  2018-11-07 12:40 ` Mauno Niko
@ 2018-11-07 13:55   ` Burton, Ross
  2018-11-07 14:28     ` Martin Jansa
  0 siblings, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2018-11-07 13:55 UTC (permalink / raw)
  To: Niko Mauno; +Cc: OE-core

Sounds about right.  Not sure what would count as a solution here?

Ross
On Wed, 7 Nov 2018 at 12:40, Mauno Niko <niko.mauno@vaisala.com> wrote:
>
> On 10/09/2018 02:00 PM, Ross Burton wrote:
> > The test suite skips several tests if the required locales are not found, so add
> > them as dependencies of glib-2.0-ptest.
> >
> > Signed-off-by: Ross Burton <ross.burton@intel.com>
> > ---
> >   meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++
> >   1 file changed, 13 insertions(+)
> >
> > diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
> > index ad4f2aebd71..f78aa9bfe6d 100644
> > --- a/meta/recipes-core/glib-2.0/glib.inc
> > +++ b/meta/recipes-core/glib-2.0/glib.inc
> > @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\
> >               glibc-gconv-iso8859-15 \
> >               glibc-charmap-invariant \
> >               glibc-localedata-translit-cjk-variants \
> > +            locale-base-tr-tr \
> > +            locale-base-lt-lt \
> > +            locale-base-ja-jp.euc-jp \
> > +            locale-base-fa-ir \
> > +            locale-base-ru-ru \
> > +            locale-base-de-de \
> > +            locale-base-pl-pl \
> > +            locale-base-hr-hr \
> > +            locale-base-el-gr \
> > +            locale-base-fr-fr \
> > +            locale-base-fr-fr \
> > +            locale-base-es-es \
> > +            locale-base-en-gb \
> >              "
> >
> >   INSANE_SKIP_${PN}-ptest += "libdir"
> >
>
> Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in DISTRO_FEATURES, it would seem after this commit I'm seeing following warnings during bitbake:
>
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps]
>   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps]
>
> If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer appear.
>
> -Niko


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] glib-2.0: add missing locale dependencies to PN-ptest
  2018-11-07 13:55   ` Burton, Ross
@ 2018-11-07 14:28     ` Martin Jansa
  0 siblings, 0 replies; 4+ messages in thread
From: Martin Jansa @ 2018-11-07 14:28 UTC (permalink / raw)
  To: Burton, Ross; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 4253 bytes --]

It was also discussed here:
http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156591.html

and resulted in few fixes for _remove operator and:
http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156695.html
http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156696.html

On Wed, Nov 7, 2018 at 2:55 PM Burton, Ross <ross.burton@intel.com> wrote:

> Sounds about right.  Not sure what would count as a solution here?
>
> Ross
> On Wed, 7 Nov 2018 at 12:40, Mauno Niko <niko.mauno@vaisala.com> wrote:
> >
> > On 10/09/2018 02:00 PM, Ross Burton wrote:
> > > The test suite skips several tests if the required locales are not
> found, so add
> > > them as dependencies of glib-2.0-ptest.
> > >
> > > Signed-off-by: Ross Burton <ross.burton@intel.com>
> > > ---
> > >   meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++
> > >   1 file changed, 13 insertions(+)
> > >
> > > diff --git a/meta/recipes-core/glib-2.0/glib.inc
> b/meta/recipes-core/glib-2.0/glib.inc
> > > index ad4f2aebd71..f78aa9bfe6d 100644
> > > --- a/meta/recipes-core/glib-2.0/glib.inc
> > > +++ b/meta/recipes-core/glib-2.0/glib.inc
> > > @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\
> > >               glibc-gconv-iso8859-15 \
> > >               glibc-charmap-invariant \
> > >               glibc-localedata-translit-cjk-variants \
> > > +            locale-base-tr-tr \
> > > +            locale-base-lt-lt \
> > > +            locale-base-ja-jp.euc-jp \
> > > +            locale-base-fa-ir \
> > > +            locale-base-ru-ru \
> > > +            locale-base-de-de \
> > > +            locale-base-pl-pl \
> > > +            locale-base-hr-hr \
> > > +            locale-base-el-gr \
> > > +            locale-base-fr-fr \
> > > +            locale-base-fr-fr \
> > > +            locale-base-es-es \
> > > +            locale-base-en-gb \
> > >              "
> > >
> > >   INSANE_SKIP_${PN}-ptest += "libdir"
> > >
> >
> > Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in
> DISTRO_FEATURES, it would seem after this commit I'm seeing following
> warnings during bitbake:
> >
> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest
> rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps]
> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest
> rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps]
> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest
> rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps]
> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest
> rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps]
> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest
> rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps]
> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest
> rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps]
> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest
> rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps]
> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest
> rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency?
> [build-deps]
> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest
> rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps]
> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest
> rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps]
> >   WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest
> rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps]
> >
> > If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer
> appear.
> >
> > -Niko
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 5790 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-11-08 23:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-09 11:00 [PATCH] glib-2.0: add missing locale dependencies to PN-ptest Ross Burton
2018-11-07 12:40 ` Mauno Niko
2018-11-07 13:55   ` Burton, Ross
2018-11-07 14:28     ` Martin Jansa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox