* [PATCH 1/2] tk: add new recipe(move from meta-oe)
2018-10-25 8:39 [PATCH 0/2] python: add tk support mingli.yu
@ 2018-10-25 8:39 ` mingli.yu
2018-10-25 8:39 ` [PATCH 2/2] python: add tk support mingli.yu
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: mingli.yu @ 2018-10-25 8:39 UTC (permalink / raw)
To: richard.purdie, openembedded-core
From: Mingli Yu <Mingli.Yu@windriver.com>
Move tk recipe from meta-oe to add tkinter
support for python.
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
.../tk/configure.use.fontconfig.with.xft.patch | 13 ++++
meta/recipes-devtools/tcltk/tk/confsearch.diff | 35 ++++++++++
meta/recipes-devtools/tcltk/tk/fix-xft.diff | 16 +++++
meta/recipes-devtools/tcltk/tk/non-linux.diff | 27 ++++++++
meta/recipes-devtools/tcltk/tk/tklibrary.diff | 22 ++++++
meta/recipes-devtools/tcltk/tk/tkprivate.diff | 41 +++++++++++
meta/recipes-devtools/tcltk/tk_8.6.8.bb | 79 ++++++++++++++++++++++
7 files changed, 233 insertions(+)
create mode 100644 meta/recipes-devtools/tcltk/tk/configure.use.fontconfig.with.xft.patch
create mode 100644 meta/recipes-devtools/tcltk/tk/confsearch.diff
create mode 100644 meta/recipes-devtools/tcltk/tk/fix-xft.diff
create mode 100644 meta/recipes-devtools/tcltk/tk/non-linux.diff
create mode 100644 meta/recipes-devtools/tcltk/tk/tklibrary.diff
create mode 100644 meta/recipes-devtools/tcltk/tk/tkprivate.diff
create mode 100644 meta/recipes-devtools/tcltk/tk_8.6.8.bb
diff --git a/meta/recipes-devtools/tcltk/tk/configure.use.fontconfig.with.xft.patch b/meta/recipes-devtools/tcltk/tk/configure.use.fontconfig.with.xft.patch
new file mode 100644
index 0000000..a0c157f
--- /dev/null
+++ b/meta/recipes-devtools/tcltk/tk/configure.use.fontconfig.with.xft.patch
@@ -0,0 +1,13 @@
+--- a/configure.in.orig 2014-05-10 14:35:39.859147385 +0000
++++ b/configure.in 2014-05-10 14:36:20.282925184 +0000
+@@ -554,8 +554,8 @@
+ dnl make sure package configurator (xft-config or pkg-config
+ dnl says that xft is present.
+ found_xft=yes
+- XFT_CFLAGS=`pkg-config --cflags xft 2>/dev/null` || found_xft="no"
+- XFT_LIBS=`pkg-config --libs xft 2>/dev/null` || found_xft="no"
++ XFT_CFLAGS=`pkg-config --cflags xft fontconfig 2>/dev/null` || found_xft="no"
++ XFT_LIBS=`pkg-config --libs xft fontconfig 2>/dev/null` || found_xft="no"
+ AC_MSG_RESULT([$found_xft])
+ dnl make sure that compiling against Xft header file doesn't bomb
+ if test "$found_xft" = "yes" ; then
diff --git a/meta/recipes-devtools/tcltk/tk/confsearch.diff b/meta/recipes-devtools/tcltk/tk/confsearch.diff
new file mode 100644
index 0000000..4dbd9a4
--- /dev/null
+++ b/meta/recipes-devtools/tcltk/tk/confsearch.diff
@@ -0,0 +1,35 @@
+Patch by Sergei Golovan allows to find tclConfig.sh in /usr/share/tcltk/tcl8.5
+and tkConfig.sh in /usr/share/tcltk/tk8.5 where they are located in Debian
+installation.
+
+--- tk8.5-8.5.8.orig/unix/configure
++++ tk8.5-8.5.8/unix/configure
+@@ -1431,7 +1431,8 @@
+ `ls -d /usr/contrib/lib 2>/dev/null` \
+ `ls -d /usr/local/lib 2>/dev/null` \
+ `ls -d /usr/pkg/lib 2>/dev/null` \
++ `ls -d /usr/share/tcltk/tcl8.5 2>/dev/null` \
+ `ls -d /usr/lib 2>/dev/null` \
+ `ls -d /usr/lib64 2>/dev/null` \
+ ; do
+ if test -f "$i/tclConfig.sh" ; then
+--- tk8.5-8.5.8.orig/unix/tcl.m4
++++ tk8.5-8.5.8/unix/tcl.m4
+@@ -93,7 +93,8 @@
+ `ls -d /usr/contrib/lib 2>/dev/null` \
+ `ls -d /usr/local/lib 2>/dev/null` \
+ `ls -d /usr/pkg/lib 2>/dev/null` \
++ `ls -d /usr/share/tcltk/tcl8.5 2>/dev/null` \
+ `ls -d /usr/lib 2>/dev/null` \
+ `ls -d /usr/lib64 2>/dev/null` \
+ ; do
+ if test -f "$i/tclConfig.sh" ; then
+@@ -223,7 +224,8 @@
+ `ls -d ${prefix}/lib 2>/dev/null` \
+ `ls -d /usr/local/lib 2>/dev/null` \
+ `ls -d /usr/contrib/lib 2>/dev/null` \
++ `ls -d /usr/share/tcltk/tk8.5 2>/dev/null` \
+ `ls -d /usr/lib 2>/dev/null` \
+ `ls -d /usr/lib64 2>/dev/null` \
+ ; do
+ if test -f "$i/tkConfig.sh" ; then
diff --git a/meta/recipes-devtools/tcltk/tk/fix-xft.diff b/meta/recipes-devtools/tcltk/tk/fix-xft.diff
new file mode 100644
index 0000000..d1bb710
--- /dev/null
+++ b/meta/recipes-devtools/tcltk/tk/fix-xft.diff
@@ -0,0 +1,16 @@
+--- /tmp/configure.in 2010-05-19 13:29:03.000000000 +0200
++++ unix/configure.in 2010-05-19 13:42:05.000000000 +0200
+@@ -526,13 +526,9 @@
+ found_xft="yes"
+ dnl make sure package configurator (xft-config or pkg-config
+ dnl says that xft is present.
+- XFT_CFLAGS=`xft-config --cflags 2>/dev/null` || found_xft="no"
+- XFT_LIBS=`xft-config --libs 2>/dev/null` || found_xft="no"
+- if test "$found_xft" = "no" ; then
+ found_xft=yes
+ XFT_CFLAGS=`pkg-config --cflags xft 2>/dev/null` || found_xft="no"
+ XFT_LIBS=`pkg-config --libs xft 2>/dev/null` || found_xft="no"
+- fi
+ AC_MSG_RESULT([$found_xft])
+ dnl make sure that compiling against Xft header file doesn't bomb
+ if test "$found_xft" = "yes" ; then
diff --git a/meta/recipes-devtools/tcltk/tk/non-linux.diff b/meta/recipes-devtools/tcltk/tk/non-linux.diff
new file mode 100644
index 0000000..7d31f9f
--- /dev/null
+++ b/meta/recipes-devtools/tcltk/tk/non-linux.diff
@@ -0,0 +1,27 @@
+Patch by Sergei Golovan (originally by Mike Markley and Chris Waters) fixes
+building on non-linux Debian architectures.
+
+--- tk8.5-8.5.8.orig/unix/configure
++++ tk8.5-8.5.8/unix/configure
+@@ -4447,6 +4447,9 @@
+ if test "`uname -s`" = "AIX" ; then
+ tcl_cv_sys_version=AIX-`uname -v`.`uname -r`
+ fi
++ if test "`uname -s`" = "NetBSD" -a -f /etc/debian_version ; then
++ tcl_cv_sys_version=NetBSD-Debian
++ fi
+ fi
+ fi
+
+--- tk8.5-8.5.8.orig/unix/tcl.m4
++++ tk8.5-8.5.8/unix/tcl.m4
+@@ -962,6 +962,9 @@
+ if test "`uname -s`" = "AIX" ; then
+ tcl_cv_sys_version=AIX-`uname -v`.`uname -r`
+ fi
++ if test "`uname -s`" = "NetBSD" -a -f /etc/debian_version ; then
++ tcl_cv_sys_version=NetBSD-Debian
++ fi
+ fi
+ fi
+ ])
diff --git a/meta/recipes-devtools/tcltk/tk/tklibrary.diff b/meta/recipes-devtools/tcltk/tk/tklibrary.diff
new file mode 100644
index 0000000..ee38c2a
--- /dev/null
+++ b/meta/recipes-devtools/tcltk/tk/tklibrary.diff
@@ -0,0 +1,22 @@
+--- tk8.5-8.5.8.orig/unix/configure
++++ tk8.5-8.5.8/unix/configure
+@@ -11070,7 +11070,7 @@
+ TCL_STUB_FLAGS="-DUSE_TCL_STUBS"
+ fi
+
+-TK_LIBRARY='$(prefix)/lib/tk$(VERSION)'
++test -z "$TK_LIBRARY" && TK_LIBRARY='$(prefix)/lib/tk$(VERSION)'
+ PRIVATE_INCLUDE_DIR='$(includedir)'
+ HTML_DIR='$(DISTDIR)/html'
+ TK_PKG_DIR='tk$(VERSION)'
+--- tk8.5-8.5.8.orig/unix/configure.in
++++ tk8.5-8.5.8/unix/configure.in
+@@ -607,7 +607,7 @@
+ TCL_STUB_FLAGS="-DUSE_TCL_STUBS"
+ fi
+
+-TK_LIBRARY='$(prefix)/lib/tk$(VERSION)'
++test -z "$TK_LIBRARY" && TK_LIBRARY='$(prefix)/lib/tk$(VERSION)'
+ PRIVATE_INCLUDE_DIR='$(includedir)'
+ HTML_DIR='$(DISTDIR)/html'
+ TK_PKG_DIR='tk$(VERSION)'
diff --git a/meta/recipes-devtools/tcltk/tk/tkprivate.diff b/meta/recipes-devtools/tcltk/tk/tkprivate.diff
new file mode 100644
index 0000000..4e15469
--- /dev/null
+++ b/meta/recipes-devtools/tcltk/tk/tkprivate.diff
@@ -0,0 +1,41 @@
+Patch by Chris Waters sets path which are normally point to a directory
+with Tk sources to a subdirectory of /usr/include/tcl8.4 (debian/rules
+puts private Tk headers there).
+
+--- tk8.5-8.5.8.orig/unix/tkConfig.sh.in
++++ tk8.5-8.5.8/unix/tkConfig.sh.in
+@@ -55,7 +55,7 @@
+
+ # String to pass to linker to pick up the Tk library from its
+ # build directory.
+-TK_BUILD_LIB_SPEC='@TK_BUILD_LIB_SPEC@'
++TK_BUILD_LIB_SPEC='@TK_LIB_SPEC@'
+
+ # String to pass to linker to pick up the Tk library from its
+ # installed directory.
+@@ -71,7 +71,7 @@
+ # different place than the directory containing the source files, this
+ # points to the location of the sources, not the location where Tk was
+ # compiled.
+-TK_SRC_DIR='@TK_SRC_DIR@'
++TK_SRC_DIR='@includedir@/tk-private'
+
+ # Needed if you want to make a 'fat' shared library library
+ # containing tk objects or link a different wish.
+@@ -86,14 +86,14 @@
+
+ # String to pass to linker to pick up the Tk stub library from its
+ # build directory.
+-TK_BUILD_STUB_LIB_SPEC='@TK_BUILD_STUB_LIB_SPEC@'
++TK_BUILD_STUB_LIB_SPEC='@TK_STUB_LIB_SPEC@'
+
+ # String to pass to linker to pick up the Tk stub library from its
+ # installed directory.
+ TK_STUB_LIB_SPEC='@TK_STUB_LIB_SPEC@'
+
+ # Path to the Tk stub library in the build directory.
+-TK_BUILD_STUB_LIB_PATH='@TK_BUILD_STUB_LIB_PATH@'
++TK_BUILD_STUB_LIB_PATH='@TK_STUB_LIB_PATH@'
+
+ # Path to the Tk stub library in the install directory.
+ TK_STUB_LIB_PATH='@TK_STUB_LIB_PATH@'
diff --git a/meta/recipes-devtools/tcltk/tk_8.6.8.bb b/meta/recipes-devtools/tcltk/tk_8.6.8.bb
new file mode 100644
index 0000000..13dc4d7
--- /dev/null
+++ b/meta/recipes-devtools/tcltk/tk_8.6.8.bb
@@ -0,0 +1,79 @@
+SUMMARY = "Tool Command Language ToolKit Extension"
+HOMEPAGE = "http://tcl.sourceforge.net"
+SECTION = "devel/tcltk"
+
+# http://www.tcl.tk/software/tcltk/license.html
+LICENSE = "tcl"
+LIC_FILES_CHKSUM = "file://../license.terms;md5=c88f99decec11afa967ad33d314f87fe \
+ file://../compat/license.terms;md5=c88f99decec11afa967ad33d314f87fe \
+ file://../doc/license.terms;md5=c88f99decec11afa967ad33d314f87fe \
+ file://../library/license.terms;md5=c88f99decec11afa967ad33d314f87fe \
+ file://../macosx/license.terms;md5=c88f99decec11afa967ad33d314f87fe \
+ file://../tests/license.terms;md5=c88f99decec11afa967ad33d314f87fe \
+ file://../unix/license.terms;md5=c88f99decec11afa967ad33d314f87fe \
+ file://../win/license.terms;md5=c88f99decec11afa967ad33d314f87fe \
+ file://../xlib/license.terms;md5=c88f99decec11afa967ad33d314f87fe \
+"
+
+DEPENDS = "tcl virtual/libx11 libxt"
+
+SRC_URI = "\
+ ${SOURCEFORGE_MIRROR}/tcl/${BPN}${PV}-src.tar.gz \
+ file://confsearch.diff;striplevel=2 \
+ file://non-linux.diff;striplevel=2 \
+ file://tklibrary.diff;striplevel=2 \
+ file://tkprivate.diff;striplevel=2 \
+ file://fix-xft.diff \
+ file://configure.use.fontconfig.with.xft.patch \
+"
+SRC_URI[md5sum] = "5e0faecba458ee1386078fb228d008ba"
+SRC_URI[sha256sum] = "49e7bca08dde95195a27f594f7c850b088be357a7c7096e44e1158c7a5fd7b33"
+
+S = "${WORKDIR}/${BPN}${PV}/unix"
+
+# Short version format: "8.6"
+VER = "${@os.path.splitext(d.getVar('PV'))[0]}"
+
+LDFLAGS += "-Wl,-rpath,${libdir}/tcltk/${PV}/lib"
+inherit autotools distro_features_check
+# depends on virtual/libx11
+REQUIRED_DISTRO_FEATURES = "x11"
+
+EXTRA_OECONF = "\
+ --enable-threads \
+ --with-x \
+ --with-tcl=${STAGING_BINDIR_CROSS} \
+ --libdir=${libdir} \
+"
+
+do_install_append() {
+ ln -sf libtk${VER}.so ${D}${libdir}/libtk${VER}.so.0
+ oe_libinstall -so libtk${VER} ${D}${libdir}
+ ln -sf wish${VER} ${D}${bindir}/wish
+
+ # Even after passing libdir=${libdir} at config, some incorrect dirs are still generated for the multilib build
+ if [ "$libdir" != "/usr/lib" ]; then
+ # Move files to correct library directory
+ mv ${D}/usr/lib/tk${VER}/* ${D}/${libdir}/tk${VER}/
+ # Remove unneeded/incorrect dir ('usr/lib/')
+ rm -rf ${D}/usr/lib
+ fi
+}
+
+PACKAGECONFIG ??= "xft"
+PACKAGECONFIG[xft] = "--enable-xft,--disable-xft,xft"
+PACKAGECONFIG[xss] = "--enable-xss,--disable-xss,libxscrnsaver libxext"
+
+PACKAGES =+ "${PN}-lib"
+
+FILES_${PN}-lib = "${libdir}/libtk${VER}.so*"
+FILES_${PN} += "${libdir}/tk*"
+
+# isn't getting picked up by shlibs code
+RDEPENDS_${PN} += "tk-lib"
+RDEPENDS_${PN}_class-native = ""
+
+BBCLASSEXTEND = "native"
+
+# Fix the path in sstate
+SSTATE_SCAN_FILES += "*Config.sh"
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] python: add tk support
2018-10-25 8:39 [PATCH 0/2] python: add tk support mingli.yu
2018-10-25 8:39 ` [PATCH 1/2] tk: add new recipe(move from meta-oe) mingli.yu
@ 2018-10-25 8:39 ` mingli.yu
2018-10-25 9:08 ` ✗ patchtest: failure for " Patchwork
2018-10-29 12:51 ` [PATCH 0/2] " Burton, Ross
3 siblings, 0 replies; 8+ messages in thread
From: mingli.yu @ 2018-10-25 8:39 UTC (permalink / raw)
To: richard.purdie, openembedded-core
From: Mingli Yu <Mingli.Yu@windriver.com>
Enable tk to add tk support for python.
before the patch:
# python
Python 2.7.15 (default, Oct 25 2018, 08:12:45)
[GCC 8.2.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import Tkinter
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib64/python2.7/lib-tk/Tkinter.py", line 39, in <module>
import _tkinter # If this fails your Python may not be configured for Tk
ImportError: No module named _tkinter
>>>
after the patch:
# python
Python 2.7.15 (default, Oct 25 2018, 08:12:45)
[GCC 8.2.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import Tkinter
>>>
Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
.../python/avoid_warning_about_tkinter.patch | 29 ----------------------
.../python/python/python2-manifest.json | 8 +++---
meta/recipes-devtools/python/python_2.7.15.bb | 8 +++---
3 files changed, 10 insertions(+), 35 deletions(-)
delete mode 100644 meta/recipes-devtools/python/python/avoid_warning_about_tkinter.patch
diff --git a/meta/recipes-devtools/python/python/avoid_warning_about_tkinter.patch b/meta/recipes-devtools/python/python/avoid_warning_about_tkinter.patch
deleted file mode 100644
index 287095f..0000000
--- a/meta/recipes-devtools/python/python/avoid_warning_about_tkinter.patch
+++ /dev/null
@@ -1,29 +0,0 @@
-_tkinter module needs tk module along with tcl. tk is not yet integrated
-in yocto so we skip the check for this module.
-Avoid a warning by not adding this module to missing variable.
-
-Upstream-Status: Inappropriate [distribution]
-
-Also simply disable the tk module since its not in DEPENDS.
-Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
-
-Index: Python-2.7.13/setup.py
-===================================================================
---- Python-2.7.13.orig/setup.py
-+++ Python-2.7.13/setup.py
-@@ -1783,10 +1783,12 @@ class PyBuildExt(build_ext):
- self.extensions.extend(exts)
-
- # Call the method for detecting whether _tkinter can be compiled
-- self.detect_tkinter(inc_dirs, lib_dirs)
-+ # self.detect_tkinter(inc_dirs, lib_dirs)
-
-- if '_tkinter' not in [e.name for e in self.extensions]:
-- missing.append('_tkinter')
-+ # tkinter module will not be avalaible as yocto
-+ # doesn't have tk integrated (yet)
-+ #if '_tkinter' not in [e.name for e in self.extensions]:
-+ # missing.append('_tkinter')
-
- ## # Uncomment these lines if you want to play with xxmodule.c
- ## ext = Extension('xx', ['xxmodule.c'])
diff --git a/meta/recipes-devtools/python/python/python2-manifest.json b/meta/recipes-devtools/python/python/python2-manifest.json
index 260fa6f..7b49e94 100644
--- a/meta/recipes-devtools/python/python/python2-manifest.json
+++ b/meta/recipes-devtools/python/python/python2-manifest.json
@@ -963,10 +963,12 @@
"tkinter": {
"summary": "Python Tcl/Tk bindings",
"rdepends": [
- "core"
+ "core",
+ "tk"
],
"files": [
- "${libdir}/python2.7/lib-tk"
+ "${libdir}/python2.7/lib-tk",
+ "${libdir}/python2.7/lib-dynload/_tkinter.so"
]
},
"unittest": {
@@ -1043,4 +1045,4 @@
"${libdir}/python2.7/lib-dynload/zlib.so"
]
}
-}
\ No newline at end of file
+}
diff --git a/meta/recipes-devtools/python/python_2.7.15.bb b/meta/recipes-devtools/python/python_2.7.15.bb
index dd969d8..a6ecbb9 100644
--- a/meta/recipes-devtools/python/python_2.7.15.bb
+++ b/meta/recipes-devtools/python/python_2.7.15.bb
@@ -1,6 +1,6 @@
require python.inc
-DEPENDS = "python-native libffi bzip2 gdbm openssl \
+DEPENDS = "python-native libffi bzip2 gdbm openssl tk \
readline sqlite3 zlib virtual/crypt"
PR = "${INC_PR}"
@@ -21,7 +21,6 @@ SRC_URI += "\
file://setuptweaks.patch \
file://check-if-target-is-64b-not-host.patch \
file://search_db_h_in_inc_dirs_and_avoid_warning.patch \
- file://avoid_warning_about_tkinter.patch \
file://avoid_warning_for_sunos_specific_module.patch \
file://python-2.7.3-remove-bsdb-rpath.patch \
file://run-ptest \
@@ -227,7 +226,10 @@ python(){
# Make it work with or without $PN
if '${PN}' in value:
value=value.split('-')[1]
- d.appendVar('RDEPENDS_' + pypackage, ' ' + pn + '-' + value)
+ if "tkinter" in pypackage and value == "tk":
+ d.appendVar('RDEPENDS_' + pypackage, ' ' + value)
+ else:
+ d.appendVar('RDEPENDS_' + pypackage, ' ' + pn + '-' + value)
d.setVar('SUMMARY_' + pypackage, python_manifest[key]['summary'])
# Prepending so to avoid python-misc getting everything
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* ✗ patchtest: failure for python: add tk support
2018-10-25 8:39 [PATCH 0/2] python: add tk support mingli.yu
2018-10-25 8:39 ` [PATCH 1/2] tk: add new recipe(move from meta-oe) mingli.yu
2018-10-25 8:39 ` [PATCH 2/2] python: add tk support mingli.yu
@ 2018-10-25 9:08 ` Patchwork
2018-10-29 12:51 ` [PATCH 0/2] " Burton, Ross
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-10-25 9:08 UTC (permalink / raw)
To: mingli.yu; +Cc: openembedded-core
== Series Details ==
Series: python: add tk support
Revision: 1
URL : https://patchwork.openembedded.org/series/14668/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue A patch file has been added, but does not have a Signed-off-by tag [test_signed_off_by_presence]
Suggested fix Sign off the added patch file (meta/recipes-devtools/tcltk/tk/configure.use.fontconfig.with.xft.patch)
* Issue Added patch file is missing Upstream-Status in the header [test_upstream_status_presence_format]
Suggested fix Add Upstream-Status: <Valid status> to the header of meta/recipes-devtools/tcltk/tk/configure.use.fontconfig.with.xft.patch
Standard format Upstream-Status: <Valid status>
Valid status Pending, Accepted, Backport, Denied, Inappropriate [reason], Submitted [where]
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] python: add tk support
2018-10-25 8:39 [PATCH 0/2] python: add tk support mingli.yu
` (2 preceding siblings ...)
2018-10-25 9:08 ` ✗ patchtest: failure for " Patchwork
@ 2018-10-29 12:51 ` Burton, Ross
2018-10-30 4:52 ` Randy MacLeod
3 siblings, 1 reply; 8+ messages in thread
From: Burton, Ross @ 2018-10-29 12:51 UTC (permalink / raw)
To: Mingli Yu; +Cc: OE-core
Terrified to ask, but why?
On Thu, 25 Oct 2018 at 09:39, <mingli.yu@windriver.com> wrote:
>
> 1, move tk recipe from meta-oe
> 2, enable tk to add tk support
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 0/2] python: add tk support
2018-10-29 12:51 ` [PATCH 0/2] " Burton, Ross
@ 2018-10-30 4:52 ` Randy MacLeod
2018-10-30 11:11 ` Burton, Ross
2018-11-05 9:29 ` Yu, Mingli
0 siblings, 2 replies; 8+ messages in thread
From: Randy MacLeod @ 2018-10-30 4:52 UTC (permalink / raw)
To: openembedded-core, Burton, Ross, Yu, Mingli, Khem Raj
On 10/29/18 8:51 AM, Burton, Ross wrote:
> Terrified to ask, but why?
> On Thu, 25 Oct 2018 at 09:39, <mingli.yu@windriver.com> wrote:
>>
>> 1, move tk recipe from meta-oe
>> 2, enable tk to add tk support
Well, tcl and tk do go together and Khem's comment from 2013
suggested that it might be pulled into oe-core some day.
I think what started us down this path is a FACE [1] compliance test.
If there's resistance to moving the package to oe-core, can we
enable python-tk even if tk stayed in meta-oe, Grace?
Also, this should be done using using PACKAGECONFIG?
Finally, what about python3-tk ?
../Randy
[1] https://en.wikipedia.org/wiki/Future_Airborne_Capability_Environment
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
# Randy MacLeod
# Wind River Linux
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] python: add tk support
2018-10-30 4:52 ` Randy MacLeod
@ 2018-10-30 11:11 ` Burton, Ross
2018-11-05 9:29 ` Yu, Mingli
1 sibling, 0 replies; 8+ messages in thread
From: Burton, Ross @ 2018-10-30 11:11 UTC (permalink / raw)
To: Randy MacLeod; +Cc: OE-core
On Tue, 30 Oct 2018 at 04:53, Randy MacLeod <randy.macleod@windriver.com> wrote:
> I think what started us down this path is a FACE [1] compliance test.
> If there's resistance to moving the package to oe-core, can we
> enable python-tk even if tk stayed in meta-oe, Grace?
> Also, this should be done using using PACKAGECONFIG?
> Finally, what about python3-tk ?
I'd happily add a PACKAGECONFIG but tcl/tk is fairly dead so I do have
instinctive opposition to adding it into oe-core.
Ross
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] python: add tk support
2018-10-30 4:52 ` Randy MacLeod
2018-10-30 11:11 ` Burton, Ross
@ 2018-11-05 9:29 ` Yu, Mingli
1 sibling, 0 replies; 8+ messages in thread
From: Yu, Mingli @ 2018-11-05 9:29 UTC (permalink / raw)
To: Randy MacLeod, openembedded-core, Burton, Ross, Khem Raj
On 2018年10月30日 12:52, Randy MacLeod wrote:
> On 10/29/18 8:51 AM, Burton, Ross wrote:
>> Terrified to ask, but why?
>> On Thu, 25 Oct 2018 at 09:39, <mingli.yu@windriver.com> wrote:
>>>
>>> 1, move tk recipe from meta-oe
>>> 2, enable tk to add tk support
>
> Well, tcl and tk do go together and Khem's comment from 2013
> suggested that it might be pulled into oe-core some day.
>
> I think what started us down this path is a FACE [1] compliance test.
> If there's resistance to moving the package to oe-core, can we
> enable python-tk even if tk stayed in meta-oe, Grace?
> Also, this should be done using using PACKAGECONFIG?
> Finally, what about python3-tk ?
Will send out v2 to use PACKAGECONFIG for tk and add tk support for
python3 altogether.
Thanks,
>
> ../Randy
>
> [1] https://en.wikipedia.org/wiki/Future_Airborne_Capability_Environment
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread