* [PATCH v3][master-next] kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND
@ 2018-10-30 19:04 Bruce Ashfield
2018-10-30 19:33 ` ✗ patchtest: failure for kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND (rev2) Patchwork
2018-10-30 19:46 ` [PATCH v3][master-next] kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND Andre McCurdy
0 siblings, 2 replies; 4+ messages in thread
From: Bruce Ashfield @ 2018-10-30 19:04 UTC (permalink / raw)
To: richard.purdie; +Cc: openembedded-core
As was warned by commit 312ee68752fa [kconfig: announce removal of
oldnoconfig if used], oldnoconfig has been removed from the 4.20 kernel.
So we switch our default mode to olddefconfig.
commit fb16d8912 [kconfig: replace 'oldnoconfig' with 'olddefconfig',
and keep the old name as an alias] introduced olddefconfig in the 3.10
kernel, we shuffle oldnoconfig to the fallback target.
The fallback mode allows kernels between 3.10 and the currently listed
oldest kernel of 3.2 to continue to configure.
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
---
v3: dropped 'yes' from the pipeline
v2: Tweaked to add a fallback mode as suggested by Andre McCurdy
Not for the release, just wanted to get this in the queue for
when master reopens so we'll be ready for 4.20+ kernel versions
Tested by configuring linux-yocto*
Bruce
meta/classes/kernel.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index e04d2fe00434..880c5ef17283 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -492,7 +492,7 @@ sysroot_stage_all () {
:
}
-KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} oldnoconfig"
+KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} olddefconfig || oe_runmake -C ${S} O=${B} CC="${KERNEL_CC}" oldnoconfig"
python check_oldest_kernel() {
oldest_kernel = d.getVar('OLDEST_KERNEL')
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✗ patchtest: failure for kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND (rev2)
2018-10-30 19:04 [PATCH v3][master-next] kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND Bruce Ashfield
@ 2018-10-30 19:33 ` Patchwork
2018-10-30 19:46 ` [PATCH v3][master-next] kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND Andre McCurdy
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-10-30 19:33 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: openembedded-core
== Series Details ==
Series: kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND (rev2)
Revision: 2
URL : https://patchwork.openembedded.org/series/14712/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master-next (currently at 6ab561af7e)
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3][master-next] kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND
2018-10-30 19:04 [PATCH v3][master-next] kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND Bruce Ashfield
2018-10-30 19:33 ` ✗ patchtest: failure for kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND (rev2) Patchwork
@ 2018-10-30 19:46 ` Andre McCurdy
2018-10-30 20:07 ` Bruce Ashfield
1 sibling, 1 reply; 4+ messages in thread
From: Andre McCurdy @ 2018-10-30 19:46 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: OE Core mailing list
On Tue, Oct 30, 2018 at 12:05 PM Bruce Ashfield
<bruce.ashfield@windriver.com> wrote:
>
> As was warned by commit 312ee68752fa [kconfig: announce removal of
> oldnoconfig if used], oldnoconfig has been removed from the 4.20 kernel.
>
> So we switch our default mode to olddefconfig.
>
> commit fb16d8912 [kconfig: replace 'oldnoconfig' with 'olddefconfig',
> and keep the old name as an alias] introduced olddefconfig in the 3.10
> kernel, we shuffle oldnoconfig to the fallback target.
>
> The fallback mode allows kernels between 3.10 and the currently listed
> oldest kernel of 3.2 to continue to configure.
>
> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> ---
>
> v3: dropped 'yes' from the pipeline
>
> v2: Tweaked to add a fallback mode as suggested by Andre McCurdy
>
> Not for the release, just wanted to get this in the queue for
> when master reopens so we'll be ready for 4.20+ kernel versions
>
> Tested by configuring linux-yocto*
>
> Bruce
>
>
> meta/classes/kernel.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index e04d2fe00434..880c5ef17283 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -492,7 +492,7 @@ sysroot_stage_all () {
> :
> }
>
> -KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} oldnoconfig"
> +KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} olddefconfig || oe_runmake -C ${S} O=${B} CC="${KERNEL_CC}" oldnoconfig"
Apart from inexplicably swapping the positions of the O= and CC=
options on the fallback command line (?!?), this version looks good.
> python check_oldest_kernel() {
> oldest_kernel = d.getVar('OLDEST_KERNEL')
> --
> 2.5.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3][master-next] kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND
2018-10-30 19:46 ` [PATCH v3][master-next] kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND Andre McCurdy
@ 2018-10-30 20:07 ` Bruce Ashfield
0 siblings, 0 replies; 4+ messages in thread
From: Bruce Ashfield @ 2018-10-30 20:07 UTC (permalink / raw)
To: Andre McCurdy; +Cc: OE Core mailing list
On 2018-10-30 3:46 PM, Andre McCurdy wrote:
> On Tue, Oct 30, 2018 at 12:05 PM Bruce Ashfield
> <bruce.ashfield@windriver.com> wrote:
>>
>> As was warned by commit 312ee68752fa [kconfig: announce removal of
>> oldnoconfig if used], oldnoconfig has been removed from the 4.20 kernel.
>>
>> So we switch our default mode to olddefconfig.
>>
>> commit fb16d8912 [kconfig: replace 'oldnoconfig' with 'olddefconfig',
>> and keep the old name as an alias] introduced olddefconfig in the 3.10
>> kernel, we shuffle oldnoconfig to the fallback target.
>>
>> The fallback mode allows kernels between 3.10 and the currently listed
>> oldest kernel of 3.2 to continue to configure.
>>
>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>> ---
>>
>> v3: dropped 'yes' from the pipeline
>>
>> v2: Tweaked to add a fallback mode as suggested by Andre McCurdy
>>
>> Not for the release, just wanted to get this in the queue for
>> when master reopens so we'll be ready for 4.20+ kernel versions
>>
>> Tested by configuring linux-yocto*
>>
>> Bruce
>>
>>
>> meta/classes/kernel.bbclass | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index e04d2fe00434..880c5ef17283 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -492,7 +492,7 @@ sysroot_stage_all () {
>> :
>> }
>>
>> -KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} oldnoconfig"
>> +KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} CC="${KERNEL_CC}" O=${B} olddefconfig || oe_runmake -C ${S} O=${B} CC="${KERNEL_CC}" oldnoconfig"
>
> Apart from inexplicably swapping the positions of the O= and CC=
> options on the fallback command line (?!?), this version looks good.
never noticed :) I just cut and pasted it differently. I'll spare
everyone a v4 for that!
Bruce
>
>> python check_oldest_kernel() {
>> oldest_kernel = d.getVar('OLDEST_KERNEL')
>> --
>> 2.5.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-30 20:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-30 19:04 [PATCH v3][master-next] kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND Bruce Ashfield
2018-10-30 19:33 ` ✗ patchtest: failure for kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND (rev2) Patchwork
2018-10-30 19:46 ` [PATCH v3][master-next] kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND Andre McCurdy
2018-10-30 20:07 ` Bruce Ashfield
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox