[PATCH] pkgconfig: export variables

[PATCH] pkgconfig: export variables

[Joshua Watt]

Export the PKG_CONFIG_PATH and PKG_CONFIG_LIBDIR variables in case the
parent shell hasn't done so.
---
 .../recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in b/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in
index 5e44bb435c3..a9324de4cf3 100644
--- a/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in
+++ b/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in
@@ -1,7 +1,7 @@
 #! /bin/sh
 
-PKG_CONFIG_PATH="@PATH_NATIVE@"
-PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
+export PKG_CONFIG_PATH="@PATH_NATIVE@"
+export PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
 unset PKG_CONFIG_SYSROOT_DIR
 
 pkg-config "$@"
-- 
2.19.1

✗ patchtest: failure for pkgconfig: export variables

[Patchwork]

== Series Details ==

Series: pkgconfig: export variables
Revision: 1
URL   : https://patchwork.openembedded.org/series/14761/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            pkgconfig: export variables
 Issue             Patch is missing Signed-off-by [test_signed_off_by_presence] 
  Suggested fix    Sign off the patch (either manually or with "git commit --amend -s")



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH] pkgconfig: export variables

[Joshua Watt]

Armin,

Would you mind backporting this to thud?

Thanks.

On Thu, 2018-11-01 at 21:45 -0500, Joshua Watt wrote:
> Export the PKG_CONFIG_PATH and PKG_CONFIG_LIBDIR variables in case
> the
> parent shell hasn't done so.
> ---
>  .../recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in | 4
> ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-
> native.in b/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-
> native.in
> index 5e44bb435c3..a9324de4cf3 100644
> --- a/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in
> +++ b/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in
> @@ -1,7 +1,7 @@
>  #! /bin/sh
>  
> -PKG_CONFIG_PATH="@PATH_NATIVE@"
> -PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
> +export PKG_CONFIG_PATH="@PATH_NATIVE@"
> +export PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
>  unset PKG_CONFIG_SYSROOT_DIR
>  
>  pkg-config "$@"
-- 
Joshua Watt <JPEWhacker@gmail.com>

Re: [PATCH] pkgconfig: export variables

[Joshua Watt]

On Thu, Dec 6, 2018 at 1:34 PM Joshua Watt <jpewhacker@gmail.com> wrote:
>
> Armin,
>
> Would you mind backporting this to thud?

Ping on the backport.

>
> Thanks.
>
> On Thu, 2018-11-01 at 21:45 -0500, Joshua Watt wrote:
> > Export the PKG_CONFIG_PATH and PKG_CONFIG_LIBDIR variables in case
> > the
> > parent shell hasn't done so.
> > ---
> >  .../recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in | 4
> > ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-
> > native.in b/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-
> > native.in
> > index 5e44bb435c3..a9324de4cf3 100644
> > --- a/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in
> > +++ b/meta/recipes-devtools/pkgconfig/pkgconfig/pkg-config-native.in
> > @@ -1,7 +1,7 @@
> >  #! /bin/sh
> >
> > -PKG_CONFIG_PATH="@PATH_NATIVE@"
> > -PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
> > +export PKG_CONFIG_PATH="@PATH_NATIVE@"
> > +export PKG_CONFIG_LIBDIR="@LIBDIR_NATIVE@"
> >  unset PKG_CONFIG_SYSROOT_DIR
> >
> >  pkg-config "$@"
> --
> Joshua Watt <JPEWhacker@gmail.com>
>