Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH v2] oe: Fix opkg status list parse - Missing postinst
@ 2018-12-12  7:26 Raul Martins
  2018-12-12  7:33 ` ✗ patchtest: failure for oe: Fix opkg status list parse - Missing postinst (rev2) Patchwork
  0 siblings, 1 reply; 2+ messages in thread
From: Raul Martins @ 2018-12-12  7:26 UTC (permalink / raw)
  To: openembedded-core; +Cc: Raul Martins

While parsing opkg package status, last package status was not
properly handled, resulting in final image without postinst and
pkg depends

Signed-off-by: Raul Martins <raul.martins@alta-rt.com>
---
 meta/lib/oe/rootfs.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
index 9bdc72c..4273891 100644
--- a/meta/lib/oe/rootfs.py
+++ b/meta/lib/oe/rootfs.py
@@ -507,9 +507,9 @@ class DpkgOpkgRootfs(Rootfs):
             return pkg_depends_list
 
         pkgs = {}
-        pkg_name = None
+        pkg_name = ""
         pkg_status_match = False
-        pkg_depends = None
+        pkg_depends = ""
 
         with open(status_file) as status:
             data = status.read()
@@ -526,7 +526,7 @@ class DpkgOpkgRootfs(Rootfs):
                     pkg_name = m_pkg.group(1)
                     #Make sure we reset other variables
                     pkg_status_match = False
-                    pkg_depends = None
+                    pkg_depends = ""
                 elif m_status is not None:
                     #New status matched
                     pkg_status_match = True
@@ -537,7 +537,7 @@ class DpkgOpkgRootfs(Rootfs):
                     pass
 
                 #Now check if we can process package depends and postinst
-                if pkg_name is not None and pkg_status_match:
+                if "" != pkg_name and pkg_status_match:
                     pkgs[pkg_name] = _get_pkg_depends_list(pkg_depends)
                 else:
                     #Not enough information
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-12  7:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-12  7:26 [PATCH v2] oe: Fix opkg status list parse - Missing postinst Raul Martins
2018-12-12  7:33 ` ✗ patchtest: failure for oe: Fix opkg status list parse - Missing postinst (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox