Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] gtk3: enable wayland banckend
@ 2018-12-17 18:06 Jed
  2018-12-17 18:10 ` Burton, Ross
  2018-12-17 18:10 ` Tim Orling
  0 siblings, 2 replies; 4+ messages in thread
From: Jed @ 2018-12-17 18:06 UTC (permalink / raw)
  To: openembedded-core

It is disabled by default, and required for things like mutter to
be able to run under Wayland.

Signed-off-by: Jed <jed.openxt@gmail.com>
---
 meta/recipes-gnome/gtk+/gtk+3.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-gnome/gtk+/gtk+3.inc b/meta/recipes-gnome/gtk+/gtk+3.inc
index 6331a4323c..83967ccb7e 100644
--- a/meta/recipes-gnome/gtk+/gtk+3.inc
+++ b/meta/recipes-gnome/gtk+/gtk+3.inc
@@ -35,6 +35,7 @@ EXTRA_OECONF += " \
                  --enable-modules \
                  --disable-cups \
                  --disable-colord \
+                 --enable-wayland-backend \
                  ${@bb.utils.contains("DISTRO_FEATURES", "x11", "", "--disable-gtk-doc", d)} \
                  "
 
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] gtk3: enable wayland banckend
  2018-12-17 18:06 [PATCH] gtk3: enable wayland banckend Jed
@ 2018-12-17 18:10 ` Burton, Ross
  2018-12-17 19:03   ` Jed Lejosne
  2018-12-17 18:10 ` Tim Orling
  1 sibling, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2018-12-17 18:10 UTC (permalink / raw)
  To: jed.openxt; +Cc: OE-core

On Mon, 17 Dec 2018 at 18:07, Jed <jed.openxt@gmail.com> wrote:
> It is disabled by default, and required for things like mutter to
> be able to run under Wayland.

From the recipe:

PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'opengl
wayland x11', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'opengl x11', 'glx', '', d)}"

PACKAGECONFIG[wayland] =
"--enable-wayland-backend,--disable-wayland-backend,wayland
wayland-protocols libxkbcommon virtual/mesa wayland-native"

It's enabled if the 'wayland' DISTRO_FEATURE is enabled.

Ross


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gtk3: enable wayland banckend
  2018-12-17 18:06 [PATCH] gtk3: enable wayland banckend Jed
  2018-12-17 18:10 ` Burton, Ross
@ 2018-12-17 18:10 ` Tim Orling
  1 sibling, 0 replies; 4+ messages in thread
From: Tim Orling @ 2018-12-17 18:10 UTC (permalink / raw)
  To: Jed; +Cc: OE-core



> On Dec 17, 2018, at 10:06 AM, Jed <jed.openxt@gmail.com> wrote:
> 
> It is disabled by default, and required for things like mutter to
> be able to run under Wayland.
> 
> Signed-off-by: Jed <jed.openxt@gmail.com>
> ---
> meta/recipes-gnome/gtk+/gtk+3.inc | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-gnome/gtk+/gtk+3.inc b/meta/recipes-gnome/gtk+/gtk+3.inc
> index 6331a4323c..83967ccb7e 100644
> --- a/meta/recipes-gnome/gtk+/gtk+3.inc
> +++ b/meta/recipes-gnome/gtk+/gtk+3.inc
> @@ -35,6 +35,7 @@ EXTRA_OECONF += " \
>                  --enable-modules \
>                  --disable-cups \
>                  --disable-colord \
> +                 --enable-wayland-backend \

Wouldn’t it be better to check that DISTRO_FEATURES contains wayland and then enable it?

>                  ${@bb.utils.contains("DISTRO_FEATURES", "x11", "", "--disable-gtk-doc", d)} \
>                  "
> 
> -- 
> 2.11.0
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] gtk3: enable wayland banckend
  2018-12-17 18:10 ` Burton, Ross
@ 2018-12-17 19:03   ` Jed Lejosne
  0 siblings, 0 replies; 4+ messages in thread
From: Jed Lejosne @ 2018-12-17 19:03 UTC (permalink / raw)
  To: ross.burton; +Cc: openembedded-core

My bad, sorry.
For some reason things started working after I added that option (I
already had the DISTRO_FEATURE), but it must have been something else.
Thank you for reviewing.

Jed
On Mon, Dec 17, 2018 at 1:10 PM Burton, Ross <ross.burton@intel.com> wrote:
>
> On Mon, 17 Dec 2018 at 18:07, Jed <jed.openxt@gmail.com> wrote:
> > It is disabled by default, and required for things like mutter to
> > be able to run under Wayland.
>
> From the recipe:
>
> PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'opengl
> wayland x11', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl x11', 'glx', '', d)}"
>
> PACKAGECONFIG[wayland] =
> "--enable-wayland-backend,--disable-wayland-backend,wayland
> wayland-protocols libxkbcommon virtual/mesa wayland-native"
>
> It's enabled if the 'wayland' DISTRO_FEATURE is enabled.
>
> Ross


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-12-17 19:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-17 18:06 [PATCH] gtk3: enable wayland banckend Jed
2018-12-17 18:10 ` Burton, Ross
2018-12-17 19:03   ` Jed Lejosne
2018-12-17 18:10 ` Tim Orling

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox