* [PATCH] gstreamer: Add RISC-V support
@ 2019-01-09 0:09 Alistair Francis
2019-01-09 0:35 ` ✗ patchtest: failure for " Patchwork
2019-01-09 2:42 ` [PATCH] " Khem Raj
0 siblings, 2 replies; 3+ messages in thread
From: Alistair Francis @ 2019-01-09 0:09 UTC (permalink / raw)
To: openembedded-core@lists.openembedded.org
Backport RISC-V support from master Gstreamer.
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
...stconfig.h.in-initial-RISC-V-support.patch | 28 +++++++++++++++++++
.../gstreamer/gstreamer1.0_1.14.4.bb | 3 ++
2 files changed, 31 insertions(+)
create mode 100644 meta/recipes-multimedia/gstreamer/files/0002-gstconfig.h.in-initial-RISC-V-support.patch
diff --git a/meta/recipes-multimedia/gstreamer/files/0002-gstconfig.h.in-initial-RISC-V-support.patch b/meta/recipes-multimedia/gstreamer/files/0002-gstconfig.h.in-initial-RISC-V-support.patch
new file mode 100644
index 0000000000..8d8f8dca00
--- /dev/null
+++ b/meta/recipes-multimedia/gstreamer/files/0002-gstconfig.h.in-initial-RISC-V-support.patch
@@ -0,0 +1,28 @@
+From 8a156d1725ecd03f2e8cdc8874e081dda2d3b43d Mon Sep 17 00:00:00 2001
+From: Aurelien Jarno <aurelien@aurel32.net>
+Date: Sun, 15 Apr 2018 00:49:55 +0200
+Subject: [PATCH] gstconfig.h.in: initial RISC-V support
+
+RISC-V supports unaligned accesses, but these might run extremely slowly
+depending on the implementation. Therefore set GST_HAVE_UNALIGNED_ACCESS
+to 0 on this architecture.
+
+https://bugzilla.gnome.org/show_bug.cgi?id=795271
+Upstream-Status: Accepted [1.15.1 - https://bugzilla.gnome.org/show_bug.cgi?id=795271]
+---
+ gst/gstconfig.h.in | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/gst/gstconfig.h.in b/gst/gstconfig.h.in
+index 6351c04da..33dfed1f6 100644
+--- a/gst/gstconfig.h.in
++++ b/gst/gstconfig.h.in
+@@ -104,7 +104,7 @@
+ * http://docs.oracle.com/cd/E19205-01/820-4155/c++_faq.html#Vers6
+ * https://software.intel.com/en-us/node/583402
+ */
+-#if defined(__alpha__) || defined(__arc__) || defined(__arm__) || defined(__aarch64__) || defined(__bfin) || defined(__hppa__) || defined(__nios2__) || defined(__MICROBLAZE__) || defined(__mips__) || defined(__or1k__) || defined(__sh__) || defined(__SH4__) || defined(__sparc__) || defined(__sparc) || defined(__ia64__) || defined(_M_ALPHA) || defined(_M_ARM) || defined(_M_IA64) || defined(__xtensa__) || defined(__e2k__)
++#if defined(__alpha__) || defined(__arc__) || defined(__arm__) || defined(__aarch64__) || defined(__bfin) || defined(__hppa__) || defined(__nios2__) || defined(__MICROBLAZE__) || defined(__mips__) || defined(__or1k__) || defined(__sh__) || defined(__SH4__) || defined(__sparc__) || defined(__sparc) || defined(__ia64__) || defined(_M_ALPHA) || defined(_M_ARM) || defined(_M_IA64) || defined(__xtensa__) || defined(__e2k__) || defined(__riscv)
+ # define GST_HAVE_UNALIGNED_ACCESS 0
+ #elif defined(__i386__) || defined(__i386) || defined(__amd64__) || defined(__amd64) || defined(__x86_64__) || defined(__ppc__) || defined(__ppc64__) || defined(__powerpc__) || defined(__powerpc64__) || defined(__m68k__) || defined(_M_IX86) || defined(_M_AMD64) || defined(_M_X64) || defined(__s390__) || defined(__s390x__) || defined(__zarch__)
+ # define GST_HAVE_UNALIGNED_ACCESS 1
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.14.4.bb
index 232234b888..c3bac1f658 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.14.4.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.14.4.bb
@@ -30,6 +30,9 @@ SRC_URI = " \
SRC_URI[md5sum] = "f67fbbc42bd85a0701df119f52fb52bd"
SRC_URI[sha256sum] = "f94f6696c5f05a3b3a9183e39c5f5c0b779f75a04c0efa497e7920afa985ffc7"
+SRC_URI_append_riscv64 = " file://0002-gstconfig.h.in-initial-RISC-V-support.patch"
+SRC_URI_append_riscv32 = " file://0002-gstconfig.h.in-initial-RISC-V-support.patch"
+
PACKAGECONFIG ??= "${@bb.utils.contains('PTEST_ENABLED', '1', 'tests', '', d)} \
"
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* ✗ patchtest: failure for gstreamer: Add RISC-V support
2019-01-09 0:09 [PATCH] gstreamer: Add RISC-V support Alistair Francis
@ 2019-01-09 0:35 ` Patchwork
2019-01-09 2:42 ` [PATCH] " Khem Raj
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2019-01-09 0:35 UTC (permalink / raw)
To: Alistair Francis; +Cc: openembedded-core
== Series Details ==
Series: gstreamer: Add RISC-V support
Revision: 1
URL : https://patchwork.openembedded.org/series/15576/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue A patch file has been added, but does not have a Signed-off-by tag [test_signed_off_by_presence]
Suggested fix Sign off the added patch file (meta/recipes-multimedia/gstreamer/files/0002-gstconfig.h.in-initial-RISC-V-support.patch)
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gstreamer: Add RISC-V support
2019-01-09 0:09 [PATCH] gstreamer: Add RISC-V support Alistair Francis
2019-01-09 0:35 ` ✗ patchtest: failure for " Patchwork
@ 2019-01-09 2:42 ` Khem Raj
1 sibling, 0 replies; 3+ messages in thread
From: Khem Raj @ 2019-01-09 2:42 UTC (permalink / raw)
To: Alistair Francis; +Cc: openembedded-core@lists.openembedded.org
On Tue, Jan 8, 2019 at 4:19 PM Alistair Francis
<Alistair.Francis@wdc.com> wrote:
>
> Backport RISC-V support from master Gstreamer.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> ...stconfig.h.in-initial-RISC-V-support.patch | 28 +++++++++++++++++++
> .../gstreamer/gstreamer1.0_1.14.4.bb | 3 ++
> 2 files changed, 31 insertions(+)
> create mode 100644 meta/recipes-multimedia/gstreamer/files/0002-gstconfig.h.in-initial-RISC-V-support.patch
>
> diff --git a/meta/recipes-multimedia/gstreamer/files/0002-gstconfig.h.in-initial-RISC-V-support.patch b/meta/recipes-multimedia/gstreamer/files/0002-gstconfig.h.in-initial-RISC-V-support.patch
> new file mode 100644
> index 0000000000..8d8f8dca00
> --- /dev/null
> +++ b/meta/recipes-multimedia/gstreamer/files/0002-gstconfig.h.in-initial-RISC-V-support.patch
> @@ -0,0 +1,28 @@
> +From 8a156d1725ecd03f2e8cdc8874e081dda2d3b43d Mon Sep 17 00:00:00 2001
> +From: Aurelien Jarno <aurelien@aurel32.net>
> +Date: Sun, 15 Apr 2018 00:49:55 +0200
> +Subject: [PATCH] gstconfig.h.in: initial RISC-V support
> +
> +RISC-V supports unaligned accesses, but these might run extremely slowly
> +depending on the implementation. Therefore set GST_HAVE_UNALIGNED_ACCESS
> +to 0 on this architecture.
> +
> +https://bugzilla.gnome.org/show_bug.cgi?id=795271
> +Upstream-Status: Accepted [1.15.1 - https://bugzilla.gnome.org/show_bug.cgi?id=795271]
> +---
> + gst/gstconfig.h.in | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/gst/gstconfig.h.in b/gst/gstconfig.h.in
> +index 6351c04da..33dfed1f6 100644
> +--- a/gst/gstconfig.h.in
> ++++ b/gst/gstconfig.h.in
> +@@ -104,7 +104,7 @@
> + * http://docs.oracle.com/cd/E19205-01/820-4155/c++_faq.html#Vers6
> + * https://software.intel.com/en-us/node/583402
> + */
> +-#if defined(__alpha__) || defined(__arc__) || defined(__arm__) || defined(__aarch64__) || defined(__bfin) || defined(__hppa__) || defined(__nios2__) || defined(__MICROBLAZE__) || defined(__mips__) || defined(__or1k__) || defined(__sh__) || defined(__SH4__) || defined(__sparc__) || defined(__sparc) || defined(__ia64__) || defined(_M_ALPHA) || defined(_M_ARM) || defined(_M_IA64) || defined(__xtensa__) || defined(__e2k__)
> ++#if defined(__alpha__) || defined(__arc__) || defined(__arm__) || defined(__aarch64__) || defined(__bfin) || defined(__hppa__) || defined(__nios2__) || defined(__MICROBLAZE__) || defined(__mips__) || defined(__or1k__) || defined(__sh__) || defined(__SH4__) || defined(__sparc__) || defined(__sparc) || defined(__ia64__) || defined(_M_ALPHA) || defined(_M_ARM) || defined(_M_IA64) || defined(__xtensa__) || defined(__e2k__) || defined(__riscv)
> + # define GST_HAVE_UNALIGNED_ACCESS 0
> + #elif defined(__i386__) || defined(__i386) || defined(__amd64__) || defined(__amd64) || defined(__x86_64__) || defined(__ppc__) || defined(__ppc64__) || defined(__powerpc__) || defined(__powerpc64__) || defined(__m68k__) || defined(_M_IX86) || defined(_M_AMD64) || defined(_M_X64) || defined(__s390__) || defined(__s390x__) || defined(__zarch__)
> + # define GST_HAVE_UNALIGNED_ACCESS 1
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.14.4.bb
> index 232234b888..c3bac1f658 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.14.4.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.14.4.bb
> @@ -30,6 +30,9 @@ SRC_URI = " \
> SRC_URI[md5sum] = "f67fbbc42bd85a0701df119f52fb52bd"
> SRC_URI[sha256sum] = "f94f6696c5f05a3b3a9183e39c5f5c0b779f75a04c0efa497e7920afa985ffc7"
>
> +SRC_URI_append_riscv64 = " file://0002-gstconfig.h.in-initial-RISC-V-support.patch"
> +SRC_URI_append_riscv32 = " file://0002-gstconfig.h.in-initial-RISC-V-support.patch"
> +
there is nothing riscv specific here. This patch should be applied
unconditionally.
> PACKAGECONFIG ??= "${@bb.utils.contains('PTEST_ENABLED', '1', 'tests', '', d)} \
> "
>
> --
> 2.19.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-09 2:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-09 0:09 [PATCH] gstreamer: Add RISC-V support Alistair Francis
2019-01-09 0:35 ` ✗ patchtest: failure for " Patchwork
2019-01-09 2:42 ` [PATCH] " Khem Raj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox