From: <kai.kang@windriver.com>
To: <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: [PATCH] libidn2: fix buildpaths qa issue in .pc file
Date: Tue, 19 Feb 2019 01:57:25 -0500 [thread overview]
Message-ID: <20190219065725.171013-1-kai.kang@windriver.com> (raw)
In-Reply-To: <4367f854b1ff23bc2972294715d3837725ee7c43.1550195817.git.kai.kang@windriver.com>
From: Kai Kang <kai.kang@windriver.com>
When enable buildpaths qa check, it show warning of libidn2:
| WARNING: libidn2-2.0.5-r0 do_package_qa: QA Issue: File
/work/armv5e-poky-linux-gnueabi/libidn2/2.0.5-r0/packages-split/libidn2-dev/usr/lib/pkgconfig/libidn2.pc
in package contained reference to tmpdir [buildpaths]
Fix the issue by substituting @LTLIBUNISTRING@ in the .pc file.
Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
.../fix-host-contamination-in-pc-file.patch | 22 +++++++++++++++++++
meta/recipes-extended/libidn/libidn2_2.0.5.bb | 3 ++-
2 files changed, 24 insertions(+), 1 deletion(-)
create mode 100644 meta/recipes-extended/libidn/libidn2/fix-host-contamination-in-pc-file.patch
diff --git a/meta/recipes-extended/libidn/libidn2/fix-host-contamination-in-pc-file.patch b/meta/recipes-extended/libidn/libidn2/fix-host-contamination-in-pc-file.patch
new file mode 100644
index 0000000000..026312ab0a
--- /dev/null
+++ b/meta/recipes-extended/libidn/libidn2/fix-host-contamination-in-pc-file.patch
@@ -0,0 +1,22 @@
+Configure option --with-libunistring-prefix is set to fix compile-host-path qa
+issue. It causes @LTLIBUNISTRING@ in line 'Libs.private' of libidn2.pc replaced
+with ${STAGING_EXECPREFIXDIR} which causes buildpaths qa issue.
+
+libunistring is a dependency of libidn2 and installs libraries to standard
+library path, so just substitute @LTLIBUNISTRING@ with standard library path
+and -lunistring in libidn2.pc.in.
+
+Upstream-Status: Inappropriate [embedded specific]
+
+Signed-off-by: Kai Kang <kai.kang@windriver.com>
+---
+diff --git a/libidn2.pc.in b/libidn2.pc.in
+index 0dade23..24cc29d 100644
+--- a/libidn2.pc.in
++++ b/libidn2.pc.in
+@@ -8,4 +8,4 @@ Description: Library implementing IDNA2008 and TR46
+ Version: @PACKAGE_VERSION@
+ Cflags: -I${includedir}
+ Libs: -L${libdir} -lidn2
+-Libs.private: @LTLIBICONV@ @LTLIBUNISTRING@
++Libs.private: @LTLIBICONV@ -L${libdir} -lunistring
diff --git a/meta/recipes-extended/libidn/libidn2_2.0.5.bb b/meta/recipes-extended/libidn/libidn2_2.0.5.bb
index 0daf7a6877..a243a9181e 100644
--- a/meta/recipes-extended/libidn/libidn2_2.0.5.bb
+++ b/meta/recipes-extended/libidn/libidn2_2.0.5.bb
@@ -11,7 +11,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=ab90e75ef97cc6318ce4f2fbda62fe4d \
SRC_URI = "${GNU_MIRROR}/libidn/${BPN}-${PV}.tar.gz \
file://Unset-need_charset_alias-when-building-for-musl.patch \
- "
+ file://fix-host-contamination-in-pc-file.patch \
+ "
SRC_URI[md5sum] = "eaf9a5b9d03b0cce3760f34b3124eb36"
SRC_URI[sha256sum] = "53f69170886f1fa6fa5b332439c7a77a7d22626a82ef17e2c1224858bb4ca2b8"
--
2.20.0
next prev parent reply other threads:[~2019-02-19 6:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 2:06 [PATCH v2 0/4] Update default value of DEBUG_PREFIX_MAP kai.kang
2019-02-15 2:06 ` [PATCH 1/4] bitbake.conf: update DEBUG_PREFIX_MAP with -fmacro-prefix-map kai.kang
2019-02-15 2:06 ` [PATCH 2/4] go-cross-canadian: set default value of DEBUG_PREFIX_MAP kai.kang
2019-02-15 2:06 ` [PATCH 3/4] libidn2: fix buildpaths qa warning kai.kang
2019-02-15 9:57 ` Richard Purdie
2019-02-18 9:32 ` Kang Kai
2019-02-19 6:57 ` kai.kang [this message]
2019-02-27 3:34 ` [PATCH v2] libidn2: fix buildpaths qa issue in .pc file Kang Kai
2019-02-15 2:06 ` [PATCH 4/4] openssl: update patch to fix buildpaths qa issue for -fmacro-prefix-map kai.kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219065725.171013-1-kai.kang@windriver.com \
--to=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox