Re: [PATCH v2] libidn2: fix buildpaths qa issue in .pc file

[Kang Kai <Kai.Kang@windriver.com>]

On 2019/2/19 下午2:57, kai.kang@windriver.com wrote:
> From: Kai Kang <kai.kang@windriver.com>
>
> When enable buildpaths qa check, it show warning of libidn2:
>
> | WARNING: libidn2-2.0.5-r0 do_package_qa: QA Issue: File
> /work/armv5e-poky-linux-gnueabi/libidn2/2.0.5-r0/packages-split/libidn2-dev/usr/lib/pkgconfig/libidn2.pc
> in package contained reference to tmpdir [buildpaths]
>
> Fix the issue by substituting @LTLIBUNISTRING@ in the .pc file.

Ping.


>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>   .../fix-host-contamination-in-pc-file.patch   | 22 +++++++++++++++++++
>   meta/recipes-extended/libidn/libidn2_2.0.5.bb |  3 ++-
>   2 files changed, 24 insertions(+), 1 deletion(-)
>   create mode 100644 meta/recipes-extended/libidn/libidn2/fix-host-contamination-in-pc-file.patch
>
> diff --git a/meta/recipes-extended/libidn/libidn2/fix-host-contamination-in-pc-file.patch b/meta/recipes-extended/libidn/libidn2/fix-host-contamination-in-pc-file.patch
> new file mode 100644
> index 0000000000..026312ab0a
> --- /dev/null
> +++ b/meta/recipes-extended/libidn/libidn2/fix-host-contamination-in-pc-file.patch
> @@ -0,0 +1,22 @@
> +Configure option --with-libunistring-prefix is set to fix compile-host-path qa
> +issue. It causes @LTLIBUNISTRING@ in line 'Libs.private' of libidn2.pc replaced
> +with ${STAGING_EXECPREFIXDIR} which causes buildpaths qa issue.
> +
> +libunistring is a dependency of libidn2 and installs libraries to standard
> +library path, so just substitute @LTLIBUNISTRING@ with standard library path
> +and -lunistring in libidn2.pc.in.
> +
> +Upstream-Status: Inappropriate [embedded specific]
> +
> +Signed-off-by: Kai Kang <kai.kang@windriver.com>
> +---
> +diff --git a/libidn2.pc.in b/libidn2.pc.in
> +index 0dade23..24cc29d 100644
> +--- a/libidn2.pc.in
> ++++ b/libidn2.pc.in
> +@@ -8,4 +8,4 @@ Description: Library implementing IDNA2008 and TR46
> + Version: @PACKAGE_VERSION@
> + Cflags: -I${includedir}
> + Libs: -L${libdir} -lidn2
> +-Libs.private: @LTLIBICONV@ @LTLIBUNISTRING@
> ++Libs.private: @LTLIBICONV@ -L${libdir} -lunistring
> diff --git a/meta/recipes-extended/libidn/libidn2_2.0.5.bb b/meta/recipes-extended/libidn/libidn2_2.0.5.bb
> index 0daf7a6877..a243a9181e 100644
> --- a/meta/recipes-extended/libidn/libidn2_2.0.5.bb
> +++ b/meta/recipes-extended/libidn/libidn2_2.0.5.bb
> @@ -11,7 +11,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=ab90e75ef97cc6318ce4f2fbda62fe4d \
>   
>   SRC_URI = "${GNU_MIRROR}/libidn/${BPN}-${PV}.tar.gz \
>              file://Unset-need_charset_alias-when-building-for-musl.patch \
> -          "
> +           file://fix-host-contamination-in-pc-file.patch \
> +           "
>   SRC_URI[md5sum] = "eaf9a5b9d03b0cce3760f34b3124eb36"
>   SRC_URI[sha256sum] = "53f69170886f1fa6fa5b332439c7a77a7d22626a82ef17e2c1224858bb4ca2b8"
>   


-- 
Kai Kang