[PATCH v2] libsndfile1: make sqlite and FLAC/Vorbis optional

[PATCH v2] libsndfile1: make sqlite and FLAC/Vorbis optional

[Max Kellermann]

From: Max Kellermann <max.kellermann@gmail.com>

Signed-off-by: Max Kellermann <max.kellermann@gmail.com>
---
 meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb b/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
index eb2c719d8d..7b5eb4f71c 100644
--- a/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
+++ b/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
@@ -1,7 +1,7 @@
 SUMMARY = "Audio format Conversion library"
 HOMEPAGE = "http://www.mega-nerd.com/libsndfile"
 AUTHOR = "Erik de Castro Lopo"
-DEPENDS = "flac libogg libvorbis sqlite3"
+DEPENDS = ""
 SECTION = "libs/multimedia"
 LICENSE = "LGPLv2.1"
 
@@ -27,8 +27,10 @@ CVE_PRODUCT = "libsndfile"
 
 S = "${WORKDIR}/libsndfile-${PV}"
 
-PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'alsa', d)}"
+PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'alsa', d)} sqlite external-libs"
 PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
+PACKAGECONFIG[sqlite] = "--enable-sqlite,--disable-sqlite,sqlite3"
+PACKAGECONFIG[external-libs] = "--enable-external-libs,--disable-external-libs,flac libogg libvorbis"
 
 inherit autotools lib_package pkgconfig
 
-- 
2.20.1

Re: [PATCH v2] libsndfile1: make sqlite and FLAC/Vorbis optional

[Burton, Ross]

I just double-took at the sqlite dependency.  This is only used by a
testing tool that we don't build or install.

How about renaming the option to regtest and disabling by default?

Ross

On Thu, 7 Mar 2019 at 13:18, Max Kellermann <max+openembedded@blarg.de> wrote:
>
> From: Max Kellermann <max.kellermann@gmail.com>
>
> Signed-off-by: Max Kellermann <max.kellermann@gmail.com>
> ---
>  meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb b/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
> index eb2c719d8d..7b5eb4f71c 100644
> --- a/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
> +++ b/meta/recipes-multimedia/libsndfile/libsndfile1_1.0.28.bb
> @@ -1,7 +1,7 @@
>  SUMMARY = "Audio format Conversion library"
>  HOMEPAGE = "http://www.mega-nerd.com/libsndfile"
>  AUTHOR = "Erik de Castro Lopo"
> -DEPENDS = "flac libogg libvorbis sqlite3"
> +DEPENDS = ""
>  SECTION = "libs/multimedia"
>  LICENSE = "LGPLv2.1"
>
> @@ -27,8 +27,10 @@ CVE_PRODUCT = "libsndfile"
>
>  S = "${WORKDIR}/libsndfile-${PV}"
>
> -PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'alsa', d)}"
> +PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'alsa', d)} sqlite external-libs"
>  PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
> +PACKAGECONFIG[sqlite] = "--enable-sqlite,--disable-sqlite,sqlite3"
> +PACKAGECONFIG[external-libs] = "--enable-external-libs,--disable-external-libs,flac libogg libvorbis"
>
>  inherit autotools lib_package pkgconfig
>
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v2] libsndfile1: make sqlite and FLAC/Vorbis optional

[Max Kellermann]

On 2019/03/07 14:23, "Burton, Ross" <ross.burton@intel.com> wrote:
> I just double-took at the sqlite dependency.  This is only used by a
> testing tool that we don't build or install.
> 
> How about renaming the option to regtest and disabling by default?

What do you think about disabling it unconditionally?

Re: [PATCH v2] libsndfile1: make sqlite and FLAC/Vorbis optional

[Burton, Ross]

On Thu, 7 Mar 2019 at 13:27, Max Kellermann <max+openembedded@blarg.de> wrote:
> > How about renaming the option to regtest and disabling by default?
>
> What do you think about disabling it unconditionally?

I wouldn't object.

Ross