Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: "Andreas Müller" <schnitzeltony@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] gstreamer1.0-python: rework gobject-introspection handling
Date: Fri, 5 Apr 2019 22:05:46 +0200	[thread overview]
Message-ID: <20190405200546.GB1614@jama> (raw)
In-Reply-To: <20190405192835.8080-1-schnitzeltony@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2032 bytes --]

On Fri, Apr 05, 2019 at 09:28:35PM +0200, Andreas Müller wrote:
> gobject-introspection is mandatory for gstreamer1.0-python - there is no
> configure option to enable or disable it.
> 
> To handle properly, this patch does:
> 
> * Make 'gobject-introspection-data' a required distro feature
> * Add
>   'UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"'
>    - it was removed in gobject-introspection.bbclass to avoid
>   | ERROR: libgee-0.18.0-r0 do_configure: QA Issue: libgee: configure was passed unrecognised options: --disable-schemas-install [unknown-configure-option]
> 
> Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> ---
>  .../gstreamer/gstreamer1.0-python_1.14.4.bb                   | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
> index 8d45ca2668..fb76a37b92 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
> @@ -16,6 +16,10 @@ PNREAL = "gst-python"
>  
>  S = "${WORKDIR}/${PNREAL}-${PV}"
>  
> +# gobject-introspection is mandatory and cannot be configured
> +REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"

Is distro_features_check inherited somewhere? I don't see it in this
part and the above IIRC doesn't work without distro_features_check
inherit.

Cheers,

> +UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"
> +
>  inherit autotools pkgconfig distutils3-base upstream-version-is-even gobject-introspection
>  
>  do_install_append() {
> -- 
> 2.20.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

  reply	other threads:[~2019-04-05 20:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-05 19:28 [PATCH] gstreamer1.0-python: rework gobject-introspection handling Andreas Müller
2019-04-05 20:05 ` Martin Jansa [this message]
2019-04-05 20:24   ` Andreas Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190405200546.GB1614@jama \
    --to=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=schnitzeltony@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox