Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] gstreamer1.0-python: rework gobject-introspection handling
@ 2019-04-05 19:28 Andreas Müller
  2019-04-05 20:05 ` Martin Jansa
  0 siblings, 1 reply; 3+ messages in thread
From: Andreas Müller @ 2019-04-05 19:28 UTC (permalink / raw)
  To: openembedded-core, ross.burton, alex.kanavin

gobject-introspection is mandatory for gstreamer1.0-python - there is no
configure option to enable or disable it.

To handle properly, this patch does:

* Make 'gobject-introspection-data' a required distro feature
* Add
  'UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"'
   - it was removed in gobject-introspection.bbclass to avoid
  | ERROR: libgee-0.18.0-r0 do_configure: QA Issue: libgee: configure was passed unrecognised options: --disable-schemas-install [unknown-configure-option]

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
---
 .../gstreamer/gstreamer1.0-python_1.14.4.bb                   | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
index 8d45ca2668..fb76a37b92 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
@@ -16,6 +16,10 @@ PNREAL = "gst-python"
 
 S = "${WORKDIR}/${PNREAL}-${PV}"
 
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
+UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"
+
 inherit autotools pkgconfig distutils3-base upstream-version-is-even gobject-introspection
 
 do_install_append() {
-- 
2.20.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] gstreamer1.0-python: rework gobject-introspection handling
  2019-04-05 19:28 [PATCH] gstreamer1.0-python: rework gobject-introspection handling Andreas Müller
@ 2019-04-05 20:05 ` Martin Jansa
  2019-04-05 20:24   ` Andreas Müller
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Jansa @ 2019-04-05 20:05 UTC (permalink / raw)
  To: Andreas Müller; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 2032 bytes --]

On Fri, Apr 05, 2019 at 09:28:35PM +0200, Andreas Müller wrote:
> gobject-introspection is mandatory for gstreamer1.0-python - there is no
> configure option to enable or disable it.
> 
> To handle properly, this patch does:
> 
> * Make 'gobject-introspection-data' a required distro feature
> * Add
>   'UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"'
>    - it was removed in gobject-introspection.bbclass to avoid
>   | ERROR: libgee-0.18.0-r0 do_configure: QA Issue: libgee: configure was passed unrecognised options: --disable-schemas-install [unknown-configure-option]
> 
> Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> ---
>  .../gstreamer/gstreamer1.0-python_1.14.4.bb                   | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
> index 8d45ca2668..fb76a37b92 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
> @@ -16,6 +16,10 @@ PNREAL = "gst-python"
>  
>  S = "${WORKDIR}/${PNREAL}-${PV}"
>  
> +# gobject-introspection is mandatory and cannot be configured
> +REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"

Is distro_features_check inherited somewhere? I don't see it in this
part and the above IIRC doesn't work without distro_features_check
inherit.

Cheers,

> +UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"
> +
>  inherit autotools pkgconfig distutils3-base upstream-version-is-even gobject-introspection
>  
>  do_install_append() {
> -- 
> 2.20.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gstreamer1.0-python: rework gobject-introspection handling
  2019-04-05 20:05 ` Martin Jansa
@ 2019-04-05 20:24   ` Andreas Müller
  0 siblings, 0 replies; 3+ messages in thread
From: Andreas Müller @ 2019-04-05 20:24 UTC (permalink / raw)
  To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer

On Fri, Apr 5, 2019 at 10:05 PM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> On Fri, Apr 05, 2019 at 09:28:35PM +0200, Andreas Müller wrote:
> > gobject-introspection is mandatory for gstreamer1.0-python - there is no
> > configure option to enable or disable it.
> >
> > To handle properly, this patch does:
> >
> > * Make 'gobject-introspection-data' a required distro feature
> > * Add
> >   'UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"'
> >    - it was removed in gobject-introspection.bbclass to avoid
> >   | ERROR: libgee-0.18.0-r0 do_configure: QA Issue: libgee: configure was passed unrecognised options: --disable-schemas-install [unknown-configure-option]
> >
> > Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> > ---
> >  .../gstreamer/gstreamer1.0-python_1.14.4.bb                   | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
> > index 8d45ca2668..fb76a37b92 100644
> > --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
> > +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb
> > @@ -16,6 +16,10 @@ PNREAL = "gst-python"
> >
> >  S = "${WORKDIR}/${PNREAL}-${PV}"
> >
> > +# gobject-introspection is mandatory and cannot be configured
> > +REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
>
> Is distro_features_check inherited somewhere? I don't see it in this
> part and the above IIRC doesn't work without distro_features_check
> inherit.
>
> Cheers,

At the time you wrote that V2 was prepared :)

I tend to forget that - need to check my meta-gnome patches for that...

Andreas


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-05 20:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-05 19:28 [PATCH] gstreamer1.0-python: rework gobject-introspection handling Andreas Müller
2019-04-05 20:05 ` Martin Jansa
2019-04-05 20:24   ` Andreas Müller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox