[PATCH] pseudo: Update to gain key bugfixes

[PATCH] pseudo: Update to gain key bugfixes

[Richard Purdie]

Newer distros are using new versions of glibc and coreutils which use the new glibc
renameat2 function. We need to intercept this for correct functioning of pseudo. This
is essential to ensure new distros continue to work with the project.

Also, this version has a fix for path/inode cross corruption problems which
may explain our mysterious locale permissions issues.

Many thanks to Otavio and Peter Seebach for the help in figuring this out and
fixing it.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-devtools/pseudo/pseudo_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/pseudo/pseudo_git.bb b/meta/recipes-devtools/pseudo/pseudo_git.bb
index 79e0b6bd21a..64b3832ca4d 100644
--- a/meta/recipes-devtools/pseudo/pseudo_git.bb
+++ b/meta/recipes-devtools/pseudo/pseudo_git.bb
@@ -8,7 +8,7 @@ SRC_URI = "git://git.yoctoproject.org/pseudo \
            file://toomanyfiles.patch \
            "
 
-SRCREV = "6294b344e5140f5467e6860f45a174440015304e"
+SRCREV = "6ebc7d6bc8ab973d0ba949eeb363821811ce8dc5"
 S = "${WORKDIR}/git"
 PV = "1.9.0+git${SRCPV}"
 
-- 
2.20.1

Re: [PATCH] pseudo: Update to gain key bugfixes

[Otavio Salvador]

On Wed, Apr 10, 2019 at 8:13 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> Newer distros are using new versions of glibc and coreutils which use the new glibc
> renameat2 function. We need to intercept this for correct functioning of pseudo. This
> is essential to ensure new distros continue to work with the project.
>
> Also, this version has a fix for path/inode cross corruption problems which
> may explain our mysterious locale permissions issues.
>
> Many thanks to Otavio and Peter Seebach for the help in figuring this out and
> fixing it.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Glad to help! ;-)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

Re: [PATCH] pseudo: Update to gain key bugfixes

[Seebs]

On Thu, 11 Apr 2019 00:12:54 +0100
Richard Purdie <richard.purdie@linuxfoundation.org> wrote:

> -SRCREV = "6294b344e5140f5467e6860f45a174440015304e"
> +SRCREV = "6ebc7d6bc8ab973d0ba949eeb363821811ce8dc5"

I would sort of recommend one of the two commits since then -- one may
fix the .NET startup failures, and the other fixes warnings that this
one introduced and I forgot to fix. But I'm also okay with this one.

-s

Re: [PATCH] pseudo: Update to gain key bugfixes

[richard.purdie]

On Wed, 2019-04-10 at 18:59 -0500, Seebs wrote:
> On Thu, 11 Apr 2019 00:12:54 +0100
> Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> 
> > -SRCREV = "6294b344e5140f5467e6860f45a174440015304e"
> > +SRCREV = "6ebc7d6bc8ab973d0ba949eeb363821811ce8dc5"
> 
> I would sort of recommend one of the two commits since then -- one
> may
> fix the .NET startup failures, and the other fixes warnings that this
> one introduced and I forgot to fix. But I'm also okay with this one.

That is good news. I've tested and updated to the later revision,
thanks!

Cheers,

Richard

Re: [PATCH] pseudo: Update to gain key bugfixes

[Andreas Müller]

On Fri, Apr 12, 2019 at 10:18 AM <richard.purdie@linuxfoundation.org> wrote:
>
> On Wed, 2019-04-10 at 18:59 -0500, Seebs wrote:
> > On Thu, 11 Apr 2019 00:12:54 +0100
> > Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> >
> > > -SRCREV = "6294b344e5140f5467e6860f45a174440015304e"
> > > +SRCREV = "6ebc7d6bc8ab973d0ba949eeb363821811ce8dc5"
> >
> > I would sort of recommend one of the two commits since then -- one
> > may
> > fix the .NET startup failures, and the other fixes warnings that this
> > one introduced and I forgot to fix. But I'm also okay with this one.
>
> That is good news. I've tested and updated to the later revision,
> thanks!
>
> Cheers,
>
> Richard
>
Hi,

If you want a happy weekend - stop reading here.

But somebody has to do widen the audience...

Seems that this commit causes issues on meta-qt5 / qtbase [1]. To make
it worse it seems that only some host configurations are affected...

Cheers

[1] https://github.com/meta-qt5/meta-qt5/issues/187

Andreas

Re: [PATCH] pseudo: Update to gain key bugfixes

[Seebs]

On Sat, 13 Apr 2019 10:03:03 +0200
Andreas Müller <schnitzeltony@gmail.com> wrote:

> On Fri, Apr 12, 2019 at 10:18 AM <richard.purdie@linuxfoundation.org>
> wrote:
> >
> > On Wed, 2019-04-10 at 18:59 -0500, Seebs wrote:
> > > On Thu, 11 Apr 2019 00:12:54 +0100
> > > Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> > >
> > > > -SRCREV = "6294b344e5140f5467e6860f45a174440015304e"
> > > > +SRCREV = "6ebc7d6bc8ab973d0ba949eeb363821811ce8dc5"
> > >
> > > I would sort of recommend one of the two commits since then -- one
> > > may
> > > fix the .NET startup failures, and the other fixes warnings that
> > > this one introduced and I forgot to fix. But I'm also okay with
> > > this one.
> >
> > That is good news. I've tested and updated to the later revision,
> > thanks!
> >
> > Cheers,
> >
> > Richard
> >
> Hi,
> 
> If you want a happy weekend - stop reading here.
> 
> But somebody has to do widen the audience...
> 
> Seems that this commit causes issues on meta-qt5 / qtbase [1]. To make
> it worse it seems that only some host configurations are affected...
> 
> Cheers
> 
> [1] https://github.com/meta-qt5/meta-qt5/issues/187
> 
> Andreas

My guess from looking at it is that qmake is using renameat2 and isn't
falling back to something else if renameat2 fails with ENOSYS.

-s

Re: [PATCH] pseudo: Update to gain key bugfixes

[Peter Kjellerstedt]

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org <openembedded-
> core-bounces@lists.openembedded.org> On Behalf Of
> richard.purdie@linuxfoundation.org
> Sent: den 12 april 2019 10:18
> To: Seebs <seebs@seebs.net>
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH] pseudo: Update to gain key bugfixes
> 
> On Wed, 2019-04-10 at 18:59 -0500, Seebs wrote:
> > On Thu, 11 Apr 2019 00:12:54 +0100
> > Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> >
> > > -SRCREV = "6294b344e5140f5467e6860f45a174440015304e"
> > > +SRCREV = "6ebc7d6bc8ab973d0ba949eeb363821811ce8dc5"
> >
> > I would sort of recommend one of the two commits since then -- one
> > may
> > fix the .NET startup failures, and the other fixes warnings that this
> > one introduced and I forgot to fix. But I'm also okay with this one.
> 
> That is good news. I've tested and updated to the later revision,
> thanks!
> 
> Cheers,
> 
> Richard

One of our developers, who has been especially affected by this 
problem, reported that he was still having problems building a 
couple of recipes even with the latest version of pseudo. After 
some debugging it was determined that the problem was due to the 
Debian version of coreutils that he was using. When he downgraded 
from 8.30-3 to 8.30-1 the problems he was seeing went away. The 
changelog for the reverted changes indicate that pseudo will 
need to be made aware about what they are doing:

,----
| coreutils (8.30-3) unstable; urgency=medium
| 
|   * Fix renameat2 patch (Closes: #923420)
| 
|  -- Michael Stone <mstone@debian.org>  Thu, 28 Feb 2019 10:30:31 -0500
| 
| coreutils (8.30-2) unstable; urgency=medium
| 
|   * Use renameat2 glibc function that can be intercepted by fakechroot
|     (Closes: #915559)
|   * Above requires autoreconf turned on again
| 
|  -- Michael Stone <mstone@debian.org>  Tue, 26 Feb 2019 07:15:19 -0500
`----

//Peter