* [PATCH v2] bluez5: remove udev dependency
@ 2019-05-23 16:41 David Frey
2019-05-25 15:51 ` Burton, Ross
0 siblings, 1 reply; 3+ messages in thread
From: David Frey @ 2019-05-23 16:41 UTC (permalink / raw)
To: openembedded-core
udev is an optional dependency of bluez5, so use PACKAGECONFIG to allow
users to decide if they want udev support.
Signed-off-by: David Frey <dpfrey@gmail.com>
---
meta/recipes-connectivity/bluez5/bluez5.inc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
index aaf2af975d..93d1b4d8b0 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -6,7 +6,7 @@ LICENSE = "GPLv2+ & LGPLv2.1+"
LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e"
-DEPENDS = "udev dbus-glib glib-2.0"
+DEPENDS = "dbus-glib glib-2.0"
PROVIDES += "bluez-hcidump"
RPROVIDES_${PN} += "bluez-hcidump"
@@ -22,6 +22,7 @@ PACKAGECONFIG ??= "obex-profiles \
hog-profiles \
tools \
deprecated \
+ udev \
"
PACKAGECONFIG[obex-profiles] = "--enable-obex,--disable-obex,libical"
PACKAGECONFIG[readline] = "--enable-client,--disable-client,readline,"
@@ -43,6 +44,7 @@ PACKAGECONFIG[threads] = "--enable-threads,--disable-threads"
PACKAGECONFIG[deprecated] = "--enable-deprecated,--disable-deprecated"
PACKAGECONFIG[mesh] = "--enable-mesh,--disable-mesh, json-c ell"
PACKAGECONFIG[btpclient] = "--enable-btpclient,--disable-btpclient, ell"
+PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
SRC_URI = "\
${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] bluez5: remove udev dependency
2019-05-23 16:41 [PATCH v2] bluez5: remove udev dependency David Frey
@ 2019-05-25 15:51 ` Burton, Ross
2019-05-27 18:57 ` David Frey
0 siblings, 1 reply; 3+ messages in thread
From: Burton, Ross @ 2019-05-25 15:51 UTC (permalink / raw)
To: David Frey; +Cc: OE-core
The commit message and the patch disagree: you're not removing the
udev dependency but allowing the user to remove it.
A better message would be 'bluez5: allow udev dependency to be
disabled with PACKAGECONFIG'
Ross
On Thu, 23 May 2019 at 17:42, David Frey <dpfrey@gmail.com> wrote:
>
> udev is an optional dependency of bluez5, so use PACKAGECONFIG to allow
> users to decide if they want udev support.
>
> Signed-off-by: David Frey <dpfrey@gmail.com>
> ---
> meta/recipes-connectivity/bluez5/bluez5.inc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index aaf2af975d..93d1b4d8b0 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -6,7 +6,7 @@ LICENSE = "GPLv2+ & LGPLv2.1+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
> file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
> file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e"
> -DEPENDS = "udev dbus-glib glib-2.0"
> +DEPENDS = "dbus-glib glib-2.0"
> PROVIDES += "bluez-hcidump"
> RPROVIDES_${PN} += "bluez-hcidump"
>
> @@ -22,6 +22,7 @@ PACKAGECONFIG ??= "obex-profiles \
> hog-profiles \
> tools \
> deprecated \
> + udev \
> "
> PACKAGECONFIG[obex-profiles] = "--enable-obex,--disable-obex,libical"
> PACKAGECONFIG[readline] = "--enable-client,--disable-client,readline,"
> @@ -43,6 +44,7 @@ PACKAGECONFIG[threads] = "--enable-threads,--disable-threads"
> PACKAGECONFIG[deprecated] = "--enable-deprecated,--disable-deprecated"
> PACKAGECONFIG[mesh] = "--enable-mesh,--disable-mesh, json-c ell"
> PACKAGECONFIG[btpclient] = "--enable-btpclient,--disable-btpclient, ell"
> +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
>
> SRC_URI = "\
> ${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
> --
> 2.21.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] bluez5: remove udev dependency
2019-05-25 15:51 ` Burton, Ross
@ 2019-05-27 18:57 ` David Frey
0 siblings, 0 replies; 3+ messages in thread
From: David Frey @ 2019-05-27 18:57 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On 5/25/2019 8:51 AM, Burton, Ross wrote:
> The commit message and the patch disagree: you're not removing the
> udev dependency but allowing the user to remove it.
>
> A better message would be 'bluez5: allow udev dependency to be
> disabled with PACKAGECONFIG'
Thanks for your feedback. I will send v3 with a clearer commit message.
David
>
> Ross
>
> On Thu, 23 May 2019 at 17:42, David Frey <dpfrey@gmail.com> wrote:
>>
>> udev is an optional dependency of bluez5, so use PACKAGECONFIG to allow
>> users to decide if they want udev support.
>>
>> Signed-off-by: David Frey <dpfrey@gmail.com>
>> ---
>> meta/recipes-connectivity/bluez5/bluez5.inc | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
>> index aaf2af975d..93d1b4d8b0 100644
>> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
>> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
>> @@ -6,7 +6,7 @@ LICENSE = "GPLv2+ & LGPLv2.1+"
>> LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>> file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
>> file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e"
>> -DEPENDS = "udev dbus-glib glib-2.0"
>> +DEPENDS = "dbus-glib glib-2.0"
>> PROVIDES += "bluez-hcidump"
>> RPROVIDES_${PN} += "bluez-hcidump"
>>
>> @@ -22,6 +22,7 @@ PACKAGECONFIG ??= "obex-profiles \
>> hog-profiles \
>> tools \
>> deprecated \
>> + udev \
>> "
>> PACKAGECONFIG[obex-profiles] = "--enable-obex,--disable-obex,libical"
>> PACKAGECONFIG[readline] = "--enable-client,--disable-client,readline,"
>> @@ -43,6 +44,7 @@ PACKAGECONFIG[threads] = "--enable-threads,--disable-threads"
>> PACKAGECONFIG[deprecated] = "--enable-deprecated,--disable-deprecated"
>> PACKAGECONFIG[mesh] = "--enable-mesh,--disable-mesh, json-c ell"
>> PACKAGECONFIG[btpclient] = "--enable-btpclient,--disable-btpclient, ell"
>> +PACKAGECONFIG[udev] = "--enable-udev,--disable-udev,udev"
>>
>> SRC_URI = "\
>> ${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
>> --
>> 2.21.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-05-27 18:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-23 16:41 [PATCH v2] bluez5: remove udev dependency David Frey
2019-05-25 15:51 ` Burton, Ross
2019-05-27 18:57 ` David Frey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox