Openembedded Core Discussions
 help / color / mirror / Atom feed
From: <mingli.yu@windriver.com>
To: <openembedded-core@lists.openembedded.org>, <matt@madison.systems>
Subject: [PATCH] go-dep: disable PTEST_ENABLED
Date: Fri, 28 Jun 2019 00:57:01 -0700	[thread overview]
Message-ID: <20190628075701.78128-1-mingli.yu@windriver.com> (raw)

From: Mingli Yu <mingli.yu@windriver.com>

The run-ptest logic for go-dep actually runs the
/usr/lib64/go-dep/ptest/github.com/golang/dep/cmd/dep/dep.test whose
source file is https://github.com/golang/dep/blob/master/cmd/dep/dep_test.go.

That dep_test.go starts by rebuilding the dep program
from source, then runs the tests using that copy of the
program, so it's assuming that we're still in a development
environment where we can run a full go build.

Considering it not being designed for a cross-build setup,
so disable PTEST_ENABLED.

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 meta/recipes-devtools/go/go-dep_0.5.0.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/go/go-dep_0.5.0.bb b/meta/recipes-devtools/go/go-dep_0.5.0.bb
index a4d631f8ea..e9fc12fa5a 100644
--- a/meta/recipes-devtools/go/go-dep_0.5.0.bb
+++ b/meta/recipes-devtools/go/go-dep_0.5.0.bb
@@ -21,5 +21,6 @@ BBCLASSEXTEND = "native nativesdk"
 
 # For compiling ptest on mips and mips64, the current go-dep version fails with the go 1.11 toolchain.
 # error message: vet config not found
-PTEST_ENABLED_mips = "0"
-PTEST_ENABLED_mips64 = "0"
+# disable PTEST_ENABLED as the run-ptest script for go-dep actually runs the /usr/lib64/go-dep/ptest/github.com/golang/dep/cmd/dep/dep.test whose source file is https://github.com/golang/dep/blob/master/cmd/dep/dep_test.go not being designed for a cross-build setup.
+PTEST_ENABLED = "0"
+PTEST_ENABLED = "0"
-- 
2.21.0



             reply	other threads:[~2019-06-28  7:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28  7:57 mingli.yu [this message]
2019-06-28 11:02 ` [PATCH] go-dep: disable PTEST_ENABLED Richard Purdie
2019-07-01  2:03   ` Yu, Mingli
2019-07-01 11:59     ` Matt Madison
2019-07-01 14:45       ` Burton, Ross
2019-07-03  2:34       ` Yu, Mingli
2019-07-03  9:24       ` [PATCH] go.bbclass: remove ptest inherit mingli.yu
2019-07-04 12:38         ` Matt Madison
2019-07-05  9:00           ` [PATCH v3] go.bbclass: separate the ptest logic to go-ptest class mingli.yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628075701.78128-1-mingli.yu@windriver.com \
    --to=mingli.yu@windriver.com \
    --cc=matt@madison.systems \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox