Re: [PATCH] go-dep: disable PTEST_ENABLED

["Yu, Mingli" <mingli.yu@windriver.com>]

On 2019年06月28日 19:02, Richard Purdie wrote:
> On Fri, 2019-06-28 at 00:57 -0700, mingli.yu@windriver.com wrote:
>> From: Mingli Yu <mingli.yu@windriver.com>
>>
>> The run-ptest logic for go-dep actually runs the
>> /usr/lib64/go-dep/ptest/github.com/golang/dep/cmd/dep/dep.test whose
>> source file is
>> https://github.com/golang/dep/blob/master/cmd/dep/dep_test.go.
>>
>> That dep_test.go starts by rebuilding the dep program
>> from source, then runs the tests using that copy of the
>> program, so it's assuming that we're still in a development
>> environment where we can run a full go build.
>>
>> Considering it not being designed for a cross-build setup,
>> so disable PTEST_ENABLED.
>>
>> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
>> ---
>>   meta/recipes-devtools/go/go-dep_0.5.0.bb | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/go/go-dep_0.5.0.bb b/meta/recipes-
>> devtools/go/go-dep_0.5.0.bb
>> index a4d631f8ea..e9fc12fa5a 100644
>> --- a/meta/recipes-devtools/go/go-dep_0.5.0.bb
>> +++ b/meta/recipes-devtools/go/go-dep_0.5.0.bb
>> @@ -21,5 +21,6 @@ BBCLASSEXTEND = "native nativesdk"
>>
>>   # For compiling ptest on mips and mips64, the current go-dep version
>> fails with the go 1.11 toolchain.
>>   # error message: vet config not found
>> -PTEST_ENABLED_mips = "0"
>> -PTEST_ENABLED_mips64 = "0"
>> +# disable PTEST_ENABLED as the run-ptest script for go-dep actually
>> runs the /usr/lib64/go-
>> dep/ptest/github.com/golang/dep/cmd/dep/dep.test whose source file is
>> https://github.com/golang/dep/blob/master/cmd/dep/dep_test.go not
>> being designed for a cross-build setup.
>> +PTEST_ENABLED = "0"
>> +PTEST_ENABLED = "0"
>
> Setting it twice looks wrong.

Sorry, it should be my typo.

>
> If we're disabling it, why would we inherit the ptest class at all as
> its not going to work anywhere?
>
> Upstream not considering cross test usecases isn't a reason to disable
> a test, we have many tests enabled where upstream haven't considered a
> cross use case, we just tend to patch as needed and start a discussion
> with them.
>
> It sounds like its actually a network access problem from the image
> you're running into anyway?

Hi RP,

Have discussed the ptest more with Matt in the maillist and also tried 
to add the patch under the guide from Matt to make the 
https://github.com/golang/dep/blob/master/cmd/dep/dep_test.go work with 
cross-setup env. But seems it still doesn't work.

Hi Matt,
What's your opinion?

Thanks,

>
> Cheers,
>
> Richard
>
>
>