From: Petr Vorel <petr.vorel@gmail.com>
To: "Hongzhi.Song" <hongzhi.song@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] ltp: getrlimit03: adjust-a-bit-of-code-to-compatiable-with mips32
Date: Thu, 18 Jul 2019 23:51:34 +0200 [thread overview]
Message-ID: <20190718215132.GD26895@dell5510> (raw)
In-Reply-To: <20190717095039.121044-1-hongzhi.song@windriver.com>
Hi Hongzhi,
...
> --- /dev/null
> +++ b/meta/recipes-extended/ltp/ltp/0001-getrlimit03-adjust-a-bit-of-code-to-compatiable-with.patch
> @@ -0,0 +1,62 @@
> +From e79652a3839869b1983d65999e5d5dcb50bc9cd7 Mon Sep 17 00:00:00 2001
> +From: "Hongzhi.Song" <hongzhi.song@windriver.com>
> +Date: Mon, 15 Jul 2019 03:39:06 -0400
> +Subject: [PATCH] getrlimit03: adjust a bit of code to compatiable with mips32
...
> +Signed-off-by: Jan Stancek <jstancek@redhat.com>
> +Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
> +
> +Upstream-Status: Backport
> +Signed-off-by: Hongzhi.Song <hongzhi.song@windriver.com>
> +---
> + testcases/kernel/syscalls/getrlimit/getrlimit03.c | 8 +++++++-
> + 1 file changed, 7 insertions(+), 1 deletion(-)
I have to say I prefer policy when only build fixes are backported / added.
(approach which e.g. buildroot has). Having many patches (25 atm) makes updating
a bit difficult (ok, not that much, 'Upstream-Status: Backport' shows what has
been merged since last release) and sometimes brings users patches which weren't
accepted by upstream (your mips patch [1] was not accepted [2]).
But I understand that LTP 3 months release cycle can be to
slow for some LTP users.
Kind regards,
Petr
PS: I'm slowly working on fixing all musl issues in LTP upstream. It's a long
term run but were moving towards that goal.
Patch "build: Add option to select libc implementation" [3] is a not a good
approach. Instead it's needed to find for each failure why it's not presented
in musl. Mostly because it uses non POSIX features or deprecated API, which
needs to be avoided or used kernel headers where it's available.
[1] http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-extended/ltp/ltp/0001-open_posix_testsuite-mmap24-2-Relax-condition-a-bit.patch
[2] https://patchwork.ozlabs.org/patch/982194/#2012168
[3] http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-extended/ltp/ltp/0004-build-Add-option-to-select-libc-implementation.patch
next prev parent reply other threads:[~2019-07-18 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 9:50 [PATCH] ltp: getrlimit03: adjust-a-bit-of-code-to-compatiable-with mips32 Hongzhi.Song
2019-07-18 21:51 ` Petr Vorel [this message]
2019-07-19 1:45 ` Hongzhi, Song
2019-07-19 6:41 ` Petr Vorel
2019-07-19 7:46 ` Hongzhi, Song
2019-07-19 8:06 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718215132.GD26895@dell5510 \
--to=petr.vorel@gmail.com \
--cc=hongzhi.song@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox