From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Petr Vorel <petr.vorel@gmail.com>,
"Hongzhi.Song" <hongzhi.song@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] ltp: getrlimit03: adjust-a-bit-of-code-to-compatiable-with mips32
Date: Fri, 19 Jul 2019 09:06:58 +0100 [thread overview]
Message-ID: <99beb56891c932f2d4efc59dd80ae69f043e5cde.camel@linuxfoundation.org> (raw)
In-Reply-To: <20190718215132.GD26895@dell5510>
Hi Petr,
On Thu, 2019-07-18 at 23:51 +0200, Petr Vorel wrote:
> I have to say I prefer policy when only build fixes are backported /
> added. (approach which e.g. buildroot has). Having many patches (25
> atm) makes updating a bit difficult (ok, not that much, 'Upstream-
> Status: Backport' shows what has been merged since last release) and
> sometimes brings users patches which weren't accepted by upstream
> (your mips patch [1] was not accepted [2]).
>
> But I understand that LTP 3 months release cycle can be to
> slow for some LTP users.
FWIW our policy does vary a lot depending on the upstream. Where we can
have an open dialog with active projects I'm very keen to figure out
how to get our patch set to zero, we really don't want patches.
Backports don't worry me so much because as you say, we clearly mark
them and those are easy to drop upon upgrade.
I see we have an ltp upgrade which looks to remove 50% of the patches
which is a good start.
That leaves 12 of them, of which 6 are musl and 6 appear to be other
test 'fixes' of various kinds.
Of the other 6, 3 say they're backports, one submitted and two pending.
Figuring out the two pending and the submitted would set us up for a
cleaner upgrade in future outside of musl.
> Kind regards,
> Petr
>
> PS: I'm slowly working on fixing all musl issues in LTP upstream.
> It's a long term run but were moving towards that goal. Patch "build:
> Add option to select libc implementation" [3] is a nota good
> approach. Instead it's needed to find for each failure why it's not
> presented in musl. Mostly because it uses non POSIX features or
> deprecated API, which needs to be avoided or used kernel headers
> where it's available.
This sounds great, I think what we have right now can only be described
as a bit of a hack. It lets us build and run tests but clearly isn't
appropriate to merge upstream. We can at the very least help with
testing and certainly want to drop our patch if/as/when we can.
Also, I'm not sure if you've seen it but our "full" builds now run ltp
for x86 and arm under qemu and report the results:
https://autobuilder.yocto.io/pub/non-release/20190712-13/testresults/testresult-report.txt
(see the Ltp and Ltp Posix sections)
I'm actually quite worried about the numbers of failures we see there.
Up to now I've been focusing on sorting out our ptest results but ltp
would be something we need to focus on next.
There should be more raw log data in
https://autobuilder.yocto.io/pub/non-release/20190712-13/testresults/qemux86-64-ltp/
and
https://autobuilder.yocto.io/pub/non-release/20190712-13/testresults/qemuarm64-ltp/testresults.json
but I've not had a chance to look at the ltp side of things at all
myself, Armin has done the integration work so far.
Cheers,
Richard
prev parent reply other threads:[~2019-07-19 8:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 9:50 [PATCH] ltp: getrlimit03: adjust-a-bit-of-code-to-compatiable-with mips32 Hongzhi.Song
2019-07-18 21:51 ` Petr Vorel
2019-07-19 1:45 ` Hongzhi, Song
2019-07-19 6:41 ` Petr Vorel
2019-07-19 7:46 ` Hongzhi, Song
2019-07-19 8:06 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99beb56891c932f2d4efc59dd80ae69f043e5cde.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=hongzhi.song@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=petr.vorel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox