[PATCH] module.bbclass: do not strip packages if modules signing is enabled

[PATCH] module.bbclass: do not strip packages if modules signing is enabled

[dbaryshkov]

From: Dmitry Eremin-Solenikov <dmitry_eremin-solenikov@mentor.com>

Stripping kernel modules will also remove signature, thus we have to
inhibit package striping in case modules signatures are enabled.

Signed-off-by: Dmitry Eremin-Solenikov <dmitry_eremin-solenikov@mentor.com>
---
 meta/classes/module.bbclass | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/classes/module.bbclass b/meta/classes/module.bbclass
index c0dfa3506133..31d5a2f21adc 100644
--- a/meta/classes/module.bbclass
+++ b/meta/classes/module.bbclass
@@ -72,3 +72,6 @@ EXPORT_FUNCTIONS do_compile do_install
 KERNEL_MODULES_META_PACKAGE = "${PN}"
 FILES_${PN} = ""
 ALLOW_EMPTY_${PN} = "1"
+
+# Do not strip modules if modules signing is enabled
+INHIBIT_PACKAGE_STRIP ?= "${@bb.utils.contains('DISTRO_FEATURES', 'modsign', '1', '0', d)}"
-- 
2.20.1

Re: [PATCH] module.bbclass: do not strip packages if modules signing is enabled

[Mittal, Anuj]

On Thu, 2019-08-08 at 12:57 +0300, dbaryshkov@gmail.com wrote:
> From: Dmitry Eremin-Solenikov <dmitry_eremin-solenikov@mentor.com>
> 
> Stripping kernel modules will also remove signature, thus we have to
> inhibit package striping in case modules signatures are enabled.
> 

Isn't this already being taken care of here:

https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=8fc56faa5d76927f42a4e7cca2418556e231938f

Thanks,

Anuj

Re: [PATCH] module.bbclass: do not strip packages if modules signing is enabled

[Dmitry Eremin-Solenikov]

чт, 8 авг. 2019 г. в 14:44, Mittal, Anuj <anuj.mittal@intel.com>:
>
> On Thu, 2019-08-08 at 12:57 +0300, dbaryshkov@gmail.com wrote:
> > From: Dmitry Eremin-Solenikov <dmitry_eremin-solenikov@mentor.com>
> >
> > Stripping kernel modules will also remove signature, thus we have to
> > inhibit package striping in case modules signatures are enabled.
> >
>
> Isn't this already being taken care of here:
>
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=8fc56faa5d76927f42a4e7cca2418556e231938f

Hmm, true. I missed that commit.

-- 
With best wishes
Dmitry