[PATCH] openssl: Fix documentation DEPENDS

[PATCH] openssl: Fix documentation DEPENDS

[Joshua Watt]

perl is required to generate the OpenSSL documentation, and therefore
should be present at do_compile. If not, OpenSSL will skip the
documentation generation, which isn't reproducible

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
 meta/recipes-connectivity/openssl/openssl_1.1.1c.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
index 75159ac725c..da15bc22a7a 100644
--- a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
+++ b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
@@ -10,6 +10,8 @@ LICENSE = "openssl"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=d343e62fc9c833710bbbed25f27364c8"
 
 DEPENDS = "hostperl-runtime-native"
+# Perl is required to generate documentation
+DEPENDS_append_class-target = " perl-native"
 
 SRC_URI = "http://www.openssl.org/source/openssl-${PV}.tar.gz \
            file://run-ptest \
-- 
2.21.0

Re: [PATCH] openssl: Fix documentation DEPENDS

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

On Tue, 27 Aug 2019 at 14:46, Joshua Watt <jpewhacker@gmail.com> wrote:

> perl is required to generate the OpenSSL documentation, and therefore
> should be present at do_compile. If not, OpenSSL will skip the
> documentation generation, which isn't reproducible
>

I'm not sure I follow you. If perl is present, documentation is generated.
If perl is not present, documentation is not generated. Where is the
non-reproducibility in this?

Alex

[-- Attachment #2: Type: text/html, Size: 788 bytes --]

Re: [PATCH] openssl: Fix documentation DEPENDS

[Joshua Watt]

On 8/27/19 7:56 AM, Alexander Kanavin wrote:
> On Tue, 27 Aug 2019 at 14:46, Joshua Watt <jpewhacker@gmail.com 
> <mailto:jpewhacker@gmail.com>> wrote:
>
>     perl is required to generate the OpenSSL documentation, and therefore
>     should be present at do_compile. If not, OpenSSL will skip the
>     documentation generation, which isn't reproducible
>
>
> I'm not sure I follow you. If perl is present, documentation is 
> generated. If perl is not present, documentation is not generated. 
> Where is the non-reproducibility in this?

RSS doesn't clear out the sysroots if it goes back and executes previous 
tasks as part of a rebuild. As such, if perl gets added by a later task, 
then bitbake goes back and re-executes the task (I don't remember 
exactly which one... do_configure maybe?), perl may be present when it 
wasn't before.

This is generally true of all RSS dependencies, and until it gets 
resolved the best we can say for reproducible builds is that two builds 
from stratch without sstate can be binary identical. It will have to be 
resolved eventually, but my current plan is to do the reproducible build 
test as two clean builds for now so if there is a lot of push back we 
can drop it.


>
> Alex

Re: [PATCH] openssl: Fix documentation DEPENDS

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]

On Tue, 27 Aug 2019 at 15:08, Joshua Watt <jpewhacker@gmail.com> wrote:

> RSS doesn't clear out the sysroots if it goes back and executes previous
> tasks as part of a rebuild. As such, if perl gets added by a later task,
> then bitbake goes back and re-executes the task (I don't remember
> exactly which one... do_configure maybe?), perl may be present when it
> wasn't before.
>

I am still not understanding. The sysroot is populated once before anything
in configure/compile/install/package executes. How would perl then
magically appear later on in the sysroot?

Alex

[-- Attachment #2: Type: text/html, Size: 913 bytes --]

Re: [PATCH] openssl: Fix documentation DEPENDS

[Joshua Watt]

On 8/27/19 8:25 AM, Alexander Kanavin wrote:
> On Tue, 27 Aug 2019 at 15:08, Joshua Watt <jpewhacker@gmail.com 
> <mailto:jpewhacker@gmail.com>> wrote:
>
>     RSS doesn't clear out the sysroots if it goes back and executes
>     previous
>     tasks as part of a rebuild. As such, if perl gets added by a later
>     task,
>     then bitbake goes back and re-executes the task (I don't remember
>     exactly which one... do_configure maybe?), perl may be present
>     when it
>     wasn't before.
>
>
> I am still not understanding. The sysroot is populated once before 
> anything in configure/compile/install/package executes. How would perl 
> then magically appear later on in the sysroot?

It's not populated just once. Any task can add things to the RSS as the 
build progresses. However, the RSS is only cleaned out at one specific 
point early in the build, which I can't recall ATM.

>
> Alex

Re: [PATCH] openssl: Fix documentation DEPENDS

[Alexander Kanavin]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

On Tue, 27 Aug 2019 at 18:12, Joshua Watt <jpewhacker@gmail.com> wrote:

> It's not populated just once. Any task can add things to the RSS as the
> build progresses. However, the RSS is only cleaned out at one specific
> point early in the build, which I can't recall ATM.
>

Can you point me to a specific example of tasks adding things to RSS
please? I'm fairly sure I haven't seen this happen yet, so would like  to
know the mechanism and use cases.

Alex

[-- Attachment #2: Type: text/html, Size: 795 bytes --]

Re: [PATCH] openssl: Fix documentation DEPENDS

[Richard Purdie]

On Tue, 2019-08-27 at 18:16 +0200, Alexander Kanavin wrote:
> On Tue, 27 Aug 2019 at 18:12, Joshua Watt <jpewhacker@gmail.com>
> wrote:
> > It's not populated just once. Any task can add things to the RSS as
> > the 
> > build progresses. However, the RSS is only cleaned out at one
> > specific 
> > point early in the build, which I can't recall ATM.
> 
> Can you point me to a specific example of tasks adding things to RSS
> please? I'm fairly sure I haven't seen this happen yet, so would
> like  to know the mechanism and use cases.

It definitely does happen. An easy example is quilt-native for
do_patch. Another would be file-native or rpm-native for do_package.

Cheers,

Richard

[PATCH] openssl: Fix documentation DEPENDS

[Joshua Watt]

perl is required to generate the OpenSSL documentation, and therefore
should be present at do_compile. If not, OpenSSL will skip the
documentation generation, which isn't reproducible

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
 meta/recipes-connectivity/openssl/openssl_1.1.1c.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
index 01174073167..c57626d8f6d 100644
--- a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
+++ b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
@@ -10,6 +10,8 @@ LICENSE = "openssl"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=d343e62fc9c833710bbbed25f27364c8"
 
 DEPENDS = "hostperl-runtime-native"
+# Perl is required to generate documentation
+DEPENDS_append_class-target = " perl-native"
 
 SRC_URI = "http://www.openssl.org/source/openssl-${PV}.tar.gz \
            file://run-ptest \
-- 
2.21.0

Re: [PATCH] openssl: Fix documentation DEPENDS

[Burton, Ross]

To avoid needing perl-native, can it be told to use the host perl?

Ross

On Thu, 27 Jun 2019 at 14:56, Joshua Watt <jpewhacker@gmail.com> wrote:
>
> perl is required to generate the OpenSSL documentation, and therefore
> should be present at do_compile. If not, OpenSSL will skip the
> documentation generation, which isn't reproducible
>
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> ---
>  meta/recipes-connectivity/openssl/openssl_1.1.1c.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> index 01174073167..c57626d8f6d 100644
> --- a/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> +++ b/meta/recipes-connectivity/openssl/openssl_1.1.1c.bb
> @@ -10,6 +10,8 @@ LICENSE = "openssl"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=d343e62fc9c833710bbbed25f27364c8"
>
>  DEPENDS = "hostperl-runtime-native"
> +# Perl is required to generate documentation
> +DEPENDS_append_class-target = " perl-native"
>
>  SRC_URI = "http://www.openssl.org/source/openssl-${PV}.tar.gz \
>             file://run-ptest \
> --
> 2.21.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core