Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 1/8] base-files: drop legacy empty file /etc/default/usbd
@ 2019-09-16 19:24 Andre McCurdy
  2019-09-16 19:24 ` [PATCH 2/8] busybox: rcS and rcK should not be writeable by everyone Andre McCurdy
                   ` (6 more replies)
  0 siblings, 7 replies; 13+ messages in thread
From: Andre McCurdy @ 2019-09-16 19:24 UTC (permalink / raw)
  To: openembedded-core

Doesn't seem to be referenced by anything in oe-core any more.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/recipes-core/base-files/base-files/usbd      | 0
 meta/recipes-core/base-files/base-files_3.0.14.bb | 2 --
 2 files changed, 2 deletions(-)
 delete mode 100644 meta/recipes-core/base-files/base-files/usbd

diff --git a/meta/recipes-core/base-files/base-files/usbd b/meta/recipes-core/base-files/base-files/usbd
deleted file mode 100644
index e69de29bb2..0000000000
diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
index 2b1f217ddb..94299431f6 100644
--- a/meta/recipes-core/base-files/base-files_3.0.14.bb
+++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
@@ -20,7 +20,6 @@ SRC_URI = "file://rotation \
            file://fstab \
            file://issue.net \
            file://issue \
-           file://usbd \
            file://share/dot.bashrc \
            file://share/dot.profile \
            file://licenses/GPL-2 \
@@ -122,7 +121,6 @@ do_install () {
 	fi
 
 	install -m 0644 ${WORKDIR}/fstab ${D}${sysconfdir}/fstab
-	install -m 0644 ${WORKDIR}/usbd ${D}${sysconfdir}/default/usbd
 	install -m 0644 ${WORKDIR}/profile ${D}${sysconfdir}/profile
 	sed -i 's#ROOTHOME#${ROOT_HOME}#' ${D}${sysconfdir}/profile
         sed -i 's#@BINDIR@#${bindir}#g' ${D}${sysconfdir}/profile
-- 
2.23.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 2/8] busybox: rcS and rcK should not be writeable by everyone
  2019-09-16 19:24 [PATCH 1/8] base-files: drop legacy empty file /etc/default/usbd Andre McCurdy
@ 2019-09-16 19:24 ` Andre McCurdy
  2019-09-16 19:24 ` [PATCH 3/8] ffmpeg: add PACKAGECONFIG controls for alsa and zlib (enable by default) Andre McCurdy
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: Andre McCurdy @ 2019-09-16 19:24 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/recipes-core/busybox/busybox.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
index 49165d7f51..4c3969501a 100644
--- a/meta/recipes-core/busybox/busybox.inc
+++ b/meta/recipes-core/busybox/busybox.inc
@@ -316,8 +316,8 @@ do_install () {
 		fi
 	fi
 	if grep -q "CONFIG_INIT=y" ${B}/.config; then
-		install -D -m 0777 ${WORKDIR}/rcS ${D}${sysconfdir}/init.d/rcS
-		install -D -m 0777 ${WORKDIR}/rcK ${D}${sysconfdir}/init.d/rcK
+		install -D -m 0755 ${WORKDIR}/rcS ${D}${sysconfdir}/init.d/rcS
+		install -D -m 0755 ${WORKDIR}/rcK ${D}${sysconfdir}/init.d/rcK
 	fi
 
 	if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then
-- 
2.23.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 3/8] ffmpeg: add PACKAGECONFIG controls for alsa and zlib (enable by default)
  2019-09-16 19:24 [PATCH 1/8] base-files: drop legacy empty file /etc/default/usbd Andre McCurdy
  2019-09-16 19:24 ` [PATCH 2/8] busybox: rcS and rcK should not be writeable by everyone Andre McCurdy
@ 2019-09-16 19:24 ` Andre McCurdy
  2019-09-16 19:24 ` [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon Andre McCurdy
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: Andre McCurdy @ 2019-09-16 19:24 UTC (permalink / raw)
  To: openembedded-core

Also move the libogg dependency to the theora PACKAGECONFIG, since
according to the configure script, theora is the specific component
which requires it.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
index 2d69d8bd72..307e37e3fe 100644
--- a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
+++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
@@ -38,12 +38,12 @@ ARM_INSTRUCTION_SET_armv6 = "arm"
 # libpostproc was previously packaged from a separate recipe
 PROVIDES = "libav libpostproc"
 
-DEPENDS = "alsa-lib zlib libogg nasm-native"
+DEPENDS = "nasm-native"
 
 inherit autotools pkgconfig
 
 PACKAGECONFIG ??= "avdevice avfilter avcodec avformat swresample swscale postproc avresample \
-                   bzlib gpl lzma theora x264 \
+                   alsa bzlib gpl lzma theora x264 zlib \
                    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xv xcb', '', d)}"
 
 # libraries to build in addition to avutil
@@ -57,6 +57,7 @@ PACKAGECONFIG[postproc] = "--enable-postproc,--disable-postproc"
 PACKAGECONFIG[avresample] = "--enable-avresample,--disable-avresample"
 
 # features to support
+PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
 PACKAGECONFIG[bzlib] = "--enable-bzlib,--disable-bzlib,bzip2"
 PACKAGECONFIG[gpl] = "--enable-gpl,--disable-gpl"
 PACKAGECONFIG[gsm] = "--enable-libgsm,--disable-libgsm,libgsm"
@@ -68,13 +69,14 @@ PACKAGECONFIG[mp3lame] = "--enable-libmp3lame,--disable-libmp3lame,lame"
 PACKAGECONFIG[openssl] = "--enable-openssl,--disable-openssl,openssl"
 PACKAGECONFIG[sdl2] = "--enable-sdl2,--disable-sdl2,virtual/libsdl2"
 PACKAGECONFIG[speex] = "--enable-libspeex,--disable-libspeex,speex"
-PACKAGECONFIG[theora] = "--enable-libtheora,--disable-libtheora,libtheora"
+PACKAGECONFIG[theora] = "--enable-libtheora,--disable-libtheora,libtheora libogg"
 PACKAGECONFIG[vaapi] = "--enable-vaapi,--disable-vaapi,libva"
 PACKAGECONFIG[vdpau] = "--enable-vdpau,--disable-vdpau,libvdpau"
 PACKAGECONFIG[vpx] = "--enable-libvpx,--disable-libvpx,libvpx"
 PACKAGECONFIG[x264] = "--enable-libx264,--disable-libx264,x264"
 PACKAGECONFIG[xcb] = "--enable-libxcb,--disable-libxcb,libxcb"
 PACKAGECONFIG[xv] = "--enable-outdev=xv,--disable-outdev=xv,libxv"
+PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib"
 
 # Check codecs that require --enable-nonfree
 USE_NONFREE = "${@bb.utils.contains_any('PACKAGECONFIG', [ 'openssl' ], 'yes', '', d)}"
-- 
2.23.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon
  2019-09-16 19:24 [PATCH 1/8] base-files: drop legacy empty file /etc/default/usbd Andre McCurdy
  2019-09-16 19:24 ` [PATCH 2/8] busybox: rcS and rcK should not be writeable by everyone Andre McCurdy
  2019-09-16 19:24 ` [PATCH 3/8] ffmpeg: add PACKAGECONFIG controls for alsa and zlib (enable by default) Andre McCurdy
@ 2019-09-16 19:24 ` Andre McCurdy
  2019-09-16 21:33   ` Christopher Larson
  2019-09-16 19:24 ` [PATCH 5/8] ffmpeg: enable more verbose build logs Andre McCurdy
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 13+ messages in thread
From: Andre McCurdy @ 2019-09-16 19:24 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
index 307e37e3fe..c4261248b6 100644
--- a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
+++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
@@ -114,10 +114,19 @@ EXTRA_OECONF = " \
     --pkg-config=pkg-config \
 "
 
+# Do not trust configure to determine if ARM vfp or neon are available.
+#
+EXTRA_OECONF_ARM = " \
+    ${@bb.utils.contains('TUNE_FEATURES','vfp','--enable-vfp','--disable-vfp', d)} \
+    ${@bb.utils.contains("TUNE_FEATURES",'neon','--enable-neon','--disable-neon',d)} \
+"
+EXTRA_OECONF_append_arm = " ${EXTRA_OECONF_ARM}"
+EXTRA_OECONF_append_armeb = " ${EXTRA_OECONF_ARM}"
+
 EXTRA_OECONF_append_linux-gnux32 = " --disable-asm"
+
 # gold crashes on x86, another solution is to --disable-asm but thats more hacky
 # ld.gold: internal error in relocate_section, at ../../gold/i386.cc:3684
-
 LDFLAGS_append_x86 = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
 
 do_configure() {
-- 
2.23.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 5/8] ffmpeg: enable more verbose build logs
  2019-09-16 19:24 [PATCH 1/8] base-files: drop legacy empty file /etc/default/usbd Andre McCurdy
                   ` (2 preceding siblings ...)
  2019-09-16 19:24 ` [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon Andre McCurdy
@ 2019-09-16 19:24 ` Andre McCurdy
  2019-09-16 19:24 ` [PATCH 6/8] libwebp: apply ARM specific config options to big endian ARM Andre McCurdy
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: Andre McCurdy @ 2019-09-16 19:24 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
index c4261248b6..2809f343b8 100644
--- a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
+++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
@@ -129,6 +129,8 @@ EXTRA_OECONF_append_linux-gnux32 = " --disable-asm"
 # ld.gold: internal error in relocate_section, at ../../gold/i386.cc:3684
 LDFLAGS_append_x86 = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
 
+EXTRA_OEMAKE = "V=1"
+
 do_configure() {
     ${S}/configure ${EXTRA_OECONF}
 }
-- 
2.23.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 6/8] libwebp: apply ARM specific config options to big endian ARM
  2019-09-16 19:24 [PATCH 1/8] base-files: drop legacy empty file /etc/default/usbd Andre McCurdy
                   ` (3 preceding siblings ...)
  2019-09-16 19:24 ` [PATCH 5/8] ffmpeg: enable more verbose build logs Andre McCurdy
@ 2019-09-16 19:24 ` Andre McCurdy
  2019-09-16 19:24 ` [PATCH 7/8] initscripts: enable alignment.sh init script for " Andre McCurdy
  2019-09-16 19:24 ` [PATCH 8/8] libunwind: apply configure over-ride to both big and little " Andre McCurdy
  6 siblings, 0 replies; 13+ messages in thread
From: Andre McCurdy @ 2019-09-16 19:24 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/recipes-multimedia/webp/libwebp_1.0.3.bb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-multimedia/webp/libwebp_1.0.3.bb b/meta/recipes-multimedia/webp/libwebp_1.0.3.bb
index 01fc02d23b..a4d1ae43d9 100644
--- a/meta/recipes-multimedia/webp/libwebp_1.0.3.bb
+++ b/meta/recipes-multimedia/webp/libwebp_1.0.3.bb
@@ -25,11 +25,14 @@ EXTRA_OECONF = " \
     --enable-libwebpdemux \
     --enable-threading \
 "
+
 # Do not trust configure to determine if neon is available.
 #
-EXTRA_OECONF_append_arm = " \
+EXTRA_OECONF_ARM = " \
     ${@bb.utils.contains("TUNE_FEATURES","neon","--enable-neon","--disable-neon",d)} \
 "
+EXTRA_OECONF_append_arm = " ${EXTRA_OECONF_ARM}"
+EXTRA_OECONF_append_armeb = " ${EXTRA_OECONF_ARM}"
 
 inherit autotools lib_package
 
-- 
2.23.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 7/8] initscripts: enable alignment.sh init script for big endian ARM
  2019-09-16 19:24 [PATCH 1/8] base-files: drop legacy empty file /etc/default/usbd Andre McCurdy
                   ` (4 preceding siblings ...)
  2019-09-16 19:24 ` [PATCH 6/8] libwebp: apply ARM specific config options to big endian ARM Andre McCurdy
@ 2019-09-16 19:24 ` Andre McCurdy
  2019-09-16 19:24 ` [PATCH 8/8] libunwind: apply configure over-ride to both big and little " Andre McCurdy
  6 siblings, 0 replies; 13+ messages in thread
From: Andre McCurdy @ 2019-09-16 19:24 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 .../initscripts/initscripts-1.0/{arm => }/alignment.sh           | 0
 meta/recipes-core/initscripts/initscripts_1.0.bb                 | 1 +
 2 files changed, 1 insertion(+)
 rename meta/recipes-core/initscripts/initscripts-1.0/{arm => }/alignment.sh (100%)

diff --git a/meta/recipes-core/initscripts/initscripts-1.0/arm/alignment.sh b/meta/recipes-core/initscripts/initscripts-1.0/alignment.sh
similarity index 100%
rename from meta/recipes-core/initscripts/initscripts-1.0/arm/alignment.sh
rename to meta/recipes-core/initscripts/initscripts-1.0/alignment.sh
diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
index 91eea4b8c2..1a59b82fbf 100644
--- a/meta/recipes-core/initscripts/initscripts_1.0.bb
+++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
@@ -40,6 +40,7 @@ SRC_URI = "file://functions \
 S = "${WORKDIR}"
 
 SRC_URI_append_arm = " file://alignment.sh"
+SRC_URI_append_armeb = " file://alignment.sh"
 
 KERNEL_VERSION = ""
 
-- 
2.23.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 8/8] libunwind: apply configure over-ride to both big and little endian ARM
  2019-09-16 19:24 [PATCH 1/8] base-files: drop legacy empty file /etc/default/usbd Andre McCurdy
                   ` (5 preceding siblings ...)
  2019-09-16 19:24 ` [PATCH 7/8] initscripts: enable alignment.sh init script for " Andre McCurdy
@ 2019-09-16 19:24 ` Andre McCurdy
  6 siblings, 0 replies; 13+ messages in thread
From: Andre McCurdy @ 2019-09-16 19:24 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/recipes-support/libunwind/libunwind.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-support/libunwind/libunwind.inc b/meta/recipes-support/libunwind/libunwind.inc
index 5726589661..76a1bf6246 100644
--- a/meta/recipes-support/libunwind/libunwind.inc
+++ b/meta/recipes-support/libunwind/libunwind.inc
@@ -12,6 +12,7 @@ PACKAGECONFIG[lzma] = "--enable-minidebuginfo,--disable-minidebuginfo,xz"
 PACKAGECONFIG[latexdocs] = "--enable-documentation, --disable-documentation, latex2man-native"
 
 EXTRA_OECONF_arm = "--enable-debug-frame"
+EXTRA_OECONF_armeb = "--enable-debug-frame"
 EXTRA_OECONF_aarch64 = "--enable-debug-frame"
 
 do_install_append () {
-- 
2.23.0



^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon
  2019-09-16 19:24 ` [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon Andre McCurdy
@ 2019-09-16 21:33   ` Christopher Larson
  2019-09-16 22:08     ` Andre McCurdy
  0 siblings, 1 reply; 13+ messages in thread
From: Christopher Larson @ 2019-09-16 21:33 UTC (permalink / raw)
  To: openembedded-core, Andre McCurdy

[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]

This seems like something that could do with a ‘why’ in the commit message and/or comments, to me.
On Sep 16, 2019, 12:25 PM -0700, Andre McCurdy <armccurdy@gmail.com>, wrote:
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
> meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
> index 307e37e3fe..c4261248b6 100644
> --- a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
> +++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
> @@ -114,10 +114,19 @@ EXTRA_OECONF = " \
> --pkg-config=pkg-config \
> "
>
> +# Do not trust configure to determine if ARM vfp or neon are available.
> +#
> +EXTRA_OECONF_ARM = " \
> + ${@bb.utils.contains('TUNE_FEATURES','vfp','--enable-vfp','--disable-vfp', d)} \
> + ${@bb.utils.contains("TUNE_FEATURES",'neon','--enable-neon','--disable-neon',d)} \
> +"
> +EXTRA_OECONF_append_arm = " ${EXTRA_OECONF_ARM}"
> +EXTRA_OECONF_append_armeb = " ${EXTRA_OECONF_ARM}"
> +
> EXTRA_OECONF_append_linux-gnux32 = " --disable-asm"
> +
> # gold crashes on x86, another solution is to --disable-asm but thats more hacky
> # ld.gold: internal error in relocate_section, at ../../gold/i386.cc:3684
> -
> LDFLAGS_append_x86 = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
>
> do_configure() {
> --
> 2.23.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[-- Attachment #2: Type: text/html, Size: 2194 bytes --]

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon
  2019-09-16 21:33   ` Christopher Larson
@ 2019-09-16 22:08     ` Andre McCurdy
  2019-09-16 22:34       ` Adrian Bunk
  0 siblings, 1 reply; 13+ messages in thread
From: Andre McCurdy @ 2019-09-16 22:08 UTC (permalink / raw)
  To: Christopher Larson; +Cc: OE Core mailing list

On Mon, Sep 16, 2019 at 2:33 PM Christopher Larson <kergoth@gmail.com> wrote:
>
> This seems like something that could do with a ‘why’ in the commit message and/or comments, to me.

To be consistent with:

  https://git.openembedded.org/openembedded-core/commit/?id=1a563214caf6bd5b3a026ebe953f8c692ebd640a

> On Sep 16, 2019, 12:25 PM -0700, Andre McCurdy <armccurdy@gmail.com>, wrote:
>
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
> meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
> index 307e37e3fe..c4261248b6 100644
> --- a/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
> +++ b/meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.bb
> @@ -114,10 +114,19 @@ EXTRA_OECONF = " \
> --pkg-config=pkg-config \
> "
>
> +# Do not trust configure to determine if ARM vfp or neon are available.
> +#
> +EXTRA_OECONF_ARM = " \
> + ${@bb.utils.contains('TUNE_FEATURES','vfp','--enable-vfp','--disable-vfp', d)} \
> + ${@bb.utils.contains("TUNE_FEATURES",'neon','--enable-neon','--disable-neon',d)} \
> +"
> +EXTRA_OECONF_append_arm = " ${EXTRA_OECONF_ARM}"
> +EXTRA_OECONF_append_armeb = " ${EXTRA_OECONF_ARM}"
> +
> EXTRA_OECONF_append_linux-gnux32 = " --disable-asm"
> +
> # gold crashes on x86, another solution is to --disable-asm but thats more hacky
> # ld.gold: internal error in relocate_section, at ../../gold/i386.cc:3684
> -
> LDFLAGS_append_x86 = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
>
> do_configure() {
> --
> 2.23.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon
  2019-09-16 22:08     ` Andre McCurdy
@ 2019-09-16 22:34       ` Adrian Bunk
  2019-09-16 22:43         ` Andre McCurdy
  0 siblings, 1 reply; 13+ messages in thread
From: Adrian Bunk @ 2019-09-16 22:34 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list

On Mon, Sep 16, 2019 at 03:08:01PM -0700, Andre McCurdy wrote:
> On Mon, Sep 16, 2019 at 2:33 PM Christopher Larson <kergoth@gmail.com> wrote:
> >
> > This seems like something that could do with a ‘why’ in the commit message and/or comments, to me.
> 
> To be consistent with:
> 
>   https://git.openembedded.org/openembedded-core/commit/?id=1a563214caf6bd5b3a026ebe953f8c692ebd640a
>...

libwebp sets -mfpu=neon when autodetecting,
is there a similar problem with ffmpeg?

> > +# Do not trust configure to determine if ARM vfp or neon are available.
> > +#
> > +EXTRA_OECONF_ARM = " \
> > + ${@bb.utils.contains('TUNE_FEATURES','vfp','--enable-vfp','--disable-vfp', d)} \
> > + ${@bb.utils.contains("TUNE_FEATURES",'neon','--enable-neon','--disable-neon',d)} \
>...

If we cannot trust the vfp autodetection, why can we trust that the 
autodetection of the vfp variant (vfpv2, vfpv3 or vfpv3-d16) and
the exact architecture (e.g. armv5te, armv6, armv6k or armv6t2)
are correct?

Which brings us back to the problem what the actual problem is (if any).

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon
  2019-09-16 22:34       ` Adrian Bunk
@ 2019-09-16 22:43         ` Andre McCurdy
  2019-09-17  8:16           ` Adrian Bunk
  0 siblings, 1 reply; 13+ messages in thread
From: Andre McCurdy @ 2019-09-16 22:43 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: OE Core mailing list

On Mon, Sep 16, 2019 at 3:34 PM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Mon, Sep 16, 2019 at 03:08:01PM -0700, Andre McCurdy wrote:
> > On Mon, Sep 16, 2019 at 2:33 PM Christopher Larson <kergoth@gmail.com> wrote:
> > >
> > > This seems like something that could do with a ‘why’ in the commit message and/or comments, to me.
> >
> > To be consistent with:
> >
> >   https://git.openembedded.org/openembedded-core/commit/?id=1a563214caf6bd5b3a026ebe953f8c692ebd640a
> >...
>
> libwebp sets -mfpu=neon when autodetecting,
> is there a similar problem with ffmpeg?
>
> > > +# Do not trust configure to determine if ARM vfp or neon are available.
> > > +#
> > > +EXTRA_OECONF_ARM = " \
> > > + ${@bb.utils.contains('TUNE_FEATURES','vfp','--enable-vfp','--disable-vfp', d)} \
> > > + ${@bb.utils.contains("TUNE_FEATURES",'neon','--enable-neon','--disable-neon',d)} \
> >...
>
> If we cannot trust the vfp autodetection, why can we trust that the
> autodetection of the vfp variant (vfpv2, vfpv3 or vfpv3-d16) and
> the exact architecture (e.g. armv5te, armv6, armv6k or armv6t2)
> are correct?

In general we can't. However these are all corner cases which are
rarely (if ever) tested.

For ffmpeg configuring with --enable-runtime-cpudetect (which I think
we effectively do by default) probably hides a lot of the configure
time misdetection too.

> Which brings us back to the problem what the actual problem is (if any).

I built for target without VFP or NEON and saw both as being enabled
according to the configure log. Didn't investigate further than that.

> cu
> Adrian
>
> --
>
>        "Is there not promise of rain?" Ling Tan asked suddenly out
>         of the darkness. There had been need of rain for many days.
>        "Only a promise," Lao Er said.
>                                        Pearl S. Buck - Dragon Seed
>


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon
  2019-09-16 22:43         ` Andre McCurdy
@ 2019-09-17  8:16           ` Adrian Bunk
  0 siblings, 0 replies; 13+ messages in thread
From: Adrian Bunk @ 2019-09-17  8:16 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list

On Mon, Sep 16, 2019 at 03:43:42PM -0700, Andre McCurdy wrote:
> On Mon, Sep 16, 2019 at 3:34 PM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > On Mon, Sep 16, 2019 at 03:08:01PM -0700, Andre McCurdy wrote:
> > > On Mon, Sep 16, 2019 at 2:33 PM Christopher Larson <kergoth@gmail.com> wrote:
> > > >
> > > > This seems like something that could do with a ‘why’ in the commit message and/or comments, to me.
> > >
> > > To be consistent with:
> > >
> > >   https://git.openembedded.org/openembedded-core/commit/?id=1a563214caf6bd5b3a026ebe953f8c692ebd640a
> > >...
> >
> > libwebp sets -mfpu=neon when autodetecting,
> > is there a similar problem with ffmpeg?
> >
> > > > +# Do not trust configure to determine if ARM vfp or neon are available.
> > > > +#
> > > > +EXTRA_OECONF_ARM = " \
> > > > + ${@bb.utils.contains('TUNE_FEATURES','vfp','--enable-vfp','--disable-vfp', d)} \
> > > > + ${@bb.utils.contains("TUNE_FEATURES",'neon','--enable-neon','--disable-neon',d)} \
> > >...
> >
> > If we cannot trust the vfp autodetection, why can we trust that the
> > autodetection of the vfp variant (vfpv2, vfpv3 or vfpv3-d16) and
> > the exact architecture (e.g. armv5te, armv6, armv6k or armv6t2)
> > are correct?
> 
> In general we can't. However these are all corner cases which are
> rarely (if ever) tested.
> 
> For ffmpeg configuring with --enable-runtime-cpudetect (which I think
> we effectively do by default) probably hides a lot of the configure
> time misdetection too.
>...

Building with --disable-runtime-cpudetect for qemuarmv5 gives:

ARCH                      arm (armv5te)
big-endian                no
runtime cpu detection     no
ARMv5TE enabled           yes
ARMv6 enabled             yes
ARMv6T2 enabled           yes
VFP enabled               yes
NEON enabled              yes


These 4 misdetections are all affecting a certain range of CPUs,
ARMv6T2 misdetection should affect more CPUs than VFP misdetection.

There likely is a common root cause that should be fixed,
instead of manually specifying every autodetected feature.


cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2019-09-17  8:16 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-16 19:24 [PATCH 1/8] base-files: drop legacy empty file /etc/default/usbd Andre McCurdy
2019-09-16 19:24 ` [PATCH 2/8] busybox: rcS and rcK should not be writeable by everyone Andre McCurdy
2019-09-16 19:24 ` [PATCH 3/8] ffmpeg: add PACKAGECONFIG controls for alsa and zlib (enable by default) Andre McCurdy
2019-09-16 19:24 ` [PATCH 4/8] ffmpeg: don't rely on configure to correctly detect ARM vfp or neon Andre McCurdy
2019-09-16 21:33   ` Christopher Larson
2019-09-16 22:08     ` Andre McCurdy
2019-09-16 22:34       ` Adrian Bunk
2019-09-16 22:43         ` Andre McCurdy
2019-09-17  8:16           ` Adrian Bunk
2019-09-16 19:24 ` [PATCH 5/8] ffmpeg: enable more verbose build logs Andre McCurdy
2019-09-16 19:24 ` [PATCH 6/8] libwebp: apply ARM specific config options to big endian ARM Andre McCurdy
2019-09-16 19:24 ` [PATCH 7/8] initscripts: enable alignment.sh init script for " Andre McCurdy
2019-09-16 19:24 ` [PATCH 8/8] libunwind: apply configure over-ride to both big and little " Andre McCurdy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox