[PATCH 1/1] bash-completion: add image feature

[PATCH 1/1] bash-completion: add image feature

[Joe Slater]

Create bc-pkgs image feature to load *-bash-completion packages
into an image.  The packages are created by the bash-completion
bbclass but are currently never referenced.

Signed-off-by: Joe Slater <joe.slater@windriver.com>
---
 meta/classes/core-image.bbclass        | 1 +
 meta/classes/populate_sdk_base.bbclass | 1 +
 2 files changed, 2 insertions(+)

diff --git a/meta/classes/core-image.bbclass b/meta/classes/core-image.bbclass
index a9a2cec..2805695 100644
--- a/meta/classes/core-image.bbclass
+++ b/meta/classes/core-image.bbclass
@@ -30,6 +30,7 @@
 # - dev-pkgs            - development packages (headers, etc.) for all installed packages in the rootfs
 # - dbg-pkgs            - debug symbol packages for all installed packages in the rootfs
 # - doc-pkgs            - documentation packages for all installed packages in the rootfs
+# - bc-pkgs             - bash-completion packages for relevant packages in the rootfs
 # - ptest-pkgs          - ptest packages for all ptest-enabled recipes
 # - read-only-rootfs    - tweaks an image to support read-only rootfs
 # - splash              - bootup splash screen
diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
index 9a3a2b4..bf8d7db 100644
--- a/meta/classes/populate_sdk_base.bbclass
+++ b/meta/classes/populate_sdk_base.bbclass
@@ -8,6 +8,7 @@ COMPLEMENTARY_GLOB[doc-pkgs] = '*-doc'
 COMPLEMENTARY_GLOB[dbg-pkgs] = '*-dbg'
 COMPLEMENTARY_GLOB[src-pkgs] = '*-src'
 COMPLEMENTARY_GLOB[ptest-pkgs] = '*-ptest'
+COMPLEMENTARY_GLOB[bc-pkgs] = '*-bash-completion'
 
 def complementary_globs(featurevar, d):
     all_globs = d.getVarFlags('COMPLEMENTARY_GLOB')
-- 
2.7.4

Re: [PATCH 1/1] bash-completion: add image feature

[Adrian Bunk]

On Fri, Sep 27, 2019 at 11:16:51AM -0700, Joe Slater wrote:
> Create bc-pkgs image feature to load *-bash-completion packages
> into an image.  The packages are created by the bash-completion
> bbclass but are currently never referenced.
>...
> +COMPLEMENTARY_GLOB[bc-pkgs] = '*-bash-completion'
>...

What about naming it bash-completion-pkgs?

This is not related to meta/recipes-extended/bc,
and descriptive names are easier to understand.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed