Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] devtool: nlohmann-fifo
@ 2019-10-14 15:15 Aatir
  2019-10-16  1:07 ` Khem Raj
  0 siblings, 1 reply; 4+ messages in thread
From: Aatir @ 2019-10-14 15:15 UTC (permalink / raw)
  To: openembedded-core

From: Tekkub <aatrapps@gmail.com>

Adding the nlohmann-fifo, c++ library for fifo maps.

Signed-off-by: Aatir <aatrapps@gmail.com>
---
 .../nlohmann-fifo/nlohmann-fifo_git.bb        | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb

diff --git a/meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb b/meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb
new file mode 100644
index 000000000..afab2eac4
--- /dev/null
+++ b/meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb
@@ -0,0 +1,22 @@
+SUMMARY = "fifo maps for c++"
+HOMEPAGE = "/"
+SECTION = "libs"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://LICENSE.MIT;md5=b67209a1e36b682a8226de19d265b1e0"
+
+SRC_URI = "git://github.com/nlohmann/fifo_map.git"
+
+PV = "1.0.0+git${SRCPV}"
+
+SRCREV = "0dfbf5dacbb15a32c43f912a7e66a54aae39d0f9"
+
+S = "${WORKDIR}/git"
+
+RDEPENDS_${PN}-dev = ""
+
+BBCLASSEXTEND = "native nativesdk"
+
+do_install() {
+    install -d ${D}${includedir}
+    install -m 0644 ${S}/src/fifo_map.hpp ${D}${includedir}/fifo_map.hpp
+}
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] devtool: nlohmann-fifo
@ 2019-10-15 13:05 Aatir
  2019-10-15 16:22 ` Peter Kjellerstedt
  0 siblings, 1 reply; 4+ messages in thread
From: Aatir @ 2019-10-15 13:05 UTC (permalink / raw)
  To: openembedded-core

From: Tekkub <aatrapps@gmail.com>

Adding nlohmann-fifo, a c++ header library for fifo maps.

Signed-off-by: Aatir <aatrapps@gmail.com>

 Author:    Aatir <aatrapps@gmail.com>
---
 .../nlohmann-fifo/nlohmann-fifo_git.bb        | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb

diff --git a/meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb b/meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb
new file mode 100644
index 000000000..afab2eac4
--- /dev/null
+++ b/meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb
@@ -0,0 +1,22 @@
+SUMMARY = "fifo maps for c++"
+HOMEPAGE = "/"
+SECTION = "libs"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://LICENSE.MIT;md5=b67209a1e36b682a8226de19d265b1e0"
+
+SRC_URI = "git://github.com/nlohmann/fifo_map.git"
+
+PV = "1.0.0+git${SRCPV}"
+
+SRCREV = "0dfbf5dacbb15a32c43f912a7e66a54aae39d0f9"
+
+S = "${WORKDIR}/git"
+
+RDEPENDS_${PN}-dev = ""
+
+BBCLASSEXTEND = "native nativesdk"
+
+do_install() {
+    install -d ${D}${includedir}
+    install -m 0644 ${S}/src/fifo_map.hpp ${D}${includedir}/fifo_map.hpp
+}
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] devtool: nlohmann-fifo
  2019-10-15 13:05 Aatir
@ 2019-10-15 16:22 ` Peter Kjellerstedt
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Kjellerstedt @ 2019-10-15 16:22 UTC (permalink / raw)
  To: Aatir, openembedded-core@lists.openembedded.org

This was sent to the wrong mailing list. Please send it to 
openembedded-devel@lists.openembedded.org instead (no idea why 
patchwork is not complaining). 

See further comments below.

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org <openembedded-
> core-bounces@lists.openembedded.org> On Behalf Of Aatir
> Sent: den 15 oktober 2019 15:06
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH] devtool: nlohmann-fifo

Change the subject to something like this instead:

nlohmann-fifo: Add recipe

> 
> From: Tekkub <aatrapps@gmail.com>
> 
> Adding nlohmann-fifo, a c++ header library for fifo maps.
> 
> Signed-off-by: Aatir <aatrapps@gmail.com>
> 
>  Author:    Aatir <aatrapps@gmail.com>

Remove the Author footer.

> ---
>  .../nlohmann-fifo/nlohmann-fifo_git.bb        | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb
> 
> diff --git a/meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb b/meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb
> new file mode 100644
> index 000000000..afab2eac4
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb
> @@ -0,0 +1,22 @@
> +SUMMARY = "fifo maps for c++"
> +HOMEPAGE = "/"

Change to:

HOMEPAGE = "https://github.com/nlohmann/fifo_map"

> +SECTION = "libs"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://LICENSE.MIT;md5=b67209a1e36b682a8226de19d265b1e0"
> +
> +SRC_URI = "git://github.com/nlohmann/fifo_map.git"
> +
> +PV = "1.0.0+git${SRCPV}"
> +
> +SRCREV = "0dfbf5dacbb15a32c43f912a7e66a54aae39d0f9"
> +
> +S = "${WORKDIR}/git"
> +
> +RDEPENDS_${PN}-dev = ""
> +
> +BBCLASSEXTEND = "native nativesdk"
> +
> +do_install() {
> +    install -d ${D}${includedir}
> +    install -m 0644 ${S}/src/fifo_map.hpp ${D}${includedir}/fifo_map.hpp

Remove "/fifo_map.hpp" at the end since the target file name matches 
the source file name.

> +}
> --
> 2.17.1

//Peter



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] devtool: nlohmann-fifo
  2019-10-14 15:15 [PATCH] devtool: nlohmann-fifo Aatir
@ 2019-10-16  1:07 ` Khem Raj
  0 siblings, 0 replies; 4+ messages in thread
From: Khem Raj @ 2019-10-16  1:07 UTC (permalink / raw)
  To: Aatir; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1661 bytes --]

On Mon, Oct 14, 2019 at 8:46 PM Aatir <aatrapps@gmail.com> wrote:

> From: Tekkub <aatrapps@gmail.com>
>
> Adding the nlohmann-fifo, c++ library for fifo maps.
>
> Signed-off-by: Aatir <aatrapps@gmail.com>
> ---
>  .../nlohmann-fifo/nlohmann-fifo_git.bb        | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 meta-oe/recipes-devtools/nlohmann-fifo/
> nlohmann-fifo_git.bb
>
> diff --git a/meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb
> b/meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb
> new file mode 100644
> index 000000000..afab2eac4
> --- /dev/null
> +++ b/meta-oe/recipes-devtools/nlohmann-fifo/nlohmann-fifo_git.bb
> @@ -0,0 +1,22 @@
> +SUMMARY = "fifo maps for c++"
> +HOMEPAGE = "/"


This needs to point to a valid url

>
> +SECTION = "libs"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM =
> "file://LICENSE.MIT;md5=b67209a1e36b682a8226de19d265b1e0"
> +
> +SRC_URI = "git://github.com/nlohmann/fifo_map.git"
> +
> +PV = "1.0.0+git${SRCPV}"
> +
> +SRCREV = "0dfbf5dacbb15a32c43f912a7e66a54aae39d0f9"
> +
> +S = "${WORKDIR}/git"
> +
> +RDEPENDS_${PN}-dev = ""


Why is this needed ?


> +
> +BBCLASSEXTEND = "native nativesdk"
> +
> +do_install() {
> +    install -d ${D}${includedir}


Delete this line


> +    install -m 0644 ${S}/src/fifo_map.hpp ${D}${includedir}/fifo_map.hpp


Use install -D -m

>
> +}
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3575 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-16  1:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-14 15:15 [PATCH] devtool: nlohmann-fifo Aatir
2019-10-16  1:07 ` Khem Raj
  -- strict thread matches above, loose matches on Subject: below --
2019-10-15 13:05 Aatir
2019-10-15 16:22 ` Peter Kjellerstedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox