* [PATCH] alsa-lib:upgrade 1.1.9 -> 1.2.1.1
@ 2019-11-20 5:17 Zang Ruochen
2019-11-20 5:32 ` ✗ patchtest: failure for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Zang Ruochen @ 2019-11-20 5:17 UTC (permalink / raw)
To: openembedded-core
The following error occurred during the steps of do-configure:
| Fixing libtool for -rpath problems.
| ../alsa-lib-1.2.1.1/configure: line 16567: libtool: No such file or directory
| mv: cannot stat 'libtool-2': No such file or directory
| chmod: cannot access 'libtool': No such file or directory
add alsa-lib/0001-Fix-problem-with-libtool-not-found.patch to fix it.
Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com>
---
...1-Fix-problem-with-libtool-not-found.patch | 31 +++++++++++++++++++
...{alsa-lib_1.1.9.bb => alsa-lib_1.2.1.1.bb} | 8 +++--
2 files changed, 36 insertions(+), 3 deletions(-)
create mode 100644 meta/recipes-multimedia/alsa/alsa-lib/0001-Fix-problem-with-libtool-not-found.patch
rename meta/recipes-multimedia/alsa/{alsa-lib_1.1.9.bb => alsa-lib_1.2.1.1.bb} (83%)
diff --git a/meta/recipes-multimedia/alsa/alsa-lib/0001-Fix-problem-with-libtool-not-found.patch b/meta/recipes-multimedia/alsa/alsa-lib/0001-Fix-problem-with-libtool-not-found.patch
new file mode 100644
index 0000000000..5fb84cd6f8
--- /dev/null
+++ b/meta/recipes-multimedia/alsa/alsa-lib/0001-Fix-problem-with-libtool-not-found.patch
@@ -0,0 +1,31 @@
+From f419276a716daf8d98846b3df50995e5ac030134 Mon Sep 17 00:00:00 2001
+From: Zang Ruochen <zangrc.fnst@cn.fujitsu.com>
+Date: Wed, 20 Nov 2019 11:24:17 +0800
+Subject: [PATCH] Fix problem with libtool not found
+
+Upstream-Status: Inappropriate
+Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com>
+---
+ configure.ac | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 35eb315..548b9ea 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -769,9 +769,9 @@ dnl Taken from https://wiki.debian.org/RpathIssue
+ case $host in
+ *-*-linux-gnu)
+ AC_MSG_RESULT([Fixing libtool for -rpath problems.])
+- sed < libtool > libtool-2 \
++ sed < "$srcdir"/libtool > "$srcdir"/libtool-2 \
+ 's/^hardcode_libdir_flag_spec.*$'/'hardcode_libdir_flag_spec=" -D__LIBTOOL_IS_A_FOOL__ "/'
+- mv libtool-2 libtool
+- chmod 755 libtool
++ mv "$srcdir"/libtool-2 "$srcdir"/libtool
++ chmod 755 "$srcdir"/libtool
+ ;;
+ esac
+--
+2.20.1
+
diff --git a/meta/recipes-multimedia/alsa/alsa-lib_1.1.9.bb b/meta/recipes-multimedia/alsa/alsa-lib_1.2.1.1.bb
similarity index 83%
rename from meta/recipes-multimedia/alsa/alsa-lib_1.1.9.bb
rename to meta/recipes-multimedia/alsa/alsa-lib_1.2.1.1.bb
index 2c63ee7522..56544b0d45 100644
--- a/meta/recipes-multimedia/alsa/alsa-lib_1.1.9.bb
+++ b/meta/recipes-multimedia/alsa/alsa-lib_1.2.1.1.bb
@@ -7,9 +7,11 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a916467b91076e631dd8edb7424769c7 \
file://src/socket.c;md5=dd1bc7f44872690224d89c1a9806e495;beginline=1;endline=26 \
"
-SRC_URI = "https://www.alsa-project.org/files/pub/lib/${BP}.tar.bz2"
-SRC_URI[md5sum] = "e6d429dbdcfaa0f034d907fa6dc3735e"
-SRC_URI[sha256sum] = "488373aef5396682f3a411a6d064ae0ad196b9c96269d0bb912fbdeec94b994b"
+SRC_URI = "https://www.alsa-project.org/files/pub/lib/${BP}.tar.bz2 \
+ file://0001-Fix-problem-with-libtool-not-found.patch \
+ "
+SRC_URI[md5sum] = "1d428f46d6160f5e4bbdd64a2ff34f45"
+SRC_URI[sha256sum] = "c95ac63c0aad43a6ac457d960569096b0b2ef72dc4e3737e77e3e2de87022cec"
inherit autotools pkgconfig
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* ✗ patchtest: failure for alsa-lib:upgrade 1.1.9 -> 1.2.1.1 2019-11-20 5:17 [PATCH] alsa-lib:upgrade 1.1.9 -> 1.2.1.1 Zang Ruochen @ 2019-11-20 5:32 ` Patchwork 2019-11-20 11:16 ` [PATCH] " Alexander Kanavin 2019-11-20 11:55 ` Mittal, Anuj 2 siblings, 0 replies; 8+ messages in thread From: Patchwork @ 2019-11-20 5:32 UTC (permalink / raw) To: Zang Ruochen; +Cc: openembedded-core == Series Details == Series: alsa-lib:upgrade 1.1.9 -> 1.2.1.1 Revision: 1 URL : https://patchwork.openembedded.org/series/21229/ State : failure == Summary == Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures: * Issue Upstream-Status is Inappropriate, but no reason was provided [test_upstream_status_presence_format] Suggested fix Include a brief reason why 0001-Fix-problem-with-libtool-not-found.patch is inappropriate Current Upstream-Status: Inappropriate Standard format Upstream-Status: Inappropriate [reason] If you believe any of these test results are incorrect, please reply to the mailing list (openembedded-core@lists.openembedded.org) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...). --- Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] alsa-lib:upgrade 1.1.9 -> 1.2.1.1 2019-11-20 5:17 [PATCH] alsa-lib:upgrade 1.1.9 -> 1.2.1.1 Zang Ruochen 2019-11-20 5:32 ` ✗ patchtest: failure for " Patchwork @ 2019-11-20 11:16 ` Alexander Kanavin 2019-12-04 21:18 ` Tanu Kaskinen 2019-11-20 11:55 ` Mittal, Anuj 2 siblings, 1 reply; 8+ messages in thread From: Alexander Kanavin @ 2019-11-20 11:16 UTC (permalink / raw) To: Zang Ruochen; +Cc: OE-core [-- Attachment #1: Type: text/plain, Size: 453 bytes --] On Wed, 20 Nov 2019 at 06:17, Zang Ruochen <zangrc.fnst@cn.fujitsu.com> wrote: > +From f419276a716daf8d98846b3df50995e5ac030134 Mon Sep 17 00:00:00 2001 > +From: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> > +Date: Wed, 20 Nov 2019 11:24:17 +0800 > +Subject: [PATCH] Fix problem with libtool not found > + > +Upstream-Status: Inappropriate > Why inappropriate? To me this seems like a real problem and should be submitted upstream. Alex [-- Attachment #2: Type: text/html, Size: 839 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] alsa-lib:upgrade 1.1.9 -> 1.2.1.1 2019-11-20 11:16 ` [PATCH] " Alexander Kanavin @ 2019-12-04 21:18 ` Tanu Kaskinen 2019-12-04 21:45 ` Ross Burton 0 siblings, 1 reply; 8+ messages in thread From: Tanu Kaskinen @ 2019-12-04 21:18 UTC (permalink / raw) To: Alexander Kanavin, Zang Ruochen; +Cc: OE-core On Wed, 2019-11-20 at 12:16 +0100, Alexander Kanavin wrote: > On Wed, 20 Nov 2019 at 06:17, Zang Ruochen <zangrc.fnst@cn.fujitsu.com> > wrote: > > > +From f419276a716daf8d98846b3df50995e5ac030134 Mon Sep 17 00:00:00 2001 > > +From: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> > > +Date: Wed, 20 Nov 2019 11:24:17 +0800 > > +Subject: [PATCH] Fix problem with libtool not found > > + > > +Upstream-Status: Inappropriate > > > > Why inappropriate? To me this seems like a real problem and should be > submitted upstream. I planned to submit this patch to upstream on behalf of Zang, but while investigating what the root cause for the failure really is, I found that this really is OE specific. Upstream for some reason (not documented in the commit message, and the main point of the commit was something else entirely[1]) added this to the end of configure.ac: dnl Taken from https://wiki.debian.org/RpathIssue case $host in *-*-linux-gnu) AC_MSG_RESULT([Fixing libtool for -rpath problems.]) sed < libtool > libtool-2 \ 's/^hardcode_libdir_flag_spec.*$'/'hardcode_libdir_flag_spec=" -D__LIBTOOL_IS_A_FOOL__ "/' mv libtool-2 libtool chmod 755 libtool ;; esac If I understand the referenced Debian wiki page correctly, this is only useful if the tarball ships libtool older than 1.5.2 (released 2004-01- 05). That is, this addition seems completely useless to me. Probably I'm missing something. The configure script fails, because it tries to modify the libtool script in the build directory, but the libtool script doesn't exist. And it doesn't exist, because OE renames it to ${host_alias}-libtool (e.g. x86_64-oe-linux-libtool). I'm not sure where the libtool script in the build directory comes from. Is it copied from the tarball's libtool script, or does it come from the libtool package? (Bitbake seems to run autoreconf and libtoolize, if that's relevant.) If the script comes from the libtool package, then modifying the script in the source directory (like Zang's patch does) is useless, since that script isn't used at all. If the tarball's libtool script is used, then Zang's patch still doesn't do what it's expected to do, because the script modification is the very last thing the configure script does, and the build directory's libtool script has already been created by then, so modifying the source directory's libtool script happens too late. I'll have to ask upstream if the strange configure.ac addition could be just removed. If it for some reason won't be removed, then an OE specific patch is needed. Either configure.ac needs to be modified to operate on ${host_alias}-libtool, or I can simply remove the libtool modification part, because OE hasn't needed that in the past, and I can't see how it would be needed now. [1] https://git.alsa-project.org/?p=alsa-lib.git;a=commitdiff;h=75d393a563efb578c79364a277087c6326267f52;hp=1f37ba2a2b1c07c04de1c368cd4943f712cccfa5 -- Tanu https://www.patreon.com/tanuk https://liberapay.com/tanuk ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] alsa-lib:upgrade 1.1.9 -> 1.2.1.1 2019-12-04 21:18 ` Tanu Kaskinen @ 2019-12-04 21:45 ` Ross Burton 0 siblings, 0 replies; 8+ messages in thread From: Ross Burton @ 2019-12-04 21:45 UTC (permalink / raw) To: openembedded-core On 04/12/2019 21:18, Tanu Kaskinen wrote: > I'll have to ask upstream if the strange configure.ac addition could be > just removed. If it for some reason won't be removed, then an OE > specific patch is needed. Either configure.ac needs to be modified to > operate on ${host_alias}-libtool, or I can simply remove the libtool > modification part, because OE hasn't needed that in the past, and I > can't see how it would be needed now. My understanding is that the used libtool is dropped into the build tree by libtoolize, and we've patched libtool to prefix the binary. So if the chunk at the end of configure.ac is kept, then the patch needs to alter the correct file. However that chunk in the configure.ac definitely looks like something the author added locally as a test, and forgot to remove when committing... An important line from that wiki page: """ Since libtool 1.5.2 (released 2004-01-25), on Linux libtool no longer sets RPATH for any directories in the dynamic linker search path, so this should no longer be an issue unless upstream used a really old version of libtool when creating their distribution tarball. """ So I'm not sure why this chunk was added at all. Ross ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] alsa-lib:upgrade 1.1.9 -> 1.2.1.1 2019-11-20 5:17 [PATCH] alsa-lib:upgrade 1.1.9 -> 1.2.1.1 Zang Ruochen 2019-11-20 5:32 ` ✗ patchtest: failure for " Patchwork 2019-11-20 11:16 ` [PATCH] " Alexander Kanavin @ 2019-11-20 11:55 ` Mittal, Anuj 2019-11-20 12:10 ` Alexander Kanavin 2 siblings, 1 reply; 8+ messages in thread From: Mittal, Anuj @ 2019-11-20 11:55 UTC (permalink / raw) To: openembedded-core@lists.openembedded.org, zangrc.fnst@cn.fujitsu.com This version has moved ucm and topology conf files to separate repositories. We should also probably fetch and package those. https://github.com/alsa-project/alsa-lib/commit/1f37ba2a2b1c07c04de1c368cd4943f712cccfa5 https://github.com/alsa-project/alsa-lib/commit/cdc8aacbb57c82a81e3b398f2ede6440d49334a5 Thanks, Anuj On Wed, 2019-11-20 at 13:17 +0800, Zang Ruochen wrote: > The following error occurred during the steps of do-configure: > > Fixing libtool for -rpath problems. > > ../alsa-lib-1.2.1.1/configure: line 16567: libtool: No such file or > > directory > > mv: cannot stat 'libtool-2': No such file or directory > > chmod: cannot access 'libtool': No such file or directory > > add alsa-lib/0001-Fix-problem-with-libtool-not-found.patch to fix it. > > Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> > --- > ...1-Fix-problem-with-libtool-not-found.patch | 31 > +++++++++++++++++++ > ...{alsa-lib_1.1.9.bb => alsa-lib_1.2.1.1.bb} | 8 +++-- > 2 files changed, 36 insertions(+), 3 deletions(-) > create mode 100644 meta/recipes-multimedia/alsa/alsa-lib/0001-Fix- > problem-with-libtool-not-found.patch > rename meta/recipes-multimedia/alsa/{alsa-lib_1.1.9.bb => alsa- > lib_1.2.1.1.bb} (83%) > > diff --git a/meta/recipes-multimedia/alsa/alsa-lib/0001-Fix-problem- > with-libtool-not-found.patch b/meta/recipes-multimedia/alsa/alsa- > lib/0001-Fix-problem-with-libtool-not-found.patch > new file mode 100644 > index 0000000000..5fb84cd6f8 > --- /dev/null > +++ b/meta/recipes-multimedia/alsa/alsa-lib/0001-Fix-problem-with- > libtool-not-found.patch > @@ -0,0 +1,31 @@ > +From f419276a716daf8d98846b3df50995e5ac030134 Mon Sep 17 00:00:00 > 2001 > +From: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> > +Date: Wed, 20 Nov 2019 11:24:17 +0800 > +Subject: [PATCH] Fix problem with libtool not found > + > +Upstream-Status: Inappropriate > +Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> > +--- > + configure.ac | 6 +++--- > + 1 file changed, 3 insertions(+), 3 deletions(-) > + > +diff --git a/configure.ac b/configure.ac > +index 35eb315..548b9ea 100644 > +--- a/configure.ac > ++++ b/configure.ac > +@@ -769,9 +769,9 @@ dnl Taken from > https://wiki.debian.org/RpathIssue > + case $host in > + *-*-linux-gnu) > + AC_MSG_RESULT([Fixing libtool for -rpath problems.]) > +- sed < libtool > libtool-2 \ > ++ sed < "$srcdir"/libtool > "$srcdir"/libtool-2 \ > + 's/^hardcode_libdir_flag_spec.*$'/'hardcode_libdir_flag_spec=" > -D__LIBTOOL_IS_A_FOOL__ "/' > +- mv libtool-2 libtool > +- chmod 755 libtool > ++ mv "$srcdir"/libtool-2 "$srcdir"/libtool > ++ chmod 755 "$srcdir"/libtool > + ;; > + esac > +-- > +2.20.1 > + > diff --git a/meta/recipes-multimedia/alsa/alsa-lib_1.1.9.bb > b/meta/recipes-multimedia/alsa/alsa-lib_1.2.1.1.bb > similarity index 83% > rename from meta/recipes-multimedia/alsa/alsa-lib_1.1.9.bb > rename to meta/recipes-multimedia/alsa/alsa-lib_1.2.1.1.bb > index 2c63ee7522..56544b0d45 100644 > --- a/meta/recipes-multimedia/alsa/alsa-lib_1.1.9.bb > +++ b/meta/recipes-multimedia/alsa/alsa-lib_1.2.1.1.bb > @@ -7,9 +7,11 @@ LIC_FILES_CHKSUM = " > file://COPYING;md5=a916467b91076e631dd8edb7424769c7 \ > file://src/socket.c;md5=dd1bc7f44872690224d89c1a > 9806e495;beginline=1;endline=26 \ > " > > -SRC_URI = "https://www.alsa-project.org/files/pub/lib/${BP}.tar.bz2" > -SRC_URI[md5sum] = "e6d429dbdcfaa0f034d907fa6dc3735e" > -SRC_URI[sha256sum] = > "488373aef5396682f3a411a6d064ae0ad196b9c96269d0bb912fbdeec94b994b" > +SRC_URI = "https://www.alsa-project.org/files/pub/lib/${BP}.tar.bz2 > \ > + file://0001-Fix-problem-with-libtool-not-found.patch \ > + " > +SRC_URI[md5sum] = "1d428f46d6160f5e4bbdd64a2ff34f45" > +SRC_URI[sha256sum] = > "c95ac63c0aad43a6ac457d960569096b0b2ef72dc4e3737e77e3e2de87022cec" > > inherit autotools pkgconfig > > -- > 2.20.1 > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] alsa-lib:upgrade 1.1.9 -> 1.2.1.1 2019-11-20 11:55 ` Mittal, Anuj @ 2019-11-20 12:10 ` Alexander Kanavin 2019-11-20 13:35 ` Tanu Kaskinen 0 siblings, 1 reply; 8+ messages in thread From: Alexander Kanavin @ 2019-11-20 12:10 UTC (permalink / raw) To: Mittal, Anuj, Tanu Kaskinen; +Cc: openembedded-core@lists.openembedded.org [-- Attachment #1: Type: text/plain, Size: 4567 bytes --] If Tanu is still around, he should probably chime in. Alex On Wed, 20 Nov 2019 at 12:55, Mittal, Anuj <anuj.mittal@intel.com> wrote: > This version has moved ucm and topology conf files to separate > repositories. We should also probably fetch and package those. > > > https://github.com/alsa-project/alsa-lib/commit/1f37ba2a2b1c07c04de1c368cd4943f712cccfa5 > > > https://github.com/alsa-project/alsa-lib/commit/cdc8aacbb57c82a81e3b398f2ede6440d49334a5 > > Thanks, > > Anuj > > On Wed, 2019-11-20 at 13:17 +0800, Zang Ruochen wrote: > > The following error occurred during the steps of do-configure: > > > Fixing libtool for -rpath problems. > > > ../alsa-lib-1.2.1.1/configure: line 16567: libtool: No such file or > > > directory > > > mv: cannot stat 'libtool-2': No such file or directory > > > chmod: cannot access 'libtool': No such file or directory > > > > add alsa-lib/0001-Fix-problem-with-libtool-not-found.patch to fix it. > > > > Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> > > --- > > ...1-Fix-problem-with-libtool-not-found.patch | 31 > > +++++++++++++++++++ > > ...{alsa-lib_1.1.9.bb => alsa-lib_1.2.1.1.bb} | 8 +++-- > > 2 files changed, 36 insertions(+), 3 deletions(-) > > create mode 100644 meta/recipes-multimedia/alsa/alsa-lib/0001-Fix- > > problem-with-libtool-not-found.patch > > rename meta/recipes-multimedia/alsa/{alsa-lib_1.1.9.bb => alsa- > > lib_1.2.1.1.bb} (83%) > > > > diff --git a/meta/recipes-multimedia/alsa/alsa-lib/0001-Fix-problem- > > with-libtool-not-found.patch b/meta/recipes-multimedia/alsa/alsa- > > lib/0001-Fix-problem-with-libtool-not-found.patch > > new file mode 100644 > > index 0000000000..5fb84cd6f8 > > --- /dev/null > > +++ b/meta/recipes-multimedia/alsa/alsa-lib/0001-Fix-problem-with- > > libtool-not-found.patch > > @@ -0,0 +1,31 @@ > > +From f419276a716daf8d98846b3df50995e5ac030134 Mon Sep 17 00:00:00 > > 2001 > > +From: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> > > +Date: Wed, 20 Nov 2019 11:24:17 +0800 > > +Subject: [PATCH] Fix problem with libtool not found > > + > > +Upstream-Status: Inappropriate > > +Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> > > +--- > > + configure.ac | 6 +++--- > > + 1 file changed, 3 insertions(+), 3 deletions(-) > > + > > +diff --git a/configure.ac b/configure.ac > > +index 35eb315..548b9ea 100644 > > +--- a/configure.ac > > ++++ b/configure.ac > > +@@ -769,9 +769,9 @@ dnl Taken from > > https://wiki.debian.org/RpathIssue > > + case $host in > > + *-*-linux-gnu) > > + AC_MSG_RESULT([Fixing libtool for -rpath problems.]) > > +- sed < libtool > libtool-2 \ > > ++ sed < "$srcdir"/libtool > "$srcdir"/libtool-2 \ > > + 's/^hardcode_libdir_flag_spec.*$'/'hardcode_libdir_flag_spec=" > > -D__LIBTOOL_IS_A_FOOL__ "/' > > +- mv libtool-2 libtool > > +- chmod 755 libtool > > ++ mv "$srcdir"/libtool-2 "$srcdir"/libtool > > ++ chmod 755 "$srcdir"/libtool > > + ;; > > + esac > > +-- > > +2.20.1 > > + > > diff --git a/meta/recipes-multimedia/alsa/alsa-lib_1.1.9.bb > > b/meta/recipes-multimedia/alsa/alsa-lib_1.2.1.1.bb > > similarity index 83% > > rename from meta/recipes-multimedia/alsa/alsa-lib_1.1.9.bb > > rename to meta/recipes-multimedia/alsa/alsa-lib_1.2.1.1.bb > > index 2c63ee7522..56544b0d45 100644 > > --- a/meta/recipes-multimedia/alsa/alsa-lib_1.1.9.bb > > +++ b/meta/recipes-multimedia/alsa/alsa-lib_1.2.1.1.bb > > @@ -7,9 +7,11 @@ LIC_FILES_CHKSUM = " > > file://COPYING;md5=a916467b91076e631dd8edb7424769c7 \ > > file://src/socket.c;md5=dd1bc7f44872690224d89c1a > > 9806e495;beginline=1;endline=26 \ > > " > > > > -SRC_URI = "https://www.alsa-project.org/files/pub/lib/${BP}.tar.bz2" > > -SRC_URI[md5sum] = "e6d429dbdcfaa0f034d907fa6dc3735e" > > -SRC_URI[sha256sum] = > > "488373aef5396682f3a411a6d064ae0ad196b9c96269d0bb912fbdeec94b994b" > > +SRC_URI = "https://www.alsa-project.org/files/pub/lib/${BP}.tar.bz2 > > \ > > + file://0001-Fix-problem-with-libtool-not-found.patch \ > > + " > > +SRC_URI[md5sum] = "1d428f46d6160f5e4bbdd64a2ff34f45" > > +SRC_URI[sha256sum] = > > "c95ac63c0aad43a6ac457d960569096b0b2ef72dc4e3737e77e3e2de87022cec" > > > > inherit autotools pkgconfig > > > > -- > > 2.20.1 > > > > > > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > [-- Attachment #2: Type: text/html, Size: 7695 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] alsa-lib:upgrade 1.1.9 -> 1.2.1.1 2019-11-20 12:10 ` Alexander Kanavin @ 2019-11-20 13:35 ` Tanu Kaskinen 0 siblings, 0 replies; 8+ messages in thread From: Tanu Kaskinen @ 2019-11-20 13:35 UTC (permalink / raw) To: Alexander Kanavin, Mittal, Anuj; +Cc: openembedded-core@lists.openembedded.org Hi, I'm still around. Yes, the moved UCM conf files need to be packaged. (And no doubt the topology files too, although that's an area I understand less well). -- Tanu On Wed, 2019-11-20 at 13:10 +0100, Alexander Kanavin wrote: > If Tanu is still around, he should probably chime in. > > Alex > > On Wed, 20 Nov 2019 at 12:55, Mittal, Anuj <anuj.mittal@intel.com> wrote: > > > This version has moved ucm and topology conf files to separate > > repositories. We should also probably fetch and package those. > > > > > > https://github.com/alsa-project/alsa-lib/commit/1f37ba2a2b1c07c04de1c368cd4943f712cccfa5 > > > > > > https://github.com/alsa-project/alsa-lib/commit/cdc8aacbb57c82a81e3b398f2ede6440d49334a5 > > > > Thanks, > > > > Anuj > > > > On Wed, 2019-11-20 at 13:17 +0800, Zang Ruochen wrote: > > > The following error occurred during the steps of do-configure: > > > > Fixing libtool for -rpath problems. > > > > ../alsa-lib-1.2.1.1/configure: line 16567: libtool: No such file or > > > > directory > > > > mv: cannot stat 'libtool-2': No such file or directory > > > > chmod: cannot access 'libtool': No such file or directory > > > > > > add alsa-lib/0001-Fix-problem-with-libtool-not-found.patch to fix it. > > > > > > Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> > > > --- > > > ...1-Fix-problem-with-libtool-not-found.patch | 31 > > > +++++++++++++++++++ > > > ...{alsa-lib_1.1.9.bb => alsa-lib_1.2.1.1.bb} | 8 +++-- > > > 2 files changed, 36 insertions(+), 3 deletions(-) > > > create mode 100644 meta/recipes-multimedia/alsa/alsa-lib/0001-Fix- > > > problem-with-libtool-not-found.patch > > > rename meta/recipes-multimedia/alsa/{alsa-lib_1.1.9.bb => alsa- > > > lib_1.2.1.1.bb} (83%) > > > > > > diff --git a/meta/recipes-multimedia/alsa/alsa-lib/0001-Fix-problem- > > > with-libtool-not-found.patch b/meta/recipes-multimedia/alsa/alsa- > > > lib/0001-Fix-problem-with-libtool-not-found.patch > > > new file mode 100644 > > > index 0000000000..5fb84cd6f8 > > > --- /dev/null > > > +++ b/meta/recipes-multimedia/alsa/alsa-lib/0001-Fix-problem-with- > > > libtool-not-found.patch > > > @@ -0,0 +1,31 @@ > > > +From f419276a716daf8d98846b3df50995e5ac030134 Mon Sep 17 00:00:00 > > > 2001 > > > +From: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> > > > +Date: Wed, 20 Nov 2019 11:24:17 +0800 > > > +Subject: [PATCH] Fix problem with libtool not found > > > + > > > +Upstream-Status: Inappropriate > > > +Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> > > > +--- > > > + configure.ac | 6 +++--- > > > + 1 file changed, 3 insertions(+), 3 deletions(-) > > > + > > > +diff --git a/configure.ac b/configure.ac > > > +index 35eb315..548b9ea 100644 > > > +--- a/configure.ac > > > ++++ b/configure.ac > > > +@@ -769,9 +769,9 @@ dnl Taken from > > > https://wiki.debian.org/RpathIssue > > > + case $host in > > > + *-*-linux-gnu) > > > + AC_MSG_RESULT([Fixing libtool for -rpath problems.]) > > > +- sed < libtool > libtool-2 \ > > > ++ sed < "$srcdir"/libtool > "$srcdir"/libtool-2 \ > > > + 's/^hardcode_libdir_flag_spec.*$'/'hardcode_libdir_flag_spec=" > > > -D__LIBTOOL_IS_A_FOOL__ "/' > > > +- mv libtool-2 libtool > > > +- chmod 755 libtool > > > ++ mv "$srcdir"/libtool-2 "$srcdir"/libtool > > > ++ chmod 755 "$srcdir"/libtool > > > + ;; > > > + esac > > > +-- > > > +2.20.1 > > > + > > > diff --git a/meta/recipes-multimedia/alsa/alsa-lib_1.1.9.bb > > > b/meta/recipes-multimedia/alsa/alsa-lib_1.2.1.1.bb > > > similarity index 83% > > > rename from meta/recipes-multimedia/alsa/alsa-lib_1.1.9.bb > > > rename to meta/recipes-multimedia/alsa/alsa-lib_1.2.1.1.bb > > > index 2c63ee7522..56544b0d45 100644 > > > --- a/meta/recipes-multimedia/alsa/alsa-lib_1.1.9.bb > > > +++ b/meta/recipes-multimedia/alsa/alsa-lib_1.2.1.1.bb > > > @@ -7,9 +7,11 @@ LIC_FILES_CHKSUM = " > > > file://COPYING;md5=a916467b91076e631dd8edb7424769c7 \ > > > file://src/socket.c;md5=dd1bc7f44872690224d89c1a > > > 9806e495;beginline=1;endline=26 \ > > > " > > > > > > -SRC_URI = "https://www.alsa-project.org/files/pub/lib/${BP}.tar.bz2" > > > -SRC_URI[md5sum] = "e6d429dbdcfaa0f034d907fa6dc3735e" > > > -SRC_URI[sha256sum] = > > > "488373aef5396682f3a411a6d064ae0ad196b9c96269d0bb912fbdeec94b994b" > > > +SRC_URI = "https://www.alsa-project.org/files/pub/lib/${BP}.tar.bz2 > > > \ > > > + file://0001-Fix-problem-with-libtool-not-found.patch \ > > > + " > > > +SRC_URI[md5sum] = "1d428f46d6160f5e4bbdd64a2ff34f45" > > > +SRC_URI[sha256sum] = > > > "c95ac63c0aad43a6ac457d960569096b0b2ef72dc4e3737e77e3e2de87022cec" > > > > > > inherit autotools pkgconfig > > > > > > -- > > > 2.20.1 > > > > > > > > > > > -- > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-12-04 21:45 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-11-20 5:17 [PATCH] alsa-lib:upgrade 1.1.9 -> 1.2.1.1 Zang Ruochen 2019-11-20 5:32 ` ✗ patchtest: failure for " Patchwork 2019-11-20 11:16 ` [PATCH] " Alexander Kanavin 2019-12-04 21:18 ` Tanu Kaskinen 2019-12-04 21:45 ` Ross Burton 2019-11-20 11:55 ` Mittal, Anuj 2019-11-20 12:10 ` Alexander Kanavin 2019-11-20 13:35 ` Tanu Kaskinen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox