[meta-oe] [PATCH 1/1] fio: remove disabling of compiler optimizations

[meta-oe] [PATCH 1/1] fio: remove disabling of compiler optimizations

[Jonathan Richardson]

Disabling compiler optimizations affects fio performance by 25-30% so
remove this from EXTRA_OECONF. Disabling of optimizations should be
machine specific if there are bugs in the code instead of the default.

Signed-off-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
---
 meta-oe/recipes-benchmark/fio/fio_3.18.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta-oe/recipes-benchmark/fio/fio_3.18.bb b/meta-oe/recipes-benchmark/fio/fio_3.18.bb
index b6484290f..2c461b8c5 100644
--- a/meta-oe/recipes-benchmark/fio/fio_3.18.bb
+++ b/meta-oe/recipes-benchmark/fio/fio_3.18.bb
@@ -33,7 +33,6 @@ S = "${WORKDIR}/git"
 DISABLE_STATIC = ""
 
 EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"
-EXTRA_OECONF = "--disable-optimizations"
 
 do_configure() {
     ./configure ${EXTRA_OECONF}
-- 
2.17.1

Re: [meta-oe] [PATCH 1/1] fio: remove disabling of compiler optimizations

[Andre McCurdy]

On Tue, Feb 18, 2020 at 12:32 PM Jonathan Richardson via
Openembedded-core <openembedded-core@lists.openembedded.org> wrote:
>
> Disabling compiler optimizations affects fio performance by 25-30% so
> remove this from EXTRA_OECONF. Disabling of optimizations should be
> machine specific if there are bugs in the code instead of the default.

Wrong mailing list ( patches for meta-oe should be sent to
openembedded-devel@lists.openembedded.org )

In general when removing a workaround or fix it's also helpful to
include a link to the commit which added it, in this case:

  https://git.openembedded.org/meta-openembedded/commit/?id=739349da0826221f98648b64b693f9ae33e7d4ea

(FWIW since that crash was seen with a much older version of fio
compiled with a now obsolete toolchain it seems perfectly justified to
remove it).

> Signed-off-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
> ---
>  meta-oe/recipes-benchmark/fio/fio_3.18.bb | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/meta-oe/recipes-benchmark/fio/fio_3.18.bb b/meta-oe/recipes-benchmark/fio/fio_3.18.bb
> index b6484290f..2c461b8c5 100644
> --- a/meta-oe/recipes-benchmark/fio/fio_3.18.bb
> +++ b/meta-oe/recipes-benchmark/fio/fio_3.18.bb
> @@ -33,7 +33,6 @@ S = "${WORKDIR}/git"
>  DISABLE_STATIC = ""
>
>  EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"
> -EXTRA_OECONF = "--disable-optimizations"
>
>  do_configure() {
>      ./configure ${EXTRA_OECONF}
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [meta-oe] [PATCH 1/1] fio: remove disabling of compiler optimizations

[Jonathan Richardson]

Sorry, that was a typo. I'll send it to devel with an updated comment. Thanks!

On Tue, Feb 18, 2020 at 12:52 PM Andre McCurdy <armccurdy@gmail.com> wrote:
>
> On Tue, Feb 18, 2020 at 12:32 PM Jonathan Richardson via
> Openembedded-core <openembedded-core@lists.openembedded.org> wrote:
> >
> > Disabling compiler optimizations affects fio performance by 25-30% so
> > remove this from EXTRA_OECONF. Disabling of optimizations should be
> > machine specific if there are bugs in the code instead of the default.
>
> Wrong mailing list ( patches for meta-oe should be sent to
> openembedded-devel@lists.openembedded.org )
>
> In general when removing a workaround or fix it's also helpful to
> include a link to the commit which added it, in this case:
>
>   https://git.openembedded.org/meta-openembedded/commit/?id=739349da0826221f98648b64b693f9ae33e7d4ea
>
> (FWIW since that crash was seen with a much older version of fio
> compiled with a now obsolete toolchain it seems perfectly justified to
> remove it).
>
> > Signed-off-by: Jonathan Richardson <jonathan.richardson@broadcom.com>
> > ---
> >  meta-oe/recipes-benchmark/fio/fio_3.18.bb | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/meta-oe/recipes-benchmark/fio/fio_3.18.bb b/meta-oe/recipes-benchmark/fio/fio_3.18.bb
> > index b6484290f..2c461b8c5 100644
> > --- a/meta-oe/recipes-benchmark/fio/fio_3.18.bb
> > +++ b/meta-oe/recipes-benchmark/fio/fio_3.18.bb
> > @@ -33,7 +33,6 @@ S = "${WORKDIR}/git"
> >  DISABLE_STATIC = ""
> >
> >  EXTRA_OEMAKE = "CC='${CC}' LDFLAGS='${LDFLAGS}'"
> > -EXTRA_OECONF = "--disable-optimizations"
> >
> >  do_configure() {
> >      ./configure ${EXTRA_OECONF}
> > --
> > 2.17.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core

✗ patchtest: failure for [meta-oe] fio: remove disabling of compiler optimizations

[Patchwork]

== Series Details ==

Series: [meta-oe] fio: remove disabling of compiler optimizations
Revision: 1
URL   : https://patchwork.openembedded.org/series/22736/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            [meta-oe,1/1] fio: remove disabling of compiler optimizations
 Issue             Series sent to the wrong mailing list [test_target_mailing_list] 
  Suggested fix    Check the project's README (meta-oe,1/1) and send the patch to the indicated list

* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at c9b5802bbe)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe