[PATCH 1/2] binutils: Fix x86_64 override usage

[PATCH 1/2] binutils: Fix x86_64 override usage

[Richard Purdie]

This override was applying to binutils-native meaning it would behave differently
depending upon the host it was building on. This is not a good idea and we have
tests to detect it which failed:

oe-selftest -r sstatetests.SStateTests.test_sstate_32_64_same_hash

binutils-native already enables all targets so we can avoid issues by not setting this
option in the native case.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-devtools/binutils/binutils.inc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
index 5b4a3392092..6ed40a14861 100644
--- a/meta/recipes-devtools/binutils/binutils.inc
+++ b/meta/recipes-devtools/binutils/binutils.inc
@@ -75,9 +75,12 @@ EXTRA_OECONF = "--program-prefix=${TARGET_PREFIX} \
                 --enable-deterministic-archives \
                 --enable-plugins \
                 ${LDGOLD} \
+                ${EXTRA_TARGETS} \
                 ${@bb.utils.contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
 
-EXTRA_OECONF_append_x86-64 = " --enable-targets=x86_64-pe,x86_64-pep "
+EXTRA_TARGETS = ""
+EXTRA_TARGETS_x86-64 = " --enable-targets=x86_64-pe,x86_64-pep "
+EXTRA_TARGETS_class-native = ""
 
 LDGOLD_class-native = ""
 LDGOLD_class-crosssdk = ""
-- 
2.25.0

[PATCH 2/2] psplash: Add missing dependency to systemd service

[Richard Purdie]

Avoid:
qemux86-64 psplash-systemd[135]: Error unable to open fifo

by adding the missing dependency on /run/ where the fifo resides.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-core/psplash/files/psplash-systemd.service | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/psplash/files/psplash-systemd.service b/meta/recipes-core/psplash/files/psplash-systemd.service
index e14f42032d8..e6de450882f 100644
--- a/meta/recipes-core/psplash/files/psplash-systemd.service
+++ b/meta/recipes-core/psplash/files/psplash-systemd.service
@@ -2,6 +2,7 @@
 Description=Start psplash-systemd progress communication helper
 DefaultDependencies=no
 After=systemd-start.service
+RequiresMountsFor=/run
 
 [Service]
 ExecStart=/usr/bin/psplash-systemd
-- 
2.25.0

Re: [PATCH 2/2] psplash: Add missing dependency to systemd service

[Richard Purdie]

On Sat, 2020-02-22 at 14:01 +0000, Richard Purdie wrote:
> Avoid:
> qemux86-64 psplash-systemd[135]: Error unable to open fifo
> 
> by adding the missing dependency on /run/ where the fifo resides.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/recipes-core/psplash/files/psplash-systemd.service | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-core/psplash/files/psplash-systemd.service
> b/meta/recipes-core/psplash/files/psplash-systemd.service
> index e14f42032d8..e6de450882f 100644
> --- a/meta/recipes-core/psplash/files/psplash-systemd.service
> +++ b/meta/recipes-core/psplash/files/psplash-systemd.service
> @@ -2,6 +2,7 @@
>  Description=Start psplash-systemd progress communication helper
>  DefaultDependencies=no
>  After=systemd-start.service
> +RequiresMountsFor=/run
>  
>  [Service]
>  ExecStart=/usr/bin/psplash-systemd

This doesn't help, the dependencies between the service files are
reversed as well. Working on a new version.

Cheers,

Richard

✗ patchtest: failure for "binutils: Fix x86_64 override ..." and 1 more

[Patchwork]

== Series Details ==

Series: "binutils: Fix x86_64 override ..." and 1 more
Revision: 1
URL   : https://patchwork.openembedded.org/series/22862/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 1d8e5d1bc1)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe