[PATCH] gdbm-native: disable readline for the native package.

[PATCH] gdbm-native: disable readline for the native package.

[Jeremy A. Puhlman]

From: Jeremy Puhlman <jpuhlman@mvista.com>

---
 meta/recipes-support/gdbm/gdbm_1.18.1.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-support/gdbm/gdbm_1.18.1.bb b/meta/recipes-support/gdbm/gdbm_1.18.1.bb
index 5326184181..52e35c8c2e 100644
--- a/meta/recipes-support/gdbm/gdbm_1.18.1.bb
+++ b/meta/recipes-support/gdbm/gdbm_1.18.1.bb
@@ -20,6 +20,8 @@ DEPENDS_class-native += "readline"
 # Needed for dbm python module
 EXTRA_OECONF = "-enable-libgdbm-compat"
 
+EXTRA_OECONF_class-native = "--without-readline"
+
 # Stop presence of dbm/nbdm on the host contaminating builds
 CACHED_CONFIGUREVARS += "ac_cv_lib_ndbm_main=no ac_cv_lib_dbm_main=no"
 
-- 
2.20.1

Re: [PATCH] gdbm-native: disable readline for the native package.

[Andre McCurdy]

On Wed, Mar 4, 2020 at 4:05 PM Jeremy A. Puhlman <jpuhlman@mvista.com> wrote:
>
> From: Jeremy Puhlman <jpuhlman@mvista.com>
>
> ---
>  meta/recipes-support/gdbm/gdbm_1.18.1.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-support/gdbm/gdbm_1.18.1.bb b/meta/recipes-support/gdbm/gdbm_1.18.1.bb
> index 5326184181..52e35c8c2e 100644
> --- a/meta/recipes-support/gdbm/gdbm_1.18.1.bb
> +++ b/meta/recipes-support/gdbm/gdbm_1.18.1.bb
> @@ -20,6 +20,8 @@ DEPENDS_class-native += "readline"
>  # Needed for dbm python module
>  EXTRA_OECONF = "-enable-libgdbm-compat"
>
> +EXTRA_OECONF_class-native = "--without-readline"

Assuming the target version is being built without readline support
(presumably that's true as the recipe doesn't indicate any dependency
on readline, but you should double check) then this configure option
should be passed in all cases, not just for native.

>  # Stop presence of dbm/nbdm on the host contaminating builds
>  CACHED_CONFIGUREVARS += "ac_cv_lib_ndbm_main=no ac_cv_lib_dbm_main=no"
>
> --
> 2.20.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] gdbm-native: disable readline for the native package.

[Jeremy A. Puhlman]

On 3/4/2020 4:16 PM, Andre McCurdy wrote:
> On Wed, Mar 4, 2020 at 4:05 PM Jeremy A. Puhlman <jpuhlman@mvista.com> wrote:
>> From: Jeremy Puhlman <jpuhlman@mvista.com>
>>
>> ---
>>   meta/recipes-support/gdbm/gdbm_1.18.1.bb | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-support/gdbm/gdbm_1.18.1.bb b/meta/recipes-support/gdbm/gdbm_1.18.1.bb
>> index 5326184181..52e35c8c2e 100644
>> --- a/meta/recipes-support/gdbm/gdbm_1.18.1.bb
>> +++ b/meta/recipes-support/gdbm/gdbm_1.18.1.bb
>> @@ -20,6 +20,8 @@ DEPENDS_class-native += "readline"
>>   # Needed for dbm python module
>>   EXTRA_OECONF = "-enable-libgdbm-compat"
>>
>> +EXTRA_OECONF_class-native = "--without-readline"
> Assuming the target version is being built without readline support
> (presumably that's true as the recipe doesn't indicate any dependency
> on readline, but you should double check) then this configure option
> should be passed in all cases, not just for native.
There is not explicit dependency which is why we are here in the first 
place for native.
>
>>   # Stop presence of dbm/nbdm on the host contaminating builds
>>   CACHED_CONFIGUREVARS += "ac_cv_lib_ndbm_main=no ac_cv_lib_dbm_main=no"
>>
>> --
>> 2.20.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Jeremy A. Puhlman
jpuhlman@mvista.com

Re: [PATCH] gdbm-native: disable readline for the native package.

[Andre McCurdy]

On Wed, Mar 4, 2020 at 4:18 PM Jeremy A. Puhlman <jpuhlman@mvista.com> wrote:
> On 3/4/2020 4:16 PM, Andre McCurdy wrote:
> > On Wed, Mar 4, 2020 at 4:05 PM Jeremy A. Puhlman <jpuhlman@mvista.com> wrote:
> >> From: Jeremy Puhlman <jpuhlman@mvista.com>
> >>
> >> ---
> >>   meta/recipes-support/gdbm/gdbm_1.18.1.bb | 2 ++
> >>   1 file changed, 2 insertions(+)
> >>
> >> diff --git a/meta/recipes-support/gdbm/gdbm_1.18.1.bb b/meta/recipes-support/gdbm/gdbm_1.18.1.bb
> >> index 5326184181..52e35c8c2e 100644
> >> --- a/meta/recipes-support/gdbm/gdbm_1.18.1.bb
> >> +++ b/meta/recipes-support/gdbm/gdbm_1.18.1.bb
> >> @@ -20,6 +20,8 @@ DEPENDS_class-native += "readline"
> >>   # Needed for dbm python module
> >>   EXTRA_OECONF = "-enable-libgdbm-compat"
> >>
> >> +EXTRA_OECONF_class-native = "--without-readline"
> > Assuming the target version is being built without readline support
> > (presumably that's true as the recipe doesn't indicate any dependency
> > on readline, but you should double check) then this configure option
> > should be passed in all cases, not just for native.
> There is not explicit dependency which is why we are here in the first
> place for native.

Right. The native issue can be fixed and the target case made clearer
by adding the explicit configure option.

Point is just that you shouldn't limit the explicit configure option
to native if it's applicable for target too.

> >
> >>   # Stop presence of dbm/nbdm on the host contaminating builds
> >>   CACHED_CONFIGUREVARS += "ac_cv_lib_ndbm_main=no ac_cv_lib_dbm_main=no"
> >>
> >> --
> >> 2.20.1
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> --
> Jeremy A. Puhlman
> jpuhlman@mvista.com
>

✗ patchtest: failure for gdbm-native: disable readline for the native package.

[Patchwork]

== Series Details ==

Series: gdbm-native: disable readline for the native package.
Revision: 1
URL   : https://patchwork.openembedded.org/series/23104/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            gdbm-native: disable readline for the native package.
 Issue             Patch is missing Signed-off-by [test_signed_off_by_presence] 
  Suggested fix    Sign off the patch (either manually or with "git commit --amend -s")



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe