[PATCH] coreutils: Fix -dev package dependencies

[PATCH] coreutils: Fix -dev package dependencies

[Richard Purdie]

The new ptest dependencies present some challenges, in particular libmodule-build-perl
which effectively depends on gcc. In multilib images, this results in both
libXX-gcc-symlinks and libYY-gcc-symlinks being installed which conflict. This also
makes little sense.

The easiest way to fix this is to disable the automatic -dev package dependencies
and manually specify the correct ones.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-core/coreutils/coreutils_8.31.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-core/coreutils/coreutils_8.31.bb b/meta/recipes-core/coreutils/coreutils_8.31.bb
index cba0bfe15cc..eac016319eb 100644
--- a/meta/recipes-core/coreutils/coreutils_8.31.bb
+++ b/meta/recipes-core/coreutils/coreutils_8.31.bb
@@ -149,6 +149,10 @@ inherit ptest
 
 RDEPENDS_${PN}-ptest += "bash findutils gawk liberror-perl libmodule-build-perl make perl perl-module-file-stat python3-core sed shadow"
 
+# -dev automatic dependencies fails as we don't want libmodule-build-perl-dev, its too heavy
+RRECOMMENDS_coreutils-dev[nodeprrecs] = "1"
+RRECOMMENDS_coreutils-dev = "acl-dev attr-dev gmp-dev libcap-dev bash-dev findutils-dev gawk-dev shadow-dev"
+
 do_install_ptest () {
     install -d ${D}${PTEST_PATH}/tests
     cp -r ${S}/tests/* ${D}${PTEST_PATH}/tests
-- 
2.25.0

✗ patchtest: failure for coreutils: Fix -dev package dependencies

[Patchwork]

== Series Details ==

Series: coreutils: Fix -dev package dependencies
Revision: 1
URL   : https://patchwork.openembedded.org/series/23199/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 04ee0e8b95)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH] coreutils: Fix -dev package dependencies

[Khem Raj]

On 3/11/20 4:44 AM, Richard Purdie wrote:
> The new ptest dependencies present some challenges, in particular libmodule-build-perl
> which effectively depends on gcc. In multilib images, this results in both
> libXX-gcc-symlinks and libYY-gcc-symlinks being installed which conflict. This also
> makes little sense.
> 
> The easiest way to fix this is to disable the automatic -dev package dependencies
> and manually specify the correct ones.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>   meta/recipes-core/coreutils/coreutils_8.31.bb | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/meta/recipes-core/coreutils/coreutils_8.31.bb b/meta/recipes-core/coreutils/coreutils_8.31.bb
> index cba0bfe15cc..eac016319eb 100644
> --- a/meta/recipes-core/coreutils/coreutils_8.31.bb
> +++ b/meta/recipes-core/coreutils/coreutils_8.31.bb
> @@ -149,6 +149,10 @@ inherit ptest
>   
>   RDEPENDS_${PN}-ptest += "bash findutils gawk liberror-perl libmodule-build-perl make perl perl-module-file-stat python3-core sed shadow"
>   
> +# -dev automatic dependencies fails as we don't want libmodule-build-perl-dev, its too heavy
> +RRECOMMENDS_coreutils-dev[nodeprrecs] = "1"
> +RRECOMMENDS_coreutils-dev = "acl-dev attr-dev gmp-dev libcap-dev bash-dev findutils-dev gawk-dev shadow-dev"
> +

this also means that any indirect dependency in future has to be added 
here manually right ? or will that situation never happen, if it will 
then perhaps a note in comments might be useful about that

>   do_install_ptest () {
>       install -d ${D}${PTEST_PATH}/tests
>       cp -r ${S}/tests/* ${D}${PTEST_PATH}/tests
> 

Re: [PATCH] coreutils: Fix -dev package dependencies

[Richard Purdie]

On Wed, 2020-03-11 at 11:29 -0700, Khem Raj wrote:
> 
> On 3/11/20 4:44 AM, Richard Purdie wrote:
> > The new ptest dependencies present some challenges, in particular
> > libmodule-build-perl
> > which effectively depends on gcc. In multilib images, this results
> > in both
> > libXX-gcc-symlinks and libYY-gcc-symlinks being installed which
> > conflict. This also
> > makes little sense.
> > 
> > The easiest way to fix this is to disable the automatic -dev
> > package dependencies
> > and manually specify the correct ones.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >   meta/recipes-core/coreutils/coreutils_8.31.bb | 4 ++++
> >   1 file changed, 4 insertions(+)
> > 
> > diff --git a/meta/recipes-core/coreutils/coreutils_8.31.bb
> > b/meta/recipes-core/coreutils/coreutils_8.31.bb
> > index cba0bfe15cc..eac016319eb 100644
> > --- a/meta/recipes-core/coreutils/coreutils_8.31.bb
> > +++ b/meta/recipes-core/coreutils/coreutils_8.31.bb
> > @@ -149,6 +149,10 @@ inherit ptest
> >   
> >   RDEPENDS_${PN}-ptest += "bash findutils gawk liberror-perl
> > libmodule-build-perl make perl perl-module-file-stat python3-core
> > sed shadow"
> >   
> > +# -dev automatic dependencies fails as we don't want libmodule-
> > build-perl-dev, its too heavy
> > +RRECOMMENDS_coreutils-dev[nodeprrecs] = "1"
> > +RRECOMMENDS_coreutils-dev = "acl-dev attr-dev gmp-dev libcap-dev
> > bash-dev findutils-dev gawk-dev shadow-dev"
> > +
> 
> this also means that any indirect dependency in future has to be
> added here manually right ? or will that situation never happen, if
> it will then perhaps a note in comments might be useful about that

If DEPENDS change, we may need to tweak this, yes.

The whole -dev thing has a bug open about reworking it and its a mess
already so this is really a bandaid for now.

I'd rather have this and coreutils-ptest than not have the ptests.

I'm trying to be pragmatic about it! :)

Cheers,

Richard

Re: [PATCH] coreutils: Fix -dev package dependencies

[Khem Raj]

On 3/11/20 11:31 AM, Richard Purdie wrote:
> On Wed, 2020-03-11 at 11:29 -0700, Khem Raj wrote:
>>
>> On 3/11/20 4:44 AM, Richard Purdie wrote:
>>> The new ptest dependencies present some challenges, in particular
>>> libmodule-build-perl
>>> which effectively depends on gcc. In multilib images, this results
>>> in both
>>> libXX-gcc-symlinks and libYY-gcc-symlinks being installed which
>>> conflict. This also
>>> makes little sense.
>>>
>>> The easiest way to fix this is to disable the automatic -dev
>>> package dependencies
>>> and manually specify the correct ones.
>>>
>>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>>> ---
>>>    meta/recipes-core/coreutils/coreutils_8.31.bb | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/meta/recipes-core/coreutils/coreutils_8.31.bb
>>> b/meta/recipes-core/coreutils/coreutils_8.31.bb
>>> index cba0bfe15cc..eac016319eb 100644
>>> --- a/meta/recipes-core/coreutils/coreutils_8.31.bb
>>> +++ b/meta/recipes-core/coreutils/coreutils_8.31.bb
>>> @@ -149,6 +149,10 @@ inherit ptest
>>>    
>>>    RDEPENDS_${PN}-ptest += "bash findutils gawk liberror-perl
>>> libmodule-build-perl make perl perl-module-file-stat python3-core
>>> sed shadow"
>>>    
>>> +# -dev automatic dependencies fails as we don't want libmodule-
>>> build-perl-dev, its too heavy
>>> +RRECOMMENDS_coreutils-dev[nodeprrecs] = "1"
>>> +RRECOMMENDS_coreutils-dev = "acl-dev attr-dev gmp-dev libcap-dev
>>> bash-dev findutils-dev gawk-dev shadow-dev"
>>> +
>>
>> this also means that any indirect dependency in future has to be
>> added here manually right ? or will that situation never happen, if
>> it will then perhaps a note in comments might be useful about that
> 
> If DEPENDS change, we may need to tweak this, yes.
> 
> The whole -dev thing has a bug open about reworking it and its a mess
> already so this is really a bandaid for now.
> 
> I'd rather have this and coreutils-ptest than not have the ptests.
> 
> I'm trying to be pragmatic about it! :)

I think change is fine, I am just thinking if we will assist keeping it 
sane with a comment, until dev package logic is reworked.
> 
> Cheers,
> 
> Richard
>