Re: [OE-core] [PATCH] mesa-gl: The purpose of mesa-gl is to provide for X11 usage

["Denys Dmytriyenko" <denis@denix.org>]

On Wed, Mar 25, 2020 at 01:14:47PM -0500, Mark Hatle wrote:
> Trying to build mesa-gl without X11 enabled, results in numerous errors
> about being incorrectly configured, such as:
> 
>   ERROR: Problem encountered: building dri drivers require at least one windowing system or classic osmesa
> 
> After consulting with the author of this recipe, it was clear that it
> was only intended for the X11 use-case, so requring X11 should avoid the
> error message above.

Hmm. That's not good. There are embedded devices that provide EGL/GLES support 
through own stack, but fall back on MESA for full desktop GL support. That's 
been working to some extent even with Wayland and w/o X11. With your change 
that won't be possible any more...

-- 
Denys


> Signed-off-by: Mark Hatle <mark.hatle@kernel.crashing.org>
> ---
>  meta/recipes-graphics/mesa/mesa-gl_20.0.1.bb | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-graphics/mesa/mesa-gl_20.0.1.bb b/meta/recipes-graphics/mesa/mesa-gl_20.0.1.bb
> index d4b1c1c454..5674c6b1fe 100644
> --- a/meta/recipes-graphics/mesa/mesa-gl_20.0.1.bb
> +++ b/meta/recipes-graphics/mesa/mesa-gl_20.0.1.bb
> @@ -6,5 +6,7 @@ PROVIDES = "virtual/libgl virtual/mesa"
>  
>  S = "${WORKDIR}/mesa-${PV}"
>  
> -PACKAGECONFIG ??= "opengl dri ${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)}"
> -PACKAGECONFIG_class-target = "opengl dri ${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)}"
> +REQUIRED_DISTRO_FEATURE = "x11"
> +
> +PACKAGECONFIG ??= "opengl dri x11"
> +PACKAGECONFIG_class-target = "opengl dri x11"
> -- 
> 2.17.1
> 

>