Openembedded Core Discussions
 help / color / mirror / Atom feed
* [OE-core][PATCH] initscripts/init-system-helpers: fix mountnfs.sh dependency
@ 2020-03-30 16:51 Jens Rehsack
  2020-03-30 17:19 ` Andre McCurdy
  0 siblings, 1 reply; 5+ messages in thread
From: Jens Rehsack @ 2020-03-30 16:51 UTC (permalink / raw)
  To: openembedded-core; +Cc: Jens Rehsack

With commit c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
    Author: Yue Tao <Yue.Tao@windriver.com>
    Date:   Fri May 25 10:48:08 2018 +0800

	initscripts: Avoid starting rpcbind daemon twice

	Check the status before start it to avoid duplicates.

the use of a script {/usr/sbin/}service is introduced - maybe earlier
provided by systemd, nowadays mostly by init-system-helpers from
debian project.

For the very first shot, maybe discussions and improvements based
on that script collection, use just the init-system-helpers-service
in initscripts/mountnfs.sh to avoid problems mounting NFS in later
boot stage.

Signed-off-by: Jens Rehsack <sno@netbsd.org>
---
 .../initscripts/init-system-helpers_1.57.bb   | 52 +++++++++++++++++++
 .../initscripts/initscripts_1.0.bb            |  1 +
 2 files changed, 53 insertions(+)
 create mode 100644 meta/recipes-core/initscripts/init-system-helpers_1.57.bb

diff --git a/meta/recipes-core/initscripts/init-system-helpers_1.57.bb b/meta/recipes-core/initscripts/init-system-helpers_1.57.bb
new file mode 100644
index 0000000000..2b09983483
--- /dev/null
+++ b/meta/recipes-core/initscripts/init-system-helpers_1.57.bb
@@ -0,0 +1,52 @@
+# Copyright (C) 2020 Jens Rehsack <sno@netbsd.org>
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+SUMMARY = "helper tools for all init systems"
+DESCRIPTION = "This package contains helper tools that are necessary for switching between \
+the various init systems that Debian contains (e. g. sysvinit or \
+systemd). An example is deb-systemd-helper, a script that enables systemd unit \
+files without depending on a running systemd. \
+\
+It also includes the \"service\", \"invoke-rc.d\", and \"update-rc.d\" scripts which \
+provide an abstraction for enabling, disabling, starting, and stopping \
+services for all supported Debian init systems as specified by the policy. \
+\
+While this package is maintained by pkg-systemd-maintainers, it is NOT \
+specific to systemd at all. Maintainers of other init systems are welcome to \
+include their helpers in this package."
+HOMEPAGE = "https://salsa.debian.org/debian/init-system-helpers"
+SECTION = "base"
+LICENSE = "BSD-3-clause & GPLv2"
+LIC_FILES_CHKSUM = "file://debian/copyright;md5=ee2b1830fcfead84d07bc060ec43e072"
+
+PACKAGES += "${PN}-invoke-rc.d ${PN}-service ${PN}-update-rc.d"
+
+DEPENDS = "perl"
+
+SRCREV = "760c625ec0e1ffebec2e391d891d389da0f65726"
+SRC_URI = "git://salsa.debian.org/debian/init-system-helpers.git"
+
+S = "${WORKDIR}/git"
+
+do_configure() {
+	:
+}
+
+do_compile() {
+	:
+}
+
+do_install() {
+	install -d -m 0755 ${D}${sbindir}
+	install -m 0755 ${S}/script/invoke-rc.d ${D}${sbindir}
+	install -m 0755 ${S}/script/service ${D}${sbindir}
+	install -m 0755 ${S}/script/update-rc.d ${D}${sbindir}
+}
+
+FILES_${PN} = ""
+FILES_${PN}-invoke-rc.d = "${sbindir}/invoke-rc.d"
+FILES_${PN}-service = "${sbindir}/service"
+FILES_${PN}-update-rc.d = "${sbindir}/update-rc.d"
+
+RDEPENDS_${PN}-update-rc.d = "perl"
+RRECOMMENDS_${PN} += "${PN}-invoke-rc.d ${PN}-service ${PN}-update-rc.d"
diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
index 1a59b82fbf..4080c4a495 100644
--- a/meta/recipes-core/initscripts/initscripts_1.0.bb
+++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
@@ -50,6 +50,7 @@ PACKAGE_WRITE_DEPS_append = " ${@bb.utils.contains('DISTRO_FEATURES','systemd','
 PACKAGES =+ "${PN}-functions ${PN}-sushell"
 RDEPENDS_${PN} = "initd-functions \
                   ${@bb.utils.contains('DISTRO_FEATURES','selinux','${PN}-sushell','',d)} \
+                  init-system-helpers-service \
 		 "
 # Recommend pn-functions so that it will be a preferred default provider for initd-functions
 RRECOMMENDS_${PN} = "${PN}-functions"
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [OE-core][PATCH] initscripts/init-system-helpers: fix mountnfs.sh dependency
  2020-03-30 16:51 [OE-core][PATCH] initscripts/init-system-helpers: fix mountnfs.sh dependency Jens Rehsack
@ 2020-03-30 17:19 ` Andre McCurdy
  2020-04-03 15:57   ` Jens Rehsack
  0 siblings, 1 reply; 5+ messages in thread
From: Andre McCurdy @ 2020-03-30 17:19 UTC (permalink / raw)
  To: Jens Rehsack; +Cc: OE Core mailing list, Jens Rehsack

On Mon, Mar 30, 2020 at 9:51 AM Jens Rehsack <rehsack@gmail.com> wrote:
>
> With commit c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
>     Author: Yue Tao <Yue.Tao@windriver.com>
>     Date:   Fri May 25 10:48:08 2018 +0800
>
>         initscripts: Avoid starting rpcbind daemon twice
>
>         Check the status before start it to avoid duplicates.
>
> the use of a script {/usr/sbin/}service is introduced - maybe earlier
> provided by systemd, nowadays mostly by init-system-helpers from
> debian project.
>
> For the very first shot, maybe discussions and improvements based
> on that script collection, use just the init-system-helpers-service
> in initscripts/mountnfs.sh to avoid problems mounting NFS in later
> boot stage.
>
> Signed-off-by: Jens Rehsack <sno@netbsd.org>
> ---
>  .../initscripts/init-system-helpers_1.57.bb   | 52 +++++++++++++++++++
>  .../initscripts/initscripts_1.0.bb            |  1 +
>  2 files changed, 53 insertions(+)
>  create mode 100644 meta/recipes-core/initscripts/init-system-helpers_1.57.bb
>
> diff --git a/meta/recipes-core/initscripts/init-system-helpers_1.57.bb b/meta/recipes-core/initscripts/init-system-helpers_1.57.bb
> new file mode 100644
> index 0000000000..2b09983483
> --- /dev/null
> +++ b/meta/recipes-core/initscripts/init-system-helpers_1.57.bb
> @@ -0,0 +1,52 @@
> +# Copyright (C) 2020 Jens Rehsack <sno@netbsd.org>
> +# Released under the MIT license (see COPYING.MIT for the terms)

Is this really necessary?

> +SUMMARY = "helper tools for all init systems"
> +DESCRIPTION = "This package contains helper tools that are necessary for switching between \
> +the various init systems that Debian contains (e. g. sysvinit or \
> +systemd). An example is deb-systemd-helper, a script that enables systemd unit \
> +files without depending on a running systemd. \
> +\
> +It also includes the \"service\", \"invoke-rc.d\", and \"update-rc.d\" scripts which \
> +provide an abstraction for enabling, disabling, starting, and stopping \
> +services for all supported Debian init systems as specified by the policy. \
> +\
> +While this package is maintained by pkg-systemd-maintainers, it is NOT \
> +specific to systemd at all. Maintainers of other init systems are welcome to \
> +include their helpers in this package."
> +HOMEPAGE = "https://salsa.debian.org/debian/init-system-helpers"
> +SECTION = "base"
> +LICENSE = "BSD-3-clause & GPLv2"
> +LIC_FILES_CHKSUM = "file://debian/copyright;md5=ee2b1830fcfead84d07bc060ec43e072"
> +
> +PACKAGES += "${PN}-invoke-rc.d ${PN}-service ${PN}-update-rc.d"

According to the OE style guide, PACKAGES should go near the end of
the recipe (after do_install, before FILES_${PN}).

> +DEPENDS = "perl"

Since this recipe doesn't do anything in do_configure or do_compile
it's odd that it needs a build time dependency on perl?

> +SRCREV = "760c625ec0e1ffebec2e391d891d389da0f65726"
> +SRC_URI = "git://salsa.debian.org/debian/init-system-helpers.git"
> +
> +S = "${WORKDIR}/git"
> +
> +do_configure() {
> +       :
> +}
> +
> +do_compile() {
> +       :
> +}
> +
> +do_install() {
> +       install -d -m 0755 ${D}${sbindir}
> +       install -m 0755 ${S}/script/invoke-rc.d ${D}${sbindir}
> +       install -m 0755 ${S}/script/service ${D}${sbindir}
> +       install -m 0755 ${S}/script/update-rc.d ${D}${sbindir}
> +}
> +
> +FILES_${PN} = ""

If you want the default package to be empty then you probably need to add:

  ALLOW_EMPTY_${PN} = "1"

> +FILES_${PN}-invoke-rc.d = "${sbindir}/invoke-rc.d"
> +FILES_${PN}-service = "${sbindir}/service"
> +FILES_${PN}-update-rc.d = "${sbindir}/update-rc.d"
> +
> +RDEPENDS_${PN}-update-rc.d = "perl"
> +RRECOMMENDS_${PN} += "${PN}-invoke-rc.d ${PN}-service ${PN}-update-rc.d"
> diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
> index 1a59b82fbf..4080c4a495 100644
> --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
> +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
> @@ -50,6 +50,7 @@ PACKAGE_WRITE_DEPS_append = " ${@bb.utils.contains('DISTRO_FEATURES','systemd','
>  PACKAGES =+ "${PN}-functions ${PN}-sushell"
>  RDEPENDS_${PN} = "initd-functions \
>                    ${@bb.utils.contains('DISTRO_FEATURES','selinux','${PN}-sushell','',d)} \
> +                  init-system-helpers-service \
>                  "
>  # Recommend pn-functions so that it will be a preferred default provider for initd-functions
>  RRECOMMENDS_${PN} = "${PN}-functions"
> --
> 2.17.1
>
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [OE-core][PATCH] initscripts/init-system-helpers: fix mountnfs.sh dependency
  2020-03-30 17:19 ` Andre McCurdy
@ 2020-04-03 15:57   ` Jens Rehsack
  2020-04-03 17:11     ` Andre McCurdy
  0 siblings, 1 reply; 5+ messages in thread
From: Jens Rehsack @ 2020-04-03 15:57 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list

[-- Attachment #1: Type: text/plain, Size: 5258 bytes --]



> Am 30.03.2020 um 19:19 schrieb Andre McCurdy <armccurdy@gmail.com>:
> 
> On Mon, Mar 30, 2020 at 9:51 AM Jens Rehsack <rehsack@gmail.com> wrote:
>> 
>> With commit c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
>>    Author: Yue Tao <Yue.Tao@windriver.com>
>>    Date:   Fri May 25 10:48:08 2018 +0800
>> 
>>        initscripts: Avoid starting rpcbind daemon twice
>> 
>>        Check the status before start it to avoid duplicates.
>> 
>> the use of a script {/usr/sbin/}service is introduced - maybe earlier
>> provided by systemd, nowadays mostly by init-system-helpers from
>> debian project.
>> 
>> For the very first shot, maybe discussions and improvements based
>> on that script collection, use just the init-system-helpers-service
>> in initscripts/mountnfs.sh to avoid problems mounting NFS in later
>> boot stage.
>> 
>> Signed-off-by: Jens Rehsack <sno@netbsd.org>
>> ---
>> .../initscripts/init-system-helpers_1.57.bb   | 52 +++++++++++++++++++
>> .../initscripts/initscripts_1.0.bb            |  1 +
>> 2 files changed, 53 insertions(+)
>> create mode 100644 meta/recipes-core/initscripts/init-system-helpers_1.57.bb
>> 
>> diff --git a/meta/recipes-core/initscripts/init-system-helpers_1.57.bb b/meta/recipes-core/initscripts/init-system-helpers_1.57.bb
>> new file mode 100644
>> index 0000000000..2b09983483
>> --- /dev/null
>> +++ b/meta/recipes-core/initscripts/init-system-helpers_1.57.bb
>> @@ -0,0 +1,52 @@
>> +# Copyright (C) 2020 Jens Rehsack <sno@netbsd.org>
>> +# Released under the MIT license (see COPYING.MIT for the terms)
> 
> Is this really necessary?

Nope. It's a default preambel, vim adds :)

>> +SUMMARY = "helper tools for all init systems"
>> +DESCRIPTION = "This package contains helper tools that are necessary for switching between \
>> +the various init systems that Debian contains (e. g. sysvinit or \
>> +systemd). An example is deb-systemd-helper, a script that enables systemd unit \
>> +files without depending on a running systemd. \
>> +\
>> +It also includes the \"service\", \"invoke-rc.d\", and \"update-rc.d\" scripts which \
>> +provide an abstraction for enabling, disabling, starting, and stopping \
>> +services for all supported Debian init systems as specified by the policy. \
>> +\
>> +While this package is maintained by pkg-systemd-maintainers, it is NOT \
>> +specific to systemd at all. Maintainers of other init systems are welcome to \
>> +include their helpers in this package."
>> +HOMEPAGE = "https://salsa.debian.org/debian/init-system-helpers"
>> +SECTION = "base"
>> +LICENSE = "BSD-3-clause & GPLv2"
>> +LIC_FILES_CHKSUM = "file://debian/copyright;md5=ee2b1830fcfead84d07bc060ec43e072"
>> +
>> +PACKAGES += "${PN}-invoke-rc.d ${PN}-service ${PN}-update-rc.d"
> 
> According to the OE style guide, PACKAGES should go near the end of
> the recipe (after do_install, before FILES_${PN}).

*shrug*
I see that neither initscripts nor busybox following this guide - so I don't know.

>> +DEPENDS = "perl"
> 
> Since this recipe doesn't do anything in do_configure or do_compile
> it's odd that it needs a build time dependency on perl?

As debian/control says so.

And maybe little time later someone wants to do something with
update-rc.d or one of the systemd helpers as debian does.
Or one likes to add man-pages (pod2man)?

It's not that wrong.

>> +SRCREV = "760c625ec0e1ffebec2e391d891d389da0f65726"
>> +SRC_URI = "git://salsa.debian.org/debian/init-system-helpers.git"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +do_configure() {
>> +       :
>> +}
>> +
>> +do_compile() {
>> +       :
>> +}
>> +
>> +do_install() {
>> +       install -d -m 0755 ${D}${sbindir}
>> +       install -m 0755 ${S}/script/invoke-rc.d ${D}${sbindir}
>> +       install -m 0755 ${S}/script/service ${D}${sbindir}
>> +       install -m 0755 ${S}/script/update-rc.d ${D}${sbindir}
>> +}
>> +
>> +FILES_${PN} = ""
> 
> If you want the default package to be empty then you probably need to add:
> 
>  ALLOW_EMPTY_${PN} = "1"

Yeah - wanted to add that but fall through ...

>> +FILES_${PN}-invoke-rc.d = "${sbindir}/invoke-rc.d"
>> +FILES_${PN}-service = "${sbindir}/service"
>> +FILES_${PN}-update-rc.d = "${sbindir}/update-rc.d"
>> +
>> +RDEPENDS_${PN}-update-rc.d = "perl"
>> +RRECOMMENDS_${PN} += "${PN}-invoke-rc.d ${PN}-service ${PN}-update-rc.d"
>> diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
>> index 1a59b82fbf..4080c4a495 100644
>> --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
>> +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
>> @@ -50,6 +50,7 @@ PACKAGE_WRITE_DEPS_append = " ${@bb.utils.contains('DISTRO_FEATURES','systemd','
>> PACKAGES =+ "${PN}-functions ${PN}-sushell"
>> RDEPENDS_${PN} = "initd-functions \
>>                   ${@bb.utils.contains('DISTRO_FEATURES','selinux','${PN}-sushell','',d)} \
>> +                  init-system-helpers-service \
>>                 "
>> # Recommend pn-functions so that it will be a preferred default provider for initd-functions
>> RRECOMMENDS_${PN} = "${PN}-functions"
>> --
>> 2.17.1
>> 
>> 

--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [OE-core][PATCH] initscripts/init-system-helpers: fix mountnfs.sh dependency
  2020-04-03 15:57   ` Jens Rehsack
@ 2020-04-03 17:11     ` Andre McCurdy
  2020-04-03 17:23       ` Jens Rehsack
  0 siblings, 1 reply; 5+ messages in thread
From: Andre McCurdy @ 2020-04-03 17:11 UTC (permalink / raw)
  To: Jens Rehsack; +Cc: OE Core mailing list

On Fri, Apr 3, 2020 at 8:57 AM Jens Rehsack <rehsack@gmail.com> wrote:
> > Am 30.03.2020 um 19:19 schrieb Andre McCurdy <armccurdy@gmail.com>:
> > On Mon, Mar 30, 2020 at 9:51 AM Jens Rehsack <rehsack@gmail.com> wrote:
> >>
> >> With commit c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
> >>    Author: Yue Tao <Yue.Tao@windriver.com>
> >>    Date:   Fri May 25 10:48:08 2018 +0800
> >>
> >>        initscripts: Avoid starting rpcbind daemon twice
> >>
> >>        Check the status before start it to avoid duplicates.
> >>
> >> the use of a script {/usr/sbin/}service is introduced - maybe earlier
> >> provided by systemd, nowadays mostly by init-system-helpers from
> >> debian project.
> >>
> >> For the very first shot, maybe discussions and improvements based
> >> on that script collection, use just the init-system-helpers-service
> >> in initscripts/mountnfs.sh to avoid problems mounting NFS in later
> >> boot stage.
> >>
> >> Signed-off-by: Jens Rehsack <sno@netbsd.org>
> >> ---
> >> .../initscripts/init-system-helpers_1.57.bb   | 52 +++++++++++++++++++
> >> .../initscripts/initscripts_1.0.bb            |  1 +
> >> 2 files changed, 53 insertions(+)
> >> create mode 100644 meta/recipes-core/initscripts/init-system-helpers_1.57.bb
> >>
> >> diff --git a/meta/recipes-core/initscripts/init-system-helpers_1.57.bb b/meta/recipes-core/initscripts/init-system-helpers_1.57.bb
> >> new file mode 100644
> >> index 0000000000..2b09983483
> >> --- /dev/null
> >> +++ b/meta/recipes-core/initscripts/init-system-helpers_1.57.bb
> >> @@ -0,0 +1,52 @@
> >> +# Copyright (C) 2020 Jens Rehsack <sno@netbsd.org>
> >> +# Released under the MIT license (see COPYING.MIT for the terms)
> >
> > Is this really necessary?
>
> Nope. It's a default preambel, vim adds :)
>
> >> +SUMMARY = "helper tools for all init systems"
> >> +DESCRIPTION = "This package contains helper tools that are necessary for switching between \
> >> +the various init systems that Debian contains (e. g. sysvinit or \
> >> +systemd). An example is deb-systemd-helper, a script that enables systemd unit \
> >> +files without depending on a running systemd. \
> >> +\
> >> +It also includes the \"service\", \"invoke-rc.d\", and \"update-rc.d\" scripts which \
> >> +provide an abstraction for enabling, disabling, starting, and stopping \
> >> +services for all supported Debian init systems as specified by the policy. \
> >> +\
> >> +While this package is maintained by pkg-systemd-maintainers, it is NOT \
> >> +specific to systemd at all. Maintainers of other init systems are welcome to \
> >> +include their helpers in this package."
> >> +HOMEPAGE = "https://salsa.debian.org/debian/init-system-helpers"
> >> +SECTION = "base"
> >> +LICENSE = "BSD-3-clause & GPLv2"
> >> +LIC_FILES_CHKSUM = "file://debian/copyright;md5=ee2b1830fcfead84d07bc060ec43e072"
> >> +
> >> +PACKAGES += "${PN}-invoke-rc.d ${PN}-service ${PN}-update-rc.d"
> >
> > According to the OE style guide, PACKAGES should go near the end of
> > the recipe (after do_install, before FILES_${PN}).
>
> *shrug*
> I see that neither initscripts nor busybox following this guide - so I don't know.

Yeah, most people don't care about variable ordering and maintainers
don't do anything to enforce it so this comment was mainly FYI.

> >> +DEPENDS = "perl"
> >
> > Since this recipe doesn't do anything in do_configure or do_compile
> > it's odd that it needs a build time dependency on perl?
>
> As debian/control says so.
>
> And maybe little time later someone wants to do something with
> update-rc.d or one of the systemd helpers as debian does.
> Or one likes to add man-pages (pod2man)?
>
> It's not that wrong.

Unnecessary build time dependencies can cause increased build times
(either due to building dependencies which otherwise would not have
been needed or limiting the scope the build scheduler has for
parallelization). Maybe not in this case since there's a run time
dependency on perl too, but in general adding unnecessary dependencies
just looks bad - as if you don't really understand the concept. Adding
a dependency now because it might be needed in the future isn't a good
justification either.

> >> +SRCREV = "760c625ec0e1ffebec2e391d891d389da0f65726"
> >> +SRC_URI = "git://salsa.debian.org/debian/init-system-helpers.git"
> >> +
> >> +S = "${WORKDIR}/git"
> >> +
> >> +do_configure() {
> >> +       :
> >> +}
> >> +
> >> +do_compile() {
> >> +       :
> >> +}
> >> +
> >> +do_install() {
> >> +       install -d -m 0755 ${D}${sbindir}
> >> +       install -m 0755 ${S}/script/invoke-rc.d ${D}${sbindir}
> >> +       install -m 0755 ${S}/script/service ${D}${sbindir}
> >> +       install -m 0755 ${S}/script/update-rc.d ${D}${sbindir}
> >> +}
> >> +
> >> +FILES_${PN} = ""
> >
> > If you want the default package to be empty then you probably need to add:
> >
> >  ALLOW_EMPTY_${PN} = "1"
>
> Yeah - wanted to add that but fall through ...
>
> >> +FILES_${PN}-invoke-rc.d = "${sbindir}/invoke-rc.d"
> >> +FILES_${PN}-service = "${sbindir}/service"
> >> +FILES_${PN}-update-rc.d = "${sbindir}/update-rc.d"
> >> +
> >> +RDEPENDS_${PN}-update-rc.d = "perl"
> >> +RRECOMMENDS_${PN} += "${PN}-invoke-rc.d ${PN}-service ${PN}-update-rc.d"
> >> diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
> >> index 1a59b82fbf..4080c4a495 100644
> >> --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
> >> +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
> >> @@ -50,6 +50,7 @@ PACKAGE_WRITE_DEPS_append = " ${@bb.utils.contains('DISTRO_FEATURES','systemd','
> >> PACKAGES =+ "${PN}-functions ${PN}-sushell"
> >> RDEPENDS_${PN} = "initd-functions \
> >>                   ${@bb.utils.contains('DISTRO_FEATURES','selinux','${PN}-sushell','',d)} \
> >> +                  init-system-helpers-service \
> >>                 "
> >> # Recommend pn-functions so that it will be a preferred default provider for initd-functions
> >> RRECOMMENDS_${PN} = "${PN}-functions"
> >> --
> >> 2.17.1
> >>
> >> 
>
> --
> Jens Rehsack - rehsack@gmail.com
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [OE-core][PATCH] initscripts/init-system-helpers: fix mountnfs.sh dependency
  2020-04-03 17:11     ` Andre McCurdy
@ 2020-04-03 17:23       ` Jens Rehsack
  0 siblings, 0 replies; 5+ messages in thread
From: Jens Rehsack @ 2020-04-03 17:23 UTC (permalink / raw)
  To: Andre McCurdy; +Cc: OE Core mailing list

[-- Attachment #1: Type: text/plain, Size: 6597 bytes --]



> Am 03.04.2020 um 19:11 schrieb Andre McCurdy <armccurdy@gmail.com>:
> 
> On Fri, Apr 3, 2020 at 8:57 AM Jens Rehsack <rehsack@gmail.com> wrote:
>>> Am 30.03.2020 um 19:19 schrieb Andre McCurdy <armccurdy@gmail.com>:
>>> On Mon, Mar 30, 2020 at 9:51 AM Jens Rehsack <rehsack@gmail.com> wrote:
>>>> 
>>>> With commit c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
>>>>   Author: Yue Tao <Yue.Tao@windriver.com>
>>>>   Date:   Fri May 25 10:48:08 2018 +0800
>>>> 
>>>>       initscripts: Avoid starting rpcbind daemon twice
>>>> 
>>>>       Check the status before start it to avoid duplicates.
>>>> 
>>>> the use of a script {/usr/sbin/}service is introduced - maybe earlier
>>>> provided by systemd, nowadays mostly by init-system-helpers from
>>>> debian project.
>>>> 
>>>> For the very first shot, maybe discussions and improvements based
>>>> on that script collection, use just the init-system-helpers-service
>>>> in initscripts/mountnfs.sh to avoid problems mounting NFS in later
>>>> boot stage.
>>>> 
>>>> Signed-off-by: Jens Rehsack <sno@netbsd.org>
>>>> ---
>>>> .../initscripts/init-system-helpers_1.57.bb   | 52 +++++++++++++++++++
>>>> .../initscripts/initscripts_1.0.bb            |  1 +
>>>> 2 files changed, 53 insertions(+)
>>>> create mode 100644 meta/recipes-core/initscripts/init-system-helpers_1.57.bb
>>>> 
>>>> diff --git a/meta/recipes-core/initscripts/init-system-helpers_1.57.bb b/meta/recipes-core/initscripts/init-system-helpers_1.57.bb
>>>> new file mode 100644
>>>> index 0000000000..2b09983483
>>>> --- /dev/null
>>>> +++ b/meta/recipes-core/initscripts/init-system-helpers_1.57.bb
>>>> @@ -0,0 +1,52 @@
>>>> +# Copyright (C) 2020 Jens Rehsack <sno@netbsd.org>
>>>> +# Released under the MIT license (see COPYING.MIT for the terms)
>>> 
>>> Is this really necessary?
>> 
>> Nope. It's a default preambel, vim adds :)
>> 
>>>> +SUMMARY = "helper tools for all init systems"
>>>> +DESCRIPTION = "This package contains helper tools that are necessary for switching between \
>>>> +the various init systems that Debian contains (e. g. sysvinit or \
>>>> +systemd). An example is deb-systemd-helper, a script that enables systemd unit \
>>>> +files without depending on a running systemd. \
>>>> +\
>>>> +It also includes the \"service\", \"invoke-rc.d\", and \"update-rc.d\" scripts which \
>>>> +provide an abstraction for enabling, disabling, starting, and stopping \
>>>> +services for all supported Debian init systems as specified by the policy. \
>>>> +\
>>>> +While this package is maintained by pkg-systemd-maintainers, it is NOT \
>>>> +specific to systemd at all. Maintainers of other init systems are welcome to \
>>>> +include their helpers in this package."
>>>> +HOMEPAGE = "https://salsa.debian.org/debian/init-system-helpers"
>>>> +SECTION = "base"
>>>> +LICENSE = "BSD-3-clause & GPLv2"
>>>> +LIC_FILES_CHKSUM = "file://debian/copyright;md5=ee2b1830fcfead84d07bc060ec43e072"
>>>> +
>>>> +PACKAGES += "${PN}-invoke-rc.d ${PN}-service ${PN}-update-rc.d"
>>> 
>>> According to the OE style guide, PACKAGES should go near the end of
>>> the recipe (after do_install, before FILES_${PN}).
>> 
>> *shrug*
>> I see that neither initscripts nor busybox following this guide - so I don't know.
> 
> Yeah, most people don't care about variable ordering and maintainers
> don't do anything to enforce it so this comment was mainly FYI.

I checked http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
but there is nothing prominent regarding style.

>>>> +DEPENDS = "perl"
>>> 
>>> Since this recipe doesn't do anything in do_configure or do_compile
>>> it's odd that it needs a build time dependency on perl?
>> 
>> As debian/control says so.
>> 
>> And maybe little time later someone wants to do something with
>> update-rc.d or one of the systemd helpers as debian does.
>> Or one likes to add man-pages (pod2man)?
>> 
>> It's not that wrong.
> 
> Unnecessary build time dependencies can cause increased build times
> (either due to building dependencies which otherwise would not have
> been needed or limiting the scope the build scheduler has for
> parallelization). Maybe not in this case since there's a run time
> dependency on perl too, but in general adding unnecessary dependencies
> just looks bad - as if you don't really understand the concept. Adding
> a dependency now because it might be needed in the future isn't a good
> justification either.

You can bet that I care for seriously unnecessary dependencies :)

>>>> +SRCREV = "760c625ec0e1ffebec2e391d891d389da0f65726"
>>>> +SRC_URI = "git://salsa.debian.org/debian/init-system-helpers.git"
>>>> +
>>>> +S = "${WORKDIR}/git"
>>>> +
>>>> +do_configure() {
>>>> +       :
>>>> +}
>>>> +
>>>> +do_compile() {
>>>> +       :
>>>> +}
>>>> +
>>>> +do_install() {
>>>> +       install -d -m 0755 ${D}${sbindir}
>>>> +       install -m 0755 ${S}/script/invoke-rc.d ${D}${sbindir}
>>>> +       install -m 0755 ${S}/script/service ${D}${sbindir}
>>>> +       install -m 0755 ${S}/script/update-rc.d ${D}${sbindir}
>>>> +}
>>>> +
>>>> +FILES_${PN} = ""
>>> 
>>> If you want the default package to be empty then you probably need to add:
>>> 
>>> ALLOW_EMPTY_${PN} = "1"
>> 
>> Yeah - wanted to add that but fall through ...
>> 
>>>> +FILES_${PN}-invoke-rc.d = "${sbindir}/invoke-rc.d"
>>>> +FILES_${PN}-service = "${sbindir}/service"
>>>> +FILES_${PN}-update-rc.d = "${sbindir}/update-rc.d"
>>>> +
>>>> +RDEPENDS_${PN}-update-rc.d = "perl"
>>>> +RRECOMMENDS_${PN} += "${PN}-invoke-rc.d ${PN}-service ${PN}-update-rc.d"
>>>> diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
>>>> index 1a59b82fbf..4080c4a495 100644
>>>> --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
>>>> +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
>>>> @@ -50,6 +50,7 @@ PACKAGE_WRITE_DEPS_append = " ${@bb.utils.contains('DISTRO_FEATURES','systemd','
>>>> PACKAGES =+ "${PN}-functions ${PN}-sushell"
>>>> RDEPENDS_${PN} = "initd-functions \
>>>>                  ${@bb.utils.contains('DISTRO_FEATURES','selinux','${PN}-sushell','',d)} \
>>>> +                  init-system-helpers-service \
>>>>                "
>>>> # Recommend pn-functions so that it will be a preferred default provider for initd-functions
>>>> RRECOMMENDS_${PN} = "${PN}-functions"
>>>> --
>>>> 2.17.1
>>>> 
>>>> 
>> 
>> --
>> Jens Rehsack - rehsack@gmail.com
>> 
> 

--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 849 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-04-03 17:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-30 16:51 [OE-core][PATCH] initscripts/init-system-helpers: fix mountnfs.sh dependency Jens Rehsack
2020-03-30 17:19 ` Andre McCurdy
2020-04-03 15:57   ` Jens Rehsack
2020-04-03 17:11     ` Andre McCurdy
2020-04-03 17:23       ` Jens Rehsack

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox