From: "Adrian Bunk" <bunk@stusta.de>
To: openembedded-core@lists.openembedded.org
Cc: Daniel Mack <daniel@zonque.org>
Subject: Re: [OE-core] [PATCH] Add -fcommon to BUILD_CFLAGS to a number of recipes
Date: Sun, 3 May 2020 23:00:00 +0300 [thread overview]
Message-ID: <20200503200000.GC25055@localhost> (raw)
In-Reply-To: <20200503082640.3686916-1-daniel@zonque.org>
On Sun, May 03, 2020 at 10:26:40AM +0200, Daniel Mack wrote:
> When building on a gcc 10 enabled host distribution (such as Fedora 32),
> a number of recipies need explicit treatment to enable '-fcommon' in
> BUILD_CFLAGS. There might be more of those fixes needed.
>...
These are not fixes, just workarounds.
Adding upstream fixes would be preferable to adding workarounds.
> --- a/meta/recipes-devtools/pseudo/pseudo.inc
> +++ b/meta/recipes-devtools/pseudo/pseudo.inc
> @@ -15,6 +15,8 @@ INSANE_SKIP_${PN}-dbg += "libdir"
>
> PROVIDES += "virtual/fakeroot"
>
> +BUILD_CFLAGS += "-fcommon"
> +
>...
Yocto is upstream for pseudo, is there anything non-trivial required
for a proper fix?
> --- a/meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb
> +++ b/meta/recipes-devtools/squashfs-tools/squashfs-tools_git.bb
> @@ -12,6 +12,7 @@ SRC_URI = "git://github.com/plougher/squashfs-tools.git;protocol=https \
>
> S = "${WORKDIR}/git/squashfs-tools"
>
> +BUILD_CFLAGS += "-fcommon"
>...
The upstream fix is a trivial one-liner that should be backported instead:
https://github.com/plougher/squashfs-tools/commit/fe2f5da4b0f8994169c53e84b7cb8a0feefc97b5
cu
Adrian
next prev parent reply other threads:[~2020-05-03 20:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 8:26 [PATCH] Add -fcommon to BUILD_CFLAGS to a number of recipes daniel
2020-05-03 8:32 ` ✗ patchtest: failure for " Patchwork
2020-05-03 10:04 ` [OE-core] [PATCH] " Richard Purdie
2020-05-03 10:55 ` Daniel Mack
2020-05-03 20:00 ` Adrian Bunk [this message]
[not found] <20200503080730.3686063-1-daniel@zonque.org>
2020-05-03 17:39 ` Khem Raj
2020-05-03 19:21 ` [OE-core] " Andre McCurdy
2020-05-04 17:46 ` Khem Raj
2020-05-06 7:22 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200503200000.GC25055@localhost \
--to=bunk@stusta.de \
--cc=daniel@zonque.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox