From: "Adrian Bunk" <bunk@stusta.de>
To: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] Add -fcommon to BUILD_CFLAGS to a number of recipes
Date: Wed, 6 May 2020 10:22:40 +0300 [thread overview]
Message-ID: <20200506072240.GB31672@localhost> (raw)
In-Reply-To: <CAJ86T=XKmHH2geeKudRLuTox2TOz3njdic5hiBSeX8hDRxUbDA@mail.gmail.com>
On Sun, May 03, 2020 at 12:21:38PM -0700, Andre McCurdy wrote:
> On Sun, May 3, 2020 at 10:39 AM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > I think add it globally to BUILD_CFLAGS perhaps is
> > Right thing to do once we upgrade to gcc10 cross compiler I have a patch to add it to gcc defaults
>
> Adding -fcommon to CFLAGS or BUILD_CFLAGS globally could interact
> badly with components which are already setting -fno-common via their
> own internal CFLAGS. It's safer to fix selectively on a per-recipe
> basis.
>...
For master per-recipe solutions would be the best option.
And for the target side this is all that is needed.
The problematic part is the host side when building older Yocto releases
on latest Linux distributions.
Per-recipe changes for dunfell oe-core and gazillion 3rd party
dunfell layers are not a desirable solution.
cu
Adrian
next prev parent reply other threads:[~2020-05-06 9:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200503080730.3686063-1-daniel@zonque.org>
2020-05-03 17:39 ` [PATCH] Add -fcommon to BUILD_CFLAGS to a number of recipes Khem Raj
2020-05-03 19:21 ` [OE-core] " Andre McCurdy
2020-05-04 17:46 ` Khem Raj
2020-05-06 7:22 ` Adrian Bunk [this message]
2020-05-03 8:26 daniel
2020-05-03 10:04 ` [OE-core] " Richard Purdie
2020-05-03 10:55 ` Daniel Mack
2020-05-03 20:00 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506072240.GB31672@localhost \
--to=bunk@stusta.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox