From: "Seebs" <seebs@seebs.net>
To: Jacob Kroon <jacob.kroon@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [pseudo][PATCH] pseudo_ipc.h: Fix enum typedef
Date: Fri, 8 May 2020 09:04:30 -0500 [thread overview]
Message-ID: <20200508090430.686c8f88@seebsdell> (raw)
In-Reply-To: <b554cabf-b8dd-5cf2-40ca-9aa5ffc53834@gmail.com>
On Fri, 8 May 2020 08:09:58 +0200
Jacob Kroon <jacob.kroon@gmail.com> wrote:
> Hi Peter,
>
> On 5/3/20 6:26 PM, Seebs wrote:
> > On Sun, 3 May 2020 17:49:09 +0200
> > "Jacob Kroon" <jacob.kroon@gmail.com> wrote:
> >
> >> The type has never been used, so an alternative fix would be to get
> >> rid of it altogether, and just keep the enum identifiers.
> >
> > I think I anticipated the type being used for something but it did
> > indeed not happen. It could also just be changed to 'enum [type]
> > { ... }', I guess.
> >
> > But I think your fix is the simplest and closest to what I probably
> > thought I was doing at the time.
> >
>
> Do you have any plans on merging this, and also the pending patches
> in oe-core, anytime soon ? Then we could bump the pseudo git rev in
> oe-core and remove those patches, if not then I can add the patch to
> the pseudo recipe. Any way you'd prefer ?
It probably makes sense to add things to the pseudo recipe for now, I'm
still trying to catch up on my task backlog from March.
-s
prev parent reply other threads:[~2020-05-08 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 4:27 [pseudo][PATCH] pseudo_ipc.h: Fix enum typedef Jacob Kroon
2020-05-03 4:32 ` ✗ patchtest: failure for " Patchwork
2020-05-03 5:04 ` Jacob Kroon
2020-05-03 5:28 ` [OE-core] [pseudo][PATCH] " Seebs
2020-05-03 15:49 ` Jacob Kroon
2020-05-03 16:26 ` Seebs
2020-05-08 6:09 ` Jacob Kroon
2020-05-08 14:04 ` Seebs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508090430.686c8f88@seebsdell \
--to=seebs@seebs.net \
--cc=jacob.kroon@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox