From: "Jacob Kroon" <jacob.kroon@gmail.com>
To: Seebs <seebs@seebs.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [pseudo][PATCH] pseudo_ipc.h: Fix enum typedef
Date: Sun, 3 May 2020 17:49:09 +0200 [thread overview]
Message-ID: <e8a9982b-1412-087f-b8ac-283b657106aa@gmail.com> (raw)
In-Reply-To: <20200503002852.1273f3a1@seebsdell>
On 5/3/20 7:28 AM, Seebs wrote:
> On Sun, 3 May 2020 06:27:12 +0200
> "Jacob Kroon" <jacob.kroon@gmail.com> wrote:
>
>> 'pseudo_access_t' is a type, so use typedef.
>>
>> Fixes building pseudo with gcc 10 where -fno-common is the default.
>
> Wow! That's amazing, and yes, that's a bug, and the fix looks right to
> me. I don't know how that got missed all these years. (But don't rely
> on this evaluation too heavily just yet, I haven't actually looked at
> the code more carefully, but this seems obvious.)
>
> -s
>
The type has never been used, so an alternative fix would be to get rid
of it altogether, and just keep the enum identifiers.
/Jacob
next prev parent reply other threads:[~2020-05-03 15:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 4:27 [pseudo][PATCH] pseudo_ipc.h: Fix enum typedef Jacob Kroon
2020-05-03 4:32 ` ✗ patchtest: failure for " Patchwork
2020-05-03 5:04 ` Jacob Kroon
2020-05-03 5:28 ` [OE-core] [pseudo][PATCH] " Seebs
2020-05-03 15:49 ` Jacob Kroon [this message]
2020-05-03 16:26 ` Seebs
2020-05-08 6:09 ` Jacob Kroon
2020-05-08 14:04 ` Seebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8a9982b-1412-087f-b8ac-283b657106aa@gmail.com \
--to=jacob.kroon@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=seebs@seebs.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox