[V2][oe-core][PATCH 1/1] vim: _FORTIFY_SOURCE=2 be gone

[V2][oe-core][PATCH 1/1] vim: _FORTIFY_SOURCE=2 be gone

[Joe Slater]

vim will abort in many places with this setting.  Replace
it with the benign _FORTIFY_SOURCE=1.

Signed-off-by: Joe Slater <joe.slater@windriver.com>
---
 meta/recipes-support/vim/vim_8.2.bb | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/recipes-support/vim/vim_8.2.bb b/meta/recipes-support/vim/vim_8.2.bb
index 60946a181f..709b6ddb55 100644
--- a/meta/recipes-support/vim/vim_8.2.bb
+++ b/meta/recipes-support/vim/vim_8.2.bb
@@ -8,3 +8,8 @@ BBCLASSEXTEND = "native"
 ALTERNATIVE_${PN}_append = " xxd"
 ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
 ALTERNATIVE_LINK_NAME[xxd] = "${bindir}/xxd"
+
+# We override the default in security_flags.inc because vim (not vim-tiny!) will abort
+# in many places for _FORTIFY_SOURCE=2.  Security flags become part of CC.
+#
+lcl_maybe_fortify = "${@oe.utils.conditional('DEBUG_BUILD','1','','-D_FORTIFY_SOURCE=1',d)}"
-- 
2.17.1

Re: [V2][oe-core][PATCH 1/1] vim: _FORTIFY_SOURCE=2 be gone

[Andre McCurdy]

On Tue, Jun 9, 2020 at 3:46 PM Joe Slater <joe.slater@windriver.com> wrote:
>
> vim will abort in many places with this setting.  Replace
> it with the benign _FORTIFY_SOURCE=1.
>
> Signed-off-by: Joe Slater <joe.slater@windriver.com>
> ---
>  meta/recipes-support/vim/vim_8.2.bb | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-support/vim/vim_8.2.bb b/meta/recipes-support/vim/vim_8.2.bb
> index 60946a181f..709b6ddb55 100644
> --- a/meta/recipes-support/vim/vim_8.2.bb
> +++ b/meta/recipes-support/vim/vim_8.2.bb
> @@ -8,3 +8,8 @@ BBCLASSEXTEND = "native"
>  ALTERNATIVE_${PN}_append = " xxd"
>  ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
>  ALTERNATIVE_LINK_NAME[xxd] = "${bindir}/xxd"
> +
> +# We override the default in security_flags.inc because vim (not vim-tiny!) will abort
> +# in many places for _FORTIFY_SOURCE=2.  Security flags become part of CC.
> +#
> +lcl_maybe_fortify = "${@oe.utils.conditional('DEBUG_BUILD','1','','-D_FORTIFY_SOURCE=1',d)}"

"lcl_maybe_fortify" was supposed to be a private local variable in
security_flags.inc. If it's now a documented global variable which
recipes are allowed to mess with, it should be renamed (e.g.
capitalised and the lcl_ prefix removed).

✗ patchtest: failure for [V2] vim: _FORTIFY_SOURCE=2 be gone (rev2)

[Patchwork]

== Series Details ==

Series: [V2] vim: _FORTIFY_SOURCE=2 be gone (rev2)
Revision: 2
URL   : https://patchwork.openembedded.org/series/24510/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 0d28b963d9)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [V2][oe-core][PATCH 1/1] vim: _FORTIFY_SOURCE=2 be gone

[Joe Slater]

Yes, as to lcl_maybe_fortify() being visible, but why the "?=" ?  Maybe, the security flags
Should have a pn-vim entry.  I don't like that.  Maybe the vim recipe should modify lcl_maybe_fortify()
but I really don't like that either.  Still, vim should be useable.  What I do not understand is why
this has not been reported.  Is everybody using the vi provided by busybox?

Joe

-----Original Message-----
From: Andre McCurdy <armccurdy@gmail.com> 
Sent: Tuesday, June 9, 2020 3:59 PM
To: Slater, Joseph <joe.slater@windriver.com>
Cc: OE Core mailing list <openembedded-core@lists.openembedded.org>; MacLeod, Randy <Randy.MacLeod@windriver.com>
Subject: Re: [V2][oe-core][PATCH 1/1] vim: _FORTIFY_SOURCE=2 be gone

On Tue, Jun 9, 2020 at 3:46 PM Joe Slater <joe.slater@windriver.com> wrote:
>
> vim will abort in many places with this setting.  Replace it with the 
> benign _FORTIFY_SOURCE=1.
>
> Signed-off-by: Joe Slater <joe.slater@windriver.com>
> ---
>  meta/recipes-support/vim/vim_8.2.bb | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-support/vim/vim_8.2.bb 
> b/meta/recipes-support/vim/vim_8.2.bb
> index 60946a181f..709b6ddb55 100644
> --- a/meta/recipes-support/vim/vim_8.2.bb
> +++ b/meta/recipes-support/vim/vim_8.2.bb
> @@ -8,3 +8,8 @@ BBCLASSEXTEND = "native"
>  ALTERNATIVE_${PN}_append = " xxd"
>  ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
>  ALTERNATIVE_LINK_NAME[xxd] = "${bindir}/xxd"
> +
> +# We override the default in security_flags.inc because vim (not 
> +vim-tiny!) will abort # in many places for _FORTIFY_SOURCE=2.  Security flags become part of CC.
> +#
> +lcl_maybe_fortify = "${@oe.utils.conditional('DEBUG_BUILD','1','','-D_FORTIFY_SOURCE=1',d)}"

"lcl_maybe_fortify" was supposed to be a private local variable in security_flags.inc. If it's now a documented global variable which recipes are allowed to mess with, it should be renamed (e.g.
capitalised and the lcl_ prefix removed).