[OE-core][PATCH] allarch: Fix wrong dependencies

[OE-core][PATCH] allarch: Fix wrong dependencies

[Daniel Gomez]

In all these cases, allarch is used but the package dependencies are not
allarch. It generates a conflict when the same package is built for different
MACHINES at the same time.

Here a build error for the ttf-ubuntu-font-family in a multiconfig enviroment:

ERROR: mc:qt5507:ttf-ubuntu-font-family-0.83-r1
do_package_write_deb:
Fatal errors occurred in subprocesses:
Command
'PATH="/workdir/build/tmp/sysroots-uninative/x86_64-linux/usr/bin:/workdir/repo/poky/scripts:/workdir/build/tmp/work/all-poky-linux/ttf-ubuntu-font-family/0.83-r1/recipe-sysroot-native/usr/bin/allarch-poky-linux:/workdir/build/tmp/work/all-poky-linux/ttf-ubuntu-font-family/0.83-r1/recipe-sysroot/usr/bin/crossscripts:/workdir/build/tmp/work/all-poky-linux/ttf-ubuntu-font-family/0.83-r1/recipe-sysroot-native/usr/sbin:/workdir/build/tmp/work/all-poky-linux/ttf-ubuntu-font-family/0.83-r1/recipe-sysroot-native/usr/bin:/workdir/build/tmp/work/all-poky-linux/ttf-ubuntu-font-family/0.83-r1/recipe-sysroot-native/sbin:/workdir/build/tmp/work/all-poky-linux/ttf-ubuntu-font-family/0.83-r1/recipe-sysroot-native/bin:/workdir/repo/poky/bitbake/bin:/workdir/build/tmp/hosttools"
dpkg-deb -b
/workdir/build/tmp/work/all-poky-linux/ttf-ubuntu-font-family/0.83-r1/packages-split/ttf-ubuntu-sans
/workdir/build/tmp/work/all-poky-linux/ttf-ubuntu-font-family/0.83-r1/deploy-debs/all'
returned non-zero exit status 2
Subprocess output:dpkg-deb: building package 'ttf-ubuntu-sans' in
'/workdir/build/tmp/work/all-poky-linux/ttf-ubuntu-font-family/0.83-r1/deploy-debs/all'.
dpkg-deb: error: unable to create
'/workdir/build/tmp/work/all-poky-linux/ttf-ubuntu-font-family/0.83-r1/deploy-debs/all':
No such file or directory

ERROR: mc:qt5507:ttf-ubuntu-font-family-0.83-r1
do_package_write_deb:
ERROR: mc:qt5507:ttf-ubuntu-font-family-0.83-r1
do_package_write_deb:
Function failed: do_package_deb
ERROR: Logfile of failure stored in:
/workdir/build/tmp/work/all-poky-linux/ttf-ubuntu-font-family/0.83-r1/temp/log.do_package_write_deb.11826
NOTE: recipe ttf-ubuntu-font-family-0.83-r1: task
do_package_write_deb:
Failed
ERROR: Task
(multiconfig:qt5507:/workdir/repo/poky/../meta-qtec-hockey/recipes-graphics/ttf-fonts/ttf-ubuntu-font-family_0.83.bb:do_package_write_deb)
failed with exit code '1'

Similar patch:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-graphics/ttf-fonts?id=0d9f7900dec4ec68d8ad6c8a455e5b4f068e3715

Signed-off-by: Daniel Gomez <daniel@qtec.com>
---
 meta-oe/recipes-graphics/terminus-font/terminus-font_4.38.bb    | 2 +-
 .../ttf-fonts/source-han-sans-cn-fonts_1.004.bb                 | 2 +-
 .../ttf-fonts/source-han-sans-jp-fonts_1.004.bb                 | 2 +-
 .../ttf-fonts/source-han-sans-kr-fonts_1.004.bb                 | 2 +-
 .../ttf-fonts/source-han-sans-tw-fonts_1.004.bb                 | 2 +-
 meta-oe/recipes-graphics/ttf-fonts/ttf-pt-sans_1.1.bb           | 2 +-
 meta-oe/recipes-graphics/ttf-fonts/ttf.inc                      | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/meta-oe/recipes-graphics/terminus-font/terminus-font_4.38.bb b/meta-oe/recipes-graphics/terminus-font/terminus-font_4.38.bb
index c460fc35c..23a73b37b 100644
--- a/meta-oe/recipes-graphics/terminus-font/terminus-font_4.38.bb
+++ b/meta-oe/recipes-graphics/terminus-font/terminus-font_4.38.bb
@@ -14,7 +14,7 @@ SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BPN}-${PV}.tar.gz"
 SRC_URI[md5sum] = "a8e792fe6e84c86ed2b6ed3e2a12ba66"
 SRC_URI[sha256sum] = "f6f4876a4dabe6a37c270c20bb9e141e38fb50e0bba200e1b9d0470e5eed97b7"

-inherit allarch fontcache
+inherit fontcache

 PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)}"
 PACKAGECONFIG[x11] = ""
diff --git a/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-cn-fonts_1.004.bb b/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-cn-fonts_1.004.bb
index 9fbfc8b49..04ab188e6 100644
--- a/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-cn-fonts_1.004.bb
+++ b/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-cn-fonts_1.004.bb
@@ -5,7 +5,7 @@ HOMEPAGE = "https://github.com/adobe-fonts/source-han-sans"
 LICENSE = "OFL-1.1"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=55719faa0112708e946b820b24b14097"

-inherit allarch fontcache
+inherit fontcache

 # Download tends to break - so - or not?
 #EXCLUDE_FROM_WORLD = "1"
diff --git a/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-jp-fonts_1.004.bb b/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-jp-fonts_1.004.bb
index 4a26a2f57..bb54e8aa5 100644
--- a/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-jp-fonts_1.004.bb
+++ b/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-jp-fonts_1.004.bb
@@ -5,7 +5,7 @@ HOMEPAGE = "https://github.com/adobe-fonts/source-han-sans"
 LICENSE = "OFL-1.1"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=55719faa0112708e946b820b24b14097"

-inherit allarch fontcache
+inherit fontcache

 # Download tends to break - so - or not?
 #EXCLUDE_FROM_WORLD = "1"
diff --git a/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-kr-fonts_1.004.bb b/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-kr-fonts_1.004.bb
index c91d1671f..52df396da 100644
--- a/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-kr-fonts_1.004.bb
+++ b/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-kr-fonts_1.004.bb
@@ -5,7 +5,7 @@ HOMEPAGE = "https://github.com/adobe-fonts/source-han-sans"
 LICENSE = "OFL-1.1"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=55719faa0112708e946b820b24b14097"

-inherit allarch fontcache
+inherit fontcache

 # Download tends to break - so - or not?
 #EXCLUDE_FROM_WORLD = "1"
diff --git a/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-tw-fonts_1.004.bb b/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-tw-fonts_1.004.bb
index 728250538..3586836e6 100644
--- a/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-tw-fonts_1.004.bb
+++ b/meta-oe/recipes-graphics/ttf-fonts/source-han-sans-tw-fonts_1.004.bb
@@ -5,7 +5,7 @@ HOMEPAGE = "https://github.com/adobe-fonts/source-han-sans"
 LICENSE = "OFL-1.1"
 LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=55719faa0112708e946b820b24b14097"

-inherit allarch fontcache
+inherit fontcache

 # Download tends to break - so - or not?
 #EXCLUDE_FROM_WORLD = "1"
diff --git a/meta-oe/recipes-graphics/ttf-fonts/ttf-pt-sans_1.1.bb b/meta-oe/recipes-graphics/ttf-fonts/ttf-pt-sans_1.1.bb
index ac60a365f..ee5cf6b3a 100644
--- a/meta-oe/recipes-graphics/ttf-fonts/ttf-pt-sans_1.1.bb
+++ b/meta-oe/recipes-graphics/ttf-fonts/ttf-pt-sans_1.1.bb
@@ -7,7 +7,7 @@ SECTION = "x11/fonts"
 LICENSE = "ParaTypeFFL-1.3"
 LIC_FILES_CHKSUM = "file://../PT%20Free%20Font%20License_eng.txt;md5=d720f3a281ed81c3f4cfc465e11b1d0d"

-inherit allarch fontcache
+inherit fontcache

 # Downloading from fedora because upstream doesn't version its zip file
 # and causes hash build failures
diff --git a/meta-oe/recipes-graphics/ttf-fonts/ttf.inc b/meta-oe/recipes-graphics/ttf-fonts/ttf.inc
index c77af3993..9faa43a07 100644
--- a/meta-oe/recipes-graphics/ttf-fonts/ttf.inc
+++ b/meta-oe/recipes-graphics/ttf-fonts/ttf.inc
@@ -9,4 +9,4 @@ do_install() {
     find ./ -name '*.tt[cf]' -exec install -m 0644 {} ${D}${datadir}/fonts/truetype/ \;
 }

-inherit allarch fontcache
+inherit fontcache
--
2.27.0

Re: [OE-core][PATCH] allarch: Fix wrong dependencies

[Richard Purdie]

On Wed, 2020-08-05 at 15:22 +0200, Daniel Gomez wrote:
> In all these cases, allarch is used but the package dependencies are not
> allarch. It generates a conflict when the same package is built for different
> MACHINES at the same time.
> 
> Here a build error for the ttf-ubuntu-font-family in a multiconfig enviroment:

This is on the wrong mailing list. I also thought there was code
somewhere to remove font dependencies from changing the task
signatures?

http://git.yoctoproject.org/cgit.cgi/poky/tree/meta/conf/layer.conf

see the lines like:

liberation-fonts->fontconfig \
cantarell-fonts->fontconfig \

Perhaps meta-oe has some of those missing?

Cheers,

Richard

✗ patchtest: failure for allarch: Fix wrong dependencies

[Patchwork]

== Series Details ==

Series: allarch: Fix wrong dependencies
Revision: 1
URL   : https://patchwork.openembedded.org/series/25470/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series sent to the wrong mailing list or some patches from the series correspond to different mailing lists [test_target_mailing_list] 
  Suggested fix    Send the series again to the correct mailing list (ML)
  Suggested ML     openembedded-devel@lists.openembedded.org [http://git.openembedded.org/meta-openembedded/]
  Patch's path:    meta-oe/recipes-graphics/terminus-font/terminus-font_4.38.bb

* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 10221e578f)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [OE-core][PATCH] allarch: Fix wrong dependencies

[Daniel Gomez]

Hi Richard,

On Wed, 5 Aug 2020 at 15:31, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Wed, 2020-08-05 at 15:22 +0200, Daniel Gomez wrote:
> > In all these cases, allarch is used but the package dependencies are not
> > allarch. It generates a conflict when the same package is built for different
> > MACHINES at the same time.
> >
> > Here a build error for the ttf-ubuntu-font-family in a multiconfig enviroment:
>
> This is on the wrong mailing list. I also thought there was code
> somewhere to remove font dependencies from changing the task
> signatures?
Sorry! I mixed the lists.
>
> http://git.yoctoproject.org/cgit.cgi/poky/tree/meta/conf/layer.conf
>
> see the lines like:
>
> liberation-fonts->fontconfig \
> cantarell-fonts->fontconfig \
>
> Perhaps meta-oe has some of those missing?
I didn't notice about that SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS list and looks like
meta-oe already implements it so, what we actually need is to include
that recipe in our layer
conf.

On the other hand, I think the following recipes are missing the
inherit allarch:
meta/recipes-graphics/ttf-fonts/ttf-bitstream-vera_1.10.bb
meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
meta/recipes-graphics/ttf-fonts/liberation-fonts_2.00.1.bb

And then, add the ttf-bitstream-vera recipe as part of the
SIGGEN_EXCLUDE_SAFE_RECIPE_DEPS.

Will send a patch to fix it.

Thanks!
>
> Cheers,
>
> Richard
>