* [PATCH] lttng-tools: Do not build for riscv64
@ 2020-08-26 5:41 Khem Raj
2020-08-26 14:00 ` [OE-core] " Jonathan Rajotte-Julien
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2020-08-26 5:41 UTC (permalink / raw)
To: openembedded-core; +Cc: Khem Raj
Since lttng-modules are not buildable, there is no point of building
tools either
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
.../packagegroups/packagegroup-core-tools-profile.bb | 1 +
meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb | 3 +++
2 files changed, 4 insertions(+)
diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
index ca35af1ec3..608e406f83 100644
--- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
+++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
@@ -41,6 +41,7 @@ LTTNGUST_arc = ""
LTTNGTOOLS = "lttng-tools"
LTTNGTOOLS_arc = ""
+LTTNGTOOLS_riscv64 = ""
LTTNGMODULES = "lttng-modules"
LTTNGMODULES_arc = ""
diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb b/meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb
index e9c8e18e22..0614e86713 100644
--- a/meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb
+++ b/meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb
@@ -162,3 +162,6 @@ do_install_ptest () {
esac
done
}
+
+COMPATIBLE_HOST_riscv64 = "null"
+
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [OE-core] [PATCH] lttng-tools: Do not build for riscv64
2020-08-26 5:41 [PATCH] lttng-tools: Do not build for riscv64 Khem Raj
@ 2020-08-26 14:00 ` Jonathan Rajotte-Julien
2020-08-27 2:16 ` Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Jonathan Rajotte-Julien @ 2020-08-26 14:00 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
Hi,
LTTng does not have a hard requirement on lttng-modules (on paper), when kernel modules
(tracer) is not present kernel tracing is disabled and only userspace tracing is
available.
Was there any report that lttng-ust (userspace tracing) is not working as
intended on riscv64?
Cheers
On Tue, Aug 25, 2020 at 10:41:01PM -0700, Khem Raj wrote:
> Since lttng-modules are not buildable, there is no point of building
> tools either
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> .../packagegroups/packagegroup-core-tools-profile.bb | 1 +
> meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> index ca35af1ec3..608e406f83 100644
> --- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> +++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
> @@ -41,6 +41,7 @@ LTTNGUST_arc = ""
>
> LTTNGTOOLS = "lttng-tools"
> LTTNGTOOLS_arc = ""
> +LTTNGTOOLS_riscv64 = ""
>
> LTTNGMODULES = "lttng-modules"
> LTTNGMODULES_arc = ""
> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb b/meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb
> index e9c8e18e22..0614e86713 100644
> --- a/meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb
> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb
> @@ -162,3 +162,6 @@ do_install_ptest () {
> esac
> done
> }
> +
> +COMPATIBLE_HOST_riscv64 = "null"
> +
> --
> 2.28.0
>
>
--
Jonathan Rajotte-Julien
EfficiOS
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [OE-core] [PATCH] lttng-tools: Do not build for riscv64
2020-08-26 14:00 ` [OE-core] " Jonathan Rajotte-Julien
@ 2020-08-27 2:16 ` Khem Raj
2020-08-27 8:21 ` Ross Burton
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2020-08-27 2:16 UTC (permalink / raw)
To: Jonathan Rajotte-Julien; +Cc: openembedded-core
On 8/26/20 7:00 AM, Jonathan Rajotte-Julien wrote:
> Hi,
>
> LTTng does not have a hard requirement on lttng-modules (on paper), when kernel modules
> (tracer) is not present kernel tracing is disabled and only userspace tracing is
> available.
>
> Was there any report that lttng-ust (userspace tracing) is not working as
> intended on riscv64?
No, but lttng-tools have this as rdep for ptest packages which is not
controlled via packageconfig or something.
>
> Cheers
>
> On Tue, Aug 25, 2020 at 10:41:01PM -0700, Khem Raj wrote:
>> Since lttng-modules are not buildable, there is no point of building
>> tools either
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> .../packagegroups/packagegroup-core-tools-profile.bb | 1 +
>> meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb | 3 +++
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
>> index ca35af1ec3..608e406f83 100644
>> --- a/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
>> +++ b/meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb
>> @@ -41,6 +41,7 @@ LTTNGUST_arc = ""
>>
>> LTTNGTOOLS = "lttng-tools"
>> LTTNGTOOLS_arc = ""
>> +LTTNGTOOLS_riscv64 = ""
>>
>> LTTNGMODULES = "lttng-modules"
>> LTTNGMODULES_arc = ""
>> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb b/meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb
>> index e9c8e18e22..0614e86713 100644
>> --- a/meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb
>> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.12.2.bb
>> @@ -162,3 +162,6 @@ do_install_ptest () {
>> esac
>> done
>> }
>> +
>> +COMPATIBLE_HOST_riscv64 = "null"
>> +
>> --
>> 2.28.0
>>
>
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [OE-core] [PATCH] lttng-tools: Do not build for riscv64
2020-08-27 2:16 ` Khem Raj
@ 2020-08-27 8:21 ` Ross Burton
2020-08-27 8:43 ` Richard Purdie
0 siblings, 1 reply; 5+ messages in thread
From: Ross Burton @ 2020-08-27 8:21 UTC (permalink / raw)
To: Khem Raj; +Cc: Jonathan Rajotte-Julien, OE-core
On Thu, 27 Aug 2020 at 03:17, Khem Raj <raj.khem@gmail.com> wrote:
> > LTTng does not have a hard requirement on lttng-modules (on paper), when kernel modules
> > (tracer) is not present kernel tracing is disabled and only userspace tracing is
> > available.
> >
> > Was there any report that lttng-ust (userspace tracing) is not working as
> > intended on riscv64?
>
> No, but lttng-tools have this as rdep for ptest packages which is not
> controlled via packageconfig or something.
Make it a recommends instead?
Ross
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core] [PATCH] lttng-tools: Do not build for riscv64
2020-08-27 8:21 ` Ross Burton
@ 2020-08-27 8:43 ` Richard Purdie
0 siblings, 0 replies; 5+ messages in thread
From: Richard Purdie @ 2020-08-27 8:43 UTC (permalink / raw)
To: Ross Burton, Khem Raj; +Cc: Jonathan Rajotte-Julien, OE-core
On Thu, 2020-08-27 at 09:21 +0100, Ross Burton wrote:
> On Thu, 27 Aug 2020 at 03:17, Khem Raj <raj.khem@gmail.com> wrote:
> > > LTTng does not have a hard requirement on lttng-modules (on
> > > paper), when kernel modules
> > > (tracer) is not present kernel tracing is disabled and only
> > > userspace tracing is
> > > available.
> > >
> > > Was there any report that lttng-ust (userspace tracing) is not
> > > working as
> > > intended on riscv64?
> >
> > No, but lttng-tools have this as rdep for ptest packages which is
> > not
> > controlled via packageconfig or something.
>
> Make it a recommends instead?
Those are still fatal from a build providers perspective...
Sounds to me like we should move the conditional skipping in lttng-
modules somewhere lttng-tools can also see it, then use that in the
RDEPENDS_lttng-tools-ptest...
Cheers,
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-27 8:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-26 5:41 [PATCH] lttng-tools: Do not build for riscv64 Khem Raj
2020-08-26 14:00 ` [OE-core] " Jonathan Rajotte-Julien
2020-08-27 2:16 ` Khem Raj
2020-08-27 8:21 ` Ross Burton
2020-08-27 8:43 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox