public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
* [PATCH] runqemu: Change virtio-vga to virtio-gpu.
@ 2020-08-30 20:15 Vasyl Vavrychuk
  2020-08-30 20:43 ` [OE-core] " Alexander Kanavin
  0 siblings, 1 reply; 7+ messages in thread
From: Vasyl Vavrychuk @ 2020-08-30 20:15 UTC (permalink / raw)
  To: openembedded-core; +Cc: Vasyl Vavrychuk

virtio-vga is available in QEMU only for hppa, i386, and ppc
architectures. On the other hand, virtio-gpu is available for all
architectures.

Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
---
 scripts/runqemu | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/scripts/runqemu b/scripts/runqemu
index 7fb5f7db57..5d6b35ffe4 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -461,19 +461,19 @@ class BaseConfig(object):
             elif arg == 'sdl':
                 if 'gl' in sys.argv[1:]:
                     self.set_dri_path()
-                    self.qemu_opt_script += ' -vga virtio -display sdl,gl=on,show-cursor=on'
+                    self.qemu_opt_script += ' -device virtio-gpu -display sdl,gl=on,show-cursor=on'
                 elif 'gl-es' in sys.argv[1:]:
                     self.set_dri_path()
-                    self.qemu_opt_script += ' -vga virtio -display sdl,gl=es,show-cursor=on'
+                    self.qemu_opt_script += ' -device virtio-gpu -display sdl,gl=es,show-cursor=on'
                 else:
                     self.qemu_opt_script += ' -display sdl,show-cursor=on'
             elif arg == 'gtk':
                 if 'gl' in sys.argv[1:]:
                     self.set_dri_path()
-                    self.qemu_opt_script += ' -vga virtio -display gtk,gl=on,show-cursor=on'
+                    self.qemu_opt_script += ' -device virtio-gpu -display gtk,gl=on,show-cursor=on'
                 elif 'gl-es' in sys.argv[1:]:
                     self.set_dri_path()
-                    self.qemu_opt_script += ' -vga virtio -display gtk,gl=es,show-cursor=on'
+                    self.qemu_opt_script += ' -device virtio-gpu -display gtk,gl=es,show-cursor=on'
                 else:
                     self.qemu_opt_script += ' -display gtk,show-cursor=on'
             elif arg == 'gl' or arg == 'gl-es':
@@ -482,7 +482,7 @@ class BaseConfig(object):
                     raise RunQemuError('Option %s also needs gtk or sdl option.' % (arg))
             elif arg == 'egl-headless':
                 self.set_dri_path()
-                self.qemu_opt_script += ' -vga virtio -display egl-headless,show-cursor=on'
+                self.qemu_opt_script += ' -device virtio-gpu -display egl-headless,show-cursor=on'
             elif arg == 'serial':
                 self.kernel_cmdline_script += ' console=ttyS0'
                 self.serialconsole = True
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [OE-core] [PATCH] runqemu: Change virtio-vga to virtio-gpu.
  2020-08-30 20:15 [PATCH] runqemu: Change virtio-vga to virtio-gpu Vasyl Vavrychuk
@ 2020-08-30 20:43 ` Alexander Kanavin
  2020-10-30 12:38   ` Vasyl Vavrychuk
  2020-11-05  9:52   ` Vasyl Vavrychuk
  0 siblings, 2 replies; 7+ messages in thread
From: Alexander Kanavin @ 2020-08-30 20:43 UTC (permalink / raw)
  To: Vasyl Vavrychuk; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 2940 bytes --]

Do the virgl selftests still pass with this change? Please run

oe-selftest -r runtime_test.TestImage.test_testimage_virgl_gtk_sdl

and

oe-selftest -r runtime_test.TestImage.test_testimage_virgl_headless

Alex


On Sun, 30 Aug 2020 at 22:15, Vasyl Vavrychuk <vvavrychuk@gmail.com> wrote:

> virtio-vga is available in QEMU only for hppa, i386, and ppc
> architectures. On the other hand, virtio-gpu is available for all
> architectures.
>
> Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
> ---
>  scripts/runqemu | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 7fb5f7db57..5d6b35ffe4 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -461,19 +461,19 @@ class BaseConfig(object):
>              elif arg == 'sdl':
>                  if 'gl' in sys.argv[1:]:
>                      self.set_dri_path()
> -                    self.qemu_opt_script += ' -vga virtio -display
> sdl,gl=on,show-cursor=on'
> +                    self.qemu_opt_script += ' -device virtio-gpu -display
> sdl,gl=on,show-cursor=on'
>                  elif 'gl-es' in sys.argv[1:]:
>                      self.set_dri_path()
> -                    self.qemu_opt_script += ' -vga virtio -display
> sdl,gl=es,show-cursor=on'
> +                    self.qemu_opt_script += ' -device virtio-gpu -display
> sdl,gl=es,show-cursor=on'
>                  else:
>                      self.qemu_opt_script += ' -display sdl,show-cursor=on'
>              elif arg == 'gtk':
>                  if 'gl' in sys.argv[1:]:
>                      self.set_dri_path()
> -                    self.qemu_opt_script += ' -vga virtio -display
> gtk,gl=on,show-cursor=on'
> +                    self.qemu_opt_script += ' -device virtio-gpu -display
> gtk,gl=on,show-cursor=on'
>                  elif 'gl-es' in sys.argv[1:]:
>                      self.set_dri_path()
> -                    self.qemu_opt_script += ' -vga virtio -display
> gtk,gl=es,show-cursor=on'
> +                    self.qemu_opt_script += ' -device virtio-gpu -display
> gtk,gl=es,show-cursor=on'
>                  else:
>                      self.qemu_opt_script += ' -display gtk,show-cursor=on'
>              elif arg == 'gl' or arg == 'gl-es':
> @@ -482,7 +482,7 @@ class BaseConfig(object):
>                      raise RunQemuError('Option %s also needs gtk or sdl
> option.' % (arg))
>              elif arg == 'egl-headless':
>                  self.set_dri_path()
> -                self.qemu_opt_script += ' -vga virtio -display
> egl-headless,show-cursor=on'
> +                self.qemu_opt_script += ' -device virtio-gpu -display
> egl-headless,show-cursor=on'
>              elif arg == 'serial':
>                  self.kernel_cmdline_script += ' console=ttyS0'
>                  self.serialconsole = True
> --
> 2.23.0
>
> 
>

[-- Attachment #2: Type: text/html, Size: 3963 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [OE-core] [PATCH] runqemu: Change virtio-vga to virtio-gpu.
  2020-08-30 20:43 ` [OE-core] " Alexander Kanavin
@ 2020-10-30 12:38   ` Vasyl Vavrychuk
  2020-10-31 12:27     ` Alexander Kanavin
  2020-11-05  9:52   ` Vasyl Vavrychuk
  1 sibling, 1 reply; 7+ messages in thread
From: Vasyl Vavrychuk @ 2020-10-30 12:38 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: OE-core

Hi, Alexander,

I am trying to run oe-selftest.

I have one question. Is there a way to run oe-selftest incrementally?

Because for now, if I run oe-selftest second time I get

  oe-selftest - ERROR - Build directory ... already exists, aborting

Then, I should remove build-st, and only after that oe-selftest can
run second time. But it take a lot of time.

Could you please help me?

Thanks,
Vasyl

On Sun, Aug 30, 2020 at 11:44 PM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> Do the virgl selftests still pass with this change? Please run
>
> oe-selftest -r runtime_test.TestImage.test_testimage_virgl_gtk_sdl
>
> and
>
> oe-selftest -r runtime_test.TestImage.test_testimage_virgl_headless
>
> Alex
>
>
> On Sun, 30 Aug 2020 at 22:15, Vasyl Vavrychuk <vvavrychuk@gmail.com> wrote:
>>
>> virtio-vga is available in QEMU only for hppa, i386, and ppc
>> architectures. On the other hand, virtio-gpu is available for all
>> architectures.
>>
>> Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
>> ---
>>  scripts/runqemu | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/scripts/runqemu b/scripts/runqemu
>> index 7fb5f7db57..5d6b35ffe4 100755
>> --- a/scripts/runqemu
>> +++ b/scripts/runqemu
>> @@ -461,19 +461,19 @@ class BaseConfig(object):
>>              elif arg == 'sdl':
>>                  if 'gl' in sys.argv[1:]:
>>                      self.set_dri_path()
>> -                    self.qemu_opt_script += ' -vga virtio -display sdl,gl=on,show-cursor=on'
>> +                    self.qemu_opt_script += ' -device virtio-gpu -display sdl,gl=on,show-cursor=on'
>>                  elif 'gl-es' in sys.argv[1:]:
>>                      self.set_dri_path()
>> -                    self.qemu_opt_script += ' -vga virtio -display sdl,gl=es,show-cursor=on'
>> +                    self.qemu_opt_script += ' -device virtio-gpu -display sdl,gl=es,show-cursor=on'
>>                  else:
>>                      self.qemu_opt_script += ' -display sdl,show-cursor=on'
>>              elif arg == 'gtk':
>>                  if 'gl' in sys.argv[1:]:
>>                      self.set_dri_path()
>> -                    self.qemu_opt_script += ' -vga virtio -display gtk,gl=on,show-cursor=on'
>> +                    self.qemu_opt_script += ' -device virtio-gpu -display gtk,gl=on,show-cursor=on'
>>                  elif 'gl-es' in sys.argv[1:]:
>>                      self.set_dri_path()
>> -                    self.qemu_opt_script += ' -vga virtio -display gtk,gl=es,show-cursor=on'
>> +                    self.qemu_opt_script += ' -device virtio-gpu -display gtk,gl=es,show-cursor=on'
>>                  else:
>>                      self.qemu_opt_script += ' -display gtk,show-cursor=on'
>>              elif arg == 'gl' or arg == 'gl-es':
>> @@ -482,7 +482,7 @@ class BaseConfig(object):
>>                      raise RunQemuError('Option %s also needs gtk or sdl option.' % (arg))
>>              elif arg == 'egl-headless':
>>                  self.set_dri_path()
>> -                self.qemu_opt_script += ' -vga virtio -display egl-headless,show-cursor=on'
>> +                self.qemu_opt_script += ' -device virtio-gpu -display egl-headless,show-cursor=on'
>>              elif arg == 'serial':
>>                  self.kernel_cmdline_script += ' console=ttyS0'
>>                  self.serialconsole = True
>> --
>> 2.23.0
>>
>> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [OE-core] [PATCH] runqemu: Change virtio-vga to virtio-gpu.
  2020-10-30 12:38   ` Vasyl Vavrychuk
@ 2020-10-31 12:27     ` Alexander Kanavin
  2020-11-01 12:27       ` Richard Purdie
  0 siblings, 1 reply; 7+ messages in thread
From: Alexander Kanavin @ 2020-10-31 12:27 UTC (permalink / raw)
  To: Vasyl Vavrychuk; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 3970 bytes --]

I think you first need to set up a build directory to use sstate-cache in
some common location, then build-st will pick it up, and you can then
easily delete it without destroying the cache.

Alex

On Fri, 30 Oct 2020 at 13:38, Vasyl Vavrychuk <vvavrychuk@gmail.com> wrote:

> Hi, Alexander,
>
> I am trying to run oe-selftest.
>
> I have one question. Is there a way to run oe-selftest incrementally?
>
> Because for now, if I run oe-selftest second time I get
>
>   oe-selftest - ERROR - Build directory ... already exists, aborting
>
> Then, I should remove build-st, and only after that oe-selftest can
> run second time. But it take a lot of time.
>
> Could you please help me?
>
> Thanks,
> Vasyl
>
> On Sun, Aug 30, 2020 at 11:44 PM Alexander Kanavin
> <alex.kanavin@gmail.com> wrote:
> >
> > Do the virgl selftests still pass with this change? Please run
> >
> > oe-selftest -r runtime_test.TestImage.test_testimage_virgl_gtk_sdl
> >
> > and
> >
> > oe-selftest -r runtime_test.TestImage.test_testimage_virgl_headless
> >
> > Alex
> >
> >
> > On Sun, 30 Aug 2020 at 22:15, Vasyl Vavrychuk <vvavrychuk@gmail.com>
> wrote:
> >>
> >> virtio-vga is available in QEMU only for hppa, i386, and ppc
> >> architectures. On the other hand, virtio-gpu is available for all
> >> architectures.
> >>
> >> Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
> >> ---
> >>  scripts/runqemu | 10 +++++-----
> >>  1 file changed, 5 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/scripts/runqemu b/scripts/runqemu
> >> index 7fb5f7db57..5d6b35ffe4 100755
> >> --- a/scripts/runqemu
> >> +++ b/scripts/runqemu
> >> @@ -461,19 +461,19 @@ class BaseConfig(object):
> >>              elif arg == 'sdl':
> >>                  if 'gl' in sys.argv[1:]:
> >>                      self.set_dri_path()
> >> -                    self.qemu_opt_script += ' -vga virtio -display
> sdl,gl=on,show-cursor=on'
> >> +                    self.qemu_opt_script += ' -device virtio-gpu
> -display sdl,gl=on,show-cursor=on'
> >>                  elif 'gl-es' in sys.argv[1:]:
> >>                      self.set_dri_path()
> >> -                    self.qemu_opt_script += ' -vga virtio -display
> sdl,gl=es,show-cursor=on'
> >> +                    self.qemu_opt_script += ' -device virtio-gpu
> -display sdl,gl=es,show-cursor=on'
> >>                  else:
> >>                      self.qemu_opt_script += ' -display
> sdl,show-cursor=on'
> >>              elif arg == 'gtk':
> >>                  if 'gl' in sys.argv[1:]:
> >>                      self.set_dri_path()
> >> -                    self.qemu_opt_script += ' -vga virtio -display
> gtk,gl=on,show-cursor=on'
> >> +                    self.qemu_opt_script += ' -device virtio-gpu
> -display gtk,gl=on,show-cursor=on'
> >>                  elif 'gl-es' in sys.argv[1:]:
> >>                      self.set_dri_path()
> >> -                    self.qemu_opt_script += ' -vga virtio -display
> gtk,gl=es,show-cursor=on'
> >> +                    self.qemu_opt_script += ' -device virtio-gpu
> -display gtk,gl=es,show-cursor=on'
> >>                  else:
> >>                      self.qemu_opt_script += ' -display
> gtk,show-cursor=on'
> >>              elif arg == 'gl' or arg == 'gl-es':
> >> @@ -482,7 +482,7 @@ class BaseConfig(object):
> >>                      raise RunQemuError('Option %s also needs gtk or
> sdl option.' % (arg))
> >>              elif arg == 'egl-headless':
> >>                  self.set_dri_path()
> >> -                self.qemu_opt_script += ' -vga virtio -display
> egl-headless,show-cursor=on'
> >> +                self.qemu_opt_script += ' -device virtio-gpu -display
> egl-headless,show-cursor=on'
> >>              elif arg == 'serial':
> >>                  self.kernel_cmdline_script += ' console=ttyS0'
> >>                  self.serialconsole = True
> >> --
> >> 2.23.0
> >>
> >> 
>

[-- Attachment #2: Type: text/html, Size: 5439 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [OE-core] [PATCH] runqemu: Change virtio-vga to virtio-gpu.
  2020-10-31 12:27     ` Alexander Kanavin
@ 2020-11-01 12:27       ` Richard Purdie
  0 siblings, 0 replies; 7+ messages in thread
From: Richard Purdie @ 2020-11-01 12:27 UTC (permalink / raw)
  To: Alexander Kanavin, Vasyl Vavrychuk; +Cc: OE-core

On Sat, 2020-10-31 at 13:27 +0100, Alexander Kanavin wrote:
> I think you first need to set up a build directory to use sstate-
> cache in some common location, then build-st will pick it up, and you
> can then easily delete it without destroying the cache.

You can do something like the patch below. I would warn that the tests
assume clean directories so you have to be careful doing this though.

Cheers,

Richard

Subject: HACK:selftest/context: Allow reuse of existing build directory

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/lib/oeqa/selftest/context.py | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/meta/lib/oeqa/selftest/context.py b/meta/lib/oeqa/selftest/context.py
index dd3609c1d6..3a2447d026 100644
--- a/meta/lib/oeqa/selftest/context.py
+++ b/meta/lib/oeqa/selftest/context.py
@@ -73,12 +73,16 @@ class OESelftestTestContext(OETestContext):
         newselftestdir = newbuilddir + "/meta-selftest"
 
         if os.path.exists(newbuilddir):
-            self.logger.error("Build directory %s already exists, aborting" % newbuilddir)
-            sys.exit(1)
+        #    self.logger.error("Build directory %s already exists, aborting" % newbuilddir)
+        #    sys.exit(1)
+            bb.utils.prunedir(newselftestdir)
+            bb.utils.prunedir(newbuilddir + "/conf")
+
+        if not os.path.exists(newbuilddir):
+            bb.utils.mkdirhier(newbuilddir)
+            oe.path.copytree(builddir + "/cache", newbuilddir + "/cache")
 
-        bb.utils.mkdirhier(newbuilddir)
         oe.path.copytree(builddir + "/conf", newbuilddir + "/conf")
-        oe.path.copytree(builddir + "/cache", newbuilddir + "/cache")
         oe.path.copytree(selftestdir, newselftestdir)
 
         for e in os.environ:




^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [OE-core] [PATCH] runqemu: Change virtio-vga to virtio-gpu.
  2020-08-30 20:43 ` [OE-core] " Alexander Kanavin
  2020-10-30 12:38   ` Vasyl Vavrychuk
@ 2020-11-05  9:52   ` Vasyl Vavrychuk
  2020-11-05  9:56     ` Alexander Kanavin
  1 sibling, 1 reply; 7+ messages in thread
From: Vasyl Vavrychuk @ 2020-11-05  9:52 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: OE-core

Which MACHINE do you want me to test? _Without_ may changes test

oe-selftest -r runtime_test.TestImage.test_testimage_virgl_gtk_sdl

fails for qemuarm64 MACHINE with

qemu-system-aarch64: Virtio VGA not available

On Sun, Aug 30, 2020 at 11:44 PM Alexander Kanavin
<alex.kanavin@gmail.com> wrote:
>
> Do the virgl selftests still pass with this change? Please run
>
> oe-selftest -r runtime_test.TestImage.test_testimage_virgl_gtk_sdl
>
> and
>
> oe-selftest -r runtime_test.TestImage.test_testimage_virgl_headless
>
> Alex
>
>
> On Sun, 30 Aug 2020 at 22:15, Vasyl Vavrychuk <vvavrychuk@gmail.com> wrote:
>>
>> virtio-vga is available in QEMU only for hppa, i386, and ppc
>> architectures. On the other hand, virtio-gpu is available for all
>> architectures.
>>
>> Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
>> ---
>>  scripts/runqemu | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/scripts/runqemu b/scripts/runqemu
>> index 7fb5f7db57..5d6b35ffe4 100755
>> --- a/scripts/runqemu
>> +++ b/scripts/runqemu
>> @@ -461,19 +461,19 @@ class BaseConfig(object):
>>              elif arg == 'sdl':
>>                  if 'gl' in sys.argv[1:]:
>>                      self.set_dri_path()
>> -                    self.qemu_opt_script += ' -vga virtio -display sdl,gl=on,show-cursor=on'
>> +                    self.qemu_opt_script += ' -device virtio-gpu -display sdl,gl=on,show-cursor=on'
>>                  elif 'gl-es' in sys.argv[1:]:
>>                      self.set_dri_path()
>> -                    self.qemu_opt_script += ' -vga virtio -display sdl,gl=es,show-cursor=on'
>> +                    self.qemu_opt_script += ' -device virtio-gpu -display sdl,gl=es,show-cursor=on'
>>                  else:
>>                      self.qemu_opt_script += ' -display sdl,show-cursor=on'
>>              elif arg == 'gtk':
>>                  if 'gl' in sys.argv[1:]:
>>                      self.set_dri_path()
>> -                    self.qemu_opt_script += ' -vga virtio -display gtk,gl=on,show-cursor=on'
>> +                    self.qemu_opt_script += ' -device virtio-gpu -display gtk,gl=on,show-cursor=on'
>>                  elif 'gl-es' in sys.argv[1:]:
>>                      self.set_dri_path()
>> -                    self.qemu_opt_script += ' -vga virtio -display gtk,gl=es,show-cursor=on'
>> +                    self.qemu_opt_script += ' -device virtio-gpu -display gtk,gl=es,show-cursor=on'
>>                  else:
>>                      self.qemu_opt_script += ' -display gtk,show-cursor=on'
>>              elif arg == 'gl' or arg == 'gl-es':
>> @@ -482,7 +482,7 @@ class BaseConfig(object):
>>                      raise RunQemuError('Option %s also needs gtk or sdl option.' % (arg))
>>              elif arg == 'egl-headless':
>>                  self.set_dri_path()
>> -                self.qemu_opt_script += ' -vga virtio -display egl-headless,show-cursor=on'
>> +                self.qemu_opt_script += ' -device virtio-gpu -display egl-headless,show-cursor=on'
>>              elif arg == 'serial':
>>                  self.kernel_cmdline_script += ' console=ttyS0'
>>                  self.serialconsole = True
>> --
>> 2.23.0
>>
>> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [OE-core] [PATCH] runqemu: Change virtio-vga to virtio-gpu.
  2020-11-05  9:52   ` Vasyl Vavrychuk
@ 2020-11-05  9:56     ` Alexander Kanavin
  0 siblings, 0 replies; 7+ messages in thread
From: Alexander Kanavin @ 2020-11-05  9:56 UTC (permalink / raw)
  To: Vasyl Vavrychuk; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 3676 bytes --]

Checking x86_64 and aarch64 would be fine (aarch64 may fail for other
reasons, but x86_64 should keep working).

Alex

On Thu, 5 Nov 2020 at 10:52, Vasyl Vavrychuk <vvavrychuk@gmail.com> wrote:

> Which MACHINE do you want me to test? _Without_ may changes test
>
> oe-selftest -r runtime_test.TestImage.test_testimage_virgl_gtk_sdl
>
> fails for qemuarm64 MACHINE with
>
> qemu-system-aarch64: Virtio VGA not available
>
> On Sun, Aug 30, 2020 at 11:44 PM Alexander Kanavin
> <alex.kanavin@gmail.com> wrote:
> >
> > Do the virgl selftests still pass with this change? Please run
> >
> > oe-selftest -r runtime_test.TestImage.test_testimage_virgl_gtk_sdl
> >
> > and
> >
> > oe-selftest -r runtime_test.TestImage.test_testimage_virgl_headless
> >
> > Alex
> >
> >
> > On Sun, 30 Aug 2020 at 22:15, Vasyl Vavrychuk <vvavrychuk@gmail.com>
> wrote:
> >>
> >> virtio-vga is available in QEMU only for hppa, i386, and ppc
> >> architectures. On the other hand, virtio-gpu is available for all
> >> architectures.
> >>
> >> Signed-off-by: Vasyl Vavrychuk <vvavrychuk@gmail.com>
> >> ---
> >>  scripts/runqemu | 10 +++++-----
> >>  1 file changed, 5 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/scripts/runqemu b/scripts/runqemu
> >> index 7fb5f7db57..5d6b35ffe4 100755
> >> --- a/scripts/runqemu
> >> +++ b/scripts/runqemu
> >> @@ -461,19 +461,19 @@ class BaseConfig(object):
> >>              elif arg == 'sdl':
> >>                  if 'gl' in sys.argv[1:]:
> >>                      self.set_dri_path()
> >> -                    self.qemu_opt_script += ' -vga virtio -display
> sdl,gl=on,show-cursor=on'
> >> +                    self.qemu_opt_script += ' -device virtio-gpu
> -display sdl,gl=on,show-cursor=on'
> >>                  elif 'gl-es' in sys.argv[1:]:
> >>                      self.set_dri_path()
> >> -                    self.qemu_opt_script += ' -vga virtio -display
> sdl,gl=es,show-cursor=on'
> >> +                    self.qemu_opt_script += ' -device virtio-gpu
> -display sdl,gl=es,show-cursor=on'
> >>                  else:
> >>                      self.qemu_opt_script += ' -display
> sdl,show-cursor=on'
> >>              elif arg == 'gtk':
> >>                  if 'gl' in sys.argv[1:]:
> >>                      self.set_dri_path()
> >> -                    self.qemu_opt_script += ' -vga virtio -display
> gtk,gl=on,show-cursor=on'
> >> +                    self.qemu_opt_script += ' -device virtio-gpu
> -display gtk,gl=on,show-cursor=on'
> >>                  elif 'gl-es' in sys.argv[1:]:
> >>                      self.set_dri_path()
> >> -                    self.qemu_opt_script += ' -vga virtio -display
> gtk,gl=es,show-cursor=on'
> >> +                    self.qemu_opt_script += ' -device virtio-gpu
> -display gtk,gl=es,show-cursor=on'
> >>                  else:
> >>                      self.qemu_opt_script += ' -display
> gtk,show-cursor=on'
> >>              elif arg == 'gl' or arg == 'gl-es':
> >> @@ -482,7 +482,7 @@ class BaseConfig(object):
> >>                      raise RunQemuError('Option %s also needs gtk or
> sdl option.' % (arg))
> >>              elif arg == 'egl-headless':
> >>                  self.set_dri_path()
> >> -                self.qemu_opt_script += ' -vga virtio -display
> egl-headless,show-cursor=on'
> >> +                self.qemu_opt_script += ' -device virtio-gpu -display
> egl-headless,show-cursor=on'
> >>              elif arg == 'serial':
> >>                  self.kernel_cmdline_script += ' console=ttyS0'
> >>                  self.serialconsole = True
> >> --
> >> 2.23.0
> >>
> >> 
>

[-- Attachment #2: Type: text/html, Size: 5117 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-11-05  9:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-30 20:15 [PATCH] runqemu: Change virtio-vga to virtio-gpu Vasyl Vavrychuk
2020-08-30 20:43 ` [OE-core] " Alexander Kanavin
2020-10-30 12:38   ` Vasyl Vavrychuk
2020-10-31 12:27     ` Alexander Kanavin
2020-11-01 12:27       ` Richard Purdie
2020-11-05  9:52   ` Vasyl Vavrychuk
2020-11-05  9:56     ` Alexander Kanavin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox