public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Douglas Royds" <douglas.royds@gmx.com>
To: openembedded-core@lists.openembedded.org
Cc: Douglas Royds <douglas.royds@taitradio.com>
Subject: [PATCH v3] externalsrc: No single-task lock if S != B
Date: Tue, 13 Oct 2020 13:48:56 +1300	[thread overview]
Message-ID: <20201013004856.13388-1-douglas.royds@gmx.com> (raw)
In-Reply-To: <CAFimOt5fQ=0JKpteCCAbDg14u-itABV7MEULuQEm3dUTFj89Lg@mail.gmail.com>

From: Douglas Royds <douglas.royds@taitradio.com>

Allow different recipes to build things from the one external source tree in
parallel, but only if the build is happening outside the source tree.

Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
---
 meta/classes/externalsrc.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass
index d200129987..dd09395788 100644
--- a/meta/classes/externalsrc.bbclass
+++ b/meta/classes/externalsrc.bbclass
@@ -85,7 +85,7 @@ python () {
             if task.endswith("_setscene"):
                 # sstate is never going to work for external source trees, disable it
                 bb.build.deltask(task, d)
-            else:
+            elif os.path.realpath(d.getVar('S')) == os.path.realpath(d.getVar('B')):
                 # Since configure will likely touch ${S}, ensure only we lock so one task has access at a time
                 d.appendVarFlag(task, "lockfiles", " ${S}/singletask.lock")

--
2.17.1


      parent reply	other threads:[~2020-10-13  0:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09  5:31 [PATCH] externalsrc: No single-task lock if S != B Douglas
2020-10-09  6:36 ` [OE-core] " Ola x Nilsson
2020-10-12  0:07 ` Douglas
2020-10-12  1:31 ` [PATCH v2] " Douglas Royds
2020-10-12 18:12   ` [OE-core] " Richard Purdie
2020-10-13  0:48 ` Douglas Royds [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201013004856.13388-1-douglas.royds@gmx.com \
    --to=douglas.royds@gmx.com \
    --cc=douglas.royds@taitradio.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox