From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Douglas Royds <douglas.royds@gmx.com>,
openembedded-core@lists.openembedded.org
Cc: Douglas Royds <douglas.royds@taitradio.com>
Subject: Re: [OE-core] [PATCH v2] externalsrc: No single-task lock if S != B
Date: Mon, 12 Oct 2020 19:12:06 +0100 [thread overview]
Message-ID: <5139e0e5374c61913563c9cbc1d4d80fa13bc350.camel@linuxfoundation.org> (raw)
In-Reply-To: <20201012013141.473-1-douglas.royds@gmx.com>
On Mon, 2020-10-12 at 14:31 +1300, Douglas Royds wrote:
> From: Douglas Royds <douglas.royds@taitradio.com>
>
> Allow different recipes to build things from the one external source tree in
> parallel, but only if the build is happening outside the source tree.
>
> Signed-off-by: Douglas Royds <douglas.royds@taitradio.com>
> ---
> meta/classes/externalsrc.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass
> index 3618b99a86..88408add71 100644
> --- a/meta/classes/externalsrc.bbclass
> +++ b/meta/classes/externalsrc.bbclass
> @@ -86,7 +86,7 @@ python () {
> if task.endswith("_setscene"):
> # sstate is never going to work for external source trees, disable it
> bb.build.deltask(task, d)
> - else:
> + elif os.path.realpath(externalsrc) == os.path.realpath(externalsrcbuild):
> # Since configure will likely touch ${S}, ensure only we lock so one task has access at a time
> d.appendVarFlag(task, "lockfiles", " ${S}/singletask.lock")
Failed in testing unfortunately, looks like these can be None:
https://autobuilder.yoctoproject.org/typhoon/#/builders/97/builds/1893/steps/8/logs/step1c
Cheers,
Richard
next prev parent reply other threads:[~2020-10-12 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 5:31 [PATCH] externalsrc: No single-task lock if S != B Douglas
2020-10-09 6:36 ` [OE-core] " Ola x Nilsson
2020-10-12 0:07 ` Douglas
2020-10-12 1:31 ` [PATCH v2] " Douglas Royds
2020-10-12 18:12 ` Richard Purdie [this message]
2020-10-13 0:48 ` [PATCH v3] " Douglas Royds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5139e0e5374c61913563c9cbc1d4d80fa13bc350.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=douglas.royds@gmx.com \
--cc=douglas.royds@taitradio.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox