[PATCH] gstreamer: use git to fetch the sources

[PATCH] gstreamer: use git to fetch the sources

[Jose Quaresma]

gstreamer has the code hosted on [1] and this repo as tags.
manage code with git its more convenient than with tarball archives.

[1] - https://gitlab.freedesktop.org/gstreamer

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../gstreamer/gst-devtools_1.18.0.bb                | 10 +++++-----
 .../gstreamer/gstreamer1.0-libav_1.18.0.bb          | 11 ++++++-----
 .../gstreamer/gstreamer1.0-omx_1.18.0.bb            | 10 +++++-----
 .../gstreamer/gstreamer1.0-plugins-bad_1.18.0.bb    |  9 +++++----
 .../gstreamer/gstreamer1.0-plugins-base_1.18.0.bb   |  9 +++++----
 .../gstreamer/gstreamer1.0-plugins-common.inc       |  2 +-
 .../gstreamer/gstreamer1.0-plugins-good_1.18.0.bb   |  8 ++++----
 .../gstreamer/gstreamer1.0-plugins-ugly_1.18.0.bb   | 11 +++++------
 .../gstreamer/gstreamer1.0-python_1.18.0.bb         | 13 ++++++-------
 .../gstreamer/gstreamer1.0-rtsp-server_1.18.0.bb    | 12 +++++-------
 .../gstreamer/gstreamer1.0-vaapi_1.18.0.bb          | 13 ++++++-------
 .../gstreamer/gstreamer1.0_1.18.0.bb                | 11 ++++++-----
 12 files changed, 59 insertions(+), 60 deletions(-)

diff --git a/meta/recipes-multimedia/gstreamer/gst-devtools_1.18.0.bb b/meta/recipes-multimedia/gstreamer/gst-devtools_1.18.0.bb
index 63e7a99b4f..59b4edea34 100644
--- a/meta/recipes-multimedia/gstreamer/gst-devtools_1.18.0.bb
+++ b/meta/recipes-multimedia/gstreamer/gst-devtools_1.18.0.bb
@@ -6,21 +6,21 @@ SECTION = "multimedia"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://validate/COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343"
 
-#S = "${WORKDIR}/gst-devtools-${PV}"
+S = "${WORKDIR}/git"
 
-SRC_URI = "https://gstreamer.freedesktop.org/src/gst-devtools/gst-devtools-${PV}.tar.xz \
+SRCREV = "796b7caad02fc69a060865d23e8e8d53500991e4"
+SRC_URI = "git://gitlab.freedesktop.org/gstreamer/gst-devtools.git;protocol=https \
            file://0001-connect-has-a-different-signature-on-musl.patch \
            "
 
-SRC_URI[md5sum] = "37ca48ea06fb4304cfc9009ec924bc52"
-SRC_URI[sha256sum] = "82337141b5654f11c440f783892ba9d9498b3b6b98c2286b000f96dce6945f16"
+UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)"
 
 DEPENDS = "json-glib glib-2.0 glib-2.0-native gstreamer1.0 gstreamer1.0-plugins-base"
 RRECOMMENDS_${PN} = "git"
 
 FILES_${PN} += "${datadir}/gstreamer-1.0/* ${libdir}/gst-validate-launcher/* ${libdir}/gstreamer-1.0/*"
 
-inherit meson pkgconfig gettext upstream-version-is-even gobject-introspection
+inherit meson pkgconfig gettext gobject-introspection
 
 # TODO: put this in a gettext.bbclass patch
 def gettext_oemeson(d):
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.18.0.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.18.0.bb
index 9fe7957daa..be67751143 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.18.0.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav_1.18.0.bb
@@ -9,15 +9,16 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=6762ed442b3822387a51c92d928ead0d \
                     file://ext/libav/gstav.h;beginline=1;endline=18;md5=a752c35267d8276fd9ca3db6994fca9c \
                     "
 
-SRC_URI = "https://gstreamer.freedesktop.org/src/gst-libav/gst-libav-${PV}.tar.xz"
-SRC_URI[md5sum] = "fe2f07356fa37445837cdde274027117"
-SRC_URI[sha256sum] = "42f93f5ce9a3fc22051e5f783a4574b56ebf213f331f75dcbc3552459bd3a06a"
+SRCREV = "215b3ed959f2b307065319f94855cc9e1ce7be95"
+SRC_URI = "git://gitlab.freedesktop.org/gstreamer/gst-libav.git;protocol=https"
 
-S = "${WORKDIR}/gst-libav-${PV}"
+S = "${WORKDIR}/git"
+
+UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)"
 
 DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base ffmpeg"
 
-inherit meson pkgconfig upstream-version-is-even
+inherit meson pkgconfig
 
 FILES_${PN} += "${libdir}/gstreamer-1.0/*.so"
 FILES_${PN}-staticdev += "${libdir}/gstreamer-1.0/*.a"
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.18.0.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.18.0.bb
index c4855034e0..ab59d9ed23 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.18.0.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.18.0.bb
@@ -7,16 +7,16 @@ LICENSE_FLAGS = "commercial"
 LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c \
                     file://omx/gstomx.h;beginline=1;endline=21;md5=5c8e1fca32704488e76d2ba9ddfa935f"
 
-SRC_URI = "https://gstreamer.freedesktop.org/src/gst-omx/gst-omx-${PV}.tar.xz"
+SRCREV = "f5efdba36c64ac2bf826cee34642e7fd54104ab1"
+SRC_URI = "git://gitlab.freedesktop.org/gstreamer/gst-omx.git;protocol=https"
 
-SRC_URI[md5sum] = "dcff9e4f055a2b1ecadc9f49f5b60a2e"
-SRC_URI[sha256sum] = "302c65e04578991364f7605e04cfb54dfd75268d51080d35f221ee1a8b341fad"
+UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)"
 
-S = "${WORKDIR}/gst-omx-${PV}"
+S = "${WORKDIR}/git"
 
 DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base gstreamer1.0-plugins-bad virtual/libomxil"
 
-inherit meson pkgconfig upstream-version-is-even
+inherit meson pkgconfig
 
 GSTREAMER_1_0_OMX_TARGET ?= "bellagio"
 GSTREAMER_1_0_OMX_CORE_NAME ?= "${libdir}/libomxil-bellagio.so.0"
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.0.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.0.bb
index 8f9036b8ec..a573090beb 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.0.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.18.0.bb
@@ -1,15 +1,16 @@
 require gstreamer1.0-plugins-common.inc
 
-SRC_URI = "https://gstreamer.freedesktop.org/src/gst-plugins-bad/gst-plugins-bad-${PV}.tar.xz \
+SRCREV = "7cb583bb0427819a6b59b783e7df67961df2155f"
+SRC_URI = "git://gitlab.freedesktop.org/gstreamer/gst-plugins-bad.git;protocol=https \
            file://0001-fix-maybe-uninitialized-warnings-when-compiling-with.patch \
            file://0002-avoid-including-sys-poll.h-directly.patch \
            file://0003-ensure-valid-sentinals-for-gst_structure_get-etc.patch \
            file://0004-opencv-resolve-missing-opencv-data-dir-in-yocto-buil.patch \
            "
-SRC_URI[md5sum] = "c1b5f2fb2d76ace6a3d04df73a8c72ea"
-SRC_URI[sha256sum] = "f382ab1caddd64aaa7acb7c4787487f63fd39bd0fde9c757655cbaa457c1185f"
 
-S = "${WORKDIR}/gst-plugins-bad-${PV}"
+UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)"
+
+S = "${WORKDIR}/git"
 
 LICENSE = "GPLv2+ & LGPLv2+ & LGPLv2.1+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=73a5855a8119deb017f5f13cf327095d \
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.18.0.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.18.0.bb
index a04af186f6..010557778a 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.18.0.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.18.0.bb
@@ -3,16 +3,17 @@ require gstreamer1.0-plugins-common.inc
 LICENSE = "GPLv2+ & LGPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=6762ed442b3822387a51c92d928ead0d"
 
-SRC_URI = "https://gstreamer.freedesktop.org/src/gst-plugins-base/gst-plugins-base-${PV}.tar.xz \
+SRCREV = "f21623c1f60949ed6a77e2c2c3857be942cd2db5"
+SRC_URI = "git://gitlab.freedesktop.org/gstreamer/gst-plugins-base.git;protocol=https \
            file://0001-ENGR00312515-get-caps-from-src-pad-when-query-caps.patch \
            file://0003-viv-fb-Make-sure-config.h-is-included.patch \
            file://0002-ssaparse-enhance-SSA-text-lines-parsing.patch \
            file://0004-glimagesink-Downrank-to-marginal.patch \
            "
-SRC_URI[md5sum] = "5ea9dc2692335e03170c3639901c2d83"
-SRC_URI[sha256sum] = "762abdd1a950809a1cea62fff7f86b5f7d6bd5f6841e3e585c700b823cdb7897"
 
-S = "${WORKDIR}/gst-plugins-base-${PV}"
+UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)"
+
+S = "${WORKDIR}/git"
 
 DEPENDS += "iso-codes util-linux zlib"
 
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
index dba96e0f6e..215faeed4e 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-common.inc
@@ -8,7 +8,7 @@ SECTION = "multimedia"
 
 DEPENDS = "gstreamer1.0 glib-2.0-native"
 
-inherit gettext meson pkgconfig upstream-version-is-even
+inherit gettext meson pkgconfig
 
 require gstreamer1.0-plugins-packaging.inc
 
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.18.0.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.18.0.bb
index 17a9d5a04e..c1cd547a31 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.18.0.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.18.0.bb
@@ -1,13 +1,13 @@
 require gstreamer1.0-plugins-common.inc
 
-SRC_URI = "https://gstreamer.freedesktop.org/src/gst-plugins-good/gst-plugins-good-${PV}.tar.xz \
+SRCREV = "6ef694ce7b40dda9f2163ed5e1b1de7378505ad0"
+SRC_URI = "git://gitlab.freedesktop.org/gstreamer/gst-plugins-good.git;protocol=https \
            file://0001-qt-include-ext-qt-gstqtgl.h-instead-of-gst-gl-gstglf.patch \
            "
 
-SRC_URI[md5sum] = "c437bf42bf830bc0f482c7d088fb37a5"
-SRC_URI[sha256sum] = "6329bc377a3afea5cf1ab329a91cc4a906f075781780d1edc59e8bea8c1a8bac"
+UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)"
 
-S = "${WORKDIR}/gst-plugins-good-${PV}"
+S = "${WORKDIR}/git"
 
 LICENSE = "GPLv2+ & LGPLv2.1+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.18.0.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.18.0.bb
index d38550c352..d735bb77d4 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.18.0.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-ugly_1.18.0.bb
@@ -6,13 +6,12 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
 LICENSE = "GPLv2+ & LGPLv2.1+ & LGPLv2+"
 LICENSE_FLAGS = "commercial"
 
-SRC_URI = " \
-            https://gstreamer.freedesktop.org/src/gst-plugins-ugly/gst-plugins-ugly-${PV}.tar.xz \
-            "
-SRC_URI[md5sum] = "01d3a24152cfd5eb27b1787d44b524c6"
-SRC_URI[sha256sum] = "686644e45e08258ae240c4519376668ad8d34ea6d0f6ab556473c317bfb7e082"
+SRCREV = "ae91a81d9aa913cee1e8310af93a8fff5445628d"
+SRC_URI = "git://gitlab.freedesktop.org/gstreamer/gst-plugins-ugly.git;protocol=https"
 
-S = "${WORKDIR}/gst-plugins-ugly-${PV}"
+UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)"
+
+S = "${WORKDIR}/git"
 
 DEPENDS += "gstreamer1.0-plugins-base"
 
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.18.0.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.18.0.bb
index 8ad6e15306..e8fdae1726 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.18.0.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.18.0.bb
@@ -5,19 +5,18 @@ SECTION = "multimedia"
 LICENSE = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=c34deae4e395ca07e725ab0076a5f740"
 
-SRC_URI = "https://gstreamer.freedesktop.org/src/${PNREAL}/${PNREAL}-${PV}.tar.xz"
-SRC_URI[md5sum] = "2d55c22fcd57cae4fad55a07019aa334"
-SRC_URI[sha256sum] = "76bfe8b85a9c4a6ddfb81874f2635fd0da38c3f39d9d2a0b175213218516dd45"
+SRCREV = "a85f99e274fe14348645c61606463ff63ceb45eb"
+SRC_URI = "git://gitlab.freedesktop.org/gstreamer/gst-python.git;protocol=https"
+
+UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)"
 
 DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base python3-pygobject"
 RDEPENDS_${PN} += "gstreamer1.0 gstreamer1.0-plugins-base python3-pygobject"
 
-PNREAL = "gst-python"
-
-S = "${WORKDIR}/${PNREAL}-${PV}"
+S = "${WORKDIR}/git"
 
 # gobject-introspection is mandatory and cannot be configured
 REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
 UNKNOWN_CONFIGURE_WHITELIST_append = " introspection"
 
-inherit meson pkgconfig distutils3-base upstream-version-is-even gobject-introspection features_check
+inherit meson pkgconfig distutils3-base gobject-introspection features_check
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-rtsp-server_1.18.0.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-rtsp-server_1.18.0.bb
index 0adfa2aac9..7e3e83d8b6 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-rtsp-server_1.18.0.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-rtsp-server_1.18.0.bb
@@ -6,16 +6,14 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=6762ed442b3822387a51c92d928ead0d"
 
 DEPENDS = "gstreamer1.0 gstreamer1.0-plugins-base"
 
-PNREAL = "gst-rtsp-server"
+SRCREV = "12eef972482ab3243743ae1bda1c40fc4411782c"
+SRC_URI = "git://gitlab.freedesktop.org/gstreamer/gst-rtsp-server.git;protocol=https"
 
-SRC_URI = "https://gstreamer.freedesktop.org/src/${PNREAL}/${PNREAL}-${PV}.tar.xz"
+UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)"
 
-SRC_URI[md5sum] = "77fe28c702a83566811ab5c7bbe99ab2"
-SRC_URI[sha256sum] = "2ad19311054cbf2df0d0622936bc703dedc06ced706df46a3d3a3ea5a4b7c70f"
+S = "${WORKDIR}/git"
 
-S = "${WORKDIR}/${PNREAL}-${PV}"
-
-inherit meson pkgconfig upstream-version-is-even gobject-introspection
+inherit meson pkgconfig gobject-introspection
 
 EXTRA_OEMESON += " \
     -Ddoc=disabled \
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.18.0.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.18.0.bb
index 60a975bf4d..2127e02b68 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.18.0.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.18.0.bb
@@ -3,20 +3,19 @@ DESCRIPTION = "gstreamer-vaapi consists of a collection of VA-API \
 based plugins for GStreamer and helper libraries: `vaapidecode', \
 `vaapiconvert', and `vaapisink'."
 
-REALPN = "gstreamer-vaapi"
-
 LICENSE = "LGPLv2.1+"
 LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c"
 
-SRC_URI = "https://gstreamer.freedesktop.org/src/${REALPN}/${REALPN}-${PV}.tar.xz"
+SRCREV = "de6fb60929252d6ee066aa06e25302a3f4a9856e"
+SRC_URI = "git://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi.git;protocol=https"
+
+UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)"
 
-SRC_URI[md5sum] = "079a3739857e0cf4904afe92659d8a18"
-SRC_URI[sha256sum] = "c6efeb8c736f75bb1b53ab18413c60c4321300e7aee66641bcc07d59c2fe9e31"
+S = "${WORKDIR}/git"
 
-S = "${WORKDIR}/${REALPN}-${PV}"
 DEPENDS = "libva gstreamer1.0 gstreamer1.0-plugins-base gstreamer1.0-plugins-bad"
 
-inherit meson pkgconfig features_check upstream-version-is-even
+inherit meson pkgconfig features_check
 
 REQUIRED_DISTRO_FEATURES ?= "opengl"
 
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.18.0.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.18.0.bb
index d382655bcb..63a04b6893 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.18.0.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0_1.18.0.bb
@@ -8,20 +8,21 @@ LICENSE = "LGPLv2+"
 
 DEPENDS = "glib-2.0 glib-2.0-native libxml2 bison-native flex-native"
 
-inherit meson pkgconfig gettext upstream-version-is-even gobject-introspection
+inherit meson pkgconfig gettext gobject-introspection
 
 LIC_FILES_CHKSUM = "file://COPYING;md5=6762ed442b3822387a51c92d928ead0d \
                     file://gst/gst.h;beginline=1;endline=21;md5=e059138481205ee2c6fc1c079c016d0d"
 
-S = "${WORKDIR}/gstreamer-${PV}"
+S = "${WORKDIR}/git"
 
-SRC_URI = "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-${PV}.tar.xz \
+SRCREV = "96148da56f9cbf23120e51ce59ab90f94d8b19b8"
+SRC_URI = "git://gitlab.freedesktop.org/gstreamer/gstreamer.git;protocol=https \
            file://0001-gst-gstpluginloader.c-when-env-var-is-set-do-not-fal.patch \
            file://0002-Remove-unused-valgrind-detection.patch \
            file://0003-meson-Add-option-for-installed-tests.patch \
            "
-SRC_URI[md5sum] = "25d683630ff8b82b2c878aa3edd3c491"
-SRC_URI[sha256sum] = "0ff09245b06c0aeb5d9a156edcab088a7e8213a0bf9c84a1ff0318f9c00c7805"
+
+UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.(\d*[02468])+(\.\d+)+)"
 
 PACKAGECONFIG ??= "${@bb.utils.contains('PTEST_ENABLED', '1', 'tests', '', d)} \
                    check \
-- 
2.29.2

Re: [OE-core] [PATCH] gstreamer: use git to fetch the sources

[Richard Purdie]

On Fri, 2020-10-30 at 23:22 +0000, Jose Quaresma wrote:
> gstreamer has the code hosted on [1] and this repo as tags.
> manage code with git its more convenient than with tarball archives.
> 
> [1] - https://gitlab.freedesktop.org/gstreamer
> 
> Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>

I'm not 100% sure about this. Tarballs tend to be less overhead for
fetching and make for easier source archiving. The git repos are easier
for day to day dev work but tend to be harder for the AUH to handle and
slower to fetch for the users taking up more space to download and
unpack. I'm therefore torn. I know where we have used git for other
core components it has caused performance issues.

We do also have the option of the devupstream class although I know
that doesn't quite work for the native cases yet sadly.

Cheers,

Richard

Re: [OE-core] [PATCH] gstreamer: use git to fetch the sources

[Jose Quaresma]

Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia
sábado, 31/10/2020 à(s) 00:32:
>
> On Fri, 2020-10-30 at 23:22 +0000, Jose Quaresma wrote:
> > gstreamer has the code hosted on [1] and this repo as tags.
> > manage code with git its more convenient than with tarball archives.
> >
> > [1] - https://gitlab.freedesktop.org/gstreamer
> >
> > Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
>
> I'm not 100% sure about this. Tarballs tend to be less overhead for
> fetching and make for easier source archiving. The git repos are easier
> for day to day dev work but tend to be harder for the AUH to handle and
> slower to fetch for the users taking up more space to download and
> unpack. I'm therefore torn. I know where we have used git for other
> core components it has caused performance issues.

I have the same opinion that tarballs have less overhead, It's much smaller.
In this specific case the git repos are very big because the gstreamer project
started a long time ago and it contains the full evolution of the project.

However I sent this patch because I think it is easy managing patches with
git but with the devtool we can achieve a very similar workflow.
With the difference that more steps are needed, to do a backport for example.

>
> We do also have the option of the devupstream class although I know
> that doesn't quite work for the native cases yet sadly.

I don't understand this sentence. What is the opinion of devupstream class?

>
> Cheers,
>
> Richard
>
>
>

Someone on the mailing list has suggested that git is preferred over the archive
but now I understand that this is only for github and it's mainly
because of the inconsistency
of the archives that they generate.

-- 
best regards,
José Quaresma

Re: [OE-core] [PATCH] gstreamer: use git to fetch the sources

[Andrey Zhizhikin]

On Sat, Oct 31, 2020 at 12:40 PM Jose Quaresma <quaresma.jose@gmail.com> wrote:
>
> Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia
> sábado, 31/10/2020 à(s) 00:32:
> >
> > On Fri, 2020-10-30 at 23:22 +0000, Jose Quaresma wrote:
> > > gstreamer has the code hosted on [1] and this repo as tags.
> > > manage code with git its more convenient than with tarball archives.
> > >
> > > [1] - https://gitlab.freedesktop.org/gstreamer
> > >
> > > Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> >
> > I'm not 100% sure about this. Tarballs tend to be less overhead for
> > fetching and make for easier source archiving. The git repos are easier
> > for day to day dev work but tend to be harder for the AUH to handle and
> > slower to fetch for the users taking up more space to download and
> > unpack. I'm therefore torn. I know where we have used git for other
> > core components it has caused performance issues.
>
> I have the same opinion that tarballs have less overhead, It's much smaller.
> In this specific case the git repos are very big because the gstreamer project
> started a long time ago and it contains the full evolution of the project.
>
> However I sent this patch because I think it is easy managing patches with
> git but with the devtool we can achieve a very similar workflow.
> With the difference that more steps are needed, to do a backport for example.
>
> >
> > We do also have the option of the devupstream class although I know
> > that doesn't quite work for the native cases yet sadly.
>
> I don't understand this sentence. What is the opinion of devupstream class?
>
> >
> > Cheers,
> >
> > Richard
> >
> >
> >
>
> Someone on the mailing list has suggested that git is preferred over the archive
> but now I understand that this is only for github and it's mainly
> because of the inconsistency
> of the archives that they generate.

I believe that was me and Alex, and this applies currently to GitHub
only. There is a QA warning about using tarballs from GitHub since
they tend to be unstable, GitLab seems to be better in this regard.

>
> --
> best regards,
> José Quaresma
>
> 
>


-- 
Regards,
Andrey.

Re: [OE-core] [PATCH] gstreamer: use git to fetch the sources

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2619 bytes --]

Are you sure _generated_ tarballs from gitlab are better?

https://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg73109.html

On Sat, Oct 31, 2020 at 1:29 PM Andrey Zhizhikin <andrey.z@gmail.com> wrote:

> On Sat, Oct 31, 2020 at 12:40 PM Jose Quaresma <quaresma.jose@gmail.com>
> wrote:
> >
> > Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia
> > sábado, 31/10/2020 à(s) 00:32:
> > >
> > > On Fri, 2020-10-30 at 23:22 +0000, Jose Quaresma wrote:
> > > > gstreamer has the code hosted on [1] and this repo as tags.
> > > > manage code with git its more convenient than with tarball archives.
> > > >
> > > > [1] - https://gitlab.freedesktop.org/gstreamer
> > > >
> > > > Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> > >
> > > I'm not 100% sure about this. Tarballs tend to be less overhead for
> > > fetching and make for easier source archiving. The git repos are easier
> > > for day to day dev work but tend to be harder for the AUH to handle and
> > > slower to fetch for the users taking up more space to download and
> > > unpack. I'm therefore torn. I know where we have used git for other
> > > core components it has caused performance issues.
> >
> > I have the same opinion that tarballs have less overhead, It's much
> smaller.
> > In this specific case the git repos are very big because the gstreamer
> project
> > started a long time ago and it contains the full evolution of the
> project.
> >
> > However I sent this patch because I think it is easy managing patches
> with
> > git but with the devtool we can achieve a very similar workflow.
> > With the difference that more steps are needed, to do a backport for
> example.
> >
> > >
> > > We do also have the option of the devupstream class although I know
> > > that doesn't quite work for the native cases yet sadly.
> >
> > I don't understand this sentence. What is the opinion of devupstream
> class?
> >
> > >
> > > Cheers,
> > >
> > > Richard
> > >
> > >
> > >
> >
> > Someone on the mailing list has suggested that git is preferred over the
> archive
> > but now I understand that this is only for github and it's mainly
> > because of the inconsistency
> > of the archives that they generate.
>
> I believe that was me and Alex, and this applies currently to GitHub
> only. There is a QA warning about using tarballs from GitHub since
> they tend to be unstable, GitLab seems to be better in this regard.
>
> >
> > --
> > best regards,
> > José Quaresma
> >
> >
> >
>
>
> --
> Regards,
> Andrey.
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 3704 bytes --]

Re: [OE-core] [PATCH] gstreamer: use git to fetch the sources

[Andrey Zhizhikin]

On Sat, Oct 31, 2020 at 2:15 PM Martin Jansa <martin.jansa@gmail.com> wrote:
>
> Are you sure _generated_ tarballs from gitlab are better?

Not at all! I was just pointing out that insane.bbclass checks for
github.com archives and totally missing gitlab.com. I guess I would
come up with the patch here to include gitlab.com as well, it makes
total sense.

>
> https://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg73109.html

Interesting reading, and honest reply from GitLab.

So far (if my grep does not lie to me), there is only one recipe in
meta-openembedded [meta-oe/recipes-support/remmina/remmina_1.4.7.bb]
uses that combination, and I guess at the upgrade it should be
switched (new version is available).

>
> On Sat, Oct 31, 2020 at 1:29 PM Andrey Zhizhikin <andrey.z@gmail.com> wrote:
>>
>> On Sat, Oct 31, 2020 at 12:40 PM Jose Quaresma <quaresma.jose@gmail.com> wrote:
>> >
>> > Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia
>> > sábado, 31/10/2020 à(s) 00:32:
>> > >
>> > > On Fri, 2020-10-30 at 23:22 +0000, Jose Quaresma wrote:
>> > > > gstreamer has the code hosted on [1] and this repo as tags.
>> > > > manage code with git its more convenient than with tarball archives.
>> > > >
>> > > > [1] - https://gitlab.freedesktop.org/gstreamer
>> > > >
>> > > > Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
>> > >
>> > > I'm not 100% sure about this. Tarballs tend to be less overhead for
>> > > fetching and make for easier source archiving. The git repos are easier
>> > > for day to day dev work but tend to be harder for the AUH to handle and
>> > > slower to fetch for the users taking up more space to download and
>> > > unpack. I'm therefore torn. I know where we have used git for other
>> > > core components it has caused performance issues.
>> >
>> > I have the same opinion that tarballs have less overhead, It's much smaller.
>> > In this specific case the git repos are very big because the gstreamer project
>> > started a long time ago and it contains the full evolution of the project.
>> >
>> > However I sent this patch because I think it is easy managing patches with
>> > git but with the devtool we can achieve a very similar workflow.
>> > With the difference that more steps are needed, to do a backport for example.
>> >
>> > >
>> > > We do also have the option of the devupstream class although I know
>> > > that doesn't quite work for the native cases yet sadly.
>> >
>> > I don't understand this sentence. What is the opinion of devupstream class?
>> >
>> > >
>> > > Cheers,
>> > >
>> > > Richard
>> > >
>> > >
>> > >
>> >
>> > Someone on the mailing list has suggested that git is preferred over the archive
>> > but now I understand that this is only for github and it's mainly
>> > because of the inconsistency
>> > of the archives that they generate.
>>
>> I believe that was me and Alex, and this applies currently to GitHub
>> only. There is a QA warning about using tarballs from GitHub since
>> they tend to be unstable, GitLab seems to be better in this regard.
>>
>> >
>> > --
>> > best regards,
>> > José Quaresma
>> >
>> >
>> >
>>
>>
>> --
>> Regards,
>> Andrey.
>>
>> 
>>


-- 
Regards,
Andrey.

Re: [OE-core] [PATCH] gstreamer: use git to fetch the sources

[Otavio Salvador]

Em sex., 30 de out. de 2020 às 21:32, Richard Purdie
<richard.purdie@linuxfoundation.org> escreveu:
> On Fri, 2020-10-30 at 23:22 +0000, Jose Quaresma wrote:
> > gstreamer has the code hosted on [1] and this repo as tags.
> > manage code with git its more convenient than with tarball archives.
> >
> > [1] - https://gitlab.freedesktop.org/gstreamer
> >
> > Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
>
> I'm not 100% sure about this. Tarballs tend to be less overhead for
> fetching and make for easier source archiving. The git repos are easier
> for day to day dev work but tend to be harder for the AUH to handle and
> slower to fetch for the users taking up more space to download and
> unpack. I'm therefore torn. I know where we have used git for other
> core components it has caused performance issues.

We could tune the git fetcher to not download whole history, we it'd
be  a win win case no?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750

Re: [OE-core] [PATCH] gstreamer: use git to fetch the sources

[Jose Quaresma]

Otavio Salvador <otavio.salvador@ossystems.com.br> escreveu no dia
sábado, 31/10/2020 à(s) 20:30:
>
> Em sex., 30 de out. de 2020 às 21:32, Richard Purdie
> <richard.purdie@linuxfoundation.org> escreveu:
> > On Fri, 2020-10-30 at 23:22 +0000, Jose Quaresma wrote:
> > > gstreamer has the code hosted on [1] and this repo as tags.
> > > manage code with git its more convenient than with tarball archives.
> > >
> > > [1] - https://gitlab.freedesktop.org/gstreamer
> > >
> > > Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> >
> > I'm not 100% sure about this. Tarballs tend to be less overhead for
> > fetching and make for easier source archiving. The git repos are easier
> > for day to day dev work but tend to be harder for the AUH to handle and
> > slower to fetch for the users taking up more space to download and
> > unpack. I'm therefore torn. I know where we have used git for other
> > core components it has caused performance issues.
>
> We could tune the git fetcher to not download whole history, we it'd
> be  a win win case no?

I don't know if it is possible to use something like: git clone –depth 1
but with a solution like this we reduce the download overhead to
values close to the file archive.

>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750



-- 
best regards,
José Quaresma

Re: [OE-core] [PATCH] gstreamer: use git to fetch the sources

[Jose Quaresma]

Jose Quaresma via lists.openembedded.org
<quaresma.jose=gmail.com@lists.openembedded.org> escreveu no dia
domingo, 1/11/2020 à(s) 21:16:
>
> Otavio Salvador <otavio.salvador@ossystems.com.br> escreveu no dia
> sábado, 31/10/2020 à(s) 20:30:
> >
> > Em sex., 30 de out. de 2020 às 21:32, Richard Purdie
> > <richard.purdie@linuxfoundation.org> escreveu:
> > > On Fri, 2020-10-30 at 23:22 +0000, Jose Quaresma wrote:
> > > > gstreamer has the code hosted on [1] and this repo as tags.
> > > > manage code with git its more convenient than with tarball archives.
> > > >
> > > > [1] - https://gitlab.freedesktop.org/gstreamer
> > > >
> > > > Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> > >
> > > I'm not 100% sure about this. Tarballs tend to be less overhead for
> > > fetching and make for easier source archiving. The git repos are easier
> > > for day to day dev work but tend to be harder for the AUH to handle and
> > > slower to fetch for the users taking up more space to download and
> > > unpack. I'm therefore torn. I know where we have used git for other
> > > core components it has caused performance issues.
> >
> > We could tune the git fetcher to not download whole history, we it'd
> > be  a win win case no?
>
> I don't know if it is possible to use something like: git clone –depth 1
> but with a solution like this we reduce the download overhead to
> values close to the file archive.

There are an env variable to control this on the bitbake lib/bb/fetch2/git.py

BB_GIT_SHALLOW_DEPTH

Allow the user to explicitly adjust the depth for named urls/branches. The
un-suffixed BB_GIT_SHALLOW_DEPTH is used as the default.

When this is set to BB_GIT_SHALLOW_DEPTH = "1", it will use git clone
–depth 1 url

Can this be a solution to prefer git fetch over archives in some cases ?

>
> >
> > --
> > Otavio Salvador                             O.S. Systems
> > http://www.ossystems.com.br        http://code.ossystems.com.br
> > Mobile: +55 (53) 9 9981-7854          Mobile: +1 (347) 903-9750
>
>
>
> --
> best regards,
> José Quaresma
>
> 
>


-- 
best regards,
José Quaresma