[meta-oe][PATCH] volatile-binds: add /srv to mount and install

[meta-oe][PATCH] volatile-binds: add /srv to mount and install

[Sinan Kaya]

We are installing a service to volatile mount /srv
directory but we are not creating it on the target.

Signed-off-by: Sinan Kaya <okaya@kernel.org>
---
 meta/recipes-core/volatile-binds/volatile-binds.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-core/volatile-binds/volatile-binds.bb b/meta/recipes-core/volatile-binds/volatile-binds.bb
index b273293e9a8..08bda6d14bc 100644
--- a/meta/recipes-core/volatile-binds/volatile-binds.bb
+++ b/meta/recipes-core/volatile-binds/volatile-binds.bb
@@ -36,6 +36,7 @@ def volatile_systemd_services(d):
 SYSTEMD_SERVICE_${PN} = "${@volatile_systemd_services(d)}"
 
 FILES_${PN} += "${systemd_unitdir}/system/*.service"
+FILES_${PN}_append = " ${servicedir}"
 
 do_compile () {
     while read spec mountpoint; do
@@ -64,6 +65,7 @@ do_compile[dirs] = "${WORKDIR}"
 
 do_install () {
     install -d ${D}${base_sbindir}
+    install -d ${D}${servicedir}
     install -m 0755 mount-copybind ${D}${base_sbindir}/
 
     install -d ${D}${systemd_unitdir}/system
-- 
2.17.1

Re: [OE-core] [meta-oe][PATCH] volatile-binds: add /srv to mount and install

[Konrad Weihmann]

On 18.11.20 23:37, Sinan Kaya wrote:
> Signed-off-by: Sinan Kaya <okaya@kernel.org>
> ---
>   meta/recipes-core/volatile-binds/volatile-binds.bb | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-core/volatile-binds/volatile-binds.bb b/meta/recipes-core/volatile-binds/volatile-binds.bb
> index b273293e9a8..08bda6d14bc 100644
> --- a/meta/recipes-core/volatile-binds/volatile-binds.bb
> +++ b/meta/recipes-core/volatile-binds/volatile-binds.bb
> @@ -36,6 +36,7 @@ def volatile_systemd_services(d):
>   SYSTEMD_SERVICE_${PN} = "${@volatile_systemd_services(d)}"
>   
>   FILES_${PN} += "${systemd_unitdir}/system/*.service"
> +FILES_${PN}_append = " ${servicedir}"

Just out of interest, why does that need to be an append?
Why can't that be part of the line above?

>   
>   do_compile () {
>       while read spec mountpoint; do
> @@ -64,6 +65,7 @@ do_compile[dirs] = "${WORKDIR}"
>   
>   do_install () {
>       install -d ${D}${base_sbindir}
> +    install -d ${D}${servicedir}
>       install -m 0755 mount-copybind ${D}${base_sbindir}/
>   
>       install -d ${D}${systemd_unitdir}/system
> 
> 
> 
> 
> 

Re: [OE-core] [meta-oe][PATCH] volatile-binds: add /srv to mount and install

[Sinan Kaya]

On 11/18/2020 5:40 PM, Konrad Weihmann wrote:
>>     FILES_${PN} += "${systemd_unitdir}/system/*.service"
>> +FILES_${PN}_append = " ${servicedir}"
> 
> Just out of interest, why does that need to be an append?
> Why can't that be part of the line above?

I can fix that. I copied from a bbappend file.

Re: [OE-core] [meta-oe][PATCH] volatile-binds: add /srv to mount and install

[Konrad Weihmann]

On 18.11.20 23:53, Sinan Kaya wrote:
> On 11/18/2020 5:40 PM, Konrad Weihmann wrote:
>>>      FILES_${PN} += "${systemd_unitdir}/system/*.service"
>>> +FILES_${PN}_append = " ${servicedir}"
>>
>> Just out of interest, why does that need to be an append?
>> Why can't that be part of the line above?
> 
> I can fix that. I copied from a bbappend file.
> 
Yeah please do so, appends are pretty invasive, better leave them out if 
there is no real need for them