[PATCH] libsdl2: Add directfb to PACKAGECONFIG rdepends

[PATCH] libsdl2: Add directfb to PACKAGECONFIG rdepends

[Mark Jonas]

When building libsdl2 with PACKAGECONFIG[directfb] then directfb is
added to the DEPENDS. But the automatically generated runtime
dependencies do not add the directfb package to the runtime
dependencies. Most likely this happens because libsdl2 does not link
against directfb but uses dlopen() or similar. Thus, the runtime
dependency to directfb needs to be declared explicitly.

Here, a runtime recommendation is used to allow ignoring the runtime
dependency using NO_RECOMMENDATIONS.

Signed-off-by: Mark Jonas <toertel@gmail.com>
---
 meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb
index 2ef7d2e5ef..ae42db2610 100644
--- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb
+++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb
@@ -58,7 +58,7 @@ PACKAGECONFIG ??= " \
 "
 PACKAGECONFIG[alsa]       = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib,"
 PACKAGECONFIG[arm-neon]   = "--enable-arm-neon,--disable-arm-neon"
-PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb"
+PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb,,directfb"
 PACKAGECONFIG[gles2]      = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"
 PACKAGECONFIG[jack]       = "--enable-jack,--disable-jack,jack"
 PACKAGECONFIG[kmsdrm]     = "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm"
-- 
2.25.1

Re: [OE-core] [PATCH] libsdl2: Add directfb to PACKAGECONFIG rdepends

[Andre McCurdy]

On Mon, Nov 23, 2020 at 11:14 AM Mark Jonas <toertel@gmail.com> wrote:
>
> When building libsdl2 with PACKAGECONFIG[directfb] then directfb is
> added to the DEPENDS. But the automatically generated runtime
> dependencies do not add the directfb package to the runtime
> dependencies. Most likely this happens because libsdl2 does not link
> against directfb but uses dlopen() or similar. Thus, the runtime
> dependency to directfb needs to be declared explicitly.
>
> Here, a runtime recommendation is used to allow ignoring the runtime
> dependency using NO_RECOMMENDATIONS.

Why would anyone want to ignore the runtime dependency?

> Signed-off-by: Mark Jonas <toertel@gmail.com>
> ---
>  meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb
> index 2ef7d2e5ef..ae42db2610 100644
> --- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb
> +++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb
> @@ -58,7 +58,7 @@ PACKAGECONFIG ??= " \
>  "
>  PACKAGECONFIG[alsa]       = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib,"
>  PACKAGECONFIG[arm-neon]   = "--enable-arm-neon,--disable-arm-neon"
> -PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb"
> +PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb,,directfb"
>  PACKAGECONFIG[gles2]      = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"
>  PACKAGECONFIG[jack]       = "--enable-jack,--disable-jack,jack"
>  PACKAGECONFIG[kmsdrm]     = "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm"
> --
> 2.25.1
>
>
> 
>

Re: [OE-core] [PATCH] libsdl2: Add directfb to PACKAGECONFIG rdepends

[Richard Purdie]

On Mon, 2020-11-23 at 11:54 -0800, Andre McCurdy wrote:
> On Mon, Nov 23, 2020 at 11:14 AM Mark Jonas <toertel@gmail.com>
> wrote:
> > When building libsdl2 with PACKAGECONFIG[directfb] then directfb is
> > added to the DEPENDS. But the automatically generated runtime
> > dependencies do not add the directfb package to the runtime
> > dependencies. Most likely this happens because libsdl2 does not
> > link
> > against directfb but uses dlopen() or similar. Thus, the runtime
> > dependency to directfb needs to be declared explicitly.
> > 
> > Here, a runtime recommendation is used to allow ignoring the
> > runtime
> > dependency using NO_RECOMMENDATIONS.
> 
> Why would anyone want to ignore the runtime dependency?

Agreed, that does seem strange. Whichever way this goes, the patch
shortlog needs to match the commit (it says rdepends right now).

Cheers,

Richard

Re: [OE-core] [PATCH] libsdl2: Add directfb to PACKAGECONFIG rdepends

[Mark Jonas]

Hi Richard and Andre,

On Tue, Nov 24, 2020 at 4:52 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Mon, 2020-11-23 at 11:54 -0800, Andre McCurdy wrote:
> > On Mon, Nov 23, 2020 at 11:14 AM Mark Jonas <toertel@gmail.com>
> > wrote:
> > > When building libsdl2 with PACKAGECONFIG[directfb] then directfb is
> > > added to the DEPENDS. But the automatically generated runtime
> > > dependencies do not add the directfb package to the runtime
> > > dependencies. Most likely this happens because libsdl2 does not
> > > link
> > > against directfb but uses dlopen() or similar. Thus, the runtime
> > > dependency to directfb needs to be declared explicitly.
> > >
> > > Here, a runtime recommendation is used to allow ignoring the
> > > runtime
> > > dependency using NO_RECOMMENDATIONS.
> >
> > Why would anyone want to ignore the runtime dependency?
>
> Agreed, that does seem strange. Whichever way this goes, the patch
> shortlog needs to match the commit (it says rdepends right now).

Thank you for the feedback. I'll send a V2 of the patch.

Greetings,
Mark

[PATCH V2] libsdl2: Add directfb to PACKAGECONFIG rdepends

[Mark Jonas]

PACKAGECONFIG[directfb] already adds directfb to the build
dependencies. But the automatically generated runtime
dependencies do not add the directfb package to the runtime
dependencies. Most likely this happens because libsdl2 does not link
against directfb but uses dlopen() or similar. Thus, the runtime
dependency to directfb needs to be declared explicitly.

Signed-off-by: Mark Jonas <toertel@gmail.com>
---
Changes in v2:
- Add directfb as a rdepends instead of a rrecommends.
- Rework commit message.

 meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb
index 2ef7d2e5ef..5fa99821c4 100644
--- a/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb
+++ b/meta/recipes-graphics/libsdl2/libsdl2_2.0.12.bb
@@ -58,7 +58,7 @@ PACKAGECONFIG ??= " \
 "
 PACKAGECONFIG[alsa]       = "--enable-alsa --disable-alsatest,--disable-alsa,alsa-lib,"
 PACKAGECONFIG[arm-neon]   = "--enable-arm-neon,--disable-arm-neon"
-PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb"
+PACKAGECONFIG[directfb]   = "--enable-video-directfb,--disable-video-directfb,directfb,directfb"
 PACKAGECONFIG[gles2]      = "--enable-video-opengles,--disable-video-opengles,virtual/libgles2"
 PACKAGECONFIG[jack]       = "--enable-jack,--disable-jack,jack"
 PACKAGECONFIG[kmsdrm]     = "--enable-video-kmsdrm,--disable-video-kmsdrm,libdrm virtual/libgbm"
--
2.25.1