* [PATCH 2/4] valgrind: exclude bar_bad/bar_bad_xml from ptests
2020-12-14 9:10 [PATCH 1/4] kea: upgrade 1.7.10 -> 1.8.1 Alexander Kanavin
@ 2020-12-14 9:10 ` Alexander Kanavin
2020-12-14 9:10 ` [PATCH 3/4] bzip2: run ptests without valgrind Alexander Kanavin
2020-12-14 9:10 ` [PATCH 4/4] lttng-tools: disable more failing ptests Alexander Kanavin
2 siblings, 0 replies; 4+ messages in thread
From: Alexander Kanavin @ 2020-12-14 9:10 UTC (permalink / raw)
To: openembedded-core; +Cc: Alexander Kanavin
The tests' output is non-deterministic and sometimes
doesn't match the sample output. This has been reported at
https://bugs.kde.org/show_bug.cgi?id=430321
(see also an earlier related bug https://bugs.kde.org/show_bug.cgi?id=358213)
Until upstream figures out how to fix this, let's not run the tests.
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
---
.../valgrind/valgrind/remove-for-aarch64 | 2 --
meta/recipes-devtools/valgrind/valgrind/remove-for-all | 2 ++
meta/recipes-devtools/valgrind/valgrind/run-ptest | 10 ++++++++++
meta/recipes-devtools/valgrind/valgrind_3.16.1.bb | 2 ++
4 files changed, 14 insertions(+), 2 deletions(-)
create mode 100644 meta/recipes-devtools/valgrind/valgrind/remove-for-all
diff --git a/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64 b/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64
index a3a0c6e50f..93bfd45a4e 100644
--- a/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64
+++ b/meta/recipes-devtools/valgrind/valgrind/remove-for-aarch64
@@ -31,8 +31,6 @@ drd/tests/annotate_static
drd/tests/annotate_trace_memory
drd/tests/annotate_trace_memory_xml
drd/tests/atomic_var
-drd/tests/bar_bad
-drd/tests/bar_bad_xml
drd/tests/bar_trivial
drd/tests/bug-235681
drd/tests/bug322621
diff --git a/meta/recipes-devtools/valgrind/valgrind/remove-for-all b/meta/recipes-devtools/valgrind/valgrind/remove-for-all
new file mode 100644
index 0000000000..d6a85c4735
--- /dev/null
+++ b/meta/recipes-devtools/valgrind/valgrind/remove-for-all
@@ -0,0 +1,2 @@
+drd/tests/bar_bad
+drd/tests/bar_bad_xml
diff --git a/meta/recipes-devtools/valgrind/valgrind/run-ptest b/meta/recipes-devtools/valgrind/valgrind/run-ptest
index 97b0a85dbf..7217dfca5d 100755
--- a/meta/recipes-devtools/valgrind/valgrind/run-ptest
+++ b/meta/recipes-devtools/valgrind/valgrind/run-ptest
@@ -17,6 +17,12 @@ EXP_TOOLS="exp-bbv exp-dhat exp-sgcheck"
GDB_BIN=@bindir@/gdb
cd ${VALGRIND_LIB}/ptest && ./gdbserver_tests/make_local_links ${GDB_BIN}
+echo "Hide valgrind tests that are non-deterministic"
+echo "Reported at https://bugs.kde.org/show_bug.cgi?id=430321"
+for i in `cat remove-for-all`; do
+ mv $i.vgtest $i.IGNORE;
+done
+
arch=`arch`
if [ "$arch" = "aarch64" ]; then
echo "Aarch64: Hide valgrind tests that result in defunct process and then out of memory"
@@ -44,6 +50,10 @@ if [ "$arch" = "aarch64" ]; then
done
fi
+echo "Restore valgrind tests that are non-deterministc"
+for i in `cat remove-for-all`; do
+ mv $i.IGNORE $i.vgtest;
+done
passed=`grep PASS: ${LOG}|wc -l`
failed=`grep FAIL: ${LOG}|wc -l`
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.16.1.bb b/meta/recipes-devtools/valgrind/valgrind_3.16.1.bb
index 5db181ac14..25fa58249c 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.16.1.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.16.1.bb
@@ -16,6 +16,7 @@ SRC_URI = "https://sourceware.org/pub/valgrind/valgrind-${PV}.tar.bz2 \
file://Added-support-for-PPC-instructions-mfatbu-mfatbl.patch \
file://run-ptest \
file://remove-for-aarch64 \
+ file://remove-for-all \
file://0004-Fix-out-of-tree-builds.patch \
file://0005-Modify-vg_test-wrapper-to-support-PTEST-formats.patch \
file://0001-Remove-tests-that-fail-to-build-on-some-PPC32-config.patch \
@@ -186,6 +187,7 @@ do_install_ptest() {
# The scripts reference config.h so add it to the top ptest dir.
cp ${B}/config.h ${D}${PTEST_PATH}
install -D ${WORKDIR}/remove-for-aarch64 ${D}${PTEST_PATH}
+ install -D ${WORKDIR}/remove-for-all ${D}${PTEST_PATH}
# Add an executable need by none/tests/bigcode
mkdir ${D}${PTEST_PATH}/perf
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 3/4] bzip2: run ptests without valgrind
2020-12-14 9:10 [PATCH 1/4] kea: upgrade 1.7.10 -> 1.8.1 Alexander Kanavin
2020-12-14 9:10 ` [PATCH 2/4] valgrind: exclude bar_bad/bar_bad_xml from ptests Alexander Kanavin
@ 2020-12-14 9:10 ` Alexander Kanavin
2020-12-14 9:10 ` [PATCH 4/4] lttng-tools: disable more failing ptests Alexander Kanavin
2 siblings, 0 replies; 4+ messages in thread
From: Alexander Kanavin @ 2020-12-14 9:10 UTC (permalink / raw)
To: openembedded-core; +Cc: Alexander Kanavin
Otherwise, valgrind significantly slows them down, and actually
even causes ptest timeouts on arm64.
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
---
meta/recipes-extended/bzip2/bzip2/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-extended/bzip2/bzip2/Makefile.am b/meta/recipes-extended/bzip2/bzip2/Makefile.am
index d4498947e8..7338df03eb 100644
--- a/meta/recipes-extended/bzip2/bzip2/Makefile.am
+++ b/meta/recipes-extended/bzip2/bzip2/Makefile.am
@@ -46,7 +46,7 @@ runtest:
else echo "FAIL: sample2 decompress"; fi
@if cmp sample3.tst sample3.ref; then echo "PASS: sample3 decompress";\
else echo "FAIL: sample3 decompress"; fi
- ./bzip2-tests/run-tests.sh --tests-dir="$(PWD)/bzip2-tests"
+ ./bzip2-tests/run-tests.sh --without-valgrind --tests-dir="$(PWD)/bzip2-tests"
install-ptest:
sed -n '/^runtest:/,/^install-ptest:/{/^install-ptest:/!p}' \
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 4/4] lttng-tools: disable more failing ptests
2020-12-14 9:10 [PATCH 1/4] kea: upgrade 1.7.10 -> 1.8.1 Alexander Kanavin
2020-12-14 9:10 ` [PATCH 2/4] valgrind: exclude bar_bad/bar_bad_xml from ptests Alexander Kanavin
2020-12-14 9:10 ` [PATCH 3/4] bzip2: run ptests without valgrind Alexander Kanavin
@ 2020-12-14 9:10 ` Alexander Kanavin
2 siblings, 0 replies; 4+ messages in thread
From: Alexander Kanavin @ 2020-12-14 9:10 UTC (permalink / raw)
To: openembedded-core; +Cc: Alexander Kanavin
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
---
...ression-disable-the-tools-live-tests.patch | 35 +++++++++++++++----
1 file changed, 28 insertions(+), 7 deletions(-)
diff --git a/meta/recipes-kernel/lttng/lttng-tools/0001-tests-regression-disable-the-tools-live-tests.patch b/meta/recipes-kernel/lttng/lttng-tools/0001-tests-regression-disable-the-tools-live-tests.patch
index f2c14ecc94..08c1423310 100644
--- a/meta/recipes-kernel/lttng/lttng-tools/0001-tests-regression-disable-the-tools-live-tests.patch
+++ b/meta/recipes-kernel/lttng/lttng-tools/0001-tests-regression-disable-the-tools-live-tests.patch
@@ -1,4 +1,4 @@
-From c69b68e5c03f1d260025fb1dd9ab7345e31e15ef Mon Sep 17 00:00:00 2001
+From de9fc501e775cae05f1f87534b4237cd78e8d9a8 Mon Sep 17 00:00:00 2001
From: Alexander Kanavin <alex.kanavin@gmail.com>
Date: Fri, 24 Jan 2020 18:03:25 +0100
Subject: [PATCH] tests/regression: disable the tools/live tests
@@ -9,15 +9,16 @@ https://bugs.lttng.org/issues/1217
Upstream-Status: Inappropriate [upstream is working on a real fix]
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
+
---
- tests/regression/Makefile.am | 4 ----
- 1 file changed, 4 deletions(-)
+ tests/regression/Makefile.am | 10 +---------
+ 1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/tests/regression/Makefile.am b/tests/regression/Makefile.am
-index 73eb9f7..b92bdbd 100644
+index cbac90d..d467886 100644
--- a/tests/regression/Makefile.am
+++ b/tests/regression/Makefile.am
-@@ -9,14 +9,10 @@ TESTS = tools/filtering/test_invalid_filter \
+@@ -11,16 +11,10 @@ TESTS = tools/filtering/test_invalid_filter \
tools/filtering/test_valid_filter \
tools/streaming/test_ust \
tools/health/test_thread_ok \
@@ -26,9 +27,29 @@ index 73eb9f7..b92bdbd 100644
- tools/live/test_lttng_ust \
tools/tracefile-limits/test_tracefile_count \
tools/tracefile-limits/test_tracefile_size \
- tools/exclusion/test_exclusion \
+- tools/exclusion/test_exclusion \
tools/snapshots/test_ust_fast \
- tools/snapshots/test_ust_streaming \
tools/save-load/test_save \
- tools/save-load/test_load \
+- tools/save-load/test_load \
tools/save-load/test_autoload \
+ tools/mi/test_mi \
+ tools/wildcard/test_event_wildcard \
+@@ -38,8 +32,7 @@ TESTS = tools/filtering/test_invalid_filter \
+ tools/working-directory/test_relayd_working_directory \
+ tools/notification/test_notification_multi_app \
+ tools/clear/test_ust \
+- tools/clear/test_kernel \
+- tools/tracker/test_event_tracker
++ tools/clear/test_kernel
+
+ if HAVE_LIBLTTNG_UST_CTL
+ SUBDIRS += ust
+@@ -60,7 +53,6 @@ TESTS += ust/before-after/test_before_after \
+ ust/multi-lib/test_multi_lib \
+ ust/rotation-destroy-flush/test_rotation_destroy_flush \
+ ust/namespaces/test_ns_contexts \
+- ust/namespaces/test_ns_contexts_change \
+ tools/metadata/test_ust \
+ tools/relayd-grouping/test_ust
+ endif # HAVE_LIBLTTNG_UST_CTL
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread