From: "Luca Bocassi" <luca.boccassi@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v2 5/5] systemd: add RRECOMMENDS for weak dependencies, if enabled
Date: Mon, 14 Dec 2020 12:34:57 +0000 [thread overview]
Message-ID: <20201214123457.122655-5-luca.boccassi@gmail.com> (raw)
In-Reply-To: <20201214123457.122655-1-luca.boccassi@gmail.com>
From: Luca Boccassi <luca.boccassi@microsoft.com>
Some libraries are now dlopen'ed and skipped at runtime if
not available. Add them to the RRECOMMENDS list, to allow
users to exclude them for smaller images even if generally
enabled at build time.
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
v2: set the rrecommends directly in PACKAGECONFIG
meta/recipes-core/systemd/systemd_247.1.bb | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/meta/recipes-core/systemd/systemd_247.1.bb b/meta/recipes-core/systemd/systemd_247.1.bb
index f20e86d94b..8814677bf2 100644
--- a/meta/recipes-core/systemd/systemd_247.1.bb
+++ b/meta/recipes-core/systemd/systemd_247.1.bb
@@ -111,6 +111,9 @@ PACKAGECONFIG_remove_libc-musl = " \
CFLAGS_append_libc-musl = " -D__UAPI_DEF_ETHHDR=0 "
+# Some of the dependencies are weak-style recommends - if not available at runtime,
+# systemd won't fail but the library-related feature will be skipped with a warning.
+
# Use the upstream systemd serial-getty@.service and rely on
# systemd-getty-generator instead of using the OE-core specific
# systemd-serialgetty.bb - not enabled by default.
@@ -123,7 +126,7 @@ PACKAGECONFIG[binfmt] = "-Dbinfmt=true,-Dbinfmt=false"
PACKAGECONFIG[bzip2] = "-Dbzip2=true,-Dbzip2=false,bzip2"
PACKAGECONFIG[cgroupv2] = "-Ddefault-hierarchy=unified,-Ddefault-hierarchy=hybrid"
PACKAGECONFIG[coredump] = "-Dcoredump=true,-Dcoredump=false"
-PACKAGECONFIG[cryptsetup] = "-Dlibcryptsetup=true,-Dlibcryptsetup=false,cryptsetup"
+PACKAGECONFIG[cryptsetup] = "-Dlibcryptsetup=true,-Dlibcryptsetup=false,cryptsetup,,cryptsetup"
PACKAGECONFIG[dbus] = "-Ddbus=true,-Ddbus=false,dbus"
PACKAGECONFIG[efi] = "-Defi=true,-Defi=false"
PACKAGECONFIG[gnu-efi] = "-Dgnu-efi=true -Defi-libdir=${STAGING_LIBDIR} -Defi-includedir=${STAGING_INCDIR}/efi,-Dgnu-efi=false,gnu-efi"
@@ -144,8 +147,8 @@ PACKAGECONFIG[iptc] = "-Dlibiptc=true,-Dlibiptc=false,iptables"
PACKAGECONFIG[journal-upload] = "-Dlibcurl=true,-Dlibcurl=false,curl"
PACKAGECONFIG[kmod] = "-Dkmod=true,-Dkmod=false,kmod"
PACKAGECONFIG[ldconfig] = "-Dldconfig=true,-Dldconfig=false,,ldconfig"
-PACKAGECONFIG[libidn] = "-Dlibidn=true,-Dlibidn=false,libidn"
-PACKAGECONFIG[libidn2] = "-Dlibidn2=true,-Dlibidn2=false,libidn2"
+PACKAGECONFIG[libidn] = "-Dlibidn=true,-Dlibidn=false,libidn,,libidn"
+PACKAGECONFIG[libidn2] = "-Dlibidn2=true,-Dlibidn2=false,libidn2,,libidn2"
PACKAGECONFIG[localed] = "-Dlocaled=true,-Dlocaled=false"
PACKAGECONFIG[logind] = "-Dlogind=true,-Dlogind=false"
PACKAGECONFIG[lz4] = "-Dlz4=true,-Dlz4=false,lz4"
@@ -163,7 +166,7 @@ PACKAGECONFIG[pam] = "-Dpam=true,-Dpam=false,libpam,${PAM_PLUGINS}"
PACKAGECONFIG[pcre2] = "-Dpcre2=true,-Dpcre2=false,libpcre2"
PACKAGECONFIG[polkit] = "-Dpolkit=true,-Dpolkit=false"
PACKAGECONFIG[portabled] = "-Dportabled=true,-Dportabled=false"
-PACKAGECONFIG[qrencode] = "-Dqrencode=true,-Dqrencode=false,qrencode"
+PACKAGECONFIG[qrencode] = "-Dqrencode=true,-Dqrencode=false,qrencode,,qrencode"
PACKAGECONFIG[quotacheck] = "-Dquotacheck=true,-Dquotacheck=false"
PACKAGECONFIG[randomseed] = "-Drandomseed=true,-Drandomseed=false"
PACKAGECONFIG[resolved] = "-Dresolve=true,-Dresolve=false"
--
2.29.2
next prev parent reply other threads:[~2020-12-14 12:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 12:53 [PATCH 1/5] systemd: update 246 -> 247 Luca Bocassi
2020-12-10 12:53 ` [PATCH 2/5] systemd: add package config for systemd-oomd Luca Bocassi
2020-12-10 17:05 ` [OE-core] " Khem Raj
2020-12-10 18:01 ` Luca Boccassi
2020-12-10 12:53 ` [PATCH 3/5] systemd: ship new systemd-dissect in -extra-utils Luca Bocassi
2020-12-10 12:53 ` [PATCH 4/5] systemd: set -Dmode=release as recommended by NEWS Luca Bocassi
2020-12-10 12:53 ` [PATCH 5/5] systemd: add RRECOMMENDS for weak dependencies, if enabled Luca Bocassi
2020-12-11 20:34 ` [OE-core] " Peter Kjellerstedt
2020-12-14 10:33 ` Luca Bocassi
2020-12-11 20:55 ` Andre McCurdy
2020-12-14 10:05 ` Luca Bocassi
2020-12-10 17:08 ` [OE-core] [PATCH 1/5] systemd: update 246 -> 247 Khem Raj
2020-12-10 18:05 ` Luca Boccassi
2020-12-10 20:40 ` Khem Raj
2020-12-11 9:32 ` Luca Boccassi
2020-12-11 16:50 ` Khem Raj
2020-12-11 20:17 ` Saul Wold
2020-12-14 12:34 ` [PATCH v2 " Luca Bocassi
2020-12-14 12:34 ` [PATCH v2 2/5] systemd: add package config for systemd-oomd Luca Bocassi
2020-12-14 12:34 ` [PATCH v2 3/5] systemd: ship new systemd-dissect in -extra-utils Luca Bocassi
2020-12-14 12:34 ` [PATCH v2 4/5] systemd: set -Dmode=release as recommended by NEWS Luca Bocassi
2020-12-14 12:34 ` Luca Bocassi [this message]
2020-12-16 17:57 ` [OE-core] [PATCH v2 1/5] systemd: update 246 -> 247 Richard Purdie
2020-12-16 18:07 ` Richard Purdie
2020-12-17 17:25 ` Luca Bocassi
2020-12-17 17:46 ` Richard Purdie
2020-12-18 9:47 ` Luca Bocassi
2020-12-18 1:46 ` Chen Qi
2020-12-18 2:00 ` Anuj Mittal
2020-12-18 9:43 ` Luca Bocassi
[not found] ` <165144ABA68FE046.22063@lists.openembedded.org>
2020-12-16 18:48 ` Richard Purdie
2020-12-18 9:42 ` [PATCH v3 " Luca Bocassi
2020-12-18 9:42 ` [PATCH v3 2/5] systemd: add package config for systemd-oomd Luca Bocassi
2020-12-18 9:42 ` [PATCH v3 3/5] systemd: ship new systemd-dissect in -extra-utils Luca Bocassi
2020-12-18 9:42 ` [PATCH v3 4/5] systemd: set -Dmode=release as recommended by NEWS Luca Bocassi
2020-12-18 9:42 ` [PATCH v3 5/5] systemd: add RRECOMMENDS for weak dependencies, if enabled Luca Bocassi
2020-12-19 10:33 ` [OE-core] [PATCH v3 1/5] systemd: update 246 -> 247 Richard Purdie
[not found] ` <165217A789F1A918.13568@lists.openembedded.org>
2020-12-19 11:03 ` Richard Purdie
[not found] ` <1652194C9AF53BB2.13568@lists.openembedded.org>
2020-12-19 11:18 ` Richard Purdie
2020-12-19 14:09 ` Peter Kjellerstedt
2020-12-19 14:55 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214123457.122655-5-luca.boccassi@gmail.com \
--to=luca.boccassi@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox